From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9D16C43331 for ; Tue, 12 Nov 2019 08:35:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA4FC206A3 for ; Tue, 12 Nov 2019 08:35:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eGBbFQxm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA4FC206A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Al7WddTRpx11lRqkGtnnXvHf+nfackDvZULSXrNAj4s=; b=eGBbFQxmE4znAZ cYrb80e94ROyhnqQ+7cGvYO6FUVl32+yNIRhLO75jUwTFMiJ3/me+bhyTMqUSqdpZbv3PTtBazrvn XL97rT5FIdGNXbmogi0oW5Sf9XhwVrZdtrZYoWWQgTKCmHi9dL6q4Pa4msPiV3z25DZOj2NQSqfBQ 0RIl8SjGEknmB2GRuzdh3igJ7ixeBI93z8j4CijYUZsHIfVkhmlbPc5W3swXhXYBaTq7dollEMZRe vQvFh9PwP77HlAhmsC0LbS7QOoh1cDu12MAyx5YncnJMce9KPi+I9yhlXw9XbQ6GsI1bf0MiRrsNx dOCDyzu8ozJOX/kXooGQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iURdz-0002dJ-DA; Tue, 12 Nov 2019 08:35:23 +0000 Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iURdv-0002cc-QV; Tue, 12 Nov 2019 08:35:21 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id D1671AC68; Tue, 12 Nov 2019 08:35:16 +0000 (UTC) Date: Tue, 12 Nov 2019 09:35:09 +0100 From: Petr Mladek To: Sergey Senozhatsky Subject: Re: [PATCH 00/50] Add log level to show_stack() Message-ID: <20191112083509.gmgjpkjffsfaw5lm@pathway.suse.cz> References: <20191106030542.868541-1-dima@arista.com> <20191106083538.z5nlpuf64cigxigh@pathway.suse.cz> <20191108103719.GB175344@google.com> <20191108130447.h3wfgo4efjkto56f@pathway.suse.cz> <20191111012336.GA85185@google.com> <20191111091207.u3lrd6cmumnx4czr@pathway.suse.cz> <20191112044447.GA121272@google.com> <20191112045704.GA138013@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191112045704.GA138013@google.com> User-Agent: NeoMutt/20170912 (1.9.0) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191112_003520_155802_C9E57AD3 X-CRM114-Status: GOOD ( 13.05 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juri Lelli , linux-sh@vger.kernel.org, Catalin Marinas , Ben Segall , Guo Ren , Pavel Machek , Vincent Guittot , Paul Burton , Dmitry Safonov , Michael Ellerman , Geert Uytterhoeven , Mel Gorman , Jiri Slaby , Matt Turner , uclinux-h8-devel@lists.sourceforge.jp, Len Brown , linux-pm@vger.kernel.org, Heiko Carstens , linux-um@lists.infradead.org, Thomas Gleixner , Dietmar Eggemann , Richard Henderson , Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Ralf Baechle , Paul Mackerras , Andrew Morton , linux-ia64@vger.kernel.org, Tetsuo Handa , James Hogan , "James E.J. Bottomley" , Max Filippov , Vincent Chen , Ingo Molnar , linux-s390@vger.kernel.org, linux-c6x-dev@linux-c6x.org, Yoshinori Sato , linux-hexagon@vger.kernel.org, Helge Deller , linux-xtensa@linux-xtensa.org, Vasily Gorbik , Aurelien Jacquiot , linux-m68k@lists.linux-m68k.org, Stafford Horne , linux-arm-kernel@lists.infradead.org, Chris Zankel , Tony Luck , Douglas Anderson , Benjamin Herrenschmidt , Dmitry Safonov <0x7f454c46@gmail.com>, Will Deacon , Daniel Thompson , Brian Cain , Christian Borntraeger , kgdb-bugreport@lists.sourceforge.net, linux-snps-arc@lists.infradead.org, Fenghua Yu , Borislav Petkov , Jeff Dike , Steven Rostedt , Ivan Kokshaysky , Greentime Hu , Guan Xuetao , linux-parisc@vger.kernel.org, linux-alpha@vger.kernel.org, Ley Foon Tan , "David S. Miller" , Rich Felker , Peter Zijlstra , "H. Peter Anvin" , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Anton Ivanov , Jonas Bonn , Richard Weinberger , x86@kernel.org, Russell King , clang-built-linux@googlegroups.com, Ingo Molnar , Mark Salter , Albert Ou , Stefan Kristiansson , openrisc@lists.librecores.org, Paul Walmsley , Michal Simek , Vineet Gupta , linux-mips@vger.kernel.org, Sergey Senozhatsky , Palmer Dabbelt , Jason Wessel , nios2-dev@lists.rocketboards.org, linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Tue 2019-11-12 13:57:04, Sergey Senozhatsky wrote: > On (19/11/12 13:44), Sergey Senozhatsky wrote: > [..] > > > But yes, this per-code-section loglevel is problematic. The feedback > > > against the patchset shows that people want it also the other way. > > > I mean to keep pr_debug() as pr_debug(). > > > > Hmm. Right. > > > > > A solution might be to use the per-code-section loglevel only instead > > > of some special loglevel. > > > > So maybe we can "overwrite" only KERN_DEFAULT loglevels? > > LOGLEVEL_DEFAULT, LOGLEVEL_NOTICE, LOGLEVEL_INFO? > > So we can downgrade some messages (log_store() only) or promote > some messages. > > DEBUG perhaps should stay debug. > > > We certainly should not mess with SCHED or with anything in between > > EMERG and ERR. > > [EMERG, WARN] This is getting too complicated. It would introduce too many hidden rules. While the explicitly passed loglevel parameter is straightforward and clear. I am getting more inclined to the solution introduced by this patchset. It looks reasonable for the different use-cases. Best Regards, Petr _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5398FC43331 for ; Tue, 12 Nov 2019 09:59:32 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63950206BA for ; Tue, 12 Nov 2019 09:59:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63950206BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47C3B83jrnzF3v0 for ; Tue, 12 Nov 2019 20:59:28 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=suse.com (client-ip=195.135.220.15; helo=mx1.suse.de; envelope-from=pmladek@suse.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.com Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47C1K85j3PzF55C for ; Tue, 12 Nov 2019 19:35:22 +1100 (AEDT) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id D1671AC68; Tue, 12 Nov 2019 08:35:16 +0000 (UTC) Date: Tue, 12 Nov 2019 09:35:09 +0100 From: Petr Mladek To: Sergey Senozhatsky Subject: Re: [PATCH 00/50] Add log level to show_stack() Message-ID: <20191112083509.gmgjpkjffsfaw5lm@pathway.suse.cz> References: <20191106030542.868541-1-dima@arista.com> <20191106083538.z5nlpuf64cigxigh@pathway.suse.cz> <20191108103719.GB175344@google.com> <20191108130447.h3wfgo4efjkto56f@pathway.suse.cz> <20191111012336.GA85185@google.com> <20191111091207.u3lrd6cmumnx4czr@pathway.suse.cz> <20191112044447.GA121272@google.com> <20191112045704.GA138013@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191112045704.GA138013@google.com> User-Agent: NeoMutt/20170912 (1.9.0) X-Mailman-Approved-At: Tue, 12 Nov 2019 20:57:18 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juri Lelli , linux-sh@vger.kernel.org, Catalin Marinas , Ben Segall , Guo Ren , Pavel Machek , Vincent Guittot , Paul Burton , Dmitry Safonov , Geert Uytterhoeven , Mel Gorman , Jiri Slaby , Matt Turner , uclinux-h8-devel@lists.sourceforge.jp, Len Brown , linux-pm@vger.kernel.org, Heiko Carstens , linux-um@lists.infradead.org, Thomas Gleixner , Dietmar Eggemann , Richard Henderson , Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Ralf Baechle , Paul Mackerras , Andrew Morton , linux-ia64@vger.kernel.org, Tetsuo Handa , James Hogan , "James E.J. Bottomley" , Max Filippov , Vincent Chen , Ingo Molnar , linux-s390@vger.kernel.org, linux-c6x-dev@linux-c6x.org, Yoshinori Sato , linux-hexagon@vger.kernel.org, Helge Deller , linux-xtensa@linux-xtensa.org, Vasily Gorbik , Aurelien Jacquiot , linux-m68k@lists.linux-m68k.org, Stafford Horne , linux-arm-kernel@lists.infradead.org, Chris Zankel , Tony Luck , Douglas Anderson , Dmitry Safonov <0x7f454c46@gmail.com>, Will Deacon , Daniel Thompson , Brian Cain , Christian Borntraeger , kgdb-bugreport@lists.sourceforge.net, linux-snps-arc@lists.infradead.org, Fenghua Yu , Borislav Petkov , Jeff Dike , Steven Rostedt , Ivan Kokshaysky , Greentime Hu , Guan Xuetao , linux-parisc@vger.kernel.org, linux-alpha@vger.kernel.org, Ley Foon Tan , "David S. Miller" , Rich Felker , Peter Zijlstra , "H. Peter Anvin" , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Anton Ivanov , Jonas Bonn , Richard Weinberger , x86@kernel.org, Russell King , clang-built-linux@googlegroups.com, Ingo Molnar , Mark Salter , Albert Ou , Stefan Kristiansson , openrisc@lists.librecores.org, Paul Walmsley , Michal Simek , Vineet Gupta , linux-mips@vger.kernel.org, Sergey Senozhatsky , Palmer Dabbelt , Jason Wessel , nios2-dev@lists.rocketboards.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue 2019-11-12 13:57:04, Sergey Senozhatsky wrote: > On (19/11/12 13:44), Sergey Senozhatsky wrote: > [..] > > > But yes, this per-code-section loglevel is problematic. The feedback > > > against the patchset shows that people want it also the other way. > > > I mean to keep pr_debug() as pr_debug(). > > > > Hmm. Right. > > > > > A solution might be to use the per-code-section loglevel only instead > > > of some special loglevel. > > > > So maybe we can "overwrite" only KERN_DEFAULT loglevels? > > LOGLEVEL_DEFAULT, LOGLEVEL_NOTICE, LOGLEVEL_INFO? > > So we can downgrade some messages (log_store() only) or promote > some messages. > > DEBUG perhaps should stay debug. > > > We certainly should not mess with SCHED or with anything in between > > EMERG and ERR. > > [EMERG, WARN] This is getting too complicated. It would introduce too many hidden rules. While the explicitly passed loglevel parameter is straightforward and clear. I am getting more inclined to the solution introduced by this patchset. It looks reasonable for the different use-cases. Best Regards, Petr From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 724F7C17440 for ; Tue, 12 Nov 2019 08:35:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 489F4206A3 for ; Tue, 12 Nov 2019 08:35:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="p79/Mmz6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 489F4206A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bMxycZME2tS/rVapNWEKJPiFbXGP23IGtFtJ2YJAZaA=; b=p79/Mmz6ho7QPC i2feHMnVi41pPofW7K3Je6E/cRDbjIXm5/pkVIdFFpUiJISQ4zHMW/boUH40hqb7dFgOyI5Wu8a8X IDKAlsY4unX1uTlz9W3CoE7zDFtf/OPTIs67Z+kJ39EkzmnfI/5uWAIW7E8gw7XdpJqPItrqQtIU8 10A0Skvhmw4iuseeckR4+q9qX8wkudgP5+VEIdAdA38+wGwEae5ksSIEUWHG4x5yU69Z4yR3YdHEY RTdDx05Xc+mKQOfGUirs22MC4pU5RNjduYYiOFpC8Q7GulxGZXWs2l1djiimsHYIrAwX3F1fHAwOc FfN8rf/hiZphDekHUc1Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iURe0-0002e7-9a; Tue, 12 Nov 2019 08:35:24 +0000 Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iURdv-0002cc-QV; Tue, 12 Nov 2019 08:35:21 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id D1671AC68; Tue, 12 Nov 2019 08:35:16 +0000 (UTC) Date: Tue, 12 Nov 2019 09:35:09 +0100 From: Petr Mladek To: Sergey Senozhatsky Subject: Re: [PATCH 00/50] Add log level to show_stack() Message-ID: <20191112083509.gmgjpkjffsfaw5lm@pathway.suse.cz> References: <20191106030542.868541-1-dima@arista.com> <20191106083538.z5nlpuf64cigxigh@pathway.suse.cz> <20191108103719.GB175344@google.com> <20191108130447.h3wfgo4efjkto56f@pathway.suse.cz> <20191111012336.GA85185@google.com> <20191111091207.u3lrd6cmumnx4czr@pathway.suse.cz> <20191112044447.GA121272@google.com> <20191112045704.GA138013@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191112045704.GA138013@google.com> User-Agent: NeoMutt/20170912 (1.9.0) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191112_003520_155802_C9E57AD3 X-CRM114-Status: GOOD ( 13.05 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juri Lelli , linux-sh@vger.kernel.org, Catalin Marinas , Ben Segall , Guo Ren , Pavel Machek , Vincent Guittot , Paul Burton , Dmitry Safonov , Michael Ellerman , Geert Uytterhoeven , Mel Gorman , Jiri Slaby , Matt Turner , uclinux-h8-devel@lists.sourceforge.jp, Len Brown , linux-pm@vger.kernel.org, Heiko Carstens , linux-um@lists.infradead.org, Thomas Gleixner , Dietmar Eggemann , Richard Henderson , Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Ralf Baechle , Paul Mackerras , Andrew Morton , linux-ia64@vger.kernel.org, Tetsuo Handa , James Hogan , "James E.J. Bottomley" , Max Filippov , Vincent Chen , Ingo Molnar , linux-s390@vger.kernel.org, linux-c6x-dev@linux-c6x.org, Yoshinori Sato , linux-hexagon@vger.kernel.org, Helge Deller , linux-xtensa@linux-xtensa.org, Vasily Gorbik , Aurelien Jacquiot , linux-m68k@lists.linux-m68k.org, Stafford Horne , linux-arm-kernel@lists.infradead.org, Chris Zankel , Tony Luck , Douglas Anderson , Benjamin Herrenschmidt , Dmitry Safonov <0x7f454c46@gmail.com>, Will Deacon , Daniel Thompson , Brian Cain , Christian Borntraeger , kgdb-bugreport@lists.sourceforge.net, linux-snps-arc@lists.infradead.org, Fenghua Yu , Borislav Petkov , Jeff Dike , Steven Rostedt , Ivan Kokshaysky , Greentime Hu , Guan Xuetao , linux-parisc@vger.kernel.org, linux-alpha@vger.kernel.org, Ley Foon Tan , "David S. Miller" , Rich Felker , Peter Zijlstra , "H. Peter Anvin" , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Anton Ivanov , Jonas Bonn , Richard Weinberger , x86@kernel.org, Russell King , clang-built-linux@googlegroups.com, Ingo Molnar , Mark Salter , Albert Ou , Stefan Kristiansson , openrisc@lists.librecores.org, Paul Walmsley , Michal Simek , Vineet Gupta , linux-mips@vger.kernel.org, Sergey Senozhatsky , Palmer Dabbelt , Jason Wessel , nios2-dev@lists.rocketboards.org, linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On Tue 2019-11-12 13:57:04, Sergey Senozhatsky wrote: > On (19/11/12 13:44), Sergey Senozhatsky wrote: > [..] > > > But yes, this per-code-section loglevel is problematic. The feedback > > > against the patchset shows that people want it also the other way. > > > I mean to keep pr_debug() as pr_debug(). > > > > Hmm. Right. > > > > > A solution might be to use the per-code-section loglevel only instead > > > of some special loglevel. > > > > So maybe we can "overwrite" only KERN_DEFAULT loglevels? > > LOGLEVEL_DEFAULT, LOGLEVEL_NOTICE, LOGLEVEL_INFO? > > So we can downgrade some messages (log_store() only) or promote > some messages. > > DEBUG perhaps should stay debug. > > > We certainly should not mess with SCHED or with anything in between > > EMERG and ERR. > > [EMERG, WARN] This is getting too complicated. It would introduce too many hidden rules. While the explicitly passed loglevel parameter is straightforward and clear. I am getting more inclined to the solution introduced by this patchset. It looks reasonable for the different use-cases. Best Regards, Petr _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Mladek Date: Tue, 12 Nov 2019 09:35:09 +0100 Subject: [OpenRISC] [PATCH 00/50] Add log level to show_stack() In-Reply-To: <20191112045704.GA138013@google.com> References: <20191106030542.868541-1-dima@arista.com> <20191106083538.z5nlpuf64cigxigh@pathway.suse.cz> <20191108103719.GB175344@google.com> <20191108130447.h3wfgo4efjkto56f@pathway.suse.cz> <20191111012336.GA85185@google.com> <20191111091207.u3lrd6cmumnx4czr@pathway.suse.cz> <20191112044447.GA121272@google.com> <20191112045704.GA138013@google.com> Message-ID: <20191112083509.gmgjpkjffsfaw5lm@pathway.suse.cz> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: openrisc@lists.librecores.org On Tue 2019-11-12 13:57:04, Sergey Senozhatsky wrote: > On (19/11/12 13:44), Sergey Senozhatsky wrote: > [..] > > > But yes, this per-code-section loglevel is problematic. The feedback > > > against the patchset shows that people want it also the other way. > > > I mean to keep pr_debug() as pr_debug(). > > > > Hmm. Right. > > > > > A solution might be to use the per-code-section loglevel only instead > > > of some special loglevel. > > > > So maybe we can "overwrite" only KERN_DEFAULT loglevels? > > LOGLEVEL_DEFAULT, LOGLEVEL_NOTICE, LOGLEVEL_INFO? > > So we can downgrade some messages (log_store() only) or promote > some messages. > > DEBUG perhaps should stay debug. > > > We certainly should not mess with SCHED or with anything in between > > EMERG and ERR. > > [EMERG, WARN] This is getting too complicated. It would introduce too many hidden rules. While the explicitly passed loglevel parameter is straightforward and clear. I am getting more inclined to the solution introduced by this patchset. It looks reasonable for the different use-cases. Best Regards, Petr From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 12 Nov 2019 09:35:09 +0100 From: Petr Mladek Subject: Re: [PATCH 00/50] Add log level to show_stack() Message-ID: <20191112083509.gmgjpkjffsfaw5lm@pathway.suse.cz> References: <20191106030542.868541-1-dima@arista.com> <20191106083538.z5nlpuf64cigxigh@pathway.suse.cz> <20191108103719.GB175344@google.com> <20191108130447.h3wfgo4efjkto56f@pathway.suse.cz> <20191111012336.GA85185@google.com> <20191111091207.u3lrd6cmumnx4czr@pathway.suse.cz> <20191112044447.GA121272@google.com> <20191112045704.GA138013@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191112045704.GA138013@google.com> To: Sergey Senozhatsky Cc: Dmitry Safonov , linux-kernel@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com>, Andrew Morton , Greg Kroah-Hartman , Ingo Molnar , Jiri Slaby , Sergey Senozhatsky , Steven Rostedt , Tetsuo Handa , Albert Ou , Ben Segall , Dietmar Eggemann , Greentime Hu , Ingo Molnar , James Hogan , Juri Lelli , Mel Gorman , Michal Simek , Palmer Dabbelt , Paul Burton , Paul Walmsley , Peter Zijlstra , Ralf Baechle , Thomas Gleixner , Vincent Chen , Vincent Guittot , Will Deacon , linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, Ivan Kokshaysky , Matt Turner , Richard Henderson , linux-alpha@vger.kernel.org, Vineet Gupta , linux-snps-arc@lists.infradead.org, Russell King , linux-arm-kernel@lists.infradead.org, clang-built-linux@googlegroups.com, Catalin Marinas , Aurelien Jacquiot , Mark Salter , linux-c6x-dev@linux-c6x.org, Guo Ren , Yoshinori Sato , uclinux-h8-devel@lists.sourceforge.jp, Brian Cain , linux-hexagon@vger.kernel.org, Fenghua Yu , Tony Luck , linux-ia64@vger.kernel.org, Geert Uytterhoeven , linux-m68k@lists.linux-m68k.org, Ley Foon Tan , nios2-dev@lists.rocketboards.org, Jonas Bonn , Stafford Horne , Stefan Kristiansson , openrisc@lists.librecores.org, Helge Deller , "James E.J. Bottomley" , linux-parisc@vger.kernel.org, Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, Christian Borntraeger , Heiko Carstens , Vasily Gorbik , linux-s390@vger.kernel.org, Rich Felker , linux-sh@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org, Anton Ivanov , Jeff Dike , Richard Weinberger , linux-um@lists.infradead.org, Guan Xuetao , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, Chris Zankel , Max Filippov , linux-xtensa@linux-xtensa.org, Len Brown , Pavel Machek , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, Daniel Thompson , Douglas Anderson , Jason Wessel , kgdb-bugreport@lists.sourceforge.net List-ID: On Tue 2019-11-12 13:57:04, Sergey Senozhatsky wrote: > On (19/11/12 13:44), Sergey Senozhatsky wrote: > [..] > > > But yes, this per-code-section loglevel is problematic. The feedback > > > against the patchset shows that people want it also the other way. > > > I mean to keep pr_debug() as pr_debug(). > > > > Hmm. Right. > > > > > A solution might be to use the per-code-section loglevel only instead > > > of some special loglevel. > > > > So maybe we can "overwrite" only KERN_DEFAULT loglevels? > > LOGLEVEL_DEFAULT, LOGLEVEL_NOTICE, LOGLEVEL_INFO? > > So we can downgrade some messages (log_store() only) or promote > some messages. > > DEBUG perhaps should stay debug. > > > We certainly should not mess with SCHED or with anything in between > > EMERG and ERR. > > [EMERG, WARN] This is getting too complicated. It would introduce too many hidden rules. While the explicitly passed loglevel parameter is straightforward and clear. I am getting more inclined to the solution introduced by this patchset. It looks reasonable for the different use-cases. Best Regards, Petr From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Mladek Subject: Re: [PATCH 00/50] Add log level to show_stack() Date: Tue, 12 Nov 2019 09:35:09 +0100 Message-ID: <20191112083509.gmgjpkjffsfaw5lm@pathway.suse.cz> References: <20191106030542.868541-1-dima@arista.com> <20191106083538.z5nlpuf64cigxigh@pathway.suse.cz> <20191108103719.GB175344@google.com> <20191108130447.h3wfgo4efjkto56f@pathway.suse.cz> <20191111012336.GA85185@google.com> <20191111091207.u3lrd6cmumnx4czr@pathway.suse.cz> <20191112044447.GA121272@google.com> <20191112045704.GA138013@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bMxycZME2tS/rVapNWEKJPiFbXGP23IGtFtJ2YJAZaA=; b=p79/Mmz6ho7QPC i2feHMnVi41pPofW7K3Je6E/cRDbjIXm5/pkVIdFFpUiJISQ4zHMW/boUH40hqb7dFgOyI5Wu8a8X IDKAlsY4unX1uTlz9W3CoE7zDFtf/OPTIs67Z+kJ39EkzmnfI/5uWAIW7E8gw7XdpJqPItrqQtIU8 10A0Skvhmw4iuseeckR4+q9qX8wkudgP5+VEIdAdA38+wGwEae5ksSIEUWHG4x5yU69Z4yR3YdHEY RTdDx05Xc+mKQOfGUirs22MC4pU5RNjduYYiOFpC8Q7GulxGZXWs2l1djiimsHYIrAwX3F1fHAwOc FfN8rf/hiZphDekHUc1Q==; Content-Disposition: inline In-Reply-To: <20191112045704.GA138013@google.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane.org@lists.infradead.org To: Sergey Senozhatsky Cc: Juri Lelli , linux-sh@vger.kernel.org, Catalin Marinas , Ben Segall , Guo Ren , Pavel Machek , Vincent Guittot , Paul Burton , Dmitry Safonov , Michael Ellerman , Geert Uytterhoeven , Mel Gorman , Jiri Slaby , Matt Turner , uclinux-h8-devel@lists.sourceforge.jp, Len Brown , linux-pm@vger.kernel.org, Heiko Carstens , linux-um@lists.infradead.org, Thomas Gleixner , Dietmar Eggemann , Richard Henderson , Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-kerne On Tue 2019-11-12 13:57:04, Sergey Senozhatsky wrote: > On (19/11/12 13:44), Sergey Senozhatsky wrote: > [..] > > > But yes, this per-code-section loglevel is problematic. The feedback > > > against the patchset shows that people want it also the other way. > > > I mean to keep pr_debug() as pr_debug(). > > > > Hmm. Right. > > > > > A solution might be to use the per-code-section loglevel only instead > > > of some special loglevel. > > > > So maybe we can "overwrite" only KERN_DEFAULT loglevels? > > LOGLEVEL_DEFAULT, LOGLEVEL_NOTICE, LOGLEVEL_INFO? > > So we can downgrade some messages (log_store() only) or promote > some messages. > > DEBUG perhaps should stay debug. > > > We certainly should not mess with SCHED or with anything in between > > EMERG and ERR. > > [EMERG, WARN] This is getting too complicated. It would introduce too many hidden rules. While the explicitly passed loglevel parameter is straightforward and clear. I am getting more inclined to the solution introduced by this patchset. It looks reasonable for the different use-cases. Best Regards, Petr