From: Sean Young <sean@mess.org>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: linux-media@vger.kernel.org,
syzbot+9d42b7773d2fecd983ab@syzkaller.appspotmail.com
Subject: Re: [PATCH 2/5] dvb-usb/af9005: initialize act_len
Date: Tue, 12 Nov 2019 09:49:04 +0000 [thread overview]
Message-ID: <20191112094904.GA19449@gofer.mess.org> (raw)
In-Reply-To: <20191112092228.15800-3-hverkuil-cisco@xs4all.nl>
On Tue, Nov 12, 2019 at 10:22:25AM +0100, Hans Verkuil wrote:
> The act_len variable was uninitialized, leading to a syzbot
> error.
>
> Syzbot link:
>
> https://syzkaller.appspot.com/bug?extid=9d42b7773d2fecd983ab
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> Reported-and-tested-by: syzbot+9d42b7773d2fecd983ab@syzkaller.appspotmail.com
> CC: Sean Young <sean@mess.org>
This is the same as:
https://patchwork.linuxtv.org/patch/59986/
Sean
> ---
> drivers/media/usb/dvb-usb/af9005.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/dvb-usb/af9005.c b/drivers/media/usb/dvb-usb/af9005.c
> index ac93e88d7038..89b4b5d84cdf 100644
> --- a/drivers/media/usb/dvb-usb/af9005.c
> +++ b/drivers/media/usb/dvb-usb/af9005.c
> @@ -554,7 +554,7 @@ static int af9005_boot_packet(struct usb_device *udev, int type, u8 *reply,
> u8 *buf, int size)
> {
> u16 checksum;
> - int act_len, i, ret;
> + int act_len = 0, i, ret;
>
> memset(buf, 0, size);
> buf[0] = (u8) (FW_BULKOUT_SIZE & 0xff);
> --
> 2.24.0
next prev parent reply other threads:[~2019-11-12 9:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 9:22 [PATCH 0/5] Fix various syzbot errors Hans Verkuil
2019-11-12 9:22 ` [PATCH 1/5] gspca: zero usb_buf Hans Verkuil
2019-11-12 9:22 ` [PATCH 2/5] dvb-usb/af9005: initialize act_len Hans Verkuil
2019-11-12 9:49 ` Sean Young [this message]
2019-11-12 9:22 ` [PATCH 3/5] dvb-usb/vp7045: initialize br[] Hans Verkuil
2019-11-12 9:50 ` Sean Young
2019-11-12 9:22 ` [PATCH 4/5] dvb-usb/digitv: initialize key[] Hans Verkuil
2019-11-12 9:51 ` Sean Young
2019-11-12 9:22 ` [PATCH 5/5] dvb-usb/dvb-usb-urb.c: initialize actlen to 0 Hans Verkuil
2019-11-12 9:53 ` Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112094904.GA19449@gofer.mess.org \
--to=sean@mess.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=syzbot+9d42b7773d2fecd983ab@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.