From: Wei Liu <wl@xen.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Juergen Gross" <jgross@suse.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>, "Wei Liu" <wl@xen.org>,
"Jan Beulich" <JBeulich@suse.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH for-4.13] xen: Drop bogus BOOLEAN definitions, TRUE and FALSE
Date: Tue, 12 Nov 2019 10:42:07 +0000 [thread overview]
Message-ID: <20191112104207.yacyxgkiyvjg6mzj@debian> (raw)
In-Reply-To: <20191111202443.7154-1-andrew.cooper3@citrix.com>
On Mon, Nov 11, 2019 at 08:24:43PM +0000, Andrew Cooper wrote:
> actypes.h and efidef.h both define BOOLEAN as unsigned char, which is buggy in
> combination with logic such as "BOOLEAN b = (a & 0x100);" Redefine BOOLEAN as
> bool instead, which doesn't truncate.
>
> Both also define TRUE and FALSE, with actypes.h being extra rude and replacing
> whatever exists thus far. Drop all uses of TRUE and FALSE, replacing them
> with true/false respectively, and drop the declarations.
>
> Also drop the pointless conditional declaration of NULL while cleaning this
> up.
>
> Finally, correct all the comments which which were found by sed.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Wei Liu <wl@xen.org>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2019-11-12 10:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 20:24 [Xen-devel] [PATCH for-4.13] xen: Drop bogus BOOLEAN definitions, TRUE and FALSE Andrew Cooper
2019-11-11 20:40 ` Stefano Stabellini
2019-11-12 8:35 ` Jan Beulich
2019-11-12 13:39 ` Andrew Cooper
2019-11-12 14:03 ` Jan Beulich
2019-12-06 21:02 ` Andrew Cooper
2019-12-09 12:11 ` Jan Beulich
2019-12-09 12:38 ` Julien Grall
2020-01-06 19:01 ` Andrew Cooper
2020-01-07 8:35 ` Jan Beulich
2019-11-12 10:42 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112104207.yacyxgkiyvjg6mzj@debian \
--to=wl@xen.org \
--cc=JBeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.