From: Luis Henriques <lhenriques@suse.com>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: Sage Weil <sage@newdream.net>, Jeff Layton <jlayton@kernel.org>,
"Yan, Zheng" <ukernel@gmail.com>,
Ceph Development <ceph-devel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 0/2] ceph: safely use 'copy-from' Op on Octopus OSDs
Date: Tue, 12 Nov 2019 10:42:16 +0000 [thread overview]
Message-ID: <20191112104216.GA2028@hermes.olymp> (raw)
In-Reply-To: <CAOi1vP-kFnu_mJaTERHbSjBxQRvfXhFWF=9_nCaaFbh7ACiVhg@mail.gmail.com>
On Mon, Nov 11, 2019 at 09:51:47PM +0100, Ilya Dryomov wrote:
> On Mon, Nov 11, 2019 at 5:30 PM Luis Henriques <lhenriques@suse.com> wrote:
> >
> > On Fri, Nov 08, 2019 at 05:31:01PM +0000, Luis Henriques wrote:
> > <snip>
> > > > - You'll need to add it for both OSDMap::Incremental and OSDMap
> > > > - You'll need to make the encoding condition by updating the block like
> > > > the one below from OSDMap::encode()
> > > >
> > > > uint8_t v = 9;
> > > > if (!HAVE_FEATURE(features, SERVER_LUMINOUS)) {
> > > > v = 3;
> > > > } else if (!HAVE_FEATURE(features, SERVER_MIMIC)) {
> > > > v = 6;
> > > > } else if (!HAVE_FEATURE(features, SERVER_NAUTILUS)) {
> > > > v = 7;
> > > > }
> > > >
> > > > to include a SERVER_OCTOPUS case too. Same goes for Incremental::encode()
> > >
> > > Awesome, thanks! I'll give it a try, and test it with the appropriate
> > > kernel client side changes to use this.
> >
> > Ok, I've got the patch bellow for the OSD code, which IIRC should do
> > exactly what we want: duplicate the require_osd_release in the client
> > side.
> >
> > Now, in order to quickly test this I've started adding flags to the
> > CEPH_FEATURES_SUPPORTED_DEFAULT definition. SERVER_MIMIC *seemed* to be
> > Ok, but once I've added SERVER_NAUTILUS I've realized that we'll need to
> > handle TYPE_MSGR2 address. Which is a _big_ thing. Is anyone already
> > looking into adding support for msgr v2 to the kernel client?
>
> It should be easy enough to hack around it for testing purposes.
>
> I made some initial steps and hope to be able to dedicate the 5.6 cycle
> to it.
Yeah, I'll give that a try; adding support for that new address type
shouldn't be a big deal. I was just wondering if that wasn't already
being handling by any new msgrv2 code under development. Thanks, Ilya.
Cheers,
--
Luís
next prev parent reply other threads:[~2019-11-12 10:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 14:15 [RFC PATCH 0/2] ceph: safely use 'copy-from' Op on Octopus OSDs Luis Henriques
2019-11-08 14:15 ` [RFC PATCH 1/2] ceph: add support for sending truncate_{seq,size} in 'copy-from' Op Luis Henriques
2019-11-08 14:15 ` [RFC PATCH 2/2] ceph: make 'copyfrom' a default mount option again Luis Henriques
2019-11-08 15:15 ` [RFC PATCH 0/2] ceph: safely use 'copy-from' Op on Octopus OSDs Ilya Dryomov
2019-11-08 16:47 ` Luis Henriques
2019-11-08 16:57 ` Sage Weil
2019-11-08 17:16 ` Luis Henriques
2019-11-08 17:22 ` Sage Weil
2019-11-08 17:31 ` Luis Henriques
2019-11-11 16:30 ` Luis Henriques
2019-11-11 20:51 ` Ilya Dryomov
2019-11-12 10:42 ` Luis Henriques [this message]
2019-11-08 16:59 ` Ilya Dryomov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112104216.GA2028@hermes.olymp \
--to=lhenriques@suse.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@newdream.net \
--cc=ukernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.