From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eugeniu Rosca <erosca@de.adit-jv.com>
Date: Tue, 12 Nov 2019 19:18:20 +0100
Subject: [U-Boot] [PATCH v4 2/2] cmd: Add dtimg command
In-Reply-To: <20180816203413.1598-2-semen.protsenko@linaro.org>
References: <20180816203413.1598-1-semen.protsenko@linaro.org>
 <20180816203413.1598-2-semen.protsenko@linaro.org>
Message-ID: <20191112181820.GA7065@vmlxhi-102.adit-jv.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Sam,

On Thu, Aug 16, 2018 at 11:34:13PM +0300, Sam Protsenko wrote:
> dtimg command allows user to work with Android DTB/DTBO image format.
> Such as, getting the address of desired DTB/DTBO file, printing the dump
> of the image in U-Boot shell, etc.
> 
> This command is needed to provide Android boot with new Android DT image
> format further.
> 
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> Reviewed-by: Tom Rini <trini@konsulko.com>

[..]

> +U_BOOT_CMD(
> +	dtimg, CONFIG_SYS_MAXARGS, 0, do_dtimg,
> +	"manipulate dtb/dtbo Android image",
> +	"dump <addr>\n"
> +	"    - parse specified image and print its structure info\n"
> +	"      <addr>: image address in RAM, in hex\n"
> +	"dtimg start <addr> <index> <varname>\n"
> +	"    - get address (hex) of FDT in the image, by index\n"
> +	"      <addr>: image address in RAM, in hex\n"
> +	"      <index>: index of desired FDT in the image\n"
> +	"      <varname>: name of variable where to store address of FDT\n"
> +	"dtimg size <addr> <index> <varname>\n"
> +	"    - get size (hex, bytes) of FDT in the image, by index\n"
> +	"      <addr>: image address in RAM, in hex\n"
> +	"      <index>: index of desired FDT in the image\n"
> +	"      <varname>: name of variable where to store size of FDT"
> +);

Since you are the author and the main stakeholder of "dtimg", could you
kindly feedback the command usage you envision for getting the start and
size of dtb/dtbo blob given a certain "id" and "rev" fields used by
mkdtboimg.py [1] and visible in the output of U-Boot's "dtimg dump" [2]?

One option would be to extend the existing "dtimg {start|size}" to
accept an argument like "id:<val>" and "rev:<val>".

Another possibility is to create brand new dtimg sub-command.
What would be your preference? TIA.

[1] https://android.googlesource.com/platform/system/libufdt/+/master/utils/src/mkdtboimg.py
[2] https://gitlab.denx.de/u-boot/u-boot/commit/e63bf1b13b3a7a

-- 
Best Regards,
Eugeniu