From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo@netfilter.org>
Cc: Phil Sutter <phil@nwl.cc>,
netfilter-devel@vger.kernel.org,
Ash Hughes <sehguh.hsa@gmail.com>
Subject: Re: [conntrack-tools PATCH] helpers: Fix for warning when compiling against libtirpc
Date: Tue, 12 Nov 2019 22:07:24 +0100 [thread overview]
Message-ID: <20191112210724.jdm6ynbuwyl5tqgj@salvia> (raw)
In-Reply-To: <99228355-5f8e-e251-ea3a-0371729e01fd@netfilter.org>
On Tue, Nov 12, 2019 at 11:58:30AM +0100, Arturo Borrero Gonzalez wrote:
> On 11/11/19 6:20 PM, Phil Sutter wrote:
> > Fix for the following warning:
> >
> > In file included from rpc.c:29:
> > /usr/include/tirpc/rpc/rpc_msg.h:214:52: warning: 'struct rpc_err' declared inside parameter list will not be visible outside of this definition or declaration
> > 214 | extern void _seterr_reply(struct rpc_msg *, struct rpc_err *);
> > | ^~~~~~~
> >
> > Struct rpc_err is declared in rpc/clnt.h which also declares rpc_call(),
> > therefore rename the local version.
> >
> > Fixes: 5ededc4476f27 ("conntrackd: search for RPC headers")
> > Signed-off-by: Phil Sutter <phil@nwl.cc>
> > ---
> > src/helpers/rpc.c | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
>
> Acked-by: Arturo Borrero Gonzalez <arturo@netfilter.org>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
prev parent reply other threads:[~2019-11-12 21:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 17:20 [conntrack-tools PATCH] helpers: Fix for warning when compiling against libtirpc Phil Sutter
2019-11-12 10:58 ` Arturo Borrero Gonzalez
2019-11-12 21:07 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112210724.jdm6ynbuwyl5tqgj@salvia \
--to=pablo@netfilter.org \
--cc=arturo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=sehguh.hsa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.