From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73C91C47410 for ; Wed, 13 Nov 2019 16:26:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 645AE22CB2 for ; Wed, 13 Nov 2019 15:49:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727953AbfKMPtu (ORCPT ); Wed, 13 Nov 2019 10:49:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:59466 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726276AbfKMPtt (ORCPT ); Wed, 13 Nov 2019 10:49:49 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 26B8222B4B; Wed, 13 Nov 2019 15:49:47 +0000 (UTC) Date: Wed, 13 Nov 2019 10:49:45 -0500 From: Steven Rostedt To: Dmitry Safonov Cc: linux-kernel@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com>, Andrew Morton , Greg Kroah-Hartman , Ingo Molnar , Jiri Slaby , Petr Mladek , Sergey Senozhatsky , Tetsuo Handa , Albert Ou , Ben Segall , Dietmar Eggemann , Greentime Hu , Ingo Molnar , James Hogan , Juri Lelli , Mel Gorman , Michal Simek , Palmer Dabbelt , Paul Burton , Paul Walmsley , Peter Zijlstra , Ralf Baechle , Thomas Gleixner , Vincent Chen , Vincent Guittot , Will Deacon , linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH 01/50] kallsyms/printk: Add loglvl to print_ip_sym() Message-ID: <20191113104945.604e34d2@gandalf.local.home> In-Reply-To: <20191106030542.868541-2-dima@arista.com> References: <20191106030542.868541-1-dima@arista.com> <20191106030542.868541-2-dima@arista.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 6 Nov 2019 03:04:52 +0000 Dmitry Safonov wrote: > --- a/kernel/trace/ftrace.c > +++ b/kernel/trace/ftrace.c > @@ -2002,12 +2002,12 @@ void ftrace_bug(int failed, struct dyn_ftrace *rec) > case -EFAULT: > FTRACE_WARN_ON_ONCE(1); > pr_info("ftrace faulted on modifying "); Hmm, I wonder if I should change that from info to something more important, as this is important information for debugging. But this has nothing to do with this patch set. > - print_ip_sym(ip); > + print_ip_sym(KERN_INFO, ip); Acked-by: Steven Rostedt (VMware) -- Steve > break; > case -EINVAL: > FTRACE_WARN_ON_ONCE(1); > pr_info("ftrace failed to modify "); > - print_ip_sym(ip); > + print_ip_sym(KERN_INFO, ip); > print_ip_ins(" actual: ", (unsigned char *)ip); > pr_cont("\n"); > if (ftrace_expected) { > @@ -2018,12 +2018,12 @@ void ftrace_bug(int failed, struct dyn_ftrace *rec) > case -EPERM: > FTRACE_WARN_ON_ONCE(1); > pr_info("ftrace faulted on writing "); > - print_ip_sym(ip); > + print_ip_sym(KERN_INFO, ip); > break; > default: > FTRACE_WARN_ON_ONCE(1); > pr_info("ftrace faulted on unknown error "); > - print_ip_sym(ip); > + print_ip_sym(KERN_INFO, ip); > } > print_bug_type(); > if (rec) { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E105C47411 for ; Wed, 13 Nov 2019 16:26:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD0C322CBB for ; Wed, 13 Nov 2019 15:49:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TmMLTbn7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD0C322CBB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xWmD4brqu5aylU8JVHjHl51hhv3H17Fuszmyfq0D4wg=; b=TmMLTbn7S9mT62 U6QaGUtyB8OgkFW8ayLxSwGWY7k0Q7hs9zp9xmOTbTfA9aCRfrehYBmaWiLeZHEzt0mj5cL8VjvLh 4kcfHOKIYERFKQen3ZSeohBvvx8BUFpsFqBUOdAC8U77eG5cQeS+9waYRL/4+ZB40Rw2w5+DGxdeY IyVso994ULLlwCgBLDODlteFomt3/Z927HSIqQ55lUeSUPqBHBsrDh/A5YeKltBn424lz3BrLFZwe SrT1LM9ZNFVtCM0khgl8V3RLM76q7dvISipT9O5HBdu3msqbWf3RSqDQE3INoiyDFTzCL67ySWKgj gWNBw57R0Btj2hTpeIwA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUutz-0002vH-UR; Wed, 13 Nov 2019 15:49:51 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUutx-0002ur-LN for linux-riscv@lists.infradead.org; Wed, 13 Nov 2019 15:49:50 +0000 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 26B8222B4B; Wed, 13 Nov 2019 15:49:47 +0000 (UTC) Date: Wed, 13 Nov 2019 10:49:45 -0500 From: Steven Rostedt To: Dmitry Safonov Subject: Re: [PATCH 01/50] kallsyms/printk: Add loglvl to print_ip_sym() Message-ID: <20191113104945.604e34d2@gandalf.local.home> In-Reply-To: <20191106030542.868541-2-dima@arista.com> References: <20191106030542.868541-1-dima@arista.com> <20191106030542.868541-2-dima@arista.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191113_074949_717271_8D6A102D X-CRM114-Status: GOOD ( 11.48 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juri Lelli , Tetsuo Handa , James Hogan , Dmitry Safonov <0x7f454c46@gmail.com>, linux-mips@vger.kernel.org, Ben Segall , linux-riscv@lists.infradead.org, Vincent Chen , Will Deacon , Ingo Molnar , Vincent Guittot , Paul Burton , Peter Zijlstra , Ingo Molnar , Mel Gorman , Jiri Slaby , Petr Mladek , Albert Ou , Greentime Hu , Paul Walmsley , Thomas Gleixner , Dietmar Eggemann , Michal Simek , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Ralf Baechle , Sergey Senozhatsky , Palmer Dabbelt , Andrew Morton Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, 6 Nov 2019 03:04:52 +0000 Dmitry Safonov wrote: > --- a/kernel/trace/ftrace.c > +++ b/kernel/trace/ftrace.c > @@ -2002,12 +2002,12 @@ void ftrace_bug(int failed, struct dyn_ftrace *rec) > case -EFAULT: > FTRACE_WARN_ON_ONCE(1); > pr_info("ftrace faulted on modifying "); Hmm, I wonder if I should change that from info to something more important, as this is important information for debugging. But this has nothing to do with this patch set. > - print_ip_sym(ip); > + print_ip_sym(KERN_INFO, ip); Acked-by: Steven Rostedt (VMware) -- Steve > break; > case -EINVAL: > FTRACE_WARN_ON_ONCE(1); > pr_info("ftrace failed to modify "); > - print_ip_sym(ip); > + print_ip_sym(KERN_INFO, ip); > print_ip_ins(" actual: ", (unsigned char *)ip); > pr_cont("\n"); > if (ftrace_expected) { > @@ -2018,12 +2018,12 @@ void ftrace_bug(int failed, struct dyn_ftrace *rec) > case -EPERM: > FTRACE_WARN_ON_ONCE(1); > pr_info("ftrace faulted on writing "); > - print_ip_sym(ip); > + print_ip_sym(KERN_INFO, ip); > break; > default: > FTRACE_WARN_ON_ONCE(1); > pr_info("ftrace faulted on unknown error "); > - print_ip_sym(ip); > + print_ip_sym(KERN_INFO, ip); > } > print_bug_type(); > if (rec) { _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv