All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Tero Kristo <t-kristo@ti.com>,
	linux-omap@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: ti: dra7: fix parent for gmac_clkctrl
Date: Wed, 13 Nov 2019 07:40:48 -0800	[thread overview]
Message-ID: <20191113154048.GN5610@atomide.com> (raw)
In-Reply-To: <f6eca2f7-beb1-fc4c-ab8b-3b20cf5e7dd1@ti.com>

* Grygorii Strashko <grygorii.strashko@ti.com> [191113 15:36]:
> 
> 
> On 13/11/2019 17:23, Tony Lindgren wrote:
> > * Grygorii Strashko <grygorii.strashko@ti.com> [191113 10:02]:
> > > 
> > > 
> > > On 11/11/2019 19:12, Tony Lindgren wrote:
> > > > * Grygorii Strashko <grygorii.strashko@ti.com> [191109 14:21]:
> > > > > The parent clk for gmac clk ctrl has to be gmac_main_clk (125MHz) instead
> > > > > of dpll_gmac_ck (1GHz). This is caused incorrect CPSW MDIO operation.
> > > > > Hence, fix it.
> > > > > 
> > > > > Fixes: commit dffa9051d546 ('clk: ti: dra7: add new clkctrl data')
> > > > > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> > > > 
> > > > Hmm is there a mux for the source though?
> > > 
> > > Not sure what do you mean here :(
> > > 
> > > fck clock for CPSW and MDIO is "gmac_main_clk" which is 125MHz and
> > > that what need to be passed to drivers and enabled through the clock tree.
> > > The TI specific PM is handled by gmac_clkctrl DRA7_GMAC_GMAC_CLKCTRL 0
> > > which required sysc programming and child modules dosn't need to even know that.
> > 
> > OK
> > 
> > > So, this patch is simply correct clock tree for dra7:
> > > dpll_gmac_ck -> .... -> gmac_main_clk -> gmac_clkctrl DRA7_GMAC_GMAC_CLKCTRL 0
> > 
> > So I guess there's no mux clock for DRA7_GMAC_GMAC_CLKCTRL 0.
> > 
> > What I meant is maybe check also that no top level mux is needed
> > similar to what we have for these configured with assigned-clocks:
> > 
> > $ git grep -C3 assigned-clock arch/arm/boot/dts/dra7*
> 
> No. No muxes here.

OK thanks for checking.

Tony

  reply	other threads:[~2019-11-13 16:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-09 14:20 [PATCH] clk: ti: dra7: fix parent for gmac_clkctrl Grygorii Strashko
2019-11-11 17:12 ` Tony Lindgren
2019-11-13 10:02   ` Grygorii Strashko
2019-11-13 15:23     ` Tony Lindgren
2019-11-13 15:35       ` Grygorii Strashko
2019-11-13 15:40         ` Tony Lindgren [this message]
2019-12-18 17:46 ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191113154048.GN5610@atomide.com \
    --to=tony@atomide.com \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.