From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1441AC432C3 for ; Fri, 15 Nov 2019 03:21:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DDD6F206F0 for ; Fri, 15 Nov 2019 03:21:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727064AbfKODVx (ORCPT ); Thu, 14 Nov 2019 22:21:53 -0500 Received: from szxga03-in.huawei.com ([45.249.212.189]:2086 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726533AbfKODVw (ORCPT ); Thu, 14 Nov 2019 22:21:52 -0500 Received: from DGGEMM402-HUB.china.huawei.com (unknown [172.30.72.56]) by Forcepoint Email with ESMTP id 0364F1DEFC3323A7AAC6; Fri, 15 Nov 2019 11:21:48 +0800 (CST) Received: from dggeme762-chm.china.huawei.com (10.3.19.108) by DGGEMM402-HUB.china.huawei.com (10.3.20.210) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 Nov 2019 11:21:47 +0800 Received: from architecture4 (10.140.130.215) by dggeme762-chm.china.huawei.com (10.3.19.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Fri, 15 Nov 2019 11:21:47 +0800 Date: Fri, 15 Nov 2019 11:24:16 +0800 From: Gao Xiang To: "Theodore Y. Ts'o" CC: Chao Yu , Andreas Dilger , , , Ritesh Harjani Subject: Re: [PATCH v2] ext4: bio_alloc with __GFP_DIRECT_RECLAIM never fails Message-ID: <20191115032416.GA156858@architecture4> References: <20191030161244.GB3953@hsiangkao-HP-ZHAN-66-Pro-G1> <20191031092315.139267-1-gaoxiang25@huawei.com> <5f46684a-a435-1e15-0054-b708edfce487@huawei.com> <20191115031953.GA30252@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20191115031953.GA30252@mit.edu> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [10.140.130.215] X-ClientProxiedBy: dggeme706-chm.china.huawei.com (10.1.199.102) To dggeme762-chm.china.huawei.com (10.3.19.108) X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ted, On Thu, Nov 14, 2019 at 10:19:53PM -0500, Theodore Y. Ts'o wrote: > On Thu, Oct 31, 2019 at 05:29:58PM +0800, Chao Yu wrote: > > On 2019/10/31 17:23, Gao Xiang wrote: > > > Similar to [1] [2], bio_alloc with __GFP_DIRECT_RECLAIM flags > > > guarantees bio allocation under some given restrictions, as > > > stated in block/bio.c and fs/direct-io.c So here it's ok to > > > not check for NULL value from bio_alloc(). > > > > > > [1] https://lore.kernel.org/r/20191030035518.65477-1-gaoxiang25@huawei.com > > > [2] https://lore.kernel.org/r/20190830162812.GA10694@infradead.org > > > Cc: Theodore Ts'o > > > Cc: Andreas Dilger > > > Cc: Ritesh Harjani > > > Cc: Chao Yu > > > Signed-off-by: Gao Xiang > > > > Reviewed-by: Chao Yu > > Thanks, applied. > > - Ted Thanks for considering this. Have a nice day. Thanks, Gao Xiang