All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Liu <bob.liu@oracle.com>
To: axboe@kernel.dk
Cc: io-uring@vger.kernel.org, Bob Liu <bob.liu@oracle.com>
Subject: [PATCH] io_uring: fix duplicated increase of cached_cq_overflow
Date: Fri, 15 Nov 2019 17:37:33 +0800	[thread overview]
Message-ID: <20191115093733.18396-1-bob.liu@oracle.com> (raw)

cached_cq_overflow already be increased in function
io_cqring_overflow_flush().

Signed-off-by: Bob Liu <bob.liu@oracle.com>
---
 fs/io_uring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 55f8b1d..eb23451 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -701,7 +701,7 @@ static void io_cqring_fill_event(struct io_kiocb *req, long res)
 		WRITE_ONCE(cqe->flags, 0);
 	} else if (ctx->cq_overflow_flushed) {
 		WRITE_ONCE(ctx->rings->cq_overflow,
-				atomic_inc_return(&ctx->cached_cq_overflow));
+				atomic_read(&ctx->cached_cq_overflow));
 	} else {
 		refcount_inc(&req->refs);
 		req->result = res;
-- 
2.9.5


             reply	other threads:[~2019-11-15  9:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-15  9:37 Bob Liu [this message]
2019-11-15  9:49 ` [PATCH] io_uring: fix duplicated increase of cached_cq_overflow Pavel Begunkov
2019-11-15 12:17   ` Bob Liu
2019-11-15 12:41     ` Pavel Begunkov
2019-11-15 13:10       ` Bob Liu
2019-11-15 16:35         ` Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191115093733.18396-1-bob.liu@oracle.com \
    --to=bob.liu@oracle.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.