From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16090C432C3 for ; Fri, 15 Nov 2019 20:12:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D16BF2073A for ; Fri, 15 Nov 2019 20:12:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kJhUtVpg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726988AbfKOUMn (ORCPT ); Fri, 15 Nov 2019 15:12:43 -0500 Received: from mail-pl1-f201.google.com ([209.85.214.201]:49434 "EHLO mail-pl1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726323AbfKOUMm (ORCPT ); Fri, 15 Nov 2019 15:12:42 -0500 Received: by mail-pl1-f201.google.com with SMTP id v1so6987411plz.16 for ; Fri, 15 Nov 2019 12:12:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=Sbu+XQWMurh2GLbIyBKUUnQnRbxa6ToLvKnRjUx2+mk=; b=kJhUtVpgdk+g5aBIsUyY+QtH27c5HF16vPkrUjCEM5Pwwaqzb2GGmppUJuBtJ2uEmE xtPzgwpzAQPIoJY/rL7pbuAyIUVWPFXDzaUWNuRf4Fv80wsomquUVelupyvev2v/ICw5 Kz/MqcK/ccdPC7sM4LJct9KbW2bWOCOHnxazL8HarJM+tCmTbblt+4xDjvhL0oN4ziia trPLPk3ZyBd+a9u45n2nx7U6HwWO3E+tE8ZA6NLvEPYTufe0it+tmbdew7Ubj1GQvJrP Mtgyqiheax6VYwAmbmr5OnynG21/mkmKBvsUHm0snlOBwpcajeCZILEAJwozH5jLK0Gu /LSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=Sbu+XQWMurh2GLbIyBKUUnQnRbxa6ToLvKnRjUx2+mk=; b=A4qQ5J9GcmKcN+ferYEIR5BrP5kGcocV/tBqMDfjYQiCk1VxbxKS2aJ6MxVw/DMaoW beTddr5xXMXG6wBzDAcKDrNtbMEQcUDSLHS5rdQzjoCgdx7G9OxPhodnaPP58f1z+Uve d6Js5PMCZqlleMgEksMbv3v4JphEMwaW7NassXxzlZdmuVNzXkyNe30TJ4DGnNGKjco0 pCCqHVQzETm1jB6SA4sPqvl/n5RrGQNB8jef3Cu2aXwpABAbBDleZqdDBlNNIeqlgjC9 BAHroW2vJLm2qTo9N5QBgwbPUFP8PTXK5f8Nnm4+1xNTKW8EO1d/+8/7jQ06i+UptChI +jYg== X-Gm-Message-State: APjAAAXqAEGtsGfPPIGC+RPfnqJ96XrESHzTZsN7/ECHkAtQerU4nXu0 1NxtLf2MngIqmKO5XvFC4CRUsWhS7Rs= X-Google-Smtp-Source: APXvYqyDBw0YFLaXPMxws6oIH6CoH8g04h4hUhbLnfPSZ1F6jkuwh61Lp96GwRDqu+epjyPBXas46UvTQs0= X-Received: by 2002:a65:6685:: with SMTP id b5mr9039818pgw.94.1573848761875; Fri, 15 Nov 2019 12:12:41 -0800 (PST) Date: Fri, 15 Nov 2019 12:12:25 -0800 Message-Id: <20191115201225.92888-1-lrizzo@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.24.0.432.g9d3f5f5b63-goog Subject: [PATCH] net/mlx4_en: fix mlx4 ethtool -N insertion From: Luigi Rizzo To: netdev@vger.kernel.org Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Luigi Rizzo Content-Type: text/plain; charset="UTF-8" Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org ethtool expects ETHTOOL_GRXCLSRLALL to set ethtool_rxnfc->data with the total number of entries in the rx classifier table. Surprisingly, mlx4 is missing this part (in principle ethtool could still move forward and try the insert). Tested: compiled and run command: phh13:~# ethtool -N eth1 flow-type udp4 queue 4 Added rule with ID 255 Signed-off-by: Luigi Rizzo Change-Id: I18a72f08dfcfb6b9f6aa80fbc12d58553e1fda76 --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c index d8313e2ee6002..c12da02c2d1bd 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c @@ -1745,6 +1745,7 @@ static int mlx4_en_get_rxnfc(struct net_device *dev, struct ethtool_rxnfc *cmd, err = mlx4_en_get_flow(dev, cmd, cmd->fs.location); break; case ETHTOOL_GRXCLSRLALL: + cmd->data = MAX_NUM_OF_FS_RULES; while ((!err || err == -ENOENT) && priority < cmd->rule_cnt) { err = mlx4_en_get_flow(dev, cmd, i); if (!err) -- 2.24.0.432.g9d3f5f5b63-goog