From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4C3CC43215 for ; Fri, 15 Nov 2019 20:43:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B424E2073A for ; Fri, 15 Nov 2019 20:43:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727083AbfKOUn0 (ORCPT ); Fri, 15 Nov 2019 15:43:26 -0500 Received: from mx2.suse.de ([195.135.220.15]:56574 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726567AbfKOUnZ (ORCPT ); Fri, 15 Nov 2019 15:43:25 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 52C57B24F; Fri, 15 Nov 2019 20:43:23 +0000 (UTC) Date: Fri, 15 Nov 2019 12:39:06 -0800 From: Davidlohr Bueso To: Peter Zijlstra Cc: mingo@kernel.org, will@kernel.org, oleg@redhat.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, bigeasy@linutronix.de, juri.lelli@redhat.com, williams@redhat.com, bristot@redhat.com, longman@redhat.com, jack@suse.com Subject: Re: [PATCH 1/5] locking/percpu-rwsem, lockdep: Make percpu-rwsem use its own lockdep_map Message-ID: <20191115203906.fbo6t7d2n6xk3saw@linux-p48b> References: <20191113102115.116470462@infradead.org> <20191113102855.696893455@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20191113102855.696893455@infradead.org> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Nov 2019, Peter Zijlstra wrote: >@@ -37,7 +48,7 @@ static inline void percpu_down_read(stru > { > might_sleep(); > >- rwsem_acquire_read(&sem->rw_sem.dep_map, 0, 0, _RET_IP_); >+ rwsem_acquire_read(&sem->dep_map, 0, 0, _RET_IP_); Unrelated to this patch, but we also need a might_sleep() annotation in percpu_down_write(). Thanks, Davidlohr