From: David Miller <davem@davemloft.net>
To: lrizzo@google.com
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, tariqt@mellanox.com
Subject: Re: [PATCH] net/mlx4_en: fix mlx4 ethtool -N insertion
Date: Sat, 16 Nov 2019 13:10:58 -0800 (PST) [thread overview]
Message-ID: <20191116.131058.1856199123293908506.davem@davemloft.net> (raw)
In-Reply-To: <20191115201225.92888-1-lrizzo@google.com>
From: Luigi Rizzo <lrizzo@google.com>
Date: Fri, 15 Nov 2019 12:12:25 -0800
> ethtool expects ETHTOOL_GRXCLSRLALL to set ethtool_rxnfc->data with the
> total number of entries in the rx classifier table. Surprisingly, mlx4
> is missing this part (in principle ethtool could still move forward and
> try the insert).
>
> Tested: compiled and run command:
> phh13:~# ethtool -N eth1 flow-type udp4 queue 4
> Added rule with ID 255
>
> Signed-off-by: Luigi Rizzo <lrizzo@google.com>
> Change-Id: I18a72f08dfcfb6b9f6aa80fbc12d58553e1fda76
Luigi, _always_ CC: the appropriate maintainer when making changes to the
kernel, as per the top-level MAINTAINERS file.
Tariq et al., please review.
next prev parent reply other threads:[~2019-11-16 21:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 20:12 [PATCH] net/mlx4_en: fix mlx4 ethtool -N insertion Luigi Rizzo
2019-11-16 21:10 ` David Miller [this message]
2019-11-17 14:46 ` Tariq Toukan
2019-11-17 18:29 ` David Miller
2019-11-18 17:38 ` Luigi Rizzo
2019-11-17 15:28 ` Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191116.131058.1856199123293908506.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lrizzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.