Hi Nitin, I love your patch! Yet something to improve: [auto build test ERROR on mmotm/master] [also build test ERROR on v5.4-rc7 next-20191115] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Nitin-Gupta/mm-Proactive-compaction/20191116-062531 base: git://git.cmpxchg.org/linux-mmotm.git master config: parisc-c3000_defconfig (attached as .config) compiler: hppa-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=parisc If you fix the issue, kindly add following tag Reported-by: kbuild test robot All error/warnings (new ones prefixed by >>): mm/compaction.c: In function 'extfrag_hpage_wmark': >> mm/compaction.c:1860:33: error: 'HUGETLB_PAGE_ORDER' undeclared (first use in this function); did you mean 'HPAGE_PMD_ORDER'? return extfrag_for_order(zone, HUGETLB_PAGE_ORDER) > wmark; ^~~~~~~~~~~~~~~~~~ HPAGE_PMD_ORDER mm/compaction.c:1860:33: note: each undeclared identifier is reported only once for each function it appears in mm/compaction.c: In function 'node_hpage_should_compact': mm/compaction.c:1869:30: error: 'HUGETLB_PAGE_ORDER' undeclared (first use in this function); did you mean 'HPAGE_PMD_ORDER'? compaction_suitable(zone, HUGETLB_PAGE_ORDER, ^~~~~~~~~~~~~~~~~~ HPAGE_PMD_ORDER mm/compaction.c: In function 'extfrag_hpage_wmark': >> mm/compaction.c:1861:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ vim +1860 mm/compaction.c 1851 1852 static unsigned int extfrag_hpage_wmark(struct zone *zone, bool low) 1853 { 1854 int node_id, wmark, wmark_low; 1855 1856 node_id = zone->zone_pgdat->node_id; 1857 wmark_low = 100 - compaction_states[node_id].hpage_compaction_effort; 1858 wmark = low ? wmark_low : min(wmark_low + 10, 100); 1859 > 1860 return extfrag_for_order(zone, HUGETLB_PAGE_ORDER) > wmark; > 1861 } 1862 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation