From: Jesper Dangaard Brouer <brouer@redhat.com>
To: "Jonathan Lemon" <jonathan.lemon@gmail.com>
Cc: "Toke Høiland-Jørgensen" <toke@redhat.com>,
netdev@vger.kernel.org,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Saeed Mahameed" <saeedm@mellanox.com>,
"Matteo Croce" <mcroce@redhat.com>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Tariq Toukan" <tariqt@mellanox.com>,
brouer@redhat.com
Subject: Re: [net-next v1 PATCH 3/4] page_pool: block alloc cache during shutdown
Date: Sat, 16 Nov 2019 11:47:07 +0100 [thread overview]
Message-ID: <20191116114707.0bfde142@carbon> (raw)
In-Reply-To: <8FD50D75-44C3-4C67-984E-0B85ADE6BAA5@gmail.com>
On Fri, 15 Nov 2019 10:38:21 -0800
"Jonathan Lemon" <jonathan.lemon@gmail.com> wrote:
> Case 1:
> Now, if the driver screws up and tries to re-use the pool and allocate
> another packet, it enters __page_pool_get_cached(), which will decrement
> the alloc.count, and return NULL. This causes a fallback to
> __get_alloc_pages_slow(), which bumps up the pool inflight count.
I can see that I made a mistake, and cannot use NULL as the poison
value. Let me drop this patch, so others (and yours) can go in before
merge window.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-11-16 10:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 15:05 [net-next v1 PATCH 0/4] page_pool: followup changes to restore tracepoint features Jesper Dangaard Brouer
2019-11-15 15:05 ` [net-next v1 PATCH 1/4] xdp: remove memory poison on free for struct xdp_mem_allocator Jesper Dangaard Brouer
2019-11-15 15:06 ` [net-next v1 PATCH 2/4] page_pool: add destroy attempts counter and rename tracepoint Jesper Dangaard Brouer
2019-11-15 16:33 ` Toke Høiland-Jørgensen
2019-11-16 10:56 ` Jesper Dangaard Brouer
2019-11-15 15:06 ` [net-next v1 PATCH 3/4] page_pool: block alloc cache during shutdown Jesper Dangaard Brouer
2019-11-15 18:38 ` Jonathan Lemon
2019-11-16 10:47 ` Jesper Dangaard Brouer [this message]
2019-11-15 15:06 ` [net-next v1 PATCH 4/4] page_pool: extend tracepoint to also include the page PFN Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191116114707.0bfde142@carbon \
--to=brouer@redhat.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jonathan.lemon@gmail.com \
--cc=lorenzo@kernel.org \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.