From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E7DCC432C0 for ; Tue, 19 Nov 2019 01:27:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 177F120692 for ; Tue, 19 Nov 2019 01:27:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727141AbfKSB1D (ORCPT ); Mon, 18 Nov 2019 20:27:03 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:52284 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726775AbfKSB1D (ORCPT ); Mon, 18 Nov 2019 20:27:03 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6FD9A150FAE85; Mon, 18 Nov 2019 17:27:02 -0800 (PST) Date: Mon, 18 Nov 2019 17:27:01 -0800 (PST) Message-Id: <20191118.172701.853956001676795272.davem@davemloft.net> To: marcelo.leitner@gmail.com Cc: netdev@vger.kernel.org, mcroce@redhat.com Subject: Re: [PATCH net] net/ipv4: fix sysctl max for fib_multipath_hash_policy From: David Miller In-Reply-To: <9b97a07518c119e531de8ab012d95a8f3feea038.1574080178.git.marcelo.leitner@gmail.com> References: <9b97a07518c119e531de8ab012d95a8f3feea038.1574080178.git.marcelo.leitner@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 18 Nov 2019 17:27:02 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Marcelo Ricardo Leitner Date: Mon, 18 Nov 2019 09:46:09 -0300 > Commit eec4844fae7c ("proc/sysctl: add shared variables for range > check") did: > - .extra2 = &two, > + .extra2 = SYSCTL_ONE, > here, which doesn't seem to be intentional, given the changelog. > This patch restores it to the previous, as the value of 2 still makes > sense (used in fib_multipath_hash()). > > Fixes: eec4844fae7c ("proc/sysctl: add shared variables for range check") > Cc: Matteo Croce > Signed-off-by: Marcelo Ricardo Leitner Applied and queued up for -stable, thanks.