All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jtoppins@redhat.com
Cc: netdev@vger.kernel.org, aelior@marvell.com, skalluru@marvell.com,
	GR-everest-linux-l2@marvell.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] bnx2x: initialize ethtool info->fw_version before use
Date: Mon, 18 Nov 2019 17:58:18 -0800 (PST)	[thread overview]
Message-ID: <20191118.175818.1172073606217291260.davem@davemloft.net> (raw)
In-Reply-To: <f40bcf8cd93677c12bca1f06e74385c9a5f49819.1574096873.git.jtoppins@redhat.com>

From: Jonathan Toppins <jtoppins@redhat.com>
Date: Mon, 18 Nov 2019 12:07:53 -0500

>     probe begin { printf("net-info  version 01.01\n")}
> 
>     function memset(msg:long) %{
>     	memset((char*)STAP_ARG_msg,-1,196);
>     %}
> 
>     probe module("bnx2x").function("bnx2x_get_drvinfo")
>     {
>       printf("In function\n");
>       memset(register("rsi"));

This makes no sense.

This function is called with the buffer cleared to zero.

You're scrambling something to simulate a "bug", but that will never
be scrambled in reality.

      parent reply	other threads:[~2019-11-19  1:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-18 17:07 [PATCH net-next] bnx2x: initialize ethtool info->fw_version before use Jonathan Toppins
2019-11-18 22:21 ` Jakub Kicinski
2019-11-19  1:58 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191118.175818.1172073606217291260.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=GR-everest-linux-l2@marvell.com \
    --cc=aelior@marvell.com \
    --cc=jtoppins@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=skalluru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.