All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhong jiang <zhongjiang@huawei.com>
To: <sashal@kernel.org>, <gregkh@linuxfoundation.org>,
	<stable@vger.kernel.org>, <willy@infradead.org>
Cc: <linux-mm@kvack.org>, <yangyingliang@huawei.com>
Subject: [PATCH 4.4] memfd: Use radix_tree_deref_slot_protected to avoid the warning.
Date: Mon, 18 Nov 2019 11:26:09 +0800	[thread overview]
Message-ID: <20191118032610.182862-3-zhongjiang@huawei.com> (raw)
In-Reply-To: <20191118032610.182862-1-zhongjiang@huawei.com>

The commit eb4058d8daf8 ("memfd: Fix locking when tagging pins")
introduces the following warning messages.

*WARNING: suspicious RCU usage in memfd_wait_for_pins*

It is because we still use radix_tree_deref_slot without read_rcu_lock.
We should use radix_tree_deref_slot_protected instead in the case.

Cc: stable@vger.kernel.org
Fixes: eb4058d8daf8 ("memfd: Fix locking when tagging pins")
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
 mm/shmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/shmem.c b/mm/shmem.c
index 62668379623b..e40239bf6dfe 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -1862,7 +1862,7 @@ static void shmem_tag_pins(struct address_space *mapping)
 	spin_lock_irq(&mapping->tree_lock);
 restart:
 	radix_tree_for_each_slot(slot, &mapping->page_tree, &iter, start) {
-		page = radix_tree_deref_slot(slot);
+		page = radix_tree_deref_slot_protected(slot, &mapping->tree_lock);
 		if (!page || radix_tree_exception(page)) {
 			if (radix_tree_deref_retry(page))
 				goto restart;
-- 
2.20.1


  parent reply	other threads:[~2019-11-18  3:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-18  3:26 [PATCH 4.14] memfd: Use radix_tree_deref_slot_protected to avoid the warning zhong jiang
2019-11-18  3:26 ` [PATCH 4.19] " zhong jiang
2019-11-18 12:25   ` Matthew Wilcox
2019-11-19  5:00   ` Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.19-stable tree gregkh
2019-11-18  3:26 ` zhong jiang [this message]
2019-11-18 12:25   ` [PATCH 4.4] memfd: Use radix_tree_deref_slot_protected to avoid the warning Matthew Wilcox
2019-11-19  4:59   ` Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.4-stable tree gregkh
2019-11-18  3:26 ` [PATCH 4.9] memfd: Use radix_tree_deref_slot_protected to avoid the warning zhong jiang
2019-11-18 12:25   ` Matthew Wilcox
2019-11-19  4:59   ` Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.9-stable tree gregkh
2019-11-18 12:24 ` [PATCH 4.14] memfd: Use radix_tree_deref_slot_protected to avoid the warning Matthew Wilcox
2019-11-19  4:59 ` Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.14-stable tree gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191118032610.182862-3-zhongjiang@huawei.com \
    --to=zhongjiang@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-mm@kvack.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=willy@infradead.org \
    --cc=yangyingliang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.