From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A667EC432C0 for ; Mon, 18 Nov 2019 12:01:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 869CB2084D for ; Mon, 18 Nov 2019 12:01:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726506AbfKRMB1 (ORCPT ); Mon, 18 Nov 2019 07:01:27 -0500 Received: from mx2.suse.de ([195.135.220.15]:37310 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726518AbfKRMBZ (ORCPT ); Mon, 18 Nov 2019 07:01:25 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8ECD9AFF6; Mon, 18 Nov 2019 12:01:20 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id CAC881E4AFE; Mon, 18 Nov 2019 10:47:37 +0100 (CET) Date: Mon, 18 Nov 2019 10:47:37 +0100 From: Jan Kara To: John Hubbard Cc: Andrew Morton , Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Christoph Hellwig , Dan Williams , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jan Kara , Jason Gunthorpe , Jens Axboe , Jonathan Corbet , =?iso-8859-1?B?Suly9G1l?= Glisse , Magnus Karlsson , Mauro Carvalho Chehab , Michael Ellerman , Michal Hocko , Mike Kravetz , Paul Mackerras , Shuah Khan , Vlastimil Babka , bpf@vger.kernel.org, dri-devel@lists.freedesktop.org, kvm@vger.kernel.org, linux-block@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, linux-rdma@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-mm@kvack.org, LKML Subject: Re: [PATCH v5 06/24] goldish_pipe: rename local pin_user_pages() routine Message-ID: <20191118094737.GD17319@quack2.suse.cz> References: <20191115055340.1825745-1-jhubbard@nvidia.com> <20191115055340.1825745-7-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191115055340.1825745-7-jhubbard@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu 14-11-19 21:53:22, John Hubbard wrote: > 1. Avoid naming conflicts: rename local static function from > "pin_user_pages()" to "pin_goldfish_pages()". > > An upcoming patch will introduce a global pin_user_pages() > function. > > Reviewed-by: Jérôme Glisse > Reviewed-by: Ira Weiny > Signed-off-by: John Hubbard Looks good to me. You can add: Reviewed-by: Jan Kara Honza > --- > drivers/platform/goldfish/goldfish_pipe.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c > index cef0133aa47a..7ed2a21a0bac 100644 > --- a/drivers/platform/goldfish/goldfish_pipe.c > +++ b/drivers/platform/goldfish/goldfish_pipe.c > @@ -257,12 +257,12 @@ static int goldfish_pipe_error_convert(int status) > } > } > > -static int pin_user_pages(unsigned long first_page, > - unsigned long last_page, > - unsigned int last_page_size, > - int is_write, > - struct page *pages[MAX_BUFFERS_PER_COMMAND], > - unsigned int *iter_last_page_size) > +static int pin_goldfish_pages(unsigned long first_page, > + unsigned long last_page, > + unsigned int last_page_size, > + int is_write, > + struct page *pages[MAX_BUFFERS_PER_COMMAND], > + unsigned int *iter_last_page_size) > { > int ret; > int requested_pages = ((last_page - first_page) >> PAGE_SHIFT) + 1; > @@ -354,9 +354,9 @@ static int transfer_max_buffers(struct goldfish_pipe *pipe, > if (mutex_lock_interruptible(&pipe->lock)) > return -ERESTARTSYS; > > - pages_count = pin_user_pages(first_page, last_page, > - last_page_size, is_write, > - pipe->pages, &iter_last_page_size); > + pages_count = pin_goldfish_pages(first_page, last_page, > + last_page_size, is_write, > + pipe->pages, &iter_last_page_size); > if (pages_count < 0) { > mutex_unlock(&pipe->lock); > return pages_count; > -- > 2.24.0 > -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62E0EC432C0 for ; Mon, 18 Nov 2019 14:10:13 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17F1B20656 for ; Mon, 18 Nov 2019 14:10:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17F1B20656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47GrSf0XPnzDqFG for ; Tue, 19 Nov 2019 01:10:10 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.220.15; helo=mx1.suse.de; envelope-from=jack@suse.cz; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.cz Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47Gnc51zX8zDqTR for ; Mon, 18 Nov 2019 23:01:24 +1100 (AEDT) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8ECD9AFF6; Mon, 18 Nov 2019 12:01:20 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id CAC881E4AFE; Mon, 18 Nov 2019 10:47:37 +0100 (CET) Date: Mon, 18 Nov 2019 10:47:37 +0100 From: Jan Kara To: John Hubbard Subject: Re: [PATCH v5 06/24] goldish_pipe: rename local pin_user_pages() routine Message-ID: <20191118094737.GD17319@quack2.suse.cz> References: <20191115055340.1825745-1-jhubbard@nvidia.com> <20191115055340.1825745-7-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191115055340.1825745-7-jhubbard@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma@vger.kernel.org, Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kernel.org, Magnus Karlsson , Jens Axboe , netdev@vger.kernel.org, Alex Williamson , Daniel Vetter , linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu 14-11-19 21:53:22, John Hubbard wrote: > 1. Avoid naming conflicts: rename local static function from > "pin_user_pages()" to "pin_goldfish_pages()". > > An upcoming patch will introduce a global pin_user_pages() > function. > > Reviewed-by: Jérôme Glisse > Reviewed-by: Ira Weiny > Signed-off-by: John Hubbard Looks good to me. You can add: Reviewed-by: Jan Kara Honza > --- > drivers/platform/goldfish/goldfish_pipe.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c > index cef0133aa47a..7ed2a21a0bac 100644 > --- a/drivers/platform/goldfish/goldfish_pipe.c > +++ b/drivers/platform/goldfish/goldfish_pipe.c > @@ -257,12 +257,12 @@ static int goldfish_pipe_error_convert(int status) > } > } > > -static int pin_user_pages(unsigned long first_page, > - unsigned long last_page, > - unsigned int last_page_size, > - int is_write, > - struct page *pages[MAX_BUFFERS_PER_COMMAND], > - unsigned int *iter_last_page_size) > +static int pin_goldfish_pages(unsigned long first_page, > + unsigned long last_page, > + unsigned int last_page_size, > + int is_write, > + struct page *pages[MAX_BUFFERS_PER_COMMAND], > + unsigned int *iter_last_page_size) > { > int ret; > int requested_pages = ((last_page - first_page) >> PAGE_SHIFT) + 1; > @@ -354,9 +354,9 @@ static int transfer_max_buffers(struct goldfish_pipe *pipe, > if (mutex_lock_interruptible(&pipe->lock)) > return -ERESTARTSYS; > > - pages_count = pin_user_pages(first_page, last_page, > - last_page_size, is_write, > - pipe->pages, &iter_last_page_size); > + pages_count = pin_goldfish_pages(first_page, last_page, > + last_page_size, is_write, > + pipe->pages, &iter_last_page_size); > if (pages_count < 0) { > mutex_unlock(&pipe->lock); > return pages_count; > -- > 2.24.0 > -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH v5 06/24] goldish_pipe: rename local pin_user_pages() routine Date: Mon, 18 Nov 2019 10:47:37 +0100 Message-ID: <20191118094737.GD17319@quack2.suse.cz> References: <20191115055340.1825745-1-jhubbard@nvidia.com> <20191115055340.1825745-7-jhubbard@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id B99496E4A5 for ; Mon, 18 Nov 2019 12:01:22 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20191115055340.1825745-7-jhubbard@nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Hubbard Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Al Viro , Dan Williams , Mauro Carvalho Chehab List-Id: dri-devel@lists.freedesktop.org T24gVGh1IDE0LTExLTE5IDIxOjUzOjIyLCBKb2huIEh1YmJhcmQgd3JvdGU6Cj4gMS4gQXZvaWQg bmFtaW5nIGNvbmZsaWN0czogcmVuYW1lIGxvY2FsIHN0YXRpYyBmdW5jdGlvbiBmcm9tCj4gInBp bl91c2VyX3BhZ2VzKCkiIHRvICJwaW5fZ29sZGZpc2hfcGFnZXMoKSIuCj4gCj4gQW4gdXBjb21p bmcgcGF0Y2ggd2lsbCBpbnRyb2R1Y2UgYSBnbG9iYWwgcGluX3VzZXJfcGFnZXMoKQo+IGZ1bmN0 aW9uLgo+IAo+IFJldmlld2VkLWJ5OiBKw6lyw7RtZSBHbGlzc2UgPGpnbGlzc2VAcmVkaGF0LmNv bT4KPiBSZXZpZXdlZC1ieTogSXJhIFdlaW55IDxpcmEud2VpbnlAaW50ZWwuY29tPgo+IFNpZ25l ZC1vZmYtYnk6IEpvaG4gSHViYmFyZCA8amh1YmJhcmRAbnZpZGlhLmNvbT4KCkxvb2tzIGdvb2Qg dG8gbWUuIFlvdSBjYW4gYWRkOgoKUmV2aWV3ZWQtYnk6IEphbiBLYXJhIDxqYWNrQHN1c2UuY3o+ CgoJCQkJCQkJCUhvbnphCgo+IC0tLQo+ICBkcml2ZXJzL3BsYXRmb3JtL2dvbGRmaXNoL2dvbGRm aXNoX3BpcGUuYyB8IDE4ICsrKysrKysrKy0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgOSBp bnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3Bs YXRmb3JtL2dvbGRmaXNoL2dvbGRmaXNoX3BpcGUuYyBiL2RyaXZlcnMvcGxhdGZvcm0vZ29sZGZp c2gvZ29sZGZpc2hfcGlwZS5jCj4gaW5kZXggY2VmMDEzM2FhNDdhLi43ZWQyYTIxYTBiYWMgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9wbGF0Zm9ybS9nb2xkZmlzaC9nb2xkZmlzaF9waXBlLmMKPiAr KysgYi9kcml2ZXJzL3BsYXRmb3JtL2dvbGRmaXNoL2dvbGRmaXNoX3BpcGUuYwo+IEBAIC0yNTcs MTIgKzI1NywxMiBAQCBzdGF0aWMgaW50IGdvbGRmaXNoX3BpcGVfZXJyb3JfY29udmVydChpbnQg c3RhdHVzKQo+ICAJfQo+ICB9Cj4gIAo+IC1zdGF0aWMgaW50IHBpbl91c2VyX3BhZ2VzKHVuc2ln bmVkIGxvbmcgZmlyc3RfcGFnZSwKPiAtCQkJICB1bnNpZ25lZCBsb25nIGxhc3RfcGFnZSwKPiAt CQkJICB1bnNpZ25lZCBpbnQgbGFzdF9wYWdlX3NpemUsCj4gLQkJCSAgaW50IGlzX3dyaXRlLAo+ IC0JCQkgIHN0cnVjdCBwYWdlICpwYWdlc1tNQVhfQlVGRkVSU19QRVJfQ09NTUFORF0sCj4gLQkJ CSAgdW5zaWduZWQgaW50ICppdGVyX2xhc3RfcGFnZV9zaXplKQo+ICtzdGF0aWMgaW50IHBpbl9n b2xkZmlzaF9wYWdlcyh1bnNpZ25lZCBsb25nIGZpcnN0X3BhZ2UsCj4gKwkJCSAgICAgIHVuc2ln bmVkIGxvbmcgbGFzdF9wYWdlLAo+ICsJCQkgICAgICB1bnNpZ25lZCBpbnQgbGFzdF9wYWdlX3Np emUsCj4gKwkJCSAgICAgIGludCBpc193cml0ZSwKPiArCQkJICAgICAgc3RydWN0IHBhZ2UgKnBh Z2VzW01BWF9CVUZGRVJTX1BFUl9DT01NQU5EXSwKPiArCQkJICAgICAgdW5zaWduZWQgaW50ICpp dGVyX2xhc3RfcGFnZV9zaXplKQo+ICB7Cj4gIAlpbnQgcmV0Owo+ICAJaW50IHJlcXVlc3RlZF9w YWdlcyA9ICgobGFzdF9wYWdlIC0gZmlyc3RfcGFnZSkgPj4gUEFHRV9TSElGVCkgKyAxOwo+IEBA IC0zNTQsOSArMzU0LDkgQEAgc3RhdGljIGludCB0cmFuc2Zlcl9tYXhfYnVmZmVycyhzdHJ1Y3Qg Z29sZGZpc2hfcGlwZSAqcGlwZSwKPiAgCWlmIChtdXRleF9sb2NrX2ludGVycnVwdGlibGUoJnBp cGUtPmxvY2spKQo+ICAJCXJldHVybiAtRVJFU1RBUlRTWVM7Cj4gIAo+IC0JcGFnZXNfY291bnQg PSBwaW5fdXNlcl9wYWdlcyhmaXJzdF9wYWdlLCBsYXN0X3BhZ2UsCj4gLQkJCQkgICAgIGxhc3Rf cGFnZV9zaXplLCBpc193cml0ZSwKPiAtCQkJCSAgICAgcGlwZS0+cGFnZXMsICZpdGVyX2xhc3Rf cGFnZV9zaXplKTsKPiArCXBhZ2VzX2NvdW50ID0gcGluX2dvbGRmaXNoX3BhZ2VzKGZpcnN0X3Bh Z2UsIGxhc3RfcGFnZSwKPiArCQkJCQkgbGFzdF9wYWdlX3NpemUsIGlzX3dyaXRlLAo+ICsJCQkJ CSBwaXBlLT5wYWdlcywgJml0ZXJfbGFzdF9wYWdlX3NpemUpOwo+ICAJaWYgKHBhZ2VzX2NvdW50 IDwgMCkgewo+ICAJCW11dGV4X3VubG9jaygmcGlwZS0+bG9jayk7Cj4gIAkJcmV0dXJuIHBhZ2Vz X2NvdW50Owo+IC0tIAo+IDIuMjQuMAo+IAotLSAKSmFuIEthcmEgPGphY2tAc3VzZS5jb20+ClNV U0UgTGFicywgQ1IKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5826EC432C0 for ; Mon, 18 Nov 2019 12:01:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33F4020891 for ; Mon, 18 Nov 2019 12:01:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33F4020891 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8200A6E4AA; Mon, 18 Nov 2019 12:01:24 +0000 (UTC) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id B99496E4A5 for ; Mon, 18 Nov 2019 12:01:22 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8ECD9AFF6; Mon, 18 Nov 2019 12:01:20 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id CAC881E4AFE; Mon, 18 Nov 2019 10:47:37 +0100 (CET) Date: Mon, 18 Nov 2019 10:47:37 +0100 From: Jan Kara To: John Hubbard Subject: Re: [PATCH v5 06/24] goldish_pipe: rename local pin_user_pages() routine Message-ID: <20191118094737.GD17319@quack2.suse.cz> References: <20191115055340.1825745-1-jhubbard@nvidia.com> <20191115055340.1825745-7-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191115055340.1825745-7-jhubbard@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kernel.org, Magnus Karlsson , Jens Axboe , netdev@vger.kernel.org, Alex Williamson , linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Kravetz Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191118094737.mawN74RqX5RxcS1bYWxdRWuAe1E1SLu78hLKphDFftA@z> T24gVGh1IDE0LTExLTE5IDIxOjUzOjIyLCBKb2huIEh1YmJhcmQgd3JvdGU6Cj4gMS4gQXZvaWQg bmFtaW5nIGNvbmZsaWN0czogcmVuYW1lIGxvY2FsIHN0YXRpYyBmdW5jdGlvbiBmcm9tCj4gInBp bl91c2VyX3BhZ2VzKCkiIHRvICJwaW5fZ29sZGZpc2hfcGFnZXMoKSIuCj4gCj4gQW4gdXBjb21p bmcgcGF0Y2ggd2lsbCBpbnRyb2R1Y2UgYSBnbG9iYWwgcGluX3VzZXJfcGFnZXMoKQo+IGZ1bmN0 aW9uLgo+IAo+IFJldmlld2VkLWJ5OiBKw6lyw7RtZSBHbGlzc2UgPGpnbGlzc2VAcmVkaGF0LmNv bT4KPiBSZXZpZXdlZC1ieTogSXJhIFdlaW55IDxpcmEud2VpbnlAaW50ZWwuY29tPgo+IFNpZ25l ZC1vZmYtYnk6IEpvaG4gSHViYmFyZCA8amh1YmJhcmRAbnZpZGlhLmNvbT4KCkxvb2tzIGdvb2Qg dG8gbWUuIFlvdSBjYW4gYWRkOgoKUmV2aWV3ZWQtYnk6IEphbiBLYXJhIDxqYWNrQHN1c2UuY3o+ CgoJCQkJCQkJCUhvbnphCgo+IC0tLQo+ICBkcml2ZXJzL3BsYXRmb3JtL2dvbGRmaXNoL2dvbGRm aXNoX3BpcGUuYyB8IDE4ICsrKysrKysrKy0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgOSBp bnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3Bs YXRmb3JtL2dvbGRmaXNoL2dvbGRmaXNoX3BpcGUuYyBiL2RyaXZlcnMvcGxhdGZvcm0vZ29sZGZp c2gvZ29sZGZpc2hfcGlwZS5jCj4gaW5kZXggY2VmMDEzM2FhNDdhLi43ZWQyYTIxYTBiYWMgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9wbGF0Zm9ybS9nb2xkZmlzaC9nb2xkZmlzaF9waXBlLmMKPiAr KysgYi9kcml2ZXJzL3BsYXRmb3JtL2dvbGRmaXNoL2dvbGRmaXNoX3BpcGUuYwo+IEBAIC0yNTcs MTIgKzI1NywxMiBAQCBzdGF0aWMgaW50IGdvbGRmaXNoX3BpcGVfZXJyb3JfY29udmVydChpbnQg c3RhdHVzKQo+ICAJfQo+ICB9Cj4gIAo+IC1zdGF0aWMgaW50IHBpbl91c2VyX3BhZ2VzKHVuc2ln bmVkIGxvbmcgZmlyc3RfcGFnZSwKPiAtCQkJICB1bnNpZ25lZCBsb25nIGxhc3RfcGFnZSwKPiAt CQkJICB1bnNpZ25lZCBpbnQgbGFzdF9wYWdlX3NpemUsCj4gLQkJCSAgaW50IGlzX3dyaXRlLAo+ IC0JCQkgIHN0cnVjdCBwYWdlICpwYWdlc1tNQVhfQlVGRkVSU19QRVJfQ09NTUFORF0sCj4gLQkJ CSAgdW5zaWduZWQgaW50ICppdGVyX2xhc3RfcGFnZV9zaXplKQo+ICtzdGF0aWMgaW50IHBpbl9n b2xkZmlzaF9wYWdlcyh1bnNpZ25lZCBsb25nIGZpcnN0X3BhZ2UsCj4gKwkJCSAgICAgIHVuc2ln bmVkIGxvbmcgbGFzdF9wYWdlLAo+ICsJCQkgICAgICB1bnNpZ25lZCBpbnQgbGFzdF9wYWdlX3Np emUsCj4gKwkJCSAgICAgIGludCBpc193cml0ZSwKPiArCQkJICAgICAgc3RydWN0IHBhZ2UgKnBh Z2VzW01BWF9CVUZGRVJTX1BFUl9DT01NQU5EXSwKPiArCQkJICAgICAgdW5zaWduZWQgaW50ICpp dGVyX2xhc3RfcGFnZV9zaXplKQo+ICB7Cj4gIAlpbnQgcmV0Owo+ICAJaW50IHJlcXVlc3RlZF9w YWdlcyA9ICgobGFzdF9wYWdlIC0gZmlyc3RfcGFnZSkgPj4gUEFHRV9TSElGVCkgKyAxOwo+IEBA IC0zNTQsOSArMzU0LDkgQEAgc3RhdGljIGludCB0cmFuc2Zlcl9tYXhfYnVmZmVycyhzdHJ1Y3Qg Z29sZGZpc2hfcGlwZSAqcGlwZSwKPiAgCWlmIChtdXRleF9sb2NrX2ludGVycnVwdGlibGUoJnBp cGUtPmxvY2spKQo+ICAJCXJldHVybiAtRVJFU1RBUlRTWVM7Cj4gIAo+IC0JcGFnZXNfY291bnQg PSBwaW5fdXNlcl9wYWdlcyhmaXJzdF9wYWdlLCBsYXN0X3BhZ2UsCj4gLQkJCQkgICAgIGxhc3Rf cGFnZV9zaXplLCBpc193cml0ZSwKPiAtCQkJCSAgICAgcGlwZS0+cGFnZXMsICZpdGVyX2xhc3Rf cGFnZV9zaXplKTsKPiArCXBhZ2VzX2NvdW50ID0gcGluX2dvbGRmaXNoX3BhZ2VzKGZpcnN0X3Bh Z2UsIGxhc3RfcGFnZSwKPiArCQkJCQkgbGFzdF9wYWdlX3NpemUsIGlzX3dyaXRlLAo+ICsJCQkJ CSBwaXBlLT5wYWdlcywgJml0ZXJfbGFzdF9wYWdlX3NpemUpOwo+ICAJaWYgKHBhZ2VzX2NvdW50 IDwgMCkgewo+ICAJCW11dGV4X3VubG9jaygmcGlwZS0+bG9jayk7Cj4gIAkJcmV0dXJuIHBhZ2Vz X2NvdW50Owo+IC0tIAo+IDIuMjQuMAo+IAotLSAKSmFuIEthcmEgPGphY2tAc3VzZS5jb20+ClNV U0UgTGFicywgQ1IKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs