From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF60EC432C0 for ; Mon, 18 Nov 2019 12:01:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8412220857 for ; Mon, 18 Nov 2019 12:01:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726985AbfKRMBs (ORCPT ); Mon, 18 Nov 2019 07:01:48 -0500 Received: from mx2.suse.de ([195.135.220.15]:37574 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726895AbfKRMB1 (ORCPT ); Mon, 18 Nov 2019 07:01:27 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E731CB061; Mon, 18 Nov 2019 12:01:20 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 7EC421E4B09; Mon, 18 Nov 2019 11:16:58 +0100 (CET) Date: Mon, 18 Nov 2019 11:16:58 +0100 From: Jan Kara To: John Hubbard Cc: Andrew Morton , Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Christoph Hellwig , Dan Williams , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jan Kara , Jason Gunthorpe , Jens Axboe , Jonathan Corbet , =?iso-8859-1?B?Suly9G1l?= Glisse , Magnus Karlsson , Mauro Carvalho Chehab , Michael Ellerman , Michal Hocko , Mike Kravetz , Paul Mackerras , Shuah Khan , Vlastimil Babka , bpf@vger.kernel.org, dri-devel@lists.freedesktop.org, kvm@vger.kernel.org, linux-block@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, linux-rdma@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-mm@kvack.org, LKML Subject: Re: [PATCH v5 11/24] goldish_pipe: convert to pin_user_pages() and put_user_page() Message-ID: <20191118101658.GG17319@quack2.suse.cz> References: <20191115055340.1825745-1-jhubbard@nvidia.com> <20191115055340.1825745-12-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191115055340.1825745-12-jhubbard@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu 14-11-19 21:53:27, John Hubbard wrote: > 1. Call the new global pin_user_pages_fast(), from pin_goldfish_pages(). > > 2. As required by pin_user_pages(), release these pages via > put_user_page(). In this case, do so via put_user_pages_dirty_lock(). > > That has the side effect of calling set_page_dirty_lock(), instead > of set_page_dirty(). This is probably more accurate. > > As Christoph Hellwig put it, "set_page_dirty() is only safe if we are > dealing with a file backed page where we have reference on the inode it > hangs off." [1] > > Another side effect is that the release code is simplified because > the page[] loop is now in gup.c instead of here, so just delete the > local release_user_pages() entirely, and call > put_user_pages_dirty_lock() directly, instead. > > [1] https://lore.kernel.org/r/20190723153640.GB720@lst.de > > Reviewed-by: Ira Weiny > Signed-off-by: John Hubbard Looks good to me. You can add: Reviewed-by: Jan Kara Honza > --- > drivers/platform/goldfish/goldfish_pipe.c | 17 +++-------------- > 1 file changed, 3 insertions(+), 14 deletions(-) > > diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c > index 7ed2a21a0bac..635a8bc1b480 100644 > --- a/drivers/platform/goldfish/goldfish_pipe.c > +++ b/drivers/platform/goldfish/goldfish_pipe.c > @@ -274,7 +274,7 @@ static int pin_goldfish_pages(unsigned long first_page, > *iter_last_page_size = last_page_size; > } > > - ret = get_user_pages_fast(first_page, requested_pages, > + ret = pin_user_pages_fast(first_page, requested_pages, > !is_write ? FOLL_WRITE : 0, > pages); > if (ret <= 0) > @@ -285,18 +285,6 @@ static int pin_goldfish_pages(unsigned long first_page, > return ret; > } > > -static void release_user_pages(struct page **pages, int pages_count, > - int is_write, s32 consumed_size) > -{ > - int i; > - > - for (i = 0; i < pages_count; i++) { > - if (!is_write && consumed_size > 0) > - set_page_dirty(pages[i]); > - put_page(pages[i]); > - } > -} > - > /* Populate the call parameters, merging adjacent pages together */ > static void populate_rw_params(struct page **pages, > int pages_count, > @@ -372,7 +360,8 @@ static int transfer_max_buffers(struct goldfish_pipe *pipe, > > *consumed_size = pipe->command_buffer->rw_params.consumed_size; > > - release_user_pages(pipe->pages, pages_count, is_write, *consumed_size); > + put_user_pages_dirty_lock(pipe->pages, pages_count, > + !is_write && *consumed_size > 0); > > mutex_unlock(&pipe->lock); > return 0; > -- > 2.24.0 > -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39EA9C432C0 for ; Mon, 18 Nov 2019 14:16:02 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E60DF20656 for ; Mon, 18 Nov 2019 14:16:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E60DF20656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47GrbN0hrnzDqLH for ; Tue, 19 Nov 2019 01:16:00 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.220.15; helo=mx1.suse.de; envelope-from=jack@suse.cz; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.cz Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47Gnc95rHZzDqQq for ; Mon, 18 Nov 2019 23:01:29 +1100 (AEDT) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E731CB061; Mon, 18 Nov 2019 12:01:20 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 7EC421E4B09; Mon, 18 Nov 2019 11:16:58 +0100 (CET) Date: Mon, 18 Nov 2019 11:16:58 +0100 From: Jan Kara To: John Hubbard Subject: Re: [PATCH v5 11/24] goldish_pipe: convert to pin_user_pages() and put_user_page() Message-ID: <20191118101658.GG17319@quack2.suse.cz> References: <20191115055340.1825745-1-jhubbard@nvidia.com> <20191115055340.1825745-12-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191115055340.1825745-12-jhubbard@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma@vger.kernel.org, Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kernel.org, Magnus Karlsson , Jens Axboe , netdev@vger.kernel.org, Alex Williamson , Daniel Vetter , linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu 14-11-19 21:53:27, John Hubbard wrote: > 1. Call the new global pin_user_pages_fast(), from pin_goldfish_pages(). > > 2. As required by pin_user_pages(), release these pages via > put_user_page(). In this case, do so via put_user_pages_dirty_lock(). > > That has the side effect of calling set_page_dirty_lock(), instead > of set_page_dirty(). This is probably more accurate. > > As Christoph Hellwig put it, "set_page_dirty() is only safe if we are > dealing with a file backed page where we have reference on the inode it > hangs off." [1] > > Another side effect is that the release code is simplified because > the page[] loop is now in gup.c instead of here, so just delete the > local release_user_pages() entirely, and call > put_user_pages_dirty_lock() directly, instead. > > [1] https://lore.kernel.org/r/20190723153640.GB720@lst.de > > Reviewed-by: Ira Weiny > Signed-off-by: John Hubbard Looks good to me. You can add: Reviewed-by: Jan Kara Honza > --- > drivers/platform/goldfish/goldfish_pipe.c | 17 +++-------------- > 1 file changed, 3 insertions(+), 14 deletions(-) > > diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c > index 7ed2a21a0bac..635a8bc1b480 100644 > --- a/drivers/platform/goldfish/goldfish_pipe.c > +++ b/drivers/platform/goldfish/goldfish_pipe.c > @@ -274,7 +274,7 @@ static int pin_goldfish_pages(unsigned long first_page, > *iter_last_page_size = last_page_size; > } > > - ret = get_user_pages_fast(first_page, requested_pages, > + ret = pin_user_pages_fast(first_page, requested_pages, > !is_write ? FOLL_WRITE : 0, > pages); > if (ret <= 0) > @@ -285,18 +285,6 @@ static int pin_goldfish_pages(unsigned long first_page, > return ret; > } > > -static void release_user_pages(struct page **pages, int pages_count, > - int is_write, s32 consumed_size) > -{ > - int i; > - > - for (i = 0; i < pages_count; i++) { > - if (!is_write && consumed_size > 0) > - set_page_dirty(pages[i]); > - put_page(pages[i]); > - } > -} > - > /* Populate the call parameters, merging adjacent pages together */ > static void populate_rw_params(struct page **pages, > int pages_count, > @@ -372,7 +360,8 @@ static int transfer_max_buffers(struct goldfish_pipe *pipe, > > *consumed_size = pipe->command_buffer->rw_params.consumed_size; > > - release_user_pages(pipe->pages, pages_count, is_write, *consumed_size); > + put_user_pages_dirty_lock(pipe->pages, pages_count, > + !is_write && *consumed_size > 0); > > mutex_unlock(&pipe->lock); > return 0; > -- > 2.24.0 > -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH v5 11/24] goldish_pipe: convert to pin_user_pages() and put_user_page() Date: Mon, 18 Nov 2019 11:16:58 +0100 Message-ID: <20191118101658.GG17319@quack2.suse.cz> References: <20191115055340.1825745-1-jhubbard@nvidia.com> <20191115055340.1825745-12-jhubbard@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 28F806E4A5 for ; Mon, 18 Nov 2019 12:01:24 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20191115055340.1825745-12-jhubbard@nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Hubbard Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Al Viro , Dan Williams , Mauro Carvalho Chehab List-Id: dri-devel@lists.freedesktop.org T24gVGh1IDE0LTExLTE5IDIxOjUzOjI3LCBKb2huIEh1YmJhcmQgd3JvdGU6Cj4gMS4gQ2FsbCB0 aGUgbmV3IGdsb2JhbCBwaW5fdXNlcl9wYWdlc19mYXN0KCksIGZyb20gcGluX2dvbGRmaXNoX3Bh Z2VzKCkuCj4gCj4gMi4gQXMgcmVxdWlyZWQgYnkgcGluX3VzZXJfcGFnZXMoKSwgcmVsZWFzZSB0 aGVzZSBwYWdlcyB2aWEKPiBwdXRfdXNlcl9wYWdlKCkuIEluIHRoaXMgY2FzZSwgZG8gc28gdmlh IHB1dF91c2VyX3BhZ2VzX2RpcnR5X2xvY2soKS4KPiAKPiBUaGF0IGhhcyB0aGUgc2lkZSBlZmZl Y3Qgb2YgY2FsbGluZyBzZXRfcGFnZV9kaXJ0eV9sb2NrKCksIGluc3RlYWQKPiBvZiBzZXRfcGFn ZV9kaXJ0eSgpLiBUaGlzIGlzIHByb2JhYmx5IG1vcmUgYWNjdXJhdGUuCj4gCj4gQXMgQ2hyaXN0 b3BoIEhlbGx3aWcgcHV0IGl0LCAic2V0X3BhZ2VfZGlydHkoKSBpcyBvbmx5IHNhZmUgaWYgd2Ug YXJlCj4gZGVhbGluZyB3aXRoIGEgZmlsZSBiYWNrZWQgcGFnZSB3aGVyZSB3ZSBoYXZlIHJlZmVy ZW5jZSBvbiB0aGUgaW5vZGUgaXQKPiBoYW5ncyBvZmYuIiBbMV0KPiAKPiBBbm90aGVyIHNpZGUg ZWZmZWN0IGlzIHRoYXQgdGhlIHJlbGVhc2UgY29kZSBpcyBzaW1wbGlmaWVkIGJlY2F1c2UKPiB0 aGUgcGFnZVtdIGxvb3AgaXMgbm93IGluIGd1cC5jIGluc3RlYWQgb2YgaGVyZSwgc28ganVzdCBk ZWxldGUgdGhlCj4gbG9jYWwgcmVsZWFzZV91c2VyX3BhZ2VzKCkgZW50aXJlbHksIGFuZCBjYWxs Cj4gcHV0X3VzZXJfcGFnZXNfZGlydHlfbG9jaygpIGRpcmVjdGx5LCBpbnN0ZWFkLgo+IAo+IFsx XSBodHRwczovL2xvcmUua2VybmVsLm9yZy9yLzIwMTkwNzIzMTUzNjQwLkdCNzIwQGxzdC5kZQo+ IAo+IFJldmlld2VkLWJ5OiBJcmEgV2VpbnkgPGlyYS53ZWlueUBpbnRlbC5jb20+Cj4gU2lnbmVk LW9mZi1ieTogSm9obiBIdWJiYXJkIDxqaHViYmFyZEBudmlkaWEuY29tPgoKTG9va3MgZ29vZCB0 byBtZS4gWW91IGNhbiBhZGQ6CgpSZXZpZXdlZC1ieTogSmFuIEthcmEgPGphY2tAc3VzZS5jej4K CgkJCQkJCQkJSG9uemEKCj4gLS0tCj4gIGRyaXZlcnMvcGxhdGZvcm0vZ29sZGZpc2gvZ29sZGZp c2hfcGlwZS5jIHwgMTcgKysrLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5z ZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGxh dGZvcm0vZ29sZGZpc2gvZ29sZGZpc2hfcGlwZS5jIGIvZHJpdmVycy9wbGF0Zm9ybS9nb2xkZmlz aC9nb2xkZmlzaF9waXBlLmMKPiBpbmRleCA3ZWQyYTIxYTBiYWMuLjYzNWE4YmMxYjQ4MCAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL3BsYXRmb3JtL2dvbGRmaXNoL2dvbGRmaXNoX3BpcGUuYwo+ICsr KyBiL2RyaXZlcnMvcGxhdGZvcm0vZ29sZGZpc2gvZ29sZGZpc2hfcGlwZS5jCj4gQEAgLTI3NCw3 ICsyNzQsNyBAQCBzdGF0aWMgaW50IHBpbl9nb2xkZmlzaF9wYWdlcyh1bnNpZ25lZCBsb25nIGZp cnN0X3BhZ2UsCj4gIAkJKml0ZXJfbGFzdF9wYWdlX3NpemUgPSBsYXN0X3BhZ2Vfc2l6ZTsKPiAg CX0KPiAgCj4gLQlyZXQgPSBnZXRfdXNlcl9wYWdlc19mYXN0KGZpcnN0X3BhZ2UsIHJlcXVlc3Rl ZF9wYWdlcywKPiArCXJldCA9IHBpbl91c2VyX3BhZ2VzX2Zhc3QoZmlyc3RfcGFnZSwgcmVxdWVz dGVkX3BhZ2VzLAo+ICAJCQkJICAhaXNfd3JpdGUgPyBGT0xMX1dSSVRFIDogMCwKPiAgCQkJCSAg cGFnZXMpOwo+ICAJaWYgKHJldCA8PSAwKQo+IEBAIC0yODUsMTggKzI4NSw2IEBAIHN0YXRpYyBp bnQgcGluX2dvbGRmaXNoX3BhZ2VzKHVuc2lnbmVkIGxvbmcgZmlyc3RfcGFnZSwKPiAgCXJldHVy biByZXQ7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIHJlbGVhc2VfdXNlcl9wYWdlcyhzdHJ1Y3Qg cGFnZSAqKnBhZ2VzLCBpbnQgcGFnZXNfY291bnQsCj4gLQkJCSAgICAgICBpbnQgaXNfd3JpdGUs IHMzMiBjb25zdW1lZF9zaXplKQo+IC17Cj4gLQlpbnQgaTsKPiAtCj4gLQlmb3IgKGkgPSAwOyBp IDwgcGFnZXNfY291bnQ7IGkrKykgewo+IC0JCWlmICghaXNfd3JpdGUgJiYgY29uc3VtZWRfc2l6 ZSA+IDApCj4gLQkJCXNldF9wYWdlX2RpcnR5KHBhZ2VzW2ldKTsKPiAtCQlwdXRfcGFnZShwYWdl c1tpXSk7Cj4gLQl9Cj4gLX0KPiAtCj4gIC8qIFBvcHVsYXRlIHRoZSBjYWxsIHBhcmFtZXRlcnMs IG1lcmdpbmcgYWRqYWNlbnQgcGFnZXMgdG9nZXRoZXIgKi8KPiAgc3RhdGljIHZvaWQgcG9wdWxh dGVfcndfcGFyYW1zKHN0cnVjdCBwYWdlICoqcGFnZXMsCj4gIAkJCSAgICAgICBpbnQgcGFnZXNf Y291bnQsCj4gQEAgLTM3Miw3ICszNjAsOCBAQCBzdGF0aWMgaW50IHRyYW5zZmVyX21heF9idWZm ZXJzKHN0cnVjdCBnb2xkZmlzaF9waXBlICpwaXBlLAo+ICAKPiAgCSpjb25zdW1lZF9zaXplID0g cGlwZS0+Y29tbWFuZF9idWZmZXItPnJ3X3BhcmFtcy5jb25zdW1lZF9zaXplOwo+ICAKPiAtCXJl bGVhc2VfdXNlcl9wYWdlcyhwaXBlLT5wYWdlcywgcGFnZXNfY291bnQsIGlzX3dyaXRlLCAqY29u c3VtZWRfc2l6ZSk7Cj4gKwlwdXRfdXNlcl9wYWdlc19kaXJ0eV9sb2NrKHBpcGUtPnBhZ2VzLCBw YWdlc19jb3VudCwKPiArCQkJCSAgIWlzX3dyaXRlICYmICpjb25zdW1lZF9zaXplID4gMCk7Cj4g IAo+ICAJbXV0ZXhfdW5sb2NrKCZwaXBlLT5sb2NrKTsKPiAgCXJldHVybiAwOwo+IC0tIAo+IDIu MjQuMAo+IAotLSAKSmFuIEthcmEgPGphY2tAc3VzZS5jb20+ClNVU0UgTGFicywgQ1IKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67B7DC432C0 for ; Mon, 18 Nov 2019 12:01:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44D9A2084D for ; Mon, 18 Nov 2019 12:01:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44D9A2084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB2BD6E4B6; Mon, 18 Nov 2019 12:01:29 +0000 (UTC) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 28F806E4A5 for ; Mon, 18 Nov 2019 12:01:24 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E731CB061; Mon, 18 Nov 2019 12:01:20 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 7EC421E4B09; Mon, 18 Nov 2019 11:16:58 +0100 (CET) Date: Mon, 18 Nov 2019 11:16:58 +0100 From: Jan Kara To: John Hubbard Subject: Re: [PATCH v5 11/24] goldish_pipe: convert to pin_user_pages() and put_user_page() Message-ID: <20191118101658.GG17319@quack2.suse.cz> References: <20191115055340.1825745-1-jhubbard@nvidia.com> <20191115055340.1825745-12-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191115055340.1825745-12-jhubbard@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kernel.org, Magnus Karlsson , Jens Axboe , netdev@vger.kernel.org, Alex Williamson , linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Kravetz Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191118101658.WY56rrxFT0jbDgJhv7yn_zZws38r_eq7nVPhqHBwcnw@z> T24gVGh1IDE0LTExLTE5IDIxOjUzOjI3LCBKb2huIEh1YmJhcmQgd3JvdGU6Cj4gMS4gQ2FsbCB0 aGUgbmV3IGdsb2JhbCBwaW5fdXNlcl9wYWdlc19mYXN0KCksIGZyb20gcGluX2dvbGRmaXNoX3Bh Z2VzKCkuCj4gCj4gMi4gQXMgcmVxdWlyZWQgYnkgcGluX3VzZXJfcGFnZXMoKSwgcmVsZWFzZSB0 aGVzZSBwYWdlcyB2aWEKPiBwdXRfdXNlcl9wYWdlKCkuIEluIHRoaXMgY2FzZSwgZG8gc28gdmlh IHB1dF91c2VyX3BhZ2VzX2RpcnR5X2xvY2soKS4KPiAKPiBUaGF0IGhhcyB0aGUgc2lkZSBlZmZl Y3Qgb2YgY2FsbGluZyBzZXRfcGFnZV9kaXJ0eV9sb2NrKCksIGluc3RlYWQKPiBvZiBzZXRfcGFn ZV9kaXJ0eSgpLiBUaGlzIGlzIHByb2JhYmx5IG1vcmUgYWNjdXJhdGUuCj4gCj4gQXMgQ2hyaXN0 b3BoIEhlbGx3aWcgcHV0IGl0LCAic2V0X3BhZ2VfZGlydHkoKSBpcyBvbmx5IHNhZmUgaWYgd2Ug YXJlCj4gZGVhbGluZyB3aXRoIGEgZmlsZSBiYWNrZWQgcGFnZSB3aGVyZSB3ZSBoYXZlIHJlZmVy ZW5jZSBvbiB0aGUgaW5vZGUgaXQKPiBoYW5ncyBvZmYuIiBbMV0KPiAKPiBBbm90aGVyIHNpZGUg ZWZmZWN0IGlzIHRoYXQgdGhlIHJlbGVhc2UgY29kZSBpcyBzaW1wbGlmaWVkIGJlY2F1c2UKPiB0 aGUgcGFnZVtdIGxvb3AgaXMgbm93IGluIGd1cC5jIGluc3RlYWQgb2YgaGVyZSwgc28ganVzdCBk ZWxldGUgdGhlCj4gbG9jYWwgcmVsZWFzZV91c2VyX3BhZ2VzKCkgZW50aXJlbHksIGFuZCBjYWxs Cj4gcHV0X3VzZXJfcGFnZXNfZGlydHlfbG9jaygpIGRpcmVjdGx5LCBpbnN0ZWFkLgo+IAo+IFsx XSBodHRwczovL2xvcmUua2VybmVsLm9yZy9yLzIwMTkwNzIzMTUzNjQwLkdCNzIwQGxzdC5kZQo+ IAo+IFJldmlld2VkLWJ5OiBJcmEgV2VpbnkgPGlyYS53ZWlueUBpbnRlbC5jb20+Cj4gU2lnbmVk LW9mZi1ieTogSm9obiBIdWJiYXJkIDxqaHViYmFyZEBudmlkaWEuY29tPgoKTG9va3MgZ29vZCB0 byBtZS4gWW91IGNhbiBhZGQ6CgpSZXZpZXdlZC1ieTogSmFuIEthcmEgPGphY2tAc3VzZS5jej4K CgkJCQkJCQkJSG9uemEKCj4gLS0tCj4gIGRyaXZlcnMvcGxhdGZvcm0vZ29sZGZpc2gvZ29sZGZp c2hfcGlwZS5jIHwgMTcgKysrLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5z ZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGxh dGZvcm0vZ29sZGZpc2gvZ29sZGZpc2hfcGlwZS5jIGIvZHJpdmVycy9wbGF0Zm9ybS9nb2xkZmlz aC9nb2xkZmlzaF9waXBlLmMKPiBpbmRleCA3ZWQyYTIxYTBiYWMuLjYzNWE4YmMxYjQ4MCAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL3BsYXRmb3JtL2dvbGRmaXNoL2dvbGRmaXNoX3BpcGUuYwo+ICsr KyBiL2RyaXZlcnMvcGxhdGZvcm0vZ29sZGZpc2gvZ29sZGZpc2hfcGlwZS5jCj4gQEAgLTI3NCw3 ICsyNzQsNyBAQCBzdGF0aWMgaW50IHBpbl9nb2xkZmlzaF9wYWdlcyh1bnNpZ25lZCBsb25nIGZp cnN0X3BhZ2UsCj4gIAkJKml0ZXJfbGFzdF9wYWdlX3NpemUgPSBsYXN0X3BhZ2Vfc2l6ZTsKPiAg CX0KPiAgCj4gLQlyZXQgPSBnZXRfdXNlcl9wYWdlc19mYXN0KGZpcnN0X3BhZ2UsIHJlcXVlc3Rl ZF9wYWdlcywKPiArCXJldCA9IHBpbl91c2VyX3BhZ2VzX2Zhc3QoZmlyc3RfcGFnZSwgcmVxdWVz dGVkX3BhZ2VzLAo+ICAJCQkJICAhaXNfd3JpdGUgPyBGT0xMX1dSSVRFIDogMCwKPiAgCQkJCSAg cGFnZXMpOwo+ICAJaWYgKHJldCA8PSAwKQo+IEBAIC0yODUsMTggKzI4NSw2IEBAIHN0YXRpYyBp bnQgcGluX2dvbGRmaXNoX3BhZ2VzKHVuc2lnbmVkIGxvbmcgZmlyc3RfcGFnZSwKPiAgCXJldHVy biByZXQ7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIHJlbGVhc2VfdXNlcl9wYWdlcyhzdHJ1Y3Qg cGFnZSAqKnBhZ2VzLCBpbnQgcGFnZXNfY291bnQsCj4gLQkJCSAgICAgICBpbnQgaXNfd3JpdGUs IHMzMiBjb25zdW1lZF9zaXplKQo+IC17Cj4gLQlpbnQgaTsKPiAtCj4gLQlmb3IgKGkgPSAwOyBp IDwgcGFnZXNfY291bnQ7IGkrKykgewo+IC0JCWlmICghaXNfd3JpdGUgJiYgY29uc3VtZWRfc2l6 ZSA+IDApCj4gLQkJCXNldF9wYWdlX2RpcnR5KHBhZ2VzW2ldKTsKPiAtCQlwdXRfcGFnZShwYWdl c1tpXSk7Cj4gLQl9Cj4gLX0KPiAtCj4gIC8qIFBvcHVsYXRlIHRoZSBjYWxsIHBhcmFtZXRlcnMs IG1lcmdpbmcgYWRqYWNlbnQgcGFnZXMgdG9nZXRoZXIgKi8KPiAgc3RhdGljIHZvaWQgcG9wdWxh dGVfcndfcGFyYW1zKHN0cnVjdCBwYWdlICoqcGFnZXMsCj4gIAkJCSAgICAgICBpbnQgcGFnZXNf Y291bnQsCj4gQEAgLTM3Miw3ICszNjAsOCBAQCBzdGF0aWMgaW50IHRyYW5zZmVyX21heF9idWZm ZXJzKHN0cnVjdCBnb2xkZmlzaF9waXBlICpwaXBlLAo+ICAKPiAgCSpjb25zdW1lZF9zaXplID0g cGlwZS0+Y29tbWFuZF9idWZmZXItPnJ3X3BhcmFtcy5jb25zdW1lZF9zaXplOwo+ICAKPiAtCXJl bGVhc2VfdXNlcl9wYWdlcyhwaXBlLT5wYWdlcywgcGFnZXNfY291bnQsIGlzX3dyaXRlLCAqY29u c3VtZWRfc2l6ZSk7Cj4gKwlwdXRfdXNlcl9wYWdlc19kaXJ0eV9sb2NrKHBpcGUtPnBhZ2VzLCBw YWdlc19jb3VudCwKPiArCQkJCSAgIWlzX3dyaXRlICYmICpjb25zdW1lZF9zaXplID4gMCk7Cj4g IAo+ICAJbXV0ZXhfdW5sb2NrKCZwaXBlLT5sb2NrKTsKPiAgCXJldHVybiAwOwo+IC0tIAo+IDIu MjQuMAo+IAotLSAKSmFuIEthcmEgPGphY2tAc3VzZS5jb20+ClNVU0UgTGFicywgQ1IKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs