From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99358C432C0 for ; Mon, 18 Nov 2019 10:33:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 735BF20730 for ; Mon, 18 Nov 2019 10:33:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726506AbfKRKdn (ORCPT ); Mon, 18 Nov 2019 05:33:43 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:47115 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726460AbfKRKdm (ORCPT ); Mon, 18 Nov 2019 05:33:42 -0500 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iWeLe-0000Y3-DL; Mon, 18 Nov 2019 11:33:34 +0100 Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1iWeLc-0003qW-HJ; Mon, 18 Nov 2019 11:33:32 +0100 Date: Mon, 18 Nov 2019 11:33:32 +0100 From: Marco Felsch To: Bartosz Golaszewski Cc: Linus Walleij , m.szyprowski@samsung.com, Charles Keepax , Mark Brown , linux-gpio , kernel@pengutronix.de Subject: Re: [PATCH] gpio: fix getting nonexclusive gpiods from DT Message-ID: <20191118103332.bmafrl5izirbauqw@pengutronix.de> References: <20190916134344.26656-1-m.felsch@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 11:32:04 up 3 days, 1:50, 20 users, load average: 0.05, 0.05, 0.03 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-gpio@vger.kernel.org Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Bart, On 19-09-17 09:53, Bartosz Golaszewski wrote: > pon., 16 wrz 2019 o 15:43 Marco Felsch napisał(a): > > > > Since commit ec757001c818 ("gpio: Enable nonexclusive gpiods from DT > > nodes") we are able to get GPIOD_FLAGS_BIT_NONEXCLUSIVE marked gpios. > > Currently the gpiolib uses the wrong flags variable for the check. We > > need to check the gpiod_flags instead of the of_gpio_flags else we > > return -EBUSY for GPIOD_FLAGS_BIT_NONEXCLUSIVE marked and requested > > gpiod's. > > > > Fixes: ec757001c818 gpio: Enable nonexclusive gpiods from DT nodes > > Signed-off-by: Marco Felsch > > --- > > drivers/gpio/gpiolib.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > > index d9074191edef..e4203c1eb869 100644 > > --- a/drivers/gpio/gpiolib.c > > +++ b/drivers/gpio/gpiolib.c > > @@ -4303,7 +4303,7 @@ struct gpio_desc *gpiod_get_from_of_node(struct device_node *node, > > transitory = flags & OF_GPIO_TRANSITORY; > > > > ret = gpiod_request(desc, label); > > - if (ret == -EBUSY && (flags & GPIOD_FLAGS_BIT_NONEXCLUSIVE)) > > + if (ret == -EBUSY && (dflags & GPIOD_FLAGS_BIT_NONEXCLUSIVE)) > > return desc; > > if (ret) > > return ERR_PTR(ret); > > -- > > 2.20.1 > > > > Queued for fixes, thanks. I rebased my patch stack ontop of -rc8 and didn't saw this commit. Is this intended? Regards, Marco > Bart > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |