From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3331AC432C3 for ; Mon, 18 Nov 2019 14:51:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0E38020659 for ; Mon, 18 Nov 2019 14:51:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727217AbfKROvj (ORCPT ); Mon, 18 Nov 2019 09:51:39 -0500 Received: from outbound-smtp24.blacknight.com ([81.17.249.192]:53900 "EHLO outbound-smtp24.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726703AbfKROvi (ORCPT ); Mon, 18 Nov 2019 09:51:38 -0500 Received: from mail.blacknight.com (pemlinmail02.blacknight.ie [81.17.254.11]) by outbound-smtp24.blacknight.com (Postfix) with ESMTPS id D383AB880B for ; Mon, 18 Nov 2019 14:51:36 +0000 (GMT) Received: (qmail 3377 invoked from network); 18 Nov 2019 14:51:36 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.18.57]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 18 Nov 2019 14:51:36 -0000 Date: Mon, 18 Nov 2019 14:51:34 +0000 From: Mel Gorman To: Ingo Molnar Cc: Vincent Guittot , linux-kernel@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, pauld@redhat.com, valentin.schneider@arm.com, srikar@linux.vnet.ibm.com, quentin.perret@arm.com, dietmar.eggemann@arm.com, Morten.Rasmussen@arm.com, hdanton@sina.com, parth@linux.ibm.com, riel@surriel.com Subject: Re: [PATCH v4 04/11] sched/fair: rework load_balance Message-ID: <20191118145134.GA3016@techsingularity.net> References: <1571405198-27570-1-git-send-email-vincent.guittot@linaro.org> <1571405198-27570-5-git-send-email-vincent.guittot@linaro.org> <20191030154534.GJ3016@techsingularity.net> <20191118135017.GA123637@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20191118135017.GA123637@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 18, 2019 at 02:50:17PM +0100, Ingo Molnar wrote: > > * Mel Gorman wrote: > > > s/groupe_type/group_type/ > > > > > enum group_type { > > > - group_other = 0, > > > + group_has_spare = 0, > > > + group_fully_busy, > > > group_misfit_task, > > > + group_asym_packing, > > > group_imbalanced, > > > - group_overloaded, > > > + group_overloaded > > > +}; > > > + > > > > While not your fault, it would be nice to comment on the meaning of each > > group type. From a glance, it's not obvious to me why a misfit task should > > be a high priority to move a task than a fully_busy (but not overloaded) > > group given that moving the misfit task might make a group overloaded. > > This part of your feedback should now be addressed in the scheduler tree > via: > > a9723389cc75: sched/fair: Add comments for group_type and balancing at SD_NUMA level > While I can't see that commit ID yet, the discussed version of the patch was fine by me. -- Mel Gorman SUSE Labs