From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Liuyixian (Eason)" <liuyixian@huawei.com>
Cc: dledford@redhat.com, leon@kernel.org, linux-rdma@vger.kernel.org,
linuxarm@huawei.com
Subject: Re: [PATCH v2 for-next 1/2] RDMA/hns: Add the workqueue framework for flush cqe handler
Date: Mon, 18 Nov 2019 13:02:29 -0400 [thread overview]
Message-ID: <20191118170229.GC2149@ziepe.ca> (raw)
In-Reply-To: <523cf93d-a849-ab24-36f0-903fb1afe7ff@huawei.com>
On Mon, Nov 18, 2019 at 09:50:24PM +0800, Liuyixian (Eason) wrote:
> > It kind of looks like this can be called multiple times? It won't work
> > right unless it is called exactly once
> >
> > Jason
>
> Yes, you are right.
>
> So I think the reasonable solution is to allocate it dynamically, and I think
> it is a very very little chance that the allocation will be failed. If this happened,
> I think the application also needs to be over.
Why do you need more than one work in parallel for this? Once you
start to move the HW to error that only has to happen once, surely?
Jason
next prev parent reply other threads:[~2019-11-18 17:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 12:52 [PATCH v2 for-next 0/2] Fix crash due to sleepy mutex while holding lock in post_{send|recv|poll} Yixian Liu
2019-11-12 12:52 ` [PATCH v2 for-next 1/2] RDMA/hns: Add the workqueue framework for flush cqe handler Yixian Liu
2019-11-15 21:06 ` Jason Gunthorpe
2019-11-18 13:50 ` Liuyixian (Eason)
2019-11-18 17:02 ` Jason Gunthorpe [this message]
2019-11-19 8:00 ` Liuyixian (Eason)
2019-11-19 9:43 ` Zengtao (B)
2019-11-19 13:09 ` Liuyixian (Eason)
2019-11-19 18:46 ` Jason Gunthorpe
2019-11-20 11:00 ` Liuyixian (Eason)
2019-11-12 12:52 ` [PATCH v2 for-next 2/2] RDMA/hns: Delayed flush cqe process with workqueue Yixian Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118170229.GC2149@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuyixian@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.