From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0BF4C43215 for ; Tue, 19 Nov 2019 16:32:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 902542231A for ; Tue, 19 Nov 2019 16:32:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728128AbfKSQcW (ORCPT ); Tue, 19 Nov 2019 11:32:22 -0500 Received: from mga12.intel.com ([192.55.52.136]:31364 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727299AbfKSQcW (ORCPT ); Tue, 19 Nov 2019 11:32:22 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Nov 2019 08:32:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,218,1571727600"; d="scan'208";a="381065906" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga005.jf.intel.com with ESMTP; 19 Nov 2019 08:32:17 -0800 Received: from andy by smile with local (Exim 4.93-RC1) (envelope-from ) id 1iX6QK-0007p2-7T; Tue, 19 Nov 2019 18:32:16 +0200 Date: Tue, 19 Nov 2019 18:32:16 +0200 From: Andy Shevchenko To: Hans de Goede Cc: Maarten Lankhorst , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , "Rafael J . Wysocki" , Len Brown , Lee Jones , linux-acpi@vger.kernel.org, intel-gfx , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] drm/i915 / LPSS / mfd: Select correct PWM controller to use based on VBT Message-ID: <20191119163216.GI32742@smile.fi.intel.com> References: <20191119151818.67531-1-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191119151818.67531-1-hdegoede@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Nov 19, 2019 at 04:18:15PM +0100, Hans de Goede wrote: > Hi All, > > This series needs to be merged through a single tree, to keep things > bisectable. I have even considered just squashing all 3 patches into 1, > but having separate commits seems better, but that does lead to an > intermediate state where the backlight sysfs interface will be broken > (and fixed 2 commits later). See below for some background info. > > The changes to drivers/acpi/acpi_lpss.c and drivers/mfd/intel_soc_pmic_core.c > are quite small and should not lead to any conflicts, so I believe that > it would be best to merge this entire series through the drm-intel tree. > > Lee, may I have your Acked-by for merging the mfd change through the > drm-intel tree? > > Rafael, may I have your Acked-by for merging the acpi_lpss change through the > drm-intel tree? > Entire series (or a single patch) makes sense to me. Thanks for fixing this old hardware! FWIW, Reviewed-by: Andy Shevchenko > Regards, > > Hans > > p.s. > > The promised background info: > > We have this long standing issue where instead of looking in the i915 > VBT (Video BIOS Table) to see if we should use the PWM block of the SoC > or of the PMIC to control the backlight of a DSI panel, we rely on > drivers/acpi/acpi_lpss.c and/or drivers/mfd/intel_soc_pmic_core.c > registering a pwm with the generic name of "pwm_backlight" and then the > i915 panel code does a pwm_get(dev, "pwm_backlight"). > > We have some heuristics in drivers/acpi/acpi_lpss.c to not register the > lookup if a Crystal Cove PMIC is presend and the mfd/intel_soc_pmic_core.c > code simply assumes that since there is a PMIC the PMIC PWM block will > be used. Basically we are winging it. > > Recently I've learned about 2 different BYT devices: > Point of View MOBII TAB-P800W > Acer Switch 10 SW5-012 > > Which use a Crystal Cove PMIC, yet the LCD is connected to the SoC/LPSS > PWM controller (and the VBT correctly indicates this), so here our old > heuristics fail. > > This series renams the PWM lookups registered by the LPSS / > intel_soc_pmic_core.c code from "pwm_backlight" to "pwm_soc_backlight" resp. > "pwm_pmic_backlight" and in the LPSS case also dropping the heuristics when > to register the lookup. This combined with teaching the i915 panel to call > pwm_get for the right lookup-name depending on the VBT bits resolves this. > -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 0/3] drm/i915 / LPSS / mfd: Select correct PWM controller to use based on VBT Date: Tue, 19 Nov 2019 18:32:16 +0200 Message-ID: <20191119163216.GI32742@smile.fi.intel.com> References: <20191119151818.67531-1-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20191119151818.67531-1-hdegoede@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Hans de Goede Cc: intel-gfx , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones , Len Brown List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBOb3YgMTksIDIwMTkgYXQgMDQ6MTg6MTVQTSArMDEwMCwgSGFucyBkZSBHb2VkZSB3 cm90ZToKPiBIaSBBbGwsCj4gCj4gVGhpcyBzZXJpZXMgbmVlZHMgdG8gYmUgbWVyZ2VkIHRocm91 Z2ggYSBzaW5nbGUgdHJlZSwgdG8ga2VlcCB0aGluZ3MKPiBiaXNlY3RhYmxlLiBJIGhhdmUgZXZl biBjb25zaWRlcmVkIGp1c3Qgc3F1YXNoaW5nIGFsbCAzIHBhdGNoZXMgaW50byAxLAo+IGJ1dCBo YXZpbmcgc2VwYXJhdGUgY29tbWl0cyBzZWVtcyBiZXR0ZXIsIGJ1dCB0aGF0IGRvZXMgbGVhZCB0 byBhbgo+IGludGVybWVkaWF0ZSBzdGF0ZSB3aGVyZSB0aGUgYmFja2xpZ2h0IHN5c2ZzIGludGVy ZmFjZSB3aWxsIGJlIGJyb2tlbgo+IChhbmQgZml4ZWQgMiBjb21taXRzIGxhdGVyKS4gU2VlIGJl bG93IGZvciBzb21lIGJhY2tncm91bmQgaW5mby4KPiAKPiBUaGUgY2hhbmdlcyB0byBkcml2ZXJz L2FjcGkvYWNwaV9scHNzLmMgYW5kIGRyaXZlcnMvbWZkL2ludGVsX3NvY19wbWljX2NvcmUuYwo+ IGFyZSBxdWl0ZSBzbWFsbCBhbmQgc2hvdWxkIG5vdCBsZWFkIHRvIGFueSBjb25mbGljdHMsIHNv IEkgYmVsaWV2ZSB0aGF0Cj4gaXQgd291bGQgYmUgYmVzdCB0byBtZXJnZSB0aGlzIGVudGlyZSBz ZXJpZXMgdGhyb3VnaCB0aGUgZHJtLWludGVsIHRyZWUuCj4gCj4gTGVlLCBtYXkgSSBoYXZlIHlv dXIgQWNrZWQtYnkgZm9yIG1lcmdpbmcgdGhlIG1mZCBjaGFuZ2UgdGhyb3VnaCB0aGUKPiBkcm0t aW50ZWwgdHJlZT8KPiAKPiBSYWZhZWwsIG1heSBJIGhhdmUgeW91ciBBY2tlZC1ieSBmb3IgbWVy Z2luZyB0aGUgYWNwaV9scHNzIGNoYW5nZSB0aHJvdWdoIHRoZQo+IGRybS1pbnRlbCB0cmVlPwo+ IAoKRW50aXJlIHNlcmllcyAob3IgYSBzaW5nbGUgcGF0Y2gpIG1ha2VzIHNlbnNlIHRvIG1lLgpU aGFua3MgZm9yIGZpeGluZyB0aGlzIG9sZCBoYXJkd2FyZSEKCkZXSVcsClJldmlld2VkLWJ5OiBB bmR5IFNoZXZjaGVua28gPGFuZHJpeS5zaGV2Y2hlbmtvQGxpbnV4LmludGVsLmNvbT4KCj4gUmVn YXJkcywKPiAKPiBIYW5zCj4gCj4gcC5zLgo+IAo+IFRoZSBwcm9taXNlZCBiYWNrZ3JvdW5kIGlu Zm86Cj4gCj4gV2UgaGF2ZSB0aGlzIGxvbmcgc3RhbmRpbmcgaXNzdWUgd2hlcmUgaW5zdGVhZCBv ZiBsb29raW5nIGluIHRoZSBpOTE1Cj4gVkJUIChWaWRlbyBCSU9TIFRhYmxlKSB0byBzZWUgaWYg d2Ugc2hvdWxkIHVzZSB0aGUgUFdNIGJsb2NrIG9mIHRoZSBTb0MKPiBvciBvZiB0aGUgUE1JQyB0 byBjb250cm9sIHRoZSBiYWNrbGlnaHQgb2YgYSBEU0kgcGFuZWwsIHdlIHJlbHkgb24KPiBkcml2 ZXJzL2FjcGkvYWNwaV9scHNzLmMgYW5kL29yIGRyaXZlcnMvbWZkL2ludGVsX3NvY19wbWljX2Nv cmUuYwo+IHJlZ2lzdGVyaW5nIGEgcHdtIHdpdGggdGhlIGdlbmVyaWMgbmFtZSBvZiAicHdtX2Jh Y2tsaWdodCIgYW5kIHRoZW4gdGhlCj4gaTkxNSBwYW5lbCBjb2RlIGRvZXMgYSBwd21fZ2V0KGRl diwgInB3bV9iYWNrbGlnaHQiKS4KPiAKPiBXZSBoYXZlIHNvbWUgaGV1cmlzdGljcyBpbiBkcml2 ZXJzL2FjcGkvYWNwaV9scHNzLmMgdG8gbm90IHJlZ2lzdGVyIHRoZQo+IGxvb2t1cCBpZiBhIENy eXN0YWwgQ292ZSBQTUlDIGlzIHByZXNlbmQgYW5kIHRoZSBtZmQvaW50ZWxfc29jX3BtaWNfY29y ZS5jCj4gY29kZSBzaW1wbHkgYXNzdW1lcyB0aGF0IHNpbmNlIHRoZXJlIGlzIGEgUE1JQyB0aGUg UE1JQyBQV00gYmxvY2sgd2lsbAo+IGJlIHVzZWQuIEJhc2ljYWxseSB3ZSBhcmUgd2luZ2luZyBp dC4KPiAKPiBSZWNlbnRseSBJJ3ZlIGxlYXJuZWQgYWJvdXQgMiBkaWZmZXJlbnQgQllUIGRldmlj ZXM6Cj4gUG9pbnQgb2YgVmlldyBNT0JJSSBUQUItUDgwMFcKPiBBY2VyIFN3aXRjaCAxMCBTVzUt MDEyCj4gCj4gV2hpY2ggdXNlIGEgQ3J5c3RhbCBDb3ZlIFBNSUMsIHlldCB0aGUgTENEIGlzIGNv bm5lY3RlZCB0byB0aGUgU29DL0xQU1MKPiBQV00gY29udHJvbGxlciAoYW5kIHRoZSBWQlQgY29y cmVjdGx5IGluZGljYXRlcyB0aGlzKSwgc28gaGVyZSBvdXIgb2xkCj4gaGV1cmlzdGljcyBmYWls Lgo+IAo+IFRoaXMgc2VyaWVzIHJlbmFtcyB0aGUgUFdNIGxvb2t1cHMgcmVnaXN0ZXJlZCBieSB0 aGUgTFBTUyAvCj4gaW50ZWxfc29jX3BtaWNfY29yZS5jIGNvZGUgZnJvbSAicHdtX2JhY2tsaWdo dCIgdG8gInB3bV9zb2NfYmFja2xpZ2h0IiByZXNwLgo+ICJwd21fcG1pY19iYWNrbGlnaHQiIGFu ZCBpbiB0aGUgTFBTUyBjYXNlIGFsc28gZHJvcHBpbmcgdGhlIGhldXJpc3RpY3Mgd2hlbgo+IHRv IHJlZ2lzdGVyIHRoZSBsb29rdXAuIFRoaXMgY29tYmluZWQgd2l0aCB0ZWFjaGluZyB0aGUgaTkx NSBwYW5lbCB0byBjYWxsCj4gcHdtX2dldCBmb3IgdGhlIHJpZ2h0IGxvb2t1cC1uYW1lIGRlcGVu ZGluZyBvbiB0aGUgVkJUIGJpdHMgcmVzb2x2ZXMgdGhpcy4KPiAKCi0tIApXaXRoIEJlc3QgUmVn YXJkcywKQW5keSBTaGV2Y2hlbmtvCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10B7AC432C3 for ; Tue, 19 Nov 2019 23:28:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E313720674 for ; Tue, 19 Nov 2019 23:28:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E313720674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C1C1D6EA1B; Tue, 19 Nov 2019 23:28:13 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0AA446E8B5; Tue, 19 Nov 2019 16:32:20 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Nov 2019 08:32:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,218,1571727600"; d="scan'208";a="381065906" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga005.jf.intel.com with ESMTP; 19 Nov 2019 08:32:17 -0800 Received: from andy by smile with local (Exim 4.93-RC1) (envelope-from ) id 1iX6QK-0007p2-7T; Tue, 19 Nov 2019 18:32:16 +0200 Date: Tue, 19 Nov 2019 18:32:16 +0200 From: Andy Shevchenko To: Hans de Goede Subject: Re: [PATCH 0/3] drm/i915 / LPSS / mfd: Select correct PWM controller to use based on VBT Message-ID: <20191119163216.GI32742@smile.fi.intel.com> References: <20191119151818.67531-1-hdegoede@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191119151818.67531-1-hdegoede@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Tue, 19 Nov 2019 23:28:08 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi , Lee Jones , Len Brown Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191119163216.NNschtsAPRCwZbdGC00wjbAfgbUjF8x6nVLrjiffbOs@z> T24gVHVlLCBOb3YgMTksIDIwMTkgYXQgMDQ6MTg6MTVQTSArMDEwMCwgSGFucyBkZSBHb2VkZSB3 cm90ZToKPiBIaSBBbGwsCj4gCj4gVGhpcyBzZXJpZXMgbmVlZHMgdG8gYmUgbWVyZ2VkIHRocm91 Z2ggYSBzaW5nbGUgdHJlZSwgdG8ga2VlcCB0aGluZ3MKPiBiaXNlY3RhYmxlLiBJIGhhdmUgZXZl biBjb25zaWRlcmVkIGp1c3Qgc3F1YXNoaW5nIGFsbCAzIHBhdGNoZXMgaW50byAxLAo+IGJ1dCBo YXZpbmcgc2VwYXJhdGUgY29tbWl0cyBzZWVtcyBiZXR0ZXIsIGJ1dCB0aGF0IGRvZXMgbGVhZCB0 byBhbgo+IGludGVybWVkaWF0ZSBzdGF0ZSB3aGVyZSB0aGUgYmFja2xpZ2h0IHN5c2ZzIGludGVy ZmFjZSB3aWxsIGJlIGJyb2tlbgo+IChhbmQgZml4ZWQgMiBjb21taXRzIGxhdGVyKS4gU2VlIGJl bG93IGZvciBzb21lIGJhY2tncm91bmQgaW5mby4KPiAKPiBUaGUgY2hhbmdlcyB0byBkcml2ZXJz L2FjcGkvYWNwaV9scHNzLmMgYW5kIGRyaXZlcnMvbWZkL2ludGVsX3NvY19wbWljX2NvcmUuYwo+ IGFyZSBxdWl0ZSBzbWFsbCBhbmQgc2hvdWxkIG5vdCBsZWFkIHRvIGFueSBjb25mbGljdHMsIHNv IEkgYmVsaWV2ZSB0aGF0Cj4gaXQgd291bGQgYmUgYmVzdCB0byBtZXJnZSB0aGlzIGVudGlyZSBz ZXJpZXMgdGhyb3VnaCB0aGUgZHJtLWludGVsIHRyZWUuCj4gCj4gTGVlLCBtYXkgSSBoYXZlIHlv dXIgQWNrZWQtYnkgZm9yIG1lcmdpbmcgdGhlIG1mZCBjaGFuZ2UgdGhyb3VnaCB0aGUKPiBkcm0t aW50ZWwgdHJlZT8KPiAKPiBSYWZhZWwsIG1heSBJIGhhdmUgeW91ciBBY2tlZC1ieSBmb3IgbWVy Z2luZyB0aGUgYWNwaV9scHNzIGNoYW5nZSB0aHJvdWdoIHRoZQo+IGRybS1pbnRlbCB0cmVlPwo+ IAoKRW50aXJlIHNlcmllcyAob3IgYSBzaW5nbGUgcGF0Y2gpIG1ha2VzIHNlbnNlIHRvIG1lLgpU aGFua3MgZm9yIGZpeGluZyB0aGlzIG9sZCBoYXJkd2FyZSEKCkZXSVcsClJldmlld2VkLWJ5OiBB bmR5IFNoZXZjaGVua28gPGFuZHJpeS5zaGV2Y2hlbmtvQGxpbnV4LmludGVsLmNvbT4KCj4gUmVn YXJkcywKPiAKPiBIYW5zCj4gCj4gcC5zLgo+IAo+IFRoZSBwcm9taXNlZCBiYWNrZ3JvdW5kIGlu Zm86Cj4gCj4gV2UgaGF2ZSB0aGlzIGxvbmcgc3RhbmRpbmcgaXNzdWUgd2hlcmUgaW5zdGVhZCBv ZiBsb29raW5nIGluIHRoZSBpOTE1Cj4gVkJUIChWaWRlbyBCSU9TIFRhYmxlKSB0byBzZWUgaWYg d2Ugc2hvdWxkIHVzZSB0aGUgUFdNIGJsb2NrIG9mIHRoZSBTb0MKPiBvciBvZiB0aGUgUE1JQyB0 byBjb250cm9sIHRoZSBiYWNrbGlnaHQgb2YgYSBEU0kgcGFuZWwsIHdlIHJlbHkgb24KPiBkcml2 ZXJzL2FjcGkvYWNwaV9scHNzLmMgYW5kL29yIGRyaXZlcnMvbWZkL2ludGVsX3NvY19wbWljX2Nv cmUuYwo+IHJlZ2lzdGVyaW5nIGEgcHdtIHdpdGggdGhlIGdlbmVyaWMgbmFtZSBvZiAicHdtX2Jh Y2tsaWdodCIgYW5kIHRoZW4gdGhlCj4gaTkxNSBwYW5lbCBjb2RlIGRvZXMgYSBwd21fZ2V0KGRl diwgInB3bV9iYWNrbGlnaHQiKS4KPiAKPiBXZSBoYXZlIHNvbWUgaGV1cmlzdGljcyBpbiBkcml2 ZXJzL2FjcGkvYWNwaV9scHNzLmMgdG8gbm90IHJlZ2lzdGVyIHRoZQo+IGxvb2t1cCBpZiBhIENy eXN0YWwgQ292ZSBQTUlDIGlzIHByZXNlbmQgYW5kIHRoZSBtZmQvaW50ZWxfc29jX3BtaWNfY29y ZS5jCj4gY29kZSBzaW1wbHkgYXNzdW1lcyB0aGF0IHNpbmNlIHRoZXJlIGlzIGEgUE1JQyB0aGUg UE1JQyBQV00gYmxvY2sgd2lsbAo+IGJlIHVzZWQuIEJhc2ljYWxseSB3ZSBhcmUgd2luZ2luZyBp dC4KPiAKPiBSZWNlbnRseSBJJ3ZlIGxlYXJuZWQgYWJvdXQgMiBkaWZmZXJlbnQgQllUIGRldmlj ZXM6Cj4gUG9pbnQgb2YgVmlldyBNT0JJSSBUQUItUDgwMFcKPiBBY2VyIFN3aXRjaCAxMCBTVzUt MDEyCj4gCj4gV2hpY2ggdXNlIGEgQ3J5c3RhbCBDb3ZlIFBNSUMsIHlldCB0aGUgTENEIGlzIGNv bm5lY3RlZCB0byB0aGUgU29DL0xQU1MKPiBQV00gY29udHJvbGxlciAoYW5kIHRoZSBWQlQgY29y cmVjdGx5IGluZGljYXRlcyB0aGlzKSwgc28gaGVyZSBvdXIgb2xkCj4gaGV1cmlzdGljcyBmYWls Lgo+IAo+IFRoaXMgc2VyaWVzIHJlbmFtcyB0aGUgUFdNIGxvb2t1cHMgcmVnaXN0ZXJlZCBieSB0 aGUgTFBTUyAvCj4gaW50ZWxfc29jX3BtaWNfY29yZS5jIGNvZGUgZnJvbSAicHdtX2JhY2tsaWdo dCIgdG8gInB3bV9zb2NfYmFja2xpZ2h0IiByZXNwLgo+ICJwd21fcG1pY19iYWNrbGlnaHQiIGFu ZCBpbiB0aGUgTFBTUyBjYXNlIGFsc28gZHJvcHBpbmcgdGhlIGhldXJpc3RpY3Mgd2hlbgo+IHRv IHJlZ2lzdGVyIHRoZSBsb29rdXAuIFRoaXMgY29tYmluZWQgd2l0aCB0ZWFjaGluZyB0aGUgaTkx NSBwYW5lbCB0byBjYWxsCj4gcHdtX2dldCBmb3IgdGhlIHJpZ2h0IGxvb2t1cC1uYW1lIGRlcGVu ZGluZyBvbiB0aGUgVkJUIGJpdHMgcmVzb2x2ZXMgdGhpcy4KPiAKCi0tIApXaXRoIEJlc3QgUmVn YXJkcywKQW5keSBTaGV2Y2hlbmtvCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A649EC432C0 for ; Tue, 19 Nov 2019 16:32:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84C50222A2 for ; Tue, 19 Nov 2019 16:32:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84C50222A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C0F56E8B5; Tue, 19 Nov 2019 16:32:22 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0AA446E8B5; Tue, 19 Nov 2019 16:32:20 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Nov 2019 08:32:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,218,1571727600"; d="scan'208";a="381065906" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga005.jf.intel.com with ESMTP; 19 Nov 2019 08:32:17 -0800 Received: from andy by smile with local (Exim 4.93-RC1) (envelope-from ) id 1iX6QK-0007p2-7T; Tue, 19 Nov 2019 18:32:16 +0200 Date: Tue, 19 Nov 2019 18:32:16 +0200 From: Andy Shevchenko To: Hans de Goede Message-ID: <20191119163216.GI32742@smile.fi.intel.com> References: <20191119151818.67531-1-hdegoede@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191119151818.67531-1-hdegoede@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH 0/3] drm/i915 / LPSS / mfd: Select correct PWM controller to use based on VBT X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones , Len Brown Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191119163216.1DetoOCTMinzZFLzAWAfaKuM2r_cZvHiIjmHvsmXSh8@z> T24gVHVlLCBOb3YgMTksIDIwMTkgYXQgMDQ6MTg6MTVQTSArMDEwMCwgSGFucyBkZSBHb2VkZSB3 cm90ZToKPiBIaSBBbGwsCj4gCj4gVGhpcyBzZXJpZXMgbmVlZHMgdG8gYmUgbWVyZ2VkIHRocm91 Z2ggYSBzaW5nbGUgdHJlZSwgdG8ga2VlcCB0aGluZ3MKPiBiaXNlY3RhYmxlLiBJIGhhdmUgZXZl biBjb25zaWRlcmVkIGp1c3Qgc3F1YXNoaW5nIGFsbCAzIHBhdGNoZXMgaW50byAxLAo+IGJ1dCBo YXZpbmcgc2VwYXJhdGUgY29tbWl0cyBzZWVtcyBiZXR0ZXIsIGJ1dCB0aGF0IGRvZXMgbGVhZCB0 byBhbgo+IGludGVybWVkaWF0ZSBzdGF0ZSB3aGVyZSB0aGUgYmFja2xpZ2h0IHN5c2ZzIGludGVy ZmFjZSB3aWxsIGJlIGJyb2tlbgo+IChhbmQgZml4ZWQgMiBjb21taXRzIGxhdGVyKS4gU2VlIGJl bG93IGZvciBzb21lIGJhY2tncm91bmQgaW5mby4KPiAKPiBUaGUgY2hhbmdlcyB0byBkcml2ZXJz L2FjcGkvYWNwaV9scHNzLmMgYW5kIGRyaXZlcnMvbWZkL2ludGVsX3NvY19wbWljX2NvcmUuYwo+ IGFyZSBxdWl0ZSBzbWFsbCBhbmQgc2hvdWxkIG5vdCBsZWFkIHRvIGFueSBjb25mbGljdHMsIHNv IEkgYmVsaWV2ZSB0aGF0Cj4gaXQgd291bGQgYmUgYmVzdCB0byBtZXJnZSB0aGlzIGVudGlyZSBz ZXJpZXMgdGhyb3VnaCB0aGUgZHJtLWludGVsIHRyZWUuCj4gCj4gTGVlLCBtYXkgSSBoYXZlIHlv dXIgQWNrZWQtYnkgZm9yIG1lcmdpbmcgdGhlIG1mZCBjaGFuZ2UgdGhyb3VnaCB0aGUKPiBkcm0t aW50ZWwgdHJlZT8KPiAKPiBSYWZhZWwsIG1heSBJIGhhdmUgeW91ciBBY2tlZC1ieSBmb3IgbWVy Z2luZyB0aGUgYWNwaV9scHNzIGNoYW5nZSB0aHJvdWdoIHRoZQo+IGRybS1pbnRlbCB0cmVlPwo+ IAoKRW50aXJlIHNlcmllcyAob3IgYSBzaW5nbGUgcGF0Y2gpIG1ha2VzIHNlbnNlIHRvIG1lLgpU aGFua3MgZm9yIGZpeGluZyB0aGlzIG9sZCBoYXJkd2FyZSEKCkZXSVcsClJldmlld2VkLWJ5OiBB bmR5IFNoZXZjaGVua28gPGFuZHJpeS5zaGV2Y2hlbmtvQGxpbnV4LmludGVsLmNvbT4KCj4gUmVn YXJkcywKPiAKPiBIYW5zCj4gCj4gcC5zLgo+IAo+IFRoZSBwcm9taXNlZCBiYWNrZ3JvdW5kIGlu Zm86Cj4gCj4gV2UgaGF2ZSB0aGlzIGxvbmcgc3RhbmRpbmcgaXNzdWUgd2hlcmUgaW5zdGVhZCBv ZiBsb29raW5nIGluIHRoZSBpOTE1Cj4gVkJUIChWaWRlbyBCSU9TIFRhYmxlKSB0byBzZWUgaWYg d2Ugc2hvdWxkIHVzZSB0aGUgUFdNIGJsb2NrIG9mIHRoZSBTb0MKPiBvciBvZiB0aGUgUE1JQyB0 byBjb250cm9sIHRoZSBiYWNrbGlnaHQgb2YgYSBEU0kgcGFuZWwsIHdlIHJlbHkgb24KPiBkcml2 ZXJzL2FjcGkvYWNwaV9scHNzLmMgYW5kL29yIGRyaXZlcnMvbWZkL2ludGVsX3NvY19wbWljX2Nv cmUuYwo+IHJlZ2lzdGVyaW5nIGEgcHdtIHdpdGggdGhlIGdlbmVyaWMgbmFtZSBvZiAicHdtX2Jh Y2tsaWdodCIgYW5kIHRoZW4gdGhlCj4gaTkxNSBwYW5lbCBjb2RlIGRvZXMgYSBwd21fZ2V0KGRl diwgInB3bV9iYWNrbGlnaHQiKS4KPiAKPiBXZSBoYXZlIHNvbWUgaGV1cmlzdGljcyBpbiBkcml2 ZXJzL2FjcGkvYWNwaV9scHNzLmMgdG8gbm90IHJlZ2lzdGVyIHRoZQo+IGxvb2t1cCBpZiBhIENy eXN0YWwgQ292ZSBQTUlDIGlzIHByZXNlbmQgYW5kIHRoZSBtZmQvaW50ZWxfc29jX3BtaWNfY29y ZS5jCj4gY29kZSBzaW1wbHkgYXNzdW1lcyB0aGF0IHNpbmNlIHRoZXJlIGlzIGEgUE1JQyB0aGUg UE1JQyBQV00gYmxvY2sgd2lsbAo+IGJlIHVzZWQuIEJhc2ljYWxseSB3ZSBhcmUgd2luZ2luZyBp dC4KPiAKPiBSZWNlbnRseSBJJ3ZlIGxlYXJuZWQgYWJvdXQgMiBkaWZmZXJlbnQgQllUIGRldmlj ZXM6Cj4gUG9pbnQgb2YgVmlldyBNT0JJSSBUQUItUDgwMFcKPiBBY2VyIFN3aXRjaCAxMCBTVzUt MDEyCj4gCj4gV2hpY2ggdXNlIGEgQ3J5c3RhbCBDb3ZlIFBNSUMsIHlldCB0aGUgTENEIGlzIGNv bm5lY3RlZCB0byB0aGUgU29DL0xQU1MKPiBQV00gY29udHJvbGxlciAoYW5kIHRoZSBWQlQgY29y cmVjdGx5IGluZGljYXRlcyB0aGlzKSwgc28gaGVyZSBvdXIgb2xkCj4gaGV1cmlzdGljcyBmYWls Lgo+IAo+IFRoaXMgc2VyaWVzIHJlbmFtcyB0aGUgUFdNIGxvb2t1cHMgcmVnaXN0ZXJlZCBieSB0 aGUgTFBTUyAvCj4gaW50ZWxfc29jX3BtaWNfY29yZS5jIGNvZGUgZnJvbSAicHdtX2JhY2tsaWdo dCIgdG8gInB3bV9zb2NfYmFja2xpZ2h0IiByZXNwLgo+ICJwd21fcG1pY19iYWNrbGlnaHQiIGFu ZCBpbiB0aGUgTFBTUyBjYXNlIGFsc28gZHJvcHBpbmcgdGhlIGhldXJpc3RpY3Mgd2hlbgo+IHRv IHJlZ2lzdGVyIHRoZSBsb29rdXAuIFRoaXMgY29tYmluZWQgd2l0aCB0ZWFjaGluZyB0aGUgaTkx NSBwYW5lbCB0byBjYWxsCj4gcHdtX2dldCBmb3IgdGhlIHJpZ2h0IGxvb2t1cC1uYW1lIGRlcGVu ZGluZyBvbiB0aGUgVkJUIGJpdHMgcmVzb2x2ZXMgdGhpcy4KPiAKCi0tIApXaXRoIEJlc3QgUmVn YXJkcywKQW5keSBTaGV2Y2hlbmtvCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4