From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF894C432C0 for ; Wed, 20 Nov 2019 10:33:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B9132243F for ; Wed, 20 Nov 2019 10:33:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DUFwtsXX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B9132243F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXNIU-0001bb-Ji for qemu-devel@archiver.kernel.org; Wed, 20 Nov 2019 05:33:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56315) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXNGt-0000fs-Vi for qemu-devel@nongnu.org; Wed, 20 Nov 2019 05:31:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXNGn-0001hm-IH for qemu-devel@nongnu.org; Wed, 20 Nov 2019 05:31:36 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:60617 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iXNGl-0001cs-IC for qemu-devel@nongnu.org; Wed, 20 Nov 2019 05:31:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574245889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HctpOGaPTv4ArStVDPuNzEF36HpWqXOc690DtET5++I=; b=DUFwtsXXAXYfgDAg9/v2T7wIWU6TuVewSVuvwwgs+A0yv0qvFa4FipaSkcUq1vNuq3AFhh wTFRK8k8UVTaEW2Qt6XR4kQbT+FJXYCIlxBgnb1Qw1CLuXQqaxLLJg+w4bmjCWEFFyMoyj oNJwD98XClH5jfIquJtVbtYqZ0lZNw4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-66-DP2k84pEN_GURYZNZVujYw-1; Wed, 20 Nov 2019 05:31:25 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9C3971034B37; Wed, 20 Nov 2019 10:31:24 +0000 (UTC) Received: from gondolin (dhcp-192-218.str.redhat.com [10.33.192.218]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6C0D36B8F1; Wed, 20 Nov 2019 10:31:23 +0000 (UTC) Date: Wed, 20 Nov 2019 11:31:21 +0100 From: Cornelia Huck To: Eric Farman Subject: Re: [RFC PATCH v1 4/8] vfio-ccw: Refactor cleanup of regions Message-ID: <20191120113121.1b1e8937.cohuck@redhat.com> In-Reply-To: <20191115033437.37926-5-farman@linux.ibm.com> References: <20191115033437.37926-1-farman@linux.ibm.com> <20191115033437.37926-5-farman@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: DP2k84pEN_GURYZNZVujYw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Halil Pasic , Jason Herne , qemu-s390x@nongnu.org, qemu-devel@nongnu.org, Jared Rossi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 15 Nov 2019 04:34:33 +0100 Eric Farman wrote: > While we're at it, add a g_free() for the async_cmd_region that > is the last thing currently created. g_free() knows how to handle > NULL pointers, so this makes it easier to remember what cleanups > need to be performed when new regions are added. >=20 > Signed-off-by: Eric Farman > --- > hw/vfio/ccw.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) Reviewed-by: Cornelia Huck