From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Hajnoczi Subject: Re: [PATCH net-next 0/6] vsock: add local transport support Date: Thu, 21 Nov 2019 09:46:43 +0000 Message-ID: <20191121094643.GD439743__20223.8780607999$1574329618$gmane$org@stefanha-x1.localdomain> References: <20191119110121.14480-1-sgarzare@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8339820992161836083==" Return-path: In-Reply-To: <20191119110121.14480-1-sgarzare@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" To: Stefano Garzarella Cc: kvm@vger.kernel.org, netdev@vger.kernel.org, Dexuan Cui , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Stefan Hajnoczi , "David S. Miller" , Jorgen Hansen List-Id: virtualization@lists.linuxfoundation.org --===============8339820992161836083== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eqp4TxRxnD4KrmFZ" Content-Disposition: inline --eqp4TxRxnD4KrmFZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 19, 2019 at 12:01:15PM +0100, Stefano Garzarella wrote: > This series introduces a new transport (vsock_loopback) to handle > local communication. > This could be useful to test vsock core itself and to allow developers > to test their applications without launching a VM. >=20 > Before this series, vmci and virtio transports allowed this behavior, > but only in the guest. > We are moving the loopback handling in a new transport, because it > might be useful to provide this feature also in the host or when > no H2G/G2H transports (hyperv, virtio, vmci) are loaded. >=20 > The user can use the loopback with the new VMADDR_CID_LOCAL (that > replaces VMADDR_CID_RESERVED) in any condition. > Otherwise, if the G2H transport is loaded, it can also use the guest > local CID as previously supported by vmci and virtio transports. > If G2H transport is not loaded, the user can also use VMADDR_CID_HOST > for local communication. >=20 > Patch 1 is a cleanup to build virtio_transport_common without virtio > Patch 2 adds the new VMADDR_CID_LOCAL, replacing VMADDR_CID_RESERVED > Patch 3 adds a new feature flag to register a loopback transport > Patch 4 adds the new vsock_loopback transport based on the loopback > implementation of virtio_transport > Patch 5 implements the logic to use the local transport for loopback > communication > Patch 6 removes the loopback from virtio_transport >=20 > @Jorgen: Do you think it might be a problem to replace > VMADDR_CID_RESERVED with VMADDR_CID_LOCAL? >=20 > Thanks, > Stefano >=20 > Stefano Garzarella (6): > vsock/virtio_transport_common: remove unused virtio header includes > vsock: add VMADDR_CID_LOCAL definition > vsock: add local transport support in the vsock core > vsock: add vsock_loopback transport > vsock: use local transport when it is loaded > vsock/virtio: remove loopback handling >=20 > MAINTAINERS | 1 + > include/net/af_vsock.h | 2 + > include/uapi/linux/vm_sockets.h | 8 +- > net/vmw_vsock/Kconfig | 12 ++ > net/vmw_vsock/Makefile | 1 + > net/vmw_vsock/af_vsock.c | 49 +++++- > net/vmw_vsock/virtio_transport.c | 61 +------ > net/vmw_vsock/virtio_transport_common.c | 3 - > net/vmw_vsock/vmci_transport.c | 2 +- > net/vmw_vsock/vsock_loopback.c | 217 ++++++++++++++++++++++++ > 10 files changed, 283 insertions(+), 73 deletions(-) > create mode 100644 net/vmw_vsock/vsock_loopback.c Please see my comments. Otherwise: Reviewed-by: Stefan Hajnoczi --eqp4TxRxnD4KrmFZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAl3WXQMACgkQnKSrs4Gr c8h4aQf5ATKD+2md5rF2gaJHwaBfEiLqsK5/ciPJv0qtYXlnZi9wionMXyFbAmo+ tWchVmMP8gpdCf9qsWBQo6beDMWJdZSCZCZ0kiAgoHXGWK50lFhtFBqXjngopcXJ Hr9IgWPWoobZR0Z0p98tHj0ToumHaFtopLL+rrtCAwkGHxNnVTgv0HRWcAsEORQc o3AI3/+6a6ESmP8dtcRZ7fY628un7VcdFVrD6mnyxPTX3CVqulPLPLC7Y+DpYtFa ZqU04KBPp/8t8HtsZZYjGv60H58qzwPDAwwEIpFZ9gYl3cKRGRvUXs3t7vKdzZGA gu9P/McerEE+0vQCtysTkHsIzrgUvg== =c63q -----END PGP SIGNATURE----- --eqp4TxRxnD4KrmFZ-- --===============8339820992161836083== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization --===============8339820992161836083==--