From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E562CC432C3 for ; Thu, 21 Nov 2019 13:55:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B52B020714 for ; Thu, 21 Nov 2019 13:55:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574344519; bh=6E0YF8yMllj8qK0e/SPC6Lbz+lUTP0OyTKxxgQareDI=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=xN6jjuxHGyyqcpQXG8jXUnRRbsF6uc+yGmQHKJjW53FJbPiG1lT2Ixw9+gtfcT4TS bndo/DnVUPeRWHMdcZzp0eLrVyk6VYEJat5FSk419e/IYRPIpGiBWUO2Ckraw1ualy TPFze2eo/eddewYy8Jb1bV+5W+XAwb2hkYUIvP9M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726833AbfKUNzS (ORCPT ); Thu, 21 Nov 2019 08:55:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:33256 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726293AbfKUNzS (ORCPT ); Thu, 21 Nov 2019 08:55:18 -0500 Received: from localhost (173-25-83-245.client.mchsi.com [173.25.83.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 47EC920679; Thu, 21 Nov 2019 13:55:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574344517; bh=6E0YF8yMllj8qK0e/SPC6Lbz+lUTP0OyTKxxgQareDI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=tECdPZzF8HyX9TTmeeiSmLmAIGiDqt8CoZWvW9wj9PVeU71Sq3d/ytdFURHqVq75T N15fg7oPvR15OANOzCtplXs4LfnKht8DXDXpiVb/mlaQWVKyJgRZhlpOaVYfbM86mG fsIFutGcLyCjWv35or3z/6Uexha4fojCRpm/8wcI= Date: Thu, 21 Nov 2019 07:55:05 -0600 From: Bjorn Helgaas To: Alex Deucher Cc: Frederick Lawler , "Deucher, Alexander" , Christian Koenig , Chunming Zhou , Dave Airlie , Daniel Vetter , Linux PCI , LKML , Maling list - DRI developers , amd-gfx list Subject: Re: [PATCH v2 1/1] drm: Prefer pcie_capability_read_word() Message-ID: <20191121135505.GA37567@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 18, 2019 at 12:42:25PM -0500, Alex Deucher wrote: > On Mon, Nov 18, 2019 at 3:37 AM Frederick Lawler wrote: > > > > Commit 8c0d3a02c130 ("PCI: Add accessors for PCI Express Capability") > > added accessors for the PCI Express Capability so that drivers didn't > > need to be aware of differences between v1 and v2 of the PCI > > Express Capability. > > > > Replace pci_read_config_word() and pci_write_config_word() calls with > > pcie_capability_read_word() and pcie_capability_write_word(). > > > > Signed-off-by: Frederick Lawler > > > > --- > > V2 > > - Squash both drm commits into one > > - Rebase ontop of d46eac1e658b > > --- > > drivers/gpu/drm/amd/amdgpu/cik.c | 63 ++++++++++++++++----------- > > drivers/gpu/drm/amd/amdgpu/si.c | 71 +++++++++++++++++++------------ > > drivers/gpu/drm/radeon/cik.c | 70 ++++++++++++++++++------------ > > drivers/gpu/drm/radeon/si.c | 73 ++++++++++++++++++++------------ > > Can you split this into two patches? One for amdgpu and one for radeon? I split this, and I also went back and split the related patches that preceded this one. I'll post the resulting series for reference. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: [PATCH v2 1/1] drm: Prefer pcie_capability_read_word() Date: Thu, 21 Nov 2019 07:55:05 -0600 Message-ID: <20191121135505.GA37567@google.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher Cc: Frederick Lawler , Dave Airlie , Linux PCI , LKML , Maling list - DRI developers , amd-gfx list , "Deucher, Alexander" , Christian Koenig List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBOb3YgMTgsIDIwMTkgYXQgMTI6NDI6MjVQTSAtMDUwMCwgQWxleCBEZXVjaGVyIHdy b3RlOgo+IE9uIE1vbiwgTm92IDE4LCAyMDE5IGF0IDM6MzcgQU0gRnJlZGVyaWNrIExhd2xlciA8 ZnJlZEBmcmVkbGF3bC5jb20+IHdyb3RlOgo+ID4KPiA+IENvbW1pdCA4YzBkM2EwMmMxMzAgKCJQ Q0k6IEFkZCBhY2Nlc3NvcnMgZm9yIFBDSSBFeHByZXNzIENhcGFiaWxpdHkiKQo+ID4gYWRkZWQg YWNjZXNzb3JzIGZvciB0aGUgUENJIEV4cHJlc3MgQ2FwYWJpbGl0eSBzbyB0aGF0IGRyaXZlcnMg ZGlkbid0Cj4gPiBuZWVkIHRvIGJlIGF3YXJlIG9mIGRpZmZlcmVuY2VzIGJldHdlZW4gdjEgYW5k IHYyIG9mIHRoZSBQQ0kKPiA+IEV4cHJlc3MgQ2FwYWJpbGl0eS4KPiA+Cj4gPiBSZXBsYWNlIHBj aV9yZWFkX2NvbmZpZ193b3JkKCkgYW5kIHBjaV93cml0ZV9jb25maWdfd29yZCgpIGNhbGxzIHdp dGgKPiA+IHBjaWVfY2FwYWJpbGl0eV9yZWFkX3dvcmQoKSBhbmQgcGNpZV9jYXBhYmlsaXR5X3dy aXRlX3dvcmQoKS4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBGcmVkZXJpY2sgTGF3bGVyIDxmcmVk QGZyZWRsYXdsLmNvbT4KPiA+Cj4gPiAtLS0KPiA+IFYyCj4gPiAtIFNxdWFzaCBib3RoIGRybSBj b21taXRzIGludG8gb25lCj4gPiAtIFJlYmFzZSBvbnRvcCBvZiBkNDZlYWMxZTY1OGIKPiA+IC0t LQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Npay5jIHwgNjMgKysrKysrKysrKysr KysrKy0tLS0tLS0tLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvc2kuYyAgfCA3 MSArKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL3Jh ZGVvbi9jaWsuYyAgICAgfCA3MCArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0KPiA+ICBk cml2ZXJzL2dwdS9kcm0vcmFkZW9uL3NpLmMgICAgICB8IDczICsrKysrKysrKysrKysrKysrKysr LS0tLS0tLS0tLS0tCj4gCj4gQ2FuIHlvdSBzcGxpdCB0aGlzIGludG8gdHdvIHBhdGNoZXM/ICBP bmUgZm9yIGFtZGdwdSBhbmQgb25lIGZvciByYWRlb24/CgpJIHNwbGl0IHRoaXMsIGFuZCBJIGFs c28gd2VudCBiYWNrIGFuZCBzcGxpdCB0aGUgcmVsYXRlZCBwYXRjaGVzIHRoYXQKcHJlY2VkZWQg dGhpcyBvbmUuICBJJ2xsIHBvc3QgdGhlIHJlc3VsdGluZyBzZXJpZXMgZm9yIHJlZmVyZW5jZS4K X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=FAKE_REPLY_C, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56DACC432C0 for ; Thu, 21 Nov 2019 13:55:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 362D720679 for ; Thu, 21 Nov 2019 13:55:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 362D720679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C21326EF3A; Thu, 21 Nov 2019 13:55:19 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id E2AED6E0E2; Thu, 21 Nov 2019 13:55:17 +0000 (UTC) Received: from localhost (173-25-83-245.client.mchsi.com [173.25.83.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 47EC920679; Thu, 21 Nov 2019 13:55:17 +0000 (UTC) Date: Thu, 21 Nov 2019 07:55:05 -0600 From: Bjorn Helgaas To: Alex Deucher Subject: Re: [PATCH v2 1/1] drm: Prefer pcie_capability_read_word() Message-ID: <20191121135505.GA37567@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574344517; bh=6E0YF8yMllj8qK0e/SPC6Lbz+lUTP0OyTKxxgQareDI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=tECdPZzF8HyX9TTmeeiSmLmAIGiDqt8CoZWvW9wj9PVeU71Sq3d/ytdFURHqVq75T N15fg7oPvR15OANOzCtplXs4LfnKht8DXDXpiVb/mlaQWVKyJgRZhlpOaVYfbM86mG fsIFutGcLyCjWv35or3z/6Uexha4fojCRpm/8wcI= X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chunming Zhou , Frederick Lawler , Dave Airlie , Linux PCI , LKML , Maling list - DRI developers , amd-gfx list , Daniel Vetter , "Deucher, Alexander" , Christian Koenig Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Message-ID: <20191121135505.NyP4piujgeyVJmxku1cYViiA7Jiw1hShkLj1byTBTeU@z> T24gTW9uLCBOb3YgMTgsIDIwMTkgYXQgMTI6NDI6MjVQTSAtMDUwMCwgQWxleCBEZXVjaGVyIHdy b3RlOgo+IE9uIE1vbiwgTm92IDE4LCAyMDE5IGF0IDM6MzcgQU0gRnJlZGVyaWNrIExhd2xlciA8 ZnJlZEBmcmVkbGF3bC5jb20+IHdyb3RlOgo+ID4KPiA+IENvbW1pdCA4YzBkM2EwMmMxMzAgKCJQ Q0k6IEFkZCBhY2Nlc3NvcnMgZm9yIFBDSSBFeHByZXNzIENhcGFiaWxpdHkiKQo+ID4gYWRkZWQg YWNjZXNzb3JzIGZvciB0aGUgUENJIEV4cHJlc3MgQ2FwYWJpbGl0eSBzbyB0aGF0IGRyaXZlcnMg ZGlkbid0Cj4gPiBuZWVkIHRvIGJlIGF3YXJlIG9mIGRpZmZlcmVuY2VzIGJldHdlZW4gdjEgYW5k IHYyIG9mIHRoZSBQQ0kKPiA+IEV4cHJlc3MgQ2FwYWJpbGl0eS4KPiA+Cj4gPiBSZXBsYWNlIHBj aV9yZWFkX2NvbmZpZ193b3JkKCkgYW5kIHBjaV93cml0ZV9jb25maWdfd29yZCgpIGNhbGxzIHdp dGgKPiA+IHBjaWVfY2FwYWJpbGl0eV9yZWFkX3dvcmQoKSBhbmQgcGNpZV9jYXBhYmlsaXR5X3dy aXRlX3dvcmQoKS4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBGcmVkZXJpY2sgTGF3bGVyIDxmcmVk QGZyZWRsYXdsLmNvbT4KPiA+Cj4gPiAtLS0KPiA+IFYyCj4gPiAtIFNxdWFzaCBib3RoIGRybSBj b21taXRzIGludG8gb25lCj4gPiAtIFJlYmFzZSBvbnRvcCBvZiBkNDZlYWMxZTY1OGIKPiA+IC0t LQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Npay5jIHwgNjMgKysrKysrKysrKysr KysrKy0tLS0tLS0tLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvc2kuYyAgfCA3 MSArKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL3Jh ZGVvbi9jaWsuYyAgICAgfCA3MCArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0KPiA+ICBk cml2ZXJzL2dwdS9kcm0vcmFkZW9uL3NpLmMgICAgICB8IDczICsrKysrKysrKysrKysrKysrKysr LS0tLS0tLS0tLS0tCj4gCj4gQ2FuIHlvdSBzcGxpdCB0aGlzIGludG8gdHdvIHBhdGNoZXM/ICBP bmUgZm9yIGFtZGdwdSBhbmQgb25lIGZvciByYWRlb24/CgpJIHNwbGl0IHRoaXMsIGFuZCBJIGFs c28gd2VudCBiYWNrIGFuZCBzcGxpdCB0aGUgcmVsYXRlZCBwYXRjaGVzIHRoYXQKcHJlY2VkZWQg dGhpcyBvbmUuICBJJ2xsIHBvc3QgdGhlIHJlc3VsdGluZyBzZXJpZXMgZm9yIHJlZmVyZW5jZS4K X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBt YWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4