From: Wei Liu <wl@xen.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Wei Liu" <liuwe@microsoft.com>, "Wei Liu" <wl@xen.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Michael Kelley" <mikelley@microsoft.com>,
"Xen Development List" <xen-devel@lists.xenproject.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH for-next v3 9/9] x86: introduce CONFIG_HYPERV and detection code
Date: Thu, 21 Nov 2019 17:02:44 +0000 [thread overview]
Message-ID: <20191121170244.4vvetqox35pcitnx@debian> (raw)
In-Reply-To: <a71f7987-751f-a13e-e73c-653a802ea30b@suse.com>
On Thu, Nov 21, 2019 at 05:59:16PM +0100, Jan Beulich wrote:
> >>
> >> Also how about having *_probe() return the address of *_ops, such
> >> that the latter could all become static?
> >
> > Previously you made a suggestion to make probe return the name of the
> > hypervisor. Here you ask for address of ops. I actually prefer the
> > method suggested here, but this means I will need to keep
> > hypervisor_name around.
>
> Is there actually any user of the name field other than the caller
> of probe? If not, surely that caller could access the name field
> without a hypervisor_name() wrapper.
I don't envision more users at this stage.
I'm fine with accessing that field directly. We can always introduce the
function again if it becomes necessary.
Wei.
>
> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2019-11-21 17:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 15:57 [Xen-devel] [PATCH for-next v3 0/9] Port Xen to Hyper-V Wei Liu
2019-10-21 15:57 ` [Xen-devel] [PATCH for-next v3 1/9] x86: introduce CONFIG_GUEST and move code Wei Liu
2019-10-23 7:55 ` Paul Durrant
2019-10-23 10:49 ` Wei Liu
2019-11-15 13:34 ` Jan Beulich
2019-10-21 15:57 ` [Xen-devel] [PATCH for-next v3 2/9] x86: include asm_defns.h directly in hypercall.h Wei Liu
2019-11-15 13:36 ` Jan Beulich
2019-10-21 15:57 ` [Xen-devel] [PATCH for-next v3 3/9] x86: drop hypervisor_cpuid_base Wei Liu
2019-11-15 13:39 ` Jan Beulich
2019-10-21 15:57 ` [Xen-devel] [PATCH for-next v3 4/9] x86: include xen/lib.h in guest/hypercall.h Wei Liu
2019-11-15 13:40 ` Jan Beulich
2019-10-21 15:57 ` [Xen-devel] [PATCH for-next v3 5/9] x86: introduce hypervisor framework Wei Liu
2019-10-23 8:19 ` Paul Durrant
2019-11-15 13:48 ` Jan Beulich
2019-11-21 16:27 ` Wei Liu
2019-10-21 15:57 ` [Xen-devel] [PATCH for-next v3 6/9] x86: rename hypervisor_{alloc, free}_unused_page Wei Liu
2019-11-15 13:49 ` Jan Beulich
2019-11-21 16:27 ` Wei Liu
2019-10-21 15:57 ` [Xen-devel] [PATCH for-next v3 7/9] x86: switch xen implementation to use hypervisor framework Wei Liu
2019-10-23 9:02 ` Paul Durrant
2019-11-15 13:56 ` Jan Beulich
2019-10-21 15:57 ` [Xen-devel] [PATCH for-next v3 8/9] x86: be more verbose when running on a hypervisor Wei Liu
2019-10-23 9:03 ` Paul Durrant
2019-11-15 13:59 ` Jan Beulich
2019-10-21 15:57 ` [Xen-devel] [PATCH for-next v3 9/9] x86: introduce CONFIG_HYPERV and detection code Wei Liu
2019-10-23 9:07 ` Paul Durrant
2019-10-23 10:50 ` Wei Liu
2019-11-15 14:07 ` Jan Beulich
2019-11-21 16:27 ` Wei Liu
2019-11-21 16:59 ` Jan Beulich
2019-11-21 17:02 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121170244.4vvetqox35pcitnx@debian \
--to=wl@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=liuwe@microsoft.com \
--cc=mikelley@microsoft.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.