From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8C6AC432C0 for ; Fri, 22 Nov 2019 10:56:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90D182073F for ; Fri, 22 Nov 2019 10:56:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574420165; bh=DGzxKgyrW12ZxPj6aJKqTQ+5fMeJA1J/Xw/awWrHAsE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Rc+SAtQ60O9c9MvVVc6Q5R9j/+wdfIS0oUgrOLtCZfofnkTjUwnxqVL/TDmG9FjNp T7HYrJJ17cV/b4IR4SlzYuw7vFCzQ3KeGO6hXJYW8xht+0/f8JHAXUBCiKI1ruH+ev mWsOA/bRW6K/enWbbVadCW/fEsLuT00SXSQGqr3s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730548AbfKVK4F (ORCPT ); Fri, 22 Nov 2019 05:56:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:43544 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730131AbfKVK4D (ORCPT ); Fri, 22 Nov 2019 05:56:03 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 065152077B; Fri, 22 Nov 2019 10:56:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574420162; bh=DGzxKgyrW12ZxPj6aJKqTQ+5fMeJA1J/Xw/awWrHAsE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XSOA7vVLduh7NLpVMSqWKTpDDyvXiM1YknPFOgv43z63HRy71JQwoPYIyrcdSTFnW H+JtBOR4vsISbugwZbFnOjhHGDelhSagFFMgPVsqxe79OLRkcv+6D0VtB8dAr2qgNf dAFWdezgxe1TfNjbiHtM63Jz1fpdb/qq3j/kUSeo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, YueHaibing , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 015/220] net: ovs: fix return type of ndo_start_xmit function Date: Fri, 22 Nov 2019 11:26:20 +0100 Message-Id: <20191122100913.681306881@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191122100912.732983531@linuxfoundation.org> References: <20191122100912.732983531@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing [ Upstream commit eddf11e18dff0e8671e06ce54e64cfc843303ab9 ] The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/openvswitch/vport-internal_dev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c index d2356a284646c..3ebf8ba7c3898 100644 --- a/net/openvswitch/vport-internal_dev.c +++ b/net/openvswitch/vport-internal_dev.c @@ -43,7 +43,8 @@ static struct internal_dev *internal_dev_priv(struct net_device *netdev) } /* Called with rcu_read_lock_bh. */ -static int internal_dev_xmit(struct sk_buff *skb, struct net_device *netdev) +static netdev_tx_t +internal_dev_xmit(struct sk_buff *skb, struct net_device *netdev) { int len, err; @@ -62,7 +63,7 @@ static int internal_dev_xmit(struct sk_buff *skb, struct net_device *netdev) } else { netdev->stats.tx_errors++; } - return 0; + return NETDEV_TX_OK; } static int internal_dev_open(struct net_device *netdev) -- 2.20.1