From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7696A6E342 for ; Fri, 22 Nov 2019 14:40:14 +0000 (UTC) Date: Fri, 22 Nov 2019 15:40:09 +0100 From: Zbigniew =?utf-8?Q?Kempczy=C5=84ski?= Message-ID: <20191122144009.GA28086@zkempczy-mobl2> References: <20191122081357.20401-1-zbigniew.kempczynski@intel.com> <20191122081357.20401-4-zbigniew.kempczynski@intel.com> <157441390633.2524.9938450950515056398@skylake-alporthouse-com> <20191122093306.GA26157@zkempczy-mobl2> <157441597171.2524.12180551028552971827@skylake-alporthouse-com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <157441597171.2524.12180551028552971827@skylake-alporthouse-com> Subject: Re: [igt-dev] [PATCH i-g-t v5 3/4] lib/i915/intel_memory_region: Add lib to manage memory regions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson Cc: igt-dev@lists.freedesktop.org List-ID: T24gRnJpLCBOb3YgMjIsIDIwMTkgYXQgMDk6NDY6MTFBTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgWmJpZ25pZXcgS2VtcGN6ecWEc2tpICgyMDE5LTExLTIyIDA5OjMzOjA3 KQo+ID4gT24gRnJpLCBOb3YgMjIsIDIwMTkgYXQgMDk6MTE6NDZBTSArMDAwMCwgQ2hyaXMgV2ls c29uIHdyb3RlOgo+ID4gCj4gPiA+ID4gK2NvbnN0IHN0cnVjdCBpbnRlbF9tZW1vcnlfcmVnaW9u IGludGVsX21lbW9yeV9yZWdpb25zW10gPSB7Cj4gPiA+ID4gKyAgICAgICB7ICJTTUVNIiwgTE9D QUxfSTkxNV9TWVNURU1fTUVNT1JZLCAwIH0sCj4gPiA+IAo+ID4gPiBJIGxvdmUgaG93IHRoZSBm cmllbmRseSBuYW1lcyBhcmUgc28gdGVyc2UgYW5kIGRvIG5vdCBmb2xsb3cgdGhlIGFwaSAvcwo+ ID4gPiAKPiA+ID4gPiArICAgICAgIHsgIkxNRU0iLCBMT0NBTF9JOTE1X0RFVklDRV9NRU1PUlks IDAgfSwKPiA+ID4gPiArICAgICAgIHsgIlNUTE4iLCBMT0NBTF9JOTE1X1NUT0xFTl9NRU1PUlks IDAgfSwKPiA+ID4gPiArICAgICAgIHsgTlVMTCwgMCwgMCB9LAo+ID4gPiA+ICt9Owo+ID4gPiA+ ICsKPiA+ID4gPiArY29uc3QgY2hhciAqbWVtb3J5X3JlZ2lvbl9uYW1lKHVpbnQzMl90IHJlZ2lv bikgewo+ID4gPiA+ICsgICAgICAgdWludDMyX3QgdHlwZTsKPiA+ID4gPiArCj4gPiA+ID4gKyAg ICAgICB0eXBlID0gTUVNT1JZX1RZUEVfRlJPTV9SRUdJT04ocmVnaW9uKTsKPiA+ID4gCj4gPiA+ IFdlIHdpbGwgbmV2ZXIgZW5kIHVwIHdpdGggZ2FyYmFnZSBoZXJlLCBidXQgd2UgYXJlIHNvIHBv bGl0ZSBpbiBvdXIKPiA+ID4gdGVzdGluZy4KPiA+IAo+ID4gSWYgeW91IGhhdmUgYmV0dGVyIGlk ZWEgSSdsbCBmaXggdGhhdC4KPiAKPiBBbGwgSSBtZWFuIGhlcmUgaXMgdGhhdCB0eXBlIDwgQVJS QVlfU0laRShpbnRlbF9tZW1vcnlfcmVnaW9ucykgZWxzZQo+IHJlcG9ydCAidW5rbm93biIgb3Ig c29tZXRoaW5nLgoKWW91J3JlIHJpZ2h0LiBBcmd1bWVudCBjaGVja2luZyBzaG91bGQgYmUgZGVm aW5pdGVseSBhZGRlZCBoZXJlLgoKPiAKPiA+ID4gPiArICAgICAgIHJldHVybiBpbnRlbF9tZW1v cnlfcmVnaW9uc1t0eXBlXS5yZWdpb25fbmFtZTsKPiA+ID4gPiArfQo+ID4gPiA+ICsvKioKPiA+ ID4gPiArICogIGdlbV9nZXRfYmF0Y2hfc2l6ZToKPiA+ID4gPiArICogIEBmZDogb3BlbiBpOTE1 IGRybSBmaWxlIGRlc2NyaXB0b3IKPiA+ID4gPiArICogIEByZWdpb246IHJlZ2lvbiBpbiB3aGlj aCB3ZSB3YW50IHRvIGNyZWF0ZSBhIGJhdGNoCj4gPiA+ID4gKyAqCj4gPiA+ID4gKyAqICBGSVhN RTogQ3VycmVudGx5IGZ1bmN0aW9uIGFzc3VtZXMgd2UgaGF2ZSA2NEsgb24gREVWSUNFIGFuZCA0 Swo+ID4gPiA+ICsgKiAgb24gU1lTVEVNIG1lbW9yeS4gVG8gYmUgZml4ZWQgYWZ0ZXIgbWVtb3J5 IHJlZ2lvbiBwYWdlIHNpemUgZGV0ZWN0aW9uCj4gPiA+ID4gKyAqICBwYXRjaCB3aWxsIGJlIG1l cmdlZC4KPiA+ID4gPiArICovCj4gPiA+ID4gK3VpbnQzMl90IGdlbV9nZXRfYmF0Y2hfc2l6ZShp bnQgZmQsIHVpbnQzMl90IHJlZ2lvbikKPiA+ID4gPiArewo+ID4gPiA+ICsgICAgICAgcmV0dXJu IElTX0RFVklDRV9NRU1PUllfUkVHSU9OKHJlZ2lvbikgPyBTWl82NEsgOiBTWl80SzsKPiA+ID4g PiArfQo+ID4gPiA+ICsKPiA+ID4gPiArc3RhdGljIGJvb2wgX190cnlfZ2VtX2NyZWF0ZV9pbl9y ZWdpb24oaW50IGZkLCB1aW50MzJfdCByZWdpb24pCj4gPiA+ID4gK3sKPiA+ID4gPiArICAgICAg IHVpbnQzMl90IHNpemUsIGhhbmRsZTsKPiA+ID4gPiArICAgICAgIGludCByZXQ7Cj4gPiA+ID4g Kwo+ID4gPiA+ICsgICAgICAgc2l6ZSA9IGdlbV9nZXRfYmF0Y2hfc2l6ZShmZCwgcmVnaW9uKTsK PiA+ID4gCj4gPiA+IHNpemU9MSB3aWxsIGFsd2F5cyBiZSBjb3JyZWN0LCB0aGF0IGhhcyBub3cg YmVlbiBlbnNocmluZWQgaW4gdGhlIEFCSS4KPiA+IAo+ID4gU2hvdWxkIEkgY2hhbmdlIGl0IG9y IHJlZ2lvbiAicGFnZSBzaXplIiBpcyBhY2NlcHRhYmxlPyAKPiAKPiBJIGRvbid0IG1pbmQ7IGp1 c3Qgc3VnZ2VzdGluZyBpdCB3YXMgcmVkdW5kYW50LiBTbyBub3QgZXZlbiB3b3J0aCB0aGUKPiBy YW50IDopCj4gCj4gPiA+IAo+ID4gPiA+ICsgICAgICAgaGFuZGxlID0gZ2VtX2NyZWF0ZShmZCwg c2l6ZSk7Cj4gPiA+ID4gKyAgICAgICByZXQgPSBnZW1fbWlncmF0ZV90b19tZW1vcnlfcmVnaW9u KGZkLCBoYW5kbGUsIHJlZ2lvbik7Cj4gPiA+IAo+ID4gPiBNaWdyYXRlIGlzIGRlZmluaXRlbHkg bm90IHN1cHBvcnRlZCBpbiB0aGUgZmlyc3Qgd2F2ZSBvZiBsYW5kaW5nczsKPiA+ID4gbWVtb3J5 IHBsYWNlbWVudCB3aWxsIGJlIGEgY29uc3RydWN0aW9uIHRpbWUgcHJvcGVydHkgd2l0aCBwb3Nz aWJsZQo+ID4gPiBsYXRlciBleHRlbnNpb24gdG8gcnVudGltZS4KPiA+IAo+ID4gSWYgSSB3b3Vs ZCBoYXZlIGdlbV9jcmVhdGVfZXh0KCkgSSB3b3VsZCBkZWZpbml0ZWx5IHVzZSBpdC4gVW5mb3J0 dW5hdGVseQo+ID4gb25seSBtZWNoYW5pc20gSSBrbm93IGF0IHRoZSBtb21lbnQgdG8gcGxhY2Ug Qk8gaW4gbWVtb3J5IHJlZ2lvbiBpcyAKPiA+IHRvIG1pZ3JhdGUgaXQuIElzIGFueXRoaW5nIEkg bWlzc2VkPyBXaWxsIHdlIGhhdmUgZ2VtX2NyZWF0ZV9leHQoKSB3aXRoCj4gPiBtZW1vcnkgcmVn aW9uIGFzIGFuIGFyZ3VtZW50Pwo+IAo+IEkgbWVhbiB0aGF0IHRoaXMgbmVlZHMgdG8gYmUgcmFp c2VkIGFzIGFuIGlzc3VlIGluIHRoZSBrZXJuZWwKPiBpbXBsZW1lbnRhdGlvbiBhcyBJIGhhdmUg bm90IHNlZW4gYSBzaW5nbGUgc3VnZ2VzdGlvbiBmb3IgaGFuZGxpbmcKPiBnZW1fY3JlYXRlIHdp dGggbXVsdGlwbGUgbWVtb3J5IHJlZ2lvbnMgc2luY2UgYWJvdXQgNSB5ZWFycyBhZ28uCj4gQW5k IHlldCBpdCBpcyBhYnNvbHV0ZWx5IGNydWNpYWwuLi4KPiAKPiA+ID4gPiArICAgICAgIC8qIEZh bGxiYWNrLCB0aGVyZSdzIG5vIG1lbXJlZ2lvbiBpOTE1X3F1ZXJ5IHN1cHBvcnRlZC4gVHJ5IHBy b2JlKCkuICovCj4gPiA+ID4gKyAgICAgICBxdWVyeV9pbmZvID0gX19wcm9iZV9yZWdpb25zKGZk KTsKPiA+ID4gCj4gPiA+IE9oLCB3ZSB3aWxsIG5vdCBoYXZlIG1lbW9yeSByZWdpb25zIHdpdGhv dXQgYSBxdWVyeS4gSWYgYW55dGhpbmcgd2Ugd2lsbAo+ID4gPiBnZXQgbWVtb3J5IHJlZ2lvbnMg ZGVzY3JpYmVkIGJlZm9yZSB5b3UgY2FuIG1ha2UgYSBjaG9pY2UuCj4gPiAKPiA+IFVuZm9ydHVu YXRlbHkgYWZ0ZXIgeW91ciBjb21tZW50IG9uIHByZXZpb3VzIHNlcmllcyBJIGNvbmNsdWRlZCBh ZnRlciBmaXJzdAo+ID4gbWVtb3J5IHJlZ2lvbiBwYXRjaGVzIGxhbmRpbmcgd2Ugd291bGQgc3Vw cG9ydCB0aGVtIHdpdGhvdXQgcXVlcnkgKGN1cnJlbnQgCj4gPiBwYXRjaGVzIGRvZXNuJ3Qgc3Vw cG9ydCB0aGVtLCB0aHVzIHRoaXMgZmFsbGJhY2spLgo+IAo+IE5vLCBJIG1lYW4gd2UgYXJlIGxh bmRpbmcgR0VNX01NQVBfT0ZGU0VUX0lPQ1RMIHNob3J0bHkgYmVmb3JlIHdlIGhhdmUKPiBtZW1v cnkgcmVnaW9ucywgYXMgdGhhdCBpb2N0bCBzaW1wbHkgZXh0ZW5kcyBleGlzdGluZyBBUEkgYW5k IGNhbiBiZQo+IHVzZWQgY3VycmVudGx5Lgo+IAo+IFRoZSBxdWVyeSBhbmQgbWVtb3J5IHJlZ2lv bnMgYXJlIHBhcnQgb2YgdGhlIHNhbWUgQVBJIGJ1bmRsZSB0aGF0IGNvbWVzCj4gbGF0ZXIKClRo YXQgbWVhbnMgdGhhdCB0aGlzIHBhdGNoIHNlcmllcyBzaG91bGQgYmUgc3BsaXR0ZWQsIGdlbV9t bWFuIGZpcnN0Cih5b3UndmUgYWxyZWFkeSBhZGRlZCBSLUIgdGhlcmUpLiBXaWxsIHlvdSBtZXJn ZSB0aGlzIHBhdGNoIChnZW1fbW1hbikKb3Igc2hvdWxkIEkgc2VuZCBpdCBhcyBzZXBhcmF0ZSB3 aXRoIFItQj8KCgo+ID4gPiA+ICsgICAgICAgaWd0X2Fzc2VydChxdWVyeV9pbmZvKTsKPiA+ID4g PiArCj4gPiA+ID4gKyAgICAgICByZXR1cm4gcXVlcnlfaW5mbzsKPiA+ID4gPiArfQo+ID4gPiA+ ICsKPiA+ID4gPiArLyoqCj4gPiA+ID4gKyAqIGdlbV9nZXRfbG1lbV9yZWdpb25fY291bnQ6Cj4g PiA+ID4gKyAqIEBmZDogb3BlbiBpOTE1IGRybSBmaWxlIGRlc2NyaXB0b3IKPiA+ID4gPiArICoK PiA+ID4gPiArICogSGVscGVyIGZ1bmN0aW9uIHRvIGNoZWNrIGhvdyBtYW55IGxtZW0gcmVnaW9u cyBhcmUgYXZhaWxhYmxlIG9uIGRldmljZS4KPiA+ID4gPiArICoKPiA+ID4gPiArICogUmV0dXJu czogTnVtYmVyIG9mIGZvdW5kIGxtZW0gcmVnaW9ucy4KPiA+ID4gPiArICovCj4gPiA+ID4gK3Vp bnQ4X3QgZ2VtX2dldF9sbWVtX3JlZ2lvbl9jb3VudChpbnQgZmQpCj4gPiA+ID4gK3sKPiA+ID4g PiArICAgICAgIHN0cnVjdCBsb2NhbF9pOTE1X3F1ZXJ5X21lbW9yeV9yZWdpb25faW5mbyAqcXVl cnlfaW5mbzsKPiA+ID4gPiArICAgICAgIHVpbnQ4X3QgbnVtX3JlZ2lvbnM7Cj4gPiA+ID4gKyAg ICAgICB1aW50OF90IGxtZW1fcmVnaW9ucyA9IDA7Cj4gPiA+ID4gKwo+ID4gPiA+ICsgICAgICAg cXVlcnlfaW5mbyA9IGdlbV9xdWVyeV9tZW1vcnlfcmVnaW9ucyhmZCk7Cj4gPiA+ID4gKyAgICAg ICBudW1fcmVnaW9ucyA9IHF1ZXJ5X2luZm8tPm51bV9yZWdpb25zOwo+ID4gPiA+ICsKPiA+ID4g PiArICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgbnVtX3JlZ2lvbnM7IGkrKykgewo+ID4gPiA+ ICsgICAgICAgICAgICAgICBpZiAoSVNfREVWSUNFX01FTU9SWV9SRUdJT04ocXVlcnlfaW5mby0+ cmVnaW9uc1tpXS5pZCkpCj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgbG1lbV9yZWdp b25zICs9IDE7Cj4gPiA+ID4gKyAgICAgICB9Cj4gPiA+ID4gKyAgICAgICBmcmVlKHF1ZXJ5X2lu Zm8pOwo+ID4gPiAKPiA+ID4gTWVoLiBEaWRuJ3QgbmVlZCB0aGUgaGVhcC4KPiA+IAo+ID4gWW91 J3JlIHN1Z2dlc3RpbmcgZG9pbmcgYWxsb2NhdGlvbiBpbiBsbWVtIHJlZ2lvbnMgdW50aWwgaXQg ZmFpbHM/Cj4gPiBBIGxvdCBvZiBpb2N0bCgpIHdpbGwgYmUgY2FsbGVkIGluIHRoaXMgY2FzZS4K PiAKPiBOb3BlLiBMb29rIGF0IHRoZSBpb2N0bCBpbnRlcmZhY2UgYWdhaW47IGZvciBtb3N0IG9m IHRoZSB0cml2aWFsCj4gYWxsb2MrZnJlZSBwYXR0ZXJucyB5b3UgY2FuIHN1cHBseSBhIHN0YWNr IGJ1ZmZlciBhbmQgZG8gYSBzaW5nbGUgaW9jdGwKPiB3aXRoIG5vIGFsbG9jYXRpb25zLgoKVG8g YmUgc3VyZSBJIHdpbGwgc3VwcG9ydCBhbGxvY2F0aW9uIG9uLXN0YWNrICh2aWEgYWxsb2NhIGZv ciBleGFtcGxlCm9yIHZhcmlhYmxlIGxlbmd0aCBhcnJheSBDOTkgZXh0ZW50aW9uIG9yIGhhcmRj b2RlZCBzaXplIHN1cmVseSBlbm91Z2gpCkkgc2hvdWxkIG11bHRpcGx5IHBvc3NpYmxlIG51bWJl ciBvZiBtZW1vcnkgcmVnaW9ucyAoY3VycmVudGx5IDE2KSBieQpudW1iZXIgb3IgaW5zdGFuY2Vz ICh1c2luZyBjdXJyZW50IHNwbGl0IGFsc28gMTYpIGJ5IHNpemVvZigqLi5yZWdpb25faW5mbykK KyBzaXplb2YoLi4ucXVlcnlfaW5mbykuIEZyb20gbXkgY2FsY3VsYXRpb24gaXQgZ2l2ZXMgMTZC ICsgMTQzMzZCIHNvIHRoaXMKcmVxdWlyZSBhcm91bmQgMTZLQiBvbiB0aGUgc3RhY2suIEhhdmUg SSBtaXNzZWQgc29tZXRoaW5nPwoKPiAKPiA+ID4gPiArYm9vbCBnZW1fcXVlcnlfaGFzX21lbW9y eV9yZWdpb24oc3RydWN0IGxvY2FsX2k5MTVfcXVlcnlfbWVtb3J5X3JlZ2lvbl9pbmZvICpxdWVy eV9pbmZvLAo+ID4gPiAKPiA+ID4gUmVtaW5kIG1lIHRvIGhhdmUgd29yZHMgd2l0aCB0aGUgbmFt aW5nIGNvbW1pdHRlZS4KPiA+ID4gCj4gPiA+IFRoZSByZXN0IGlzIGZvciBhbiBpbnRlcmZhY2Ug dGhhdCBoYXMgeWV0IHRvIGJlIHNlZW4gYW5kIGRpc2N1c3NlZCwgc28KPiA+ID4gc2hlbHZpbmcg Zm9yIGxhdGVyLgo+ID4gPiAtQ2hyaXMKPiA+IAo+ID4gVG8gYmUgb3duZXN0IEkgZG9uJ3Qga25v dyB3aGF0J3Mgd3Jvbmcgd2l0aCB0aGlzIGZ1bmN0aW9uIG5hbWUuIAo+ID4gSWYgeW91IGhhdmUg YmV0dGVyIGNhbmRpZGF0ZSB5b3UncmUgd2VsY29tZS4KPiAKPiBJdCdzIHRoZSB1QVBJIHR5cGUg bmFtZSB0aGF0IGhhcyBnb25lIGEgbGl0dGxlIG92ZXJib2FyZCB3aXRoIGl0cyBIdW5nYXJpYW4K PiBpbmhlcml0YW5jZS4gSSdtIGp1c3QgbWFraW5nIGEgbm90ZSB0byBjb21wbGFpbiB0byBpdHMg YXV0aG9yLgo+IC1DaHJpcwoKSSBkb24ndCBrbm93IHdoYXQgSHVuZ2FyaWFuIGluaGVyaXRhbmNl IG1lYW5zLiBJIGtub3cgd2h5IEkgbGlrZWx5IGxlZnQKdGhpcyBmdW5jdGlvbiAtIHByZXZpb3Vz bHkgaW50ZXJmYWNlIGFsbG93cyBoYXZpbmcgZGlmZmVyZW50IG1lbW9yeSByZWdpb24gCnF1ZXJ5 IHZpZXdzIGRlcGVuZGluZyBvbiBmZF9zZXRwYXJhbSBzZXR0aW5ncy4gSSdsbCByZW1vdmUgaXQu CgpaYmlnbmlldwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXY=