From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA5ACC432C3 for ; Fri, 22 Nov 2019 17:09:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A075920714 for ; Fri, 22 Nov 2019 17:09:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Wl09CDLN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="eIBsIiSX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A075920714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s4yqforITvZFMBsfSCpSs56vbYnMAwpBFvvicqqJWG8=; b=Wl09CDLN3Mwj8D XioV/V5F7SwdzAAzkB38JaNbJfFnMXujQOBVuNuSPNb0U021iJDV8eGqfsaN6fWN9QP2ACvRPeL20 tQha3WCC3hp/h1HEkHS++gbiK5QuM+wpVef1XmGNazXu/4YriIHaadPXWaelrkJGDhjmGCrNQPUgN 6WJFsgZj7rIslsYUWz5J/aTc6Ib2tpjps8xYZGcROUSqzT1OrCFVRhfqurke5nytzztMdMeCowJ1b LwG2KUqPzxaWRYARFFFCi6dZx/ycDRd15xhMZT7vi8eoOdFt8ipxI+u2hNzeSqiWOsDcAEML5RBdR SLVLO8hD0oS35ew4D6jQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iYCRS-0005sJ-R9; Fri, 22 Nov 2019 17:09:58 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iYCRP-0005r0-M7 for linux-mediatek@lists.infradead.org; Fri, 22 Nov 2019 17:09:57 +0000 Received: by mail-wr1-x441.google.com with SMTP id s5so9507762wrw.2 for ; Fri, 22 Nov 2019 09:09:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GveeeDV1nQsr0bSwcCCx8Vsl+3Babn6Mlzv1ByhFH+Y=; b=eIBsIiSXvp5sCJ0yKABqoG/j1h+d84G9Zl0HXR0dSvxVhfIscq6daBNS4i0L3j3Fbf duO+xDNv0XJY09AcoqHPk0Ix3qIgPTsZ0UDjULIVZXqDQWkXjSytqrRayjTNAz81gVce goTINcX86DPQxJjU2D2wGD4TGIw4AIpqF/sgU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GveeeDV1nQsr0bSwcCCx8Vsl+3Babn6Mlzv1ByhFH+Y=; b=qCkRlu7BZZ1UOBebbRAtBYZe37NKubIgzIu+BgzLiilhNwdpbcHhxLGMeLWIq/8569 y1BV7vHj1+QHNb66NIkql6HhJYOH6SDW/DXVCF4ygk+nG9L/0plknPBs8KFS9x4CcNIc 77X7GEDyEGzMi5SS4nA4F2Rgi8YPV6DAxVpnyiAuOqru+s6/XAcLKwivUxO0SisZJb74 DP13GrkYFAl5TDr169ndPbJzfUpH1Q/yklJ+KPpg6bT1N1fkV4GQ8+BEPDQNadJCxSJb X1pYYD5UagnlA7Ws0ogMXJL4Fket1cOai+xSVkx9nNEkpMNTFqYUCZ5IrKYArUB8e/+r +jLA== X-Gm-Message-State: APjAAAUFB7x3wJJeHs26ufyL3/XhFC2/9SuwKWaxXiTrjEGWsXA357T5 8tPc+J/IXxPT3dC8E7y/Ft2xyw== X-Google-Smtp-Source: APXvYqw21AitnDiR+uQCAQr38tNh94j5CW1Rt6qcwqHjdlzEy/qK8QLOZBeeWzbGVlFlIo1UR84bxw== X-Received: by 2002:a5d:570f:: with SMTP id a15mr18390167wrv.316.1574442592095; Fri, 22 Nov 2019 09:09:52 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id y11sm6590631wrq.12.2019.11.22.09.09.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2019 09:09:51 -0800 (PST) Date: Fri, 22 Nov 2019 18:09:49 +0100 From: Daniel Vetter To: CK Hu Subject: Re: [PATCH 3/8] drm/mediatek: don't open-code drm_gem_fb_create Message-ID: <20191122170949.GH6236@phenom.ffwll.local> References: <20191115092120.4445-1-daniel.vetter@ffwll.ch> <20191115092120.4445-4-daniel.vetter@ffwll.ch> <1574408559.21408.2.camel@mtksdaap41> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1574408559.21408.2.camel@mtksdaap41> X-Operating-System: Linux phenom 5.3.0-1-amd64 User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191122_090955_792901_163B9138 X-CRM114-Status: GOOD ( 22.08 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , DRI Development , linux-mediatek@lists.infradead.org, Philipp Zabel , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, Nov 22, 2019 at 03:42:39PM +0800, CK Hu wrote: > Hi, Daniel: > > On Fri, 2019-11-15 at 10:21 +0100, Daniel Vetter wrote: > > Aside: There's a few other fb_create implementations which > > simply check for valid buffer format (or an approximation thereof), > > and then call drm_gem_fb_create. For atomic drivers at least we could > > walk all planes and make sure the format/modifier combo is valid, > > and remove even more code. > > > > For non-atomic drivers that's not possible, since the format list for > > the primary buffer might be garbage (and most likely it is). > > > > Also delete mtk_drm_fb.[hc] since it would now only contain one > > function. > > Acked-by: CK Hu Pushed to drm-misc-next, thanks for taking a look. -Daniel > > > > > Signed-off-by: Daniel Vetter > > Cc: CK Hu > > Cc: Philipp Zabel > > Cc: Matthias Brugger > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-mediatek@lists.infradead.org > > --- > > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 16 ++++- > > drivers/gpu/drm/mediatek/mtk_drm_fb.c | 92 ------------------------ > > drivers/gpu/drm/mediatek/mtk_drm_fb.h | 13 ---- > > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 - > > 4 files changed, 15 insertions(+), 107 deletions(-) > > delete mode 100644 drivers/gpu/drm/mediatek/mtk_drm_fb.c > > delete mode 100644 drivers/gpu/drm/mediatek/mtk_drm_fb.h > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > index 84d14213d992..2b1c122066ea 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > @@ -16,8 +16,10 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -27,7 +29,6 @@ > > #include "mtk_drm_ddp.h" > > #include "mtk_drm_ddp_comp.h" > > #include "mtk_drm_drv.h" > > -#include "mtk_drm_fb.h" > > #include "mtk_drm_gem.h" > > > > #define DRIVER_NAME "mediatek" > > @@ -115,6 +116,19 @@ static int mtk_atomic_commit(struct drm_device *drm, > > return 0; > > } > > > > +static struct drm_framebuffer * > > +mtk_drm_mode_fb_create(struct drm_device *dev, > > + struct drm_file *file, > > + const struct drm_mode_fb_cmd2 *cmd) > > +{ > > + const struct drm_format_info *info = drm_get_format_info(dev, cmd); > > + > > + if (info->num_planes != 1) > > + return ERR_PTR(-EINVAL); > > + > > + return drm_gem_fb_create(dev, file, cmd); > > +} > > + > > static const struct drm_mode_config_funcs mtk_drm_mode_config_funcs = { > > .fb_create = mtk_drm_mode_fb_create, > > .atomic_check = drm_atomic_helper_check, > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_fb.c b/drivers/gpu/drm/mediatek/mtk_drm_fb.c > > deleted file mode 100644 > > index 3f230a28a2dc..000000000000 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_fb.c > > +++ /dev/null > > @@ -1,92 +0,0 @@ > > -// SPDX-License-Identifier: GPL-2.0-only > > -/* > > - * Copyright (c) 2015 MediaTek Inc. > > - */ > > - > > -#include > > -#include > > - > > -#include > > -#include > > -#include > > -#include > > -#include > > - > > -#include "mtk_drm_drv.h" > > -#include "mtk_drm_fb.h" > > -#include "mtk_drm_gem.h" > > - > > -static const struct drm_framebuffer_funcs mtk_drm_fb_funcs = { > > - .create_handle = drm_gem_fb_create_handle, > > - .destroy = drm_gem_fb_destroy, > > -}; > > - > > -static struct drm_framebuffer *mtk_drm_framebuffer_init(struct drm_device *dev, > > - const struct drm_mode_fb_cmd2 *mode, > > - struct drm_gem_object *obj) > > -{ > > - const struct drm_format_info *info = drm_get_format_info(dev, mode); > > - struct drm_framebuffer *fb; > > - int ret; > > - > > - if (info->num_planes != 1) > > - return ERR_PTR(-EINVAL); > > - > > - fb = kzalloc(sizeof(*fb), GFP_KERNEL); > > - if (!fb) > > - return ERR_PTR(-ENOMEM); > > - > > - drm_helper_mode_fill_fb_struct(dev, fb, mode); > > - > > - fb->obj[0] = obj; > > - > > - ret = drm_framebuffer_init(dev, fb, &mtk_drm_fb_funcs); > > - if (ret) { > > - DRM_ERROR("failed to initialize framebuffer\n"); > > - kfree(fb); > > - return ERR_PTR(ret); > > - } > > - > > - return fb; > > -} > > - > > -struct drm_framebuffer *mtk_drm_mode_fb_create(struct drm_device *dev, > > - struct drm_file *file, > > - const struct drm_mode_fb_cmd2 *cmd) > > -{ > > - const struct drm_format_info *info = drm_get_format_info(dev, cmd); > > - struct drm_framebuffer *fb; > > - struct drm_gem_object *gem; > > - unsigned int width = cmd->width; > > - unsigned int height = cmd->height; > > - unsigned int size, bpp; > > - int ret; > > - > > - if (info->num_planes != 1) > > - return ERR_PTR(-EINVAL); > > - > > - gem = drm_gem_object_lookup(file, cmd->handles[0]); > > - if (!gem) > > - return ERR_PTR(-ENOENT); > > - > > - bpp = info->cpp[0]; > > - size = (height - 1) * cmd->pitches[0] + width * bpp; > > - size += cmd->offsets[0]; > > - > > - if (gem->size < size) { > > - ret = -EINVAL; > > - goto unreference; > > - } > > - > > - fb = mtk_drm_framebuffer_init(dev, cmd, gem); > > - if (IS_ERR(fb)) { > > - ret = PTR_ERR(fb); > > - goto unreference; > > - } > > - > > - return fb; > > - > > -unreference: > > - drm_gem_object_put_unlocked(gem); > > - return ERR_PTR(ret); > > -} > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_fb.h b/drivers/gpu/drm/mediatek/mtk_drm_fb.h > > deleted file mode 100644 > > index eb64d26001c6..000000000000 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_fb.h > > +++ /dev/null > > @@ -1,13 +0,0 @@ > > -/* SPDX-License-Identifier: GPL-2.0-only */ > > -/* > > - * Copyright (c) 2015 MediaTek Inc. > > - */ > > - > > -#ifndef MTK_DRM_FB_H > > -#define MTK_DRM_FB_H > > - > > -struct drm_framebuffer *mtk_drm_mode_fb_create(struct drm_device *dev, > > - struct drm_file *file, > > - const struct drm_mode_fb_cmd2 *cmd); > > - > > -#endif /* MTK_DRM_FB_H */ > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > > index 3b0cc91c7023..540ef2faa40a 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > > @@ -13,7 +13,6 @@ > > #include "mtk_drm_crtc.h" > > #include "mtk_drm_ddp_comp.h" > > #include "mtk_drm_drv.h" > > -#include "mtk_drm_fb.h" > > #include "mtk_drm_gem.h" > > #include "mtk_drm_plane.h" > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4A01C432C0 for ; Fri, 22 Nov 2019 17:10:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A46AB20714 for ; Fri, 22 Nov 2019 17:10:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="u1h8RKZb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="eIBsIiSX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A46AB20714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5Cjy88fMDOU1o6x6LxBznIbGOglzeycStwZXCRayNIM=; b=u1h8RKZbM+Xt1d GXYOEYLss7ZdHlpwUC+1oPZxcodoX7SQLabEFuXJbLNT8Q2uP4gg94boXsEZZV3CEvXpvGDSmJP7v wZ++j8CFtM8WgBWVS6W38BfgI6IgvJLLJfSE1DrAQAluZYVquSj9R2iW771z1E5T3QmXZiT+86ZPD 6y5bxs5acMr9fUva1iJj7K5BzoFq6BQbBAvwxUyg2rZJDtoGP8//VXr9WD8sFSagdDnE4mXzvTNxk 51njAU2EHVprHnNjPpZ6VJDQcpcm5OHWR6U19jt0udDzBlhUnW98XhaRoeafkRBO5g8SfhmEOEw6u 6ouTbSPXqDRAoVNqI7ug==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iYCRT-0005sk-Mv; Fri, 22 Nov 2019 17:09:59 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iYCRP-0005r2-MA for linux-arm-kernel@lists.infradead.org; Fri, 22 Nov 2019 17:09:57 +0000 Received: by mail-wr1-x442.google.com with SMTP id z10so9434964wrs.12 for ; Fri, 22 Nov 2019 09:09:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GveeeDV1nQsr0bSwcCCx8Vsl+3Babn6Mlzv1ByhFH+Y=; b=eIBsIiSXvp5sCJ0yKABqoG/j1h+d84G9Zl0HXR0dSvxVhfIscq6daBNS4i0L3j3Fbf duO+xDNv0XJY09AcoqHPk0Ix3qIgPTsZ0UDjULIVZXqDQWkXjSytqrRayjTNAz81gVce goTINcX86DPQxJjU2D2wGD4TGIw4AIpqF/sgU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GveeeDV1nQsr0bSwcCCx8Vsl+3Babn6Mlzv1ByhFH+Y=; b=t6sZSSy3gNjuaoMYcJ7/40pZaFRAZLmSrrmz2Nb3+MVw8/7/1butKIMt/pls90CXCg DmqSYi9p3weZ8hONtd7B5S01LcVxHieSITSifPwq62yzjyjArA3oSbUTzEtVddU0NSpQ 5BgoGZdbzaSYY2qGX3FqZhJBXs+AJ+N+yn7sSK00613Ppj2nCXhzMBvjl6wDo+6cw8By gPYdw6fTxLBlDBePNY/cpdqQHhGTQcUP+FYB4pEJyKids9dLDNCCrSdP4YTEwXTiPu3L 2yp6sdVC1faxrNluGdSI1r+CD0ySKX4EWfOBL6SPwcNwkHmwhS6EjIa+B/zHeE7xNpDB 9+Xw== X-Gm-Message-State: APjAAAU4IQRNFGhc9GBXQ38cuCPpW8djhjJzLhw8ehT6p+rSMsJ0FpMC Gh9c2M9fmjHVZ30/bGOip8fuiQ== X-Google-Smtp-Source: APXvYqw21AitnDiR+uQCAQr38tNh94j5CW1Rt6qcwqHjdlzEy/qK8QLOZBeeWzbGVlFlIo1UR84bxw== X-Received: by 2002:a5d:570f:: with SMTP id a15mr18390167wrv.316.1574442592095; Fri, 22 Nov 2019 09:09:52 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id y11sm6590631wrq.12.2019.11.22.09.09.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2019 09:09:51 -0800 (PST) Date: Fri, 22 Nov 2019 18:09:49 +0100 From: Daniel Vetter To: CK Hu Subject: Re: [PATCH 3/8] drm/mediatek: don't open-code drm_gem_fb_create Message-ID: <20191122170949.GH6236@phenom.ffwll.local> References: <20191115092120.4445-1-daniel.vetter@ffwll.ch> <20191115092120.4445-4-daniel.vetter@ffwll.ch> <1574408559.21408.2.camel@mtksdaap41> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1574408559.21408.2.camel@mtksdaap41> X-Operating-System: Linux phenom 5.3.0-1-amd64 User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191122_090955_793222_62574589 X-CRM114-Status: GOOD ( 23.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , DRI Development , linux-mediatek@lists.infradead.org, Philipp Zabel , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 22, 2019 at 03:42:39PM +0800, CK Hu wrote: > Hi, Daniel: > > On Fri, 2019-11-15 at 10:21 +0100, Daniel Vetter wrote: > > Aside: There's a few other fb_create implementations which > > simply check for valid buffer format (or an approximation thereof), > > and then call drm_gem_fb_create. For atomic drivers at least we could > > walk all planes and make sure the format/modifier combo is valid, > > and remove even more code. > > > > For non-atomic drivers that's not possible, since the format list for > > the primary buffer might be garbage (and most likely it is). > > > > Also delete mtk_drm_fb.[hc] since it would now only contain one > > function. > > Acked-by: CK Hu Pushed to drm-misc-next, thanks for taking a look. -Daniel > > > > > Signed-off-by: Daniel Vetter > > Cc: CK Hu > > Cc: Philipp Zabel > > Cc: Matthias Brugger > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-mediatek@lists.infradead.org > > --- > > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 16 ++++- > > drivers/gpu/drm/mediatek/mtk_drm_fb.c | 92 ------------------------ > > drivers/gpu/drm/mediatek/mtk_drm_fb.h | 13 ---- > > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 - > > 4 files changed, 15 insertions(+), 107 deletions(-) > > delete mode 100644 drivers/gpu/drm/mediatek/mtk_drm_fb.c > > delete mode 100644 drivers/gpu/drm/mediatek/mtk_drm_fb.h > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > index 84d14213d992..2b1c122066ea 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > @@ -16,8 +16,10 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -27,7 +29,6 @@ > > #include "mtk_drm_ddp.h" > > #include "mtk_drm_ddp_comp.h" > > #include "mtk_drm_drv.h" > > -#include "mtk_drm_fb.h" > > #include "mtk_drm_gem.h" > > > > #define DRIVER_NAME "mediatek" > > @@ -115,6 +116,19 @@ static int mtk_atomic_commit(struct drm_device *drm, > > return 0; > > } > > > > +static struct drm_framebuffer * > > +mtk_drm_mode_fb_create(struct drm_device *dev, > > + struct drm_file *file, > > + const struct drm_mode_fb_cmd2 *cmd) > > +{ > > + const struct drm_format_info *info = drm_get_format_info(dev, cmd); > > + > > + if (info->num_planes != 1) > > + return ERR_PTR(-EINVAL); > > + > > + return drm_gem_fb_create(dev, file, cmd); > > +} > > + > > static const struct drm_mode_config_funcs mtk_drm_mode_config_funcs = { > > .fb_create = mtk_drm_mode_fb_create, > > .atomic_check = drm_atomic_helper_check, > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_fb.c b/drivers/gpu/drm/mediatek/mtk_drm_fb.c > > deleted file mode 100644 > > index 3f230a28a2dc..000000000000 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_fb.c > > +++ /dev/null > > @@ -1,92 +0,0 @@ > > -// SPDX-License-Identifier: GPL-2.0-only > > -/* > > - * Copyright (c) 2015 MediaTek Inc. > > - */ > > - > > -#include > > -#include > > - > > -#include > > -#include > > -#include > > -#include > > -#include > > - > > -#include "mtk_drm_drv.h" > > -#include "mtk_drm_fb.h" > > -#include "mtk_drm_gem.h" > > - > > -static const struct drm_framebuffer_funcs mtk_drm_fb_funcs = { > > - .create_handle = drm_gem_fb_create_handle, > > - .destroy = drm_gem_fb_destroy, > > -}; > > - > > -static struct drm_framebuffer *mtk_drm_framebuffer_init(struct drm_device *dev, > > - const struct drm_mode_fb_cmd2 *mode, > > - struct drm_gem_object *obj) > > -{ > > - const struct drm_format_info *info = drm_get_format_info(dev, mode); > > - struct drm_framebuffer *fb; > > - int ret; > > - > > - if (info->num_planes != 1) > > - return ERR_PTR(-EINVAL); > > - > > - fb = kzalloc(sizeof(*fb), GFP_KERNEL); > > - if (!fb) > > - return ERR_PTR(-ENOMEM); > > - > > - drm_helper_mode_fill_fb_struct(dev, fb, mode); > > - > > - fb->obj[0] = obj; > > - > > - ret = drm_framebuffer_init(dev, fb, &mtk_drm_fb_funcs); > > - if (ret) { > > - DRM_ERROR("failed to initialize framebuffer\n"); > > - kfree(fb); > > - return ERR_PTR(ret); > > - } > > - > > - return fb; > > -} > > - > > -struct drm_framebuffer *mtk_drm_mode_fb_create(struct drm_device *dev, > > - struct drm_file *file, > > - const struct drm_mode_fb_cmd2 *cmd) > > -{ > > - const struct drm_format_info *info = drm_get_format_info(dev, cmd); > > - struct drm_framebuffer *fb; > > - struct drm_gem_object *gem; > > - unsigned int width = cmd->width; > > - unsigned int height = cmd->height; > > - unsigned int size, bpp; > > - int ret; > > - > > - if (info->num_planes != 1) > > - return ERR_PTR(-EINVAL); > > - > > - gem = drm_gem_object_lookup(file, cmd->handles[0]); > > - if (!gem) > > - return ERR_PTR(-ENOENT); > > - > > - bpp = info->cpp[0]; > > - size = (height - 1) * cmd->pitches[0] + width * bpp; > > - size += cmd->offsets[0]; > > - > > - if (gem->size < size) { > > - ret = -EINVAL; > > - goto unreference; > > - } > > - > > - fb = mtk_drm_framebuffer_init(dev, cmd, gem); > > - if (IS_ERR(fb)) { > > - ret = PTR_ERR(fb); > > - goto unreference; > > - } > > - > > - return fb; > > - > > -unreference: > > - drm_gem_object_put_unlocked(gem); > > - return ERR_PTR(ret); > > -} > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_fb.h b/drivers/gpu/drm/mediatek/mtk_drm_fb.h > > deleted file mode 100644 > > index eb64d26001c6..000000000000 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_fb.h > > +++ /dev/null > > @@ -1,13 +0,0 @@ > > -/* SPDX-License-Identifier: GPL-2.0-only */ > > -/* > > - * Copyright (c) 2015 MediaTek Inc. > > - */ > > - > > -#ifndef MTK_DRM_FB_H > > -#define MTK_DRM_FB_H > > - > > -struct drm_framebuffer *mtk_drm_mode_fb_create(struct drm_device *dev, > > - struct drm_file *file, > > - const struct drm_mode_fb_cmd2 *cmd); > > - > > -#endif /* MTK_DRM_FB_H */ > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > > index 3b0cc91c7023..540ef2faa40a 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > > @@ -13,7 +13,6 @@ > > #include "mtk_drm_crtc.h" > > #include "mtk_drm_ddp_comp.h" > > #include "mtk_drm_drv.h" > > -#include "mtk_drm_fb.h" > > #include "mtk_drm_gem.h" > > #include "mtk_drm_plane.h" > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 3/8] drm/mediatek: don't open-code drm_gem_fb_create Date: Fri, 22 Nov 2019 18:09:49 +0100 Message-ID: <20191122170949.GH6236@phenom.ffwll.local> References: <20191115092120.4445-1-daniel.vetter@ffwll.ch> <20191115092120.4445-4-daniel.vetter@ffwll.ch> <1574408559.21408.2.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1574408559.21408.2.camel@mtksdaap41> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: CK Hu Cc: Daniel Vetter , Intel Graphics Development , DRI Development , linux-mediatek@lists.infradead.org, Philipp Zabel , Matthias Brugger , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBOb3YgMjIsIDIwMTkgYXQgMDM6NDI6MzlQTSArMDgwMCwgQ0sgSHUgd3JvdGU6Cj4g SGksIERhbmllbDoKPiAKPiBPbiBGcmksIDIwMTktMTEtMTUgYXQgMTA6MjEgKzAxMDAsIERhbmll bCBWZXR0ZXIgd3JvdGU6Cj4gPiBBc2lkZTogVGhlcmUncyBhIGZldyBvdGhlciBmYl9jcmVhdGUg aW1wbGVtZW50YXRpb25zIHdoaWNoCj4gPiBzaW1wbHkgY2hlY2sgZm9yIHZhbGlkIGJ1ZmZlciBm b3JtYXQgKG9yIGFuIGFwcHJveGltYXRpb24gdGhlcmVvZiksCj4gPiBhbmQgdGhlbiBjYWxsIGRy bV9nZW1fZmJfY3JlYXRlLiBGb3IgYXRvbWljIGRyaXZlcnMgYXQgbGVhc3Qgd2UgY291bGQKPiA+ IHdhbGsgYWxsIHBsYW5lcyBhbmQgbWFrZSBzdXJlIHRoZSBmb3JtYXQvbW9kaWZpZXIgY29tYm8g aXMgdmFsaWQsCj4gPiBhbmQgcmVtb3ZlIGV2ZW4gbW9yZSBjb2RlLgo+ID4gCj4gPiBGb3Igbm9u LWF0b21pYyBkcml2ZXJzIHRoYXQncyBub3QgcG9zc2libGUsIHNpbmNlIHRoZSBmb3JtYXQgbGlz dCBmb3IKPiA+IHRoZSBwcmltYXJ5IGJ1ZmZlciBtaWdodCBiZSBnYXJiYWdlIChhbmQgbW9zdCBs aWtlbHkgaXQgaXMpLgo+ID4gCj4gPiBBbHNvIGRlbGV0ZSBtdGtfZHJtX2ZiLltoY10gc2luY2Ug aXQgd291bGQgbm93IG9ubHkgY29udGFpbiBvbmUKPiA+IGZ1bmN0aW9uLgo+IAo+IEFja2VkLWJ5 OiBDSyBIdSA8Y2suaHVAbWVkaWF0ZWsuY29tPgoKUHVzaGVkIHRvIGRybS1taXNjLW5leHQsIHRo YW5rcyBmb3IgdGFraW5nIGEgbG9vay4KLURhbmllbAoKPiAKPiA+IAo+ID4gU2lnbmVkLW9mZi1i eTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiA+IENjOiBDSyBIdSA8 Y2suaHVAbWVkaWF0ZWsuY29tPgo+ID4gQ2M6IFBoaWxpcHAgWmFiZWwgPHAuemFiZWxAcGVuZ3V0 cm9uaXguZGU+Cj4gPiBDYzogTWF0dGhpYXMgQnJ1Z2dlciA8bWF0dGhpYXMuYmdnQGdtYWlsLmNv bT4KPiA+IENjOiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKPiA+IENjOiBs aW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnCj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dw dS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kcnYuYyAgIHwgMTYgKysrKy0KPiA+ICBkcml2ZXJzL2dw dS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9mYi5jICAgIHwgOTIgLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZmIuaCAgICB8IDEzIC0t LS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9wbGFuZS5jIHwgIDEgLQo+ ID4gIDQgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMTA3IGRlbGV0aW9ucygtKQo+ ID4gIGRlbGV0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9m Yi5jCj4gPiAgZGVsZXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtf ZHJtX2ZiLmgKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9t dGtfZHJtX2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZHJ2LmMKPiA+ IGluZGV4IDg0ZDE0MjEzZDk5Mi4uMmIxYzEyMjA2NmVhIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZHJ2LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9tZWRpYXRlay9tdGtfZHJtX2Rydi5jCj4gPiBAQCAtMTYsOCArMTYsMTAgQEAKPiA+ICAjaW5j bHVkZSA8ZHJtL2RybV9hdG9taWNfaGVscGVyLmg+Cj4gPiAgI2luY2x1ZGUgPGRybS9kcm1fZHJ2 Lmg+Cj4gPiAgI2luY2x1ZGUgPGRybS9kcm1fZmJfaGVscGVyLmg+Cj4gPiArI2luY2x1ZGUgPGRy bS9kcm1fZm91cmNjLmg+Cj4gPiAgI2luY2x1ZGUgPGRybS9kcm1fZ2VtLmg+Cj4gPiAgI2luY2x1 ZGUgPGRybS9kcm1fZ2VtX2NtYV9oZWxwZXIuaD4KPiA+ICsjaW5jbHVkZSA8ZHJtL2RybV9nZW1f ZnJhbWVidWZmZXJfaGVscGVyLmg+Cj4gPiAgI2luY2x1ZGUgPGRybS9kcm1fb2YuaD4KPiA+ICAj aW5jbHVkZSA8ZHJtL2RybV9wcm9iZV9oZWxwZXIuaD4KPiA+ICAjaW5jbHVkZSA8ZHJtL2RybV92 YmxhbmsuaD4KPiA+IEBAIC0yNyw3ICsyOSw2IEBACj4gPiAgI2luY2x1ZGUgIm10a19kcm1fZGRw LmgiCj4gPiAgI2luY2x1ZGUgIm10a19kcm1fZGRwX2NvbXAuaCIKPiA+ICAjaW5jbHVkZSAibXRr X2RybV9kcnYuaCIKPiA+IC0jaW5jbHVkZSAibXRrX2RybV9mYi5oIgo+ID4gICNpbmNsdWRlICJt dGtfZHJtX2dlbS5oIgo+ID4gIAo+ID4gICNkZWZpbmUgRFJJVkVSX05BTUUgIm1lZGlhdGVrIgo+ ID4gQEAgLTExNSw2ICsxMTYsMTkgQEAgc3RhdGljIGludCBtdGtfYXRvbWljX2NvbW1pdChzdHJ1 Y3QgZHJtX2RldmljZSAqZHJtLAo+ID4gIAlyZXR1cm4gMDsKPiA+ICB9Cj4gPiAgCj4gPiArc3Rh dGljIHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKgo+ID4gK210a19kcm1fbW9kZV9mYl9jcmVhdGUo c3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ICsJCSAgICAgICBzdHJ1Y3QgZHJtX2ZpbGUgKmZp bGUsCj4gPiArCQkgICAgICAgY29uc3Qgc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIgKmNtZCkKPiA+ ICt7Cj4gPiArCWNvbnN0IHN0cnVjdCBkcm1fZm9ybWF0X2luZm8gKmluZm8gPSBkcm1fZ2V0X2Zv cm1hdF9pbmZvKGRldiwgY21kKTsKPiA+ICsKPiA+ICsJaWYgKGluZm8tPm51bV9wbGFuZXMgIT0g MSkKPiA+ICsJCXJldHVybiBFUlJfUFRSKC1FSU5WQUwpOwo+ID4gKwo+ID4gKwlyZXR1cm4gZHJt X2dlbV9mYl9jcmVhdGUoZGV2LCBmaWxlLCBjbWQpOwo+ID4gK30KPiA+ICsKPiA+ICBzdGF0aWMg Y29uc3Qgc3RydWN0IGRybV9tb2RlX2NvbmZpZ19mdW5jcyBtdGtfZHJtX21vZGVfY29uZmlnX2Z1 bmNzID0gewo+ID4gIAkuZmJfY3JlYXRlID0gbXRrX2RybV9tb2RlX2ZiX2NyZWF0ZSwKPiA+ICAJ LmF0b21pY19jaGVjayA9IGRybV9hdG9taWNfaGVscGVyX2NoZWNrLAo+ID4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2ZiLmMgYi9kcml2ZXJzL2dwdS9kcm0v bWVkaWF0ZWsvbXRrX2RybV9mYi5jCj4gPiBkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKPiA+IGlu ZGV4IDNmMjMwYTI4YTJkYy4uMDAwMDAwMDAwMDAwCj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v bWVkaWF0ZWsvbXRrX2RybV9mYi5jCj4gPiArKysgL2Rldi9udWxsCj4gPiBAQCAtMSw5MiArMCww IEBACj4gPiAtLy8gU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAtb25seQo+ID4gLS8q Cj4gPiAtICogQ29weXJpZ2h0IChjKSAyMDE1IE1lZGlhVGVrIEluYy4KPiA+IC0gKi8KPiA+IC0K PiA+IC0jaW5jbHVkZSA8bGludXgvZG1hLWJ1Zi5oPgo+ID4gLSNpbmNsdWRlIDxsaW51eC9kbWEt cmVzdi5oPgo+ID4gLQo+ID4gLSNpbmNsdWRlIDxkcm0vZHJtX21vZGVzZXRfaGVscGVyLmg+Cj4g PiAtI2luY2x1ZGUgPGRybS9kcm1fZmJfaGVscGVyLmg+Cj4gPiAtI2luY2x1ZGUgPGRybS9kcm1f Zm91cmNjLmg+Cj4gPiAtI2luY2x1ZGUgPGRybS9kcm1fZ2VtLmg+Cj4gPiAtI2luY2x1ZGUgPGRy bS9kcm1fZ2VtX2ZyYW1lYnVmZmVyX2hlbHBlci5oPgo+ID4gLQo+ID4gLSNpbmNsdWRlICJtdGtf ZHJtX2Rydi5oIgo+ID4gLSNpbmNsdWRlICJtdGtfZHJtX2ZiLmgiCj4gPiAtI2luY2x1ZGUgIm10 a19kcm1fZ2VtLmgiCj4gPiAtCj4gPiAtc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fZnJhbWVidWZm ZXJfZnVuY3MgbXRrX2RybV9mYl9mdW5jcyA9IHsKPiA+IC0JLmNyZWF0ZV9oYW5kbGUgPSBkcm1f Z2VtX2ZiX2NyZWF0ZV9oYW5kbGUsCj4gPiAtCS5kZXN0cm95ID0gZHJtX2dlbV9mYl9kZXN0cm95 LAo+ID4gLX07Cj4gPiAtCj4gPiAtc3RhdGljIHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKm10a19k cm1fZnJhbWVidWZmZXJfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4gLQkJCQkJY29u c3Qgc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIgKm1vZGUsCj4gPiAtCQkJCQlzdHJ1Y3QgZHJtX2dl bV9vYmplY3QgKm9iaikKPiA+IC17Cj4gPiAtCWNvbnN0IHN0cnVjdCBkcm1fZm9ybWF0X2luZm8g KmluZm8gPSBkcm1fZ2V0X2Zvcm1hdF9pbmZvKGRldiwgbW9kZSk7Cj4gPiAtCXN0cnVjdCBkcm1f ZnJhbWVidWZmZXIgKmZiOwo+ID4gLQlpbnQgcmV0Owo+ID4gLQo+ID4gLQlpZiAoaW5mby0+bnVt X3BsYW5lcyAhPSAxKQo+ID4gLQkJcmV0dXJuIEVSUl9QVFIoLUVJTlZBTCk7Cj4gPiAtCj4gPiAt CWZiID0ga3phbGxvYyhzaXplb2YoKmZiKSwgR0ZQX0tFUk5FTCk7Cj4gPiAtCWlmICghZmIpCj4g PiAtCQlyZXR1cm4gRVJSX1BUUigtRU5PTUVNKTsKPiA+IC0KPiA+IC0JZHJtX2hlbHBlcl9tb2Rl X2ZpbGxfZmJfc3RydWN0KGRldiwgZmIsIG1vZGUpOwo+ID4gLQo+ID4gLQlmYi0+b2JqWzBdID0g b2JqOwo+ID4gLQo+ID4gLQlyZXQgPSBkcm1fZnJhbWVidWZmZXJfaW5pdChkZXYsIGZiLCAmbXRr X2RybV9mYl9mdW5jcyk7Cj4gPiAtCWlmIChyZXQpIHsKPiA+IC0JCURSTV9FUlJPUigiZmFpbGVk IHRvIGluaXRpYWxpemUgZnJhbWVidWZmZXJcbiIpOwo+ID4gLQkJa2ZyZWUoZmIpOwo+ID4gLQkJ cmV0dXJuIEVSUl9QVFIocmV0KTsKPiA+IC0JfQo+ID4gLQo+ID4gLQlyZXR1cm4gZmI7Cj4gPiAt fQo+ID4gLQo+ID4gLXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKm10a19kcm1fbW9kZV9mYl9jcmVh dGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+IC0JCQkJCSAgICAgICBzdHJ1Y3QgZHJtX2Zp bGUgKmZpbGUsCj4gPiAtCQkJCQkgICAgICAgY29uc3Qgc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIg KmNtZCkKPiA+IC17Cj4gPiAtCWNvbnN0IHN0cnVjdCBkcm1fZm9ybWF0X2luZm8gKmluZm8gPSBk cm1fZ2V0X2Zvcm1hdF9pbmZvKGRldiwgY21kKTsKPiA+IC0Jc3RydWN0IGRybV9mcmFtZWJ1ZmZl ciAqZmI7Cj4gPiAtCXN0cnVjdCBkcm1fZ2VtX29iamVjdCAqZ2VtOwo+ID4gLQl1bnNpZ25lZCBp bnQgd2lkdGggPSBjbWQtPndpZHRoOwo+ID4gLQl1bnNpZ25lZCBpbnQgaGVpZ2h0ID0gY21kLT5o ZWlnaHQ7Cj4gPiAtCXVuc2lnbmVkIGludCBzaXplLCBicHA7Cj4gPiAtCWludCByZXQ7Cj4gPiAt Cj4gPiAtCWlmIChpbmZvLT5udW1fcGxhbmVzICE9IDEpCj4gPiAtCQlyZXR1cm4gRVJSX1BUUigt RUlOVkFMKTsKPiA+IC0KPiA+IC0JZ2VtID0gZHJtX2dlbV9vYmplY3RfbG9va3VwKGZpbGUsIGNt ZC0+aGFuZGxlc1swXSk7Cj4gPiAtCWlmICghZ2VtKQo+ID4gLQkJcmV0dXJuIEVSUl9QVFIoLUVO T0VOVCk7Cj4gPiAtCj4gPiAtCWJwcCA9IGluZm8tPmNwcFswXTsKPiA+IC0Jc2l6ZSA9IChoZWln aHQgLSAxKSAqIGNtZC0+cGl0Y2hlc1swXSArIHdpZHRoICogYnBwOwo+ID4gLQlzaXplICs9IGNt ZC0+b2Zmc2V0c1swXTsKPiA+IC0KPiA+IC0JaWYgKGdlbS0+c2l6ZSA8IHNpemUpIHsKPiA+IC0J CXJldCA9IC1FSU5WQUw7Cj4gPiAtCQlnb3RvIHVucmVmZXJlbmNlOwo+ID4gLQl9Cj4gPiAtCj4g PiAtCWZiID0gbXRrX2RybV9mcmFtZWJ1ZmZlcl9pbml0KGRldiwgY21kLCBnZW0pOwo+ID4gLQlp ZiAoSVNfRVJSKGZiKSkgewo+ID4gLQkJcmV0ID0gUFRSX0VSUihmYik7Cj4gPiAtCQlnb3RvIHVu cmVmZXJlbmNlOwo+ID4gLQl9Cj4gPiAtCj4gPiAtCXJldHVybiBmYjsKPiA+IC0KPiA+IC11bnJl ZmVyZW5jZToKPiA+IC0JZHJtX2dlbV9vYmplY3RfcHV0X3VubG9ja2VkKGdlbSk7Cj4gPiAtCXJl dHVybiBFUlJfUFRSKHJldCk7Cj4gPiAtfQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9tZWRpYXRlay9tdGtfZHJtX2ZiLmggYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2Ry bV9mYi5oCj4gPiBkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKPiA+IGluZGV4IGViNjRkMjYwMDFj Ni4uMDAwMDAwMDAwMDAwCj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2Ry bV9mYi5oCj4gPiArKysgL2Rldi9udWxsCj4gPiBAQCAtMSwxMyArMCwwIEBACj4gPiAtLyogU1BE WC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAtb25seSAqLwo+ID4gLS8qCj4gPiAtICogQ29w eXJpZ2h0IChjKSAyMDE1IE1lZGlhVGVrIEluYy4KPiA+IC0gKi8KPiA+IC0KPiA+IC0jaWZuZGVm IE1US19EUk1fRkJfSAo+ID4gLSNkZWZpbmUgTVRLX0RSTV9GQl9ICj4gPiAtCj4gPiAtc3RydWN0 IGRybV9mcmFtZWJ1ZmZlciAqbXRrX2RybV9tb2RlX2ZiX2NyZWF0ZShzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2LAo+ID4gLQkJCQkJICAgICAgIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSwKPiA+IC0JCQkJ CSAgICAgICBjb25zdCBzdHJ1Y3QgZHJtX21vZGVfZmJfY21kMiAqY21kKTsKPiA+IC0KPiA+IC0j ZW5kaWYgLyogTVRLX0RSTV9GQl9IICovCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L21lZGlhdGVrL210a19kcm1fcGxhbmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtf ZHJtX3BsYW5lLmMKPiA+IGluZGV4IDNiMGNjOTFjNzAyMy4uNTQwZWYyZmFhNDBhIDEwMDY0NAo+ ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fcGxhbmUuYwo+ID4gKysr IGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fcGxhbmUuYwo+ID4gQEAgLTEzLDcg KzEzLDYgQEAKPiA+ICAjaW5jbHVkZSAibXRrX2RybV9jcnRjLmgiCj4gPiAgI2luY2x1ZGUgIm10 a19kcm1fZGRwX2NvbXAuaCIKPiA+ICAjaW5jbHVkZSAibXRrX2RybV9kcnYuaCIKPiA+IC0jaW5j bHVkZSAibXRrX2RybV9mYi5oIgo+ID4gICNpbmNsdWRlICJtdGtfZHJtX2dlbS5oIgo+ID4gICNp bmNsdWRlICJtdGtfZHJtX3BsYW5lLmgiCj4gPiAgCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0 d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5427CC432C3 for ; Fri, 22 Nov 2019 17:09:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31F2920714 for ; Fri, 22 Nov 2019 17:09:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31F2920714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E91696E429; Fri, 22 Nov 2019 17:09:55 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 233036E0FF for ; Fri, 22 Nov 2019 17:09:54 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id i12so9425922wrn.11 for ; Fri, 22 Nov 2019 09:09:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GveeeDV1nQsr0bSwcCCx8Vsl+3Babn6Mlzv1ByhFH+Y=; b=cWlg9KmIUQFeyi3aYmUbdDHVfcF+fb6CR0131oyB7ez662FKtT7n+MW9AT46MQfNoW el3x4l5Vztzk5G/ZTzBPAo4qDiv9dR21sG1MW3r2u7z9pVUQFLA2QcknABhihdWp1dXO LQp/Me4i7dlyGP0fnJRp9e0l0LBLPG7VNltMT7Qu9pbdzChNkRMtiX+mGYZGP7MiCUb7 wDdGvgyA6DIdJk7eal9yZ2DwrmEEZ51SbJtkqubcGith0TToz1Yz0VZRvwR6a4cda+R0 kx7rSZQ3N9B1tK7NKWxb9hfrRraAZMW1qgKHrHY8HtqyIZr4a+4IiyXFRZop28vQrCH+ pATw== X-Gm-Message-State: APjAAAVzsm6DzDNO2a7jsMe8DfQ6ScSqPJFd1eXxfDv+cZD8Y/UveRKL HOmbCt409QspP7JoBQ/tHJtsIw== X-Google-Smtp-Source: APXvYqw21AitnDiR+uQCAQr38tNh94j5CW1Rt6qcwqHjdlzEy/qK8QLOZBeeWzbGVlFlIo1UR84bxw== X-Received: by 2002:a5d:570f:: with SMTP id a15mr18390167wrv.316.1574442592095; Fri, 22 Nov 2019 09:09:52 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id y11sm6590631wrq.12.2019.11.22.09.09.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2019 09:09:51 -0800 (PST) Date: Fri, 22 Nov 2019 18:09:49 +0100 From: Daniel Vetter To: CK Hu Subject: Re: [PATCH 3/8] drm/mediatek: don't open-code drm_gem_fb_create Message-ID: <20191122170949.GH6236@phenom.ffwll.local> References: <20191115092120.4445-1-daniel.vetter@ffwll.ch> <20191115092120.4445-4-daniel.vetter@ffwll.ch> <1574408559.21408.2.camel@mtksdaap41> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1574408559.21408.2.camel@mtksdaap41> X-Operating-System: Linux phenom 5.3.0-1-amd64 User-Agent: Mutt/1.12.2 (2019-09-21) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GveeeDV1nQsr0bSwcCCx8Vsl+3Babn6Mlzv1ByhFH+Y=; b=eIBsIiSXvp5sCJ0yKABqoG/j1h+d84G9Zl0HXR0dSvxVhfIscq6daBNS4i0L3j3Fbf duO+xDNv0XJY09AcoqHPk0Ix3qIgPTsZ0UDjULIVZXqDQWkXjSytqrRayjTNAz81gVce goTINcX86DPQxJjU2D2wGD4TGIw4AIpqF/sgU= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , DRI Development , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191122170949.8S9V7ICalDJ_jIHkDeIc5XDPVGnPG_AonZ8PqEf7a3s@z> T24gRnJpLCBOb3YgMjIsIDIwMTkgYXQgMDM6NDI6MzlQTSArMDgwMCwgQ0sgSHUgd3JvdGU6Cj4g SGksIERhbmllbDoKPiAKPiBPbiBGcmksIDIwMTktMTEtMTUgYXQgMTA6MjEgKzAxMDAsIERhbmll bCBWZXR0ZXIgd3JvdGU6Cj4gPiBBc2lkZTogVGhlcmUncyBhIGZldyBvdGhlciBmYl9jcmVhdGUg aW1wbGVtZW50YXRpb25zIHdoaWNoCj4gPiBzaW1wbHkgY2hlY2sgZm9yIHZhbGlkIGJ1ZmZlciBm b3JtYXQgKG9yIGFuIGFwcHJveGltYXRpb24gdGhlcmVvZiksCj4gPiBhbmQgdGhlbiBjYWxsIGRy bV9nZW1fZmJfY3JlYXRlLiBGb3IgYXRvbWljIGRyaXZlcnMgYXQgbGVhc3Qgd2UgY291bGQKPiA+ IHdhbGsgYWxsIHBsYW5lcyBhbmQgbWFrZSBzdXJlIHRoZSBmb3JtYXQvbW9kaWZpZXIgY29tYm8g aXMgdmFsaWQsCj4gPiBhbmQgcmVtb3ZlIGV2ZW4gbW9yZSBjb2RlLgo+ID4gCj4gPiBGb3Igbm9u LWF0b21pYyBkcml2ZXJzIHRoYXQncyBub3QgcG9zc2libGUsIHNpbmNlIHRoZSBmb3JtYXQgbGlz dCBmb3IKPiA+IHRoZSBwcmltYXJ5IGJ1ZmZlciBtaWdodCBiZSBnYXJiYWdlIChhbmQgbW9zdCBs aWtlbHkgaXQgaXMpLgo+ID4gCj4gPiBBbHNvIGRlbGV0ZSBtdGtfZHJtX2ZiLltoY10gc2luY2Ug aXQgd291bGQgbm93IG9ubHkgY29udGFpbiBvbmUKPiA+IGZ1bmN0aW9uLgo+IAo+IEFja2VkLWJ5 OiBDSyBIdSA8Y2suaHVAbWVkaWF0ZWsuY29tPgoKUHVzaGVkIHRvIGRybS1taXNjLW5leHQsIHRo YW5rcyBmb3IgdGFraW5nIGEgbG9vay4KLURhbmllbAoKPiAKPiA+IAo+ID4gU2lnbmVkLW9mZi1i eTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiA+IENjOiBDSyBIdSA8 Y2suaHVAbWVkaWF0ZWsuY29tPgo+ID4gQ2M6IFBoaWxpcHAgWmFiZWwgPHAuemFiZWxAcGVuZ3V0 cm9uaXguZGU+Cj4gPiBDYzogTWF0dGhpYXMgQnJ1Z2dlciA8bWF0dGhpYXMuYmdnQGdtYWlsLmNv bT4KPiA+IENjOiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKPiA+IENjOiBs aW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnCj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dw dS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kcnYuYyAgIHwgMTYgKysrKy0KPiA+ICBkcml2ZXJzL2dw dS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9mYi5jICAgIHwgOTIgLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZmIuaCAgICB8IDEzIC0t LS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9wbGFuZS5jIHwgIDEgLQo+ ID4gIDQgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMTA3IGRlbGV0aW9ucygtKQo+ ID4gIGRlbGV0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9m Yi5jCj4gPiAgZGVsZXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtf ZHJtX2ZiLmgKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9t dGtfZHJtX2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZHJ2LmMKPiA+ IGluZGV4IDg0ZDE0MjEzZDk5Mi4uMmIxYzEyMjA2NmVhIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZHJ2LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9tZWRpYXRlay9tdGtfZHJtX2Rydi5jCj4gPiBAQCAtMTYsOCArMTYsMTAgQEAKPiA+ICAjaW5j bHVkZSA8ZHJtL2RybV9hdG9taWNfaGVscGVyLmg+Cj4gPiAgI2luY2x1ZGUgPGRybS9kcm1fZHJ2 Lmg+Cj4gPiAgI2luY2x1ZGUgPGRybS9kcm1fZmJfaGVscGVyLmg+Cj4gPiArI2luY2x1ZGUgPGRy bS9kcm1fZm91cmNjLmg+Cj4gPiAgI2luY2x1ZGUgPGRybS9kcm1fZ2VtLmg+Cj4gPiAgI2luY2x1 ZGUgPGRybS9kcm1fZ2VtX2NtYV9oZWxwZXIuaD4KPiA+ICsjaW5jbHVkZSA8ZHJtL2RybV9nZW1f ZnJhbWVidWZmZXJfaGVscGVyLmg+Cj4gPiAgI2luY2x1ZGUgPGRybS9kcm1fb2YuaD4KPiA+ICAj aW5jbHVkZSA8ZHJtL2RybV9wcm9iZV9oZWxwZXIuaD4KPiA+ICAjaW5jbHVkZSA8ZHJtL2RybV92 YmxhbmsuaD4KPiA+IEBAIC0yNyw3ICsyOSw2IEBACj4gPiAgI2luY2x1ZGUgIm10a19kcm1fZGRw LmgiCj4gPiAgI2luY2x1ZGUgIm10a19kcm1fZGRwX2NvbXAuaCIKPiA+ICAjaW5jbHVkZSAibXRr X2RybV9kcnYuaCIKPiA+IC0jaW5jbHVkZSAibXRrX2RybV9mYi5oIgo+ID4gICNpbmNsdWRlICJt dGtfZHJtX2dlbS5oIgo+ID4gIAo+ID4gICNkZWZpbmUgRFJJVkVSX05BTUUgIm1lZGlhdGVrIgo+ ID4gQEAgLTExNSw2ICsxMTYsMTkgQEAgc3RhdGljIGludCBtdGtfYXRvbWljX2NvbW1pdChzdHJ1 Y3QgZHJtX2RldmljZSAqZHJtLAo+ID4gIAlyZXR1cm4gMDsKPiA+ICB9Cj4gPiAgCj4gPiArc3Rh dGljIHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKgo+ID4gK210a19kcm1fbW9kZV9mYl9jcmVhdGUo c3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ICsJCSAgICAgICBzdHJ1Y3QgZHJtX2ZpbGUgKmZp bGUsCj4gPiArCQkgICAgICAgY29uc3Qgc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIgKmNtZCkKPiA+ ICt7Cj4gPiArCWNvbnN0IHN0cnVjdCBkcm1fZm9ybWF0X2luZm8gKmluZm8gPSBkcm1fZ2V0X2Zv cm1hdF9pbmZvKGRldiwgY21kKTsKPiA+ICsKPiA+ICsJaWYgKGluZm8tPm51bV9wbGFuZXMgIT0g MSkKPiA+ICsJCXJldHVybiBFUlJfUFRSKC1FSU5WQUwpOwo+ID4gKwo+ID4gKwlyZXR1cm4gZHJt X2dlbV9mYl9jcmVhdGUoZGV2LCBmaWxlLCBjbWQpOwo+ID4gK30KPiA+ICsKPiA+ICBzdGF0aWMg Y29uc3Qgc3RydWN0IGRybV9tb2RlX2NvbmZpZ19mdW5jcyBtdGtfZHJtX21vZGVfY29uZmlnX2Z1 bmNzID0gewo+ID4gIAkuZmJfY3JlYXRlID0gbXRrX2RybV9tb2RlX2ZiX2NyZWF0ZSwKPiA+ICAJ LmF0b21pY19jaGVjayA9IGRybV9hdG9taWNfaGVscGVyX2NoZWNrLAo+ID4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2ZiLmMgYi9kcml2ZXJzL2dwdS9kcm0v bWVkaWF0ZWsvbXRrX2RybV9mYi5jCj4gPiBkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKPiA+IGlu ZGV4IDNmMjMwYTI4YTJkYy4uMDAwMDAwMDAwMDAwCj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v bWVkaWF0ZWsvbXRrX2RybV9mYi5jCj4gPiArKysgL2Rldi9udWxsCj4gPiBAQCAtMSw5MiArMCww IEBACj4gPiAtLy8gU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAtb25seQo+ID4gLS8q Cj4gPiAtICogQ29weXJpZ2h0IChjKSAyMDE1IE1lZGlhVGVrIEluYy4KPiA+IC0gKi8KPiA+IC0K PiA+IC0jaW5jbHVkZSA8bGludXgvZG1hLWJ1Zi5oPgo+ID4gLSNpbmNsdWRlIDxsaW51eC9kbWEt cmVzdi5oPgo+ID4gLQo+ID4gLSNpbmNsdWRlIDxkcm0vZHJtX21vZGVzZXRfaGVscGVyLmg+Cj4g PiAtI2luY2x1ZGUgPGRybS9kcm1fZmJfaGVscGVyLmg+Cj4gPiAtI2luY2x1ZGUgPGRybS9kcm1f Zm91cmNjLmg+Cj4gPiAtI2luY2x1ZGUgPGRybS9kcm1fZ2VtLmg+Cj4gPiAtI2luY2x1ZGUgPGRy bS9kcm1fZ2VtX2ZyYW1lYnVmZmVyX2hlbHBlci5oPgo+ID4gLQo+ID4gLSNpbmNsdWRlICJtdGtf ZHJtX2Rydi5oIgo+ID4gLSNpbmNsdWRlICJtdGtfZHJtX2ZiLmgiCj4gPiAtI2luY2x1ZGUgIm10 a19kcm1fZ2VtLmgiCj4gPiAtCj4gPiAtc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fZnJhbWVidWZm ZXJfZnVuY3MgbXRrX2RybV9mYl9mdW5jcyA9IHsKPiA+IC0JLmNyZWF0ZV9oYW5kbGUgPSBkcm1f Z2VtX2ZiX2NyZWF0ZV9oYW5kbGUsCj4gPiAtCS5kZXN0cm95ID0gZHJtX2dlbV9mYl9kZXN0cm95 LAo+ID4gLX07Cj4gPiAtCj4gPiAtc3RhdGljIHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKm10a19k cm1fZnJhbWVidWZmZXJfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4gLQkJCQkJY29u c3Qgc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIgKm1vZGUsCj4gPiAtCQkJCQlzdHJ1Y3QgZHJtX2dl bV9vYmplY3QgKm9iaikKPiA+IC17Cj4gPiAtCWNvbnN0IHN0cnVjdCBkcm1fZm9ybWF0X2luZm8g KmluZm8gPSBkcm1fZ2V0X2Zvcm1hdF9pbmZvKGRldiwgbW9kZSk7Cj4gPiAtCXN0cnVjdCBkcm1f ZnJhbWVidWZmZXIgKmZiOwo+ID4gLQlpbnQgcmV0Owo+ID4gLQo+ID4gLQlpZiAoaW5mby0+bnVt X3BsYW5lcyAhPSAxKQo+ID4gLQkJcmV0dXJuIEVSUl9QVFIoLUVJTlZBTCk7Cj4gPiAtCj4gPiAt CWZiID0ga3phbGxvYyhzaXplb2YoKmZiKSwgR0ZQX0tFUk5FTCk7Cj4gPiAtCWlmICghZmIpCj4g PiAtCQlyZXR1cm4gRVJSX1BUUigtRU5PTUVNKTsKPiA+IC0KPiA+IC0JZHJtX2hlbHBlcl9tb2Rl X2ZpbGxfZmJfc3RydWN0KGRldiwgZmIsIG1vZGUpOwo+ID4gLQo+ID4gLQlmYi0+b2JqWzBdID0g b2JqOwo+ID4gLQo+ID4gLQlyZXQgPSBkcm1fZnJhbWVidWZmZXJfaW5pdChkZXYsIGZiLCAmbXRr X2RybV9mYl9mdW5jcyk7Cj4gPiAtCWlmIChyZXQpIHsKPiA+IC0JCURSTV9FUlJPUigiZmFpbGVk IHRvIGluaXRpYWxpemUgZnJhbWVidWZmZXJcbiIpOwo+ID4gLQkJa2ZyZWUoZmIpOwo+ID4gLQkJ cmV0dXJuIEVSUl9QVFIocmV0KTsKPiA+IC0JfQo+ID4gLQo+ID4gLQlyZXR1cm4gZmI7Cj4gPiAt fQo+ID4gLQo+ID4gLXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKm10a19kcm1fbW9kZV9mYl9jcmVh dGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+IC0JCQkJCSAgICAgICBzdHJ1Y3QgZHJtX2Zp bGUgKmZpbGUsCj4gPiAtCQkJCQkgICAgICAgY29uc3Qgc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIg KmNtZCkKPiA+IC17Cj4gPiAtCWNvbnN0IHN0cnVjdCBkcm1fZm9ybWF0X2luZm8gKmluZm8gPSBk cm1fZ2V0X2Zvcm1hdF9pbmZvKGRldiwgY21kKTsKPiA+IC0Jc3RydWN0IGRybV9mcmFtZWJ1ZmZl ciAqZmI7Cj4gPiAtCXN0cnVjdCBkcm1fZ2VtX29iamVjdCAqZ2VtOwo+ID4gLQl1bnNpZ25lZCBp bnQgd2lkdGggPSBjbWQtPndpZHRoOwo+ID4gLQl1bnNpZ25lZCBpbnQgaGVpZ2h0ID0gY21kLT5o ZWlnaHQ7Cj4gPiAtCXVuc2lnbmVkIGludCBzaXplLCBicHA7Cj4gPiAtCWludCByZXQ7Cj4gPiAt Cj4gPiAtCWlmIChpbmZvLT5udW1fcGxhbmVzICE9IDEpCj4gPiAtCQlyZXR1cm4gRVJSX1BUUigt RUlOVkFMKTsKPiA+IC0KPiA+IC0JZ2VtID0gZHJtX2dlbV9vYmplY3RfbG9va3VwKGZpbGUsIGNt ZC0+aGFuZGxlc1swXSk7Cj4gPiAtCWlmICghZ2VtKQo+ID4gLQkJcmV0dXJuIEVSUl9QVFIoLUVO T0VOVCk7Cj4gPiAtCj4gPiAtCWJwcCA9IGluZm8tPmNwcFswXTsKPiA+IC0Jc2l6ZSA9IChoZWln aHQgLSAxKSAqIGNtZC0+cGl0Y2hlc1swXSArIHdpZHRoICogYnBwOwo+ID4gLQlzaXplICs9IGNt ZC0+b2Zmc2V0c1swXTsKPiA+IC0KPiA+IC0JaWYgKGdlbS0+c2l6ZSA8IHNpemUpIHsKPiA+IC0J CXJldCA9IC1FSU5WQUw7Cj4gPiAtCQlnb3RvIHVucmVmZXJlbmNlOwo+ID4gLQl9Cj4gPiAtCj4g PiAtCWZiID0gbXRrX2RybV9mcmFtZWJ1ZmZlcl9pbml0KGRldiwgY21kLCBnZW0pOwo+ID4gLQlp ZiAoSVNfRVJSKGZiKSkgewo+ID4gLQkJcmV0ID0gUFRSX0VSUihmYik7Cj4gPiAtCQlnb3RvIHVu cmVmZXJlbmNlOwo+ID4gLQl9Cj4gPiAtCj4gPiAtCXJldHVybiBmYjsKPiA+IC0KPiA+IC11bnJl ZmVyZW5jZToKPiA+IC0JZHJtX2dlbV9vYmplY3RfcHV0X3VubG9ja2VkKGdlbSk7Cj4gPiAtCXJl dHVybiBFUlJfUFRSKHJldCk7Cj4gPiAtfQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9tZWRpYXRlay9tdGtfZHJtX2ZiLmggYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2Ry bV9mYi5oCj4gPiBkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKPiA+IGluZGV4IGViNjRkMjYwMDFj Ni4uMDAwMDAwMDAwMDAwCj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2Ry bV9mYi5oCj4gPiArKysgL2Rldi9udWxsCj4gPiBAQCAtMSwxMyArMCwwIEBACj4gPiAtLyogU1BE WC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAtb25seSAqLwo+ID4gLS8qCj4gPiAtICogQ29w eXJpZ2h0IChjKSAyMDE1IE1lZGlhVGVrIEluYy4KPiA+IC0gKi8KPiA+IC0KPiA+IC0jaWZuZGVm IE1US19EUk1fRkJfSAo+ID4gLSNkZWZpbmUgTVRLX0RSTV9GQl9ICj4gPiAtCj4gPiAtc3RydWN0 IGRybV9mcmFtZWJ1ZmZlciAqbXRrX2RybV9tb2RlX2ZiX2NyZWF0ZShzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2LAo+ID4gLQkJCQkJICAgICAgIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSwKPiA+IC0JCQkJ CSAgICAgICBjb25zdCBzdHJ1Y3QgZHJtX21vZGVfZmJfY21kMiAqY21kKTsKPiA+IC0KPiA+IC0j ZW5kaWYgLyogTVRLX0RSTV9GQl9IICovCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L21lZGlhdGVrL210a19kcm1fcGxhbmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtf ZHJtX3BsYW5lLmMKPiA+IGluZGV4IDNiMGNjOTFjNzAyMy4uNTQwZWYyZmFhNDBhIDEwMDY0NAo+ ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fcGxhbmUuYwo+ID4gKysr IGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fcGxhbmUuYwo+ID4gQEAgLTEzLDcg KzEzLDYgQEAKPiA+ICAjaW5jbHVkZSAibXRrX2RybV9jcnRjLmgiCj4gPiAgI2luY2x1ZGUgIm10 a19kcm1fZGRwX2NvbXAuaCIKPiA+ICAjaW5jbHVkZSAibXRrX2RybV9kcnYuaCIKPiA+IC0jaW5j bHVkZSAibXRrX2RybV9mYi5oIgo+ID4gICNpbmNsdWRlICJtdGtfZHJtX2dlbS5oIgo+ID4gICNp bmNsdWRlICJtdGtfZHJtX3BsYW5lLmgiCj4gPiAgCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0 d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46CE6C432C0 for ; Fri, 22 Nov 2019 17:09:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA7DE20714 for ; Fri, 22 Nov 2019 17:09:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA7DE20714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 762FA6E0FF; Fri, 22 Nov 2019 17:09:55 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 951606E0FF for ; Fri, 22 Nov 2019 17:09:53 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id n1so9452676wra.10 for ; Fri, 22 Nov 2019 09:09:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GveeeDV1nQsr0bSwcCCx8Vsl+3Babn6Mlzv1ByhFH+Y=; b=SHAkrCddXzXyzDOYMhdsSGIpC60CyC5hr+SaRIURYVhuazFjm2Y+MUzdc3B0ChwR0A iqL57NK5fImG5S0vm6pp3oPj3W6wxV6+shbk1KoENf8wxssBQi/4aC5Prok4ZRStiTgd +0zD3YwEyVRY5G9z41v1FCoPj/0KzHkj8Ei1mwD9bun9QPe9OASF22UjeqaDQsADrceA CWDdScUM0mHLNbWLpmdFKYhA1a4V1aMGRhu5UNGWJbjSozvBBBmcfCqC6nMRnyw/Cf97 n4XpFgjrCoK6MTujoXenqc+TVFH2yPh7+YV/O+FLpxj2ebXqFYwAjpQgjoDAqR0hjMgR IqTg== X-Gm-Message-State: APjAAAX9CJDc4+F7ifW0y5tsa5/gfSFiMPTSAH5IvGWURtS92abiKd1U iO/eZR0I2Lpin7G5m9x/zLeARA== X-Google-Smtp-Source: APXvYqw21AitnDiR+uQCAQr38tNh94j5CW1Rt6qcwqHjdlzEy/qK8QLOZBeeWzbGVlFlIo1UR84bxw== X-Received: by 2002:a5d:570f:: with SMTP id a15mr18390167wrv.316.1574442592095; Fri, 22 Nov 2019 09:09:52 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id y11sm6590631wrq.12.2019.11.22.09.09.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2019 09:09:51 -0800 (PST) Date: Fri, 22 Nov 2019 18:09:49 +0100 From: Daniel Vetter To: CK Hu Message-ID: <20191122170949.GH6236@phenom.ffwll.local> References: <20191115092120.4445-1-daniel.vetter@ffwll.ch> <20191115092120.4445-4-daniel.vetter@ffwll.ch> <1574408559.21408.2.camel@mtksdaap41> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1574408559.21408.2.camel@mtksdaap41> X-Operating-System: Linux phenom 5.3.0-1-amd64 User-Agent: Mutt/1.12.2 (2019-09-21) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GveeeDV1nQsr0bSwcCCx8Vsl+3Babn6Mlzv1ByhFH+Y=; b=eIBsIiSXvp5sCJ0yKABqoG/j1h+d84G9Zl0HXR0dSvxVhfIscq6daBNS4i0L3j3Fbf duO+xDNv0XJY09AcoqHPk0Ix3qIgPTsZ0UDjULIVZXqDQWkXjSytqrRayjTNAz81gVce goTINcX86DPQxJjU2D2wGD4TGIw4AIpqF/sgU= Subject: Re: [Intel-gfx] [PATCH 3/8] drm/mediatek: don't open-code drm_gem_fb_create X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , DRI Development , linux-mediatek@lists.infradead.org, Philipp Zabel , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191122170949.UdwktLKTJouvgNMcmtgRjr68vLrHftIepDLitH_57CI@z> T24gRnJpLCBOb3YgMjIsIDIwMTkgYXQgMDM6NDI6MzlQTSArMDgwMCwgQ0sgSHUgd3JvdGU6Cj4g SGksIERhbmllbDoKPiAKPiBPbiBGcmksIDIwMTktMTEtMTUgYXQgMTA6MjEgKzAxMDAsIERhbmll bCBWZXR0ZXIgd3JvdGU6Cj4gPiBBc2lkZTogVGhlcmUncyBhIGZldyBvdGhlciBmYl9jcmVhdGUg aW1wbGVtZW50YXRpb25zIHdoaWNoCj4gPiBzaW1wbHkgY2hlY2sgZm9yIHZhbGlkIGJ1ZmZlciBm b3JtYXQgKG9yIGFuIGFwcHJveGltYXRpb24gdGhlcmVvZiksCj4gPiBhbmQgdGhlbiBjYWxsIGRy bV9nZW1fZmJfY3JlYXRlLiBGb3IgYXRvbWljIGRyaXZlcnMgYXQgbGVhc3Qgd2UgY291bGQKPiA+ IHdhbGsgYWxsIHBsYW5lcyBhbmQgbWFrZSBzdXJlIHRoZSBmb3JtYXQvbW9kaWZpZXIgY29tYm8g aXMgdmFsaWQsCj4gPiBhbmQgcmVtb3ZlIGV2ZW4gbW9yZSBjb2RlLgo+ID4gCj4gPiBGb3Igbm9u LWF0b21pYyBkcml2ZXJzIHRoYXQncyBub3QgcG9zc2libGUsIHNpbmNlIHRoZSBmb3JtYXQgbGlz dCBmb3IKPiA+IHRoZSBwcmltYXJ5IGJ1ZmZlciBtaWdodCBiZSBnYXJiYWdlIChhbmQgbW9zdCBs aWtlbHkgaXQgaXMpLgo+ID4gCj4gPiBBbHNvIGRlbGV0ZSBtdGtfZHJtX2ZiLltoY10gc2luY2Ug aXQgd291bGQgbm93IG9ubHkgY29udGFpbiBvbmUKPiA+IGZ1bmN0aW9uLgo+IAo+IEFja2VkLWJ5 OiBDSyBIdSA8Y2suaHVAbWVkaWF0ZWsuY29tPgoKUHVzaGVkIHRvIGRybS1taXNjLW5leHQsIHRo YW5rcyBmb3IgdGFraW5nIGEgbG9vay4KLURhbmllbAoKPiAKPiA+IAo+ID4gU2lnbmVkLW9mZi1i eTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiA+IENjOiBDSyBIdSA8 Y2suaHVAbWVkaWF0ZWsuY29tPgo+ID4gQ2M6IFBoaWxpcHAgWmFiZWwgPHAuemFiZWxAcGVuZ3V0 cm9uaXguZGU+Cj4gPiBDYzogTWF0dGhpYXMgQnJ1Z2dlciA8bWF0dGhpYXMuYmdnQGdtYWlsLmNv bT4KPiA+IENjOiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKPiA+IENjOiBs aW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnCj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dw dS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kcnYuYyAgIHwgMTYgKysrKy0KPiA+ICBkcml2ZXJzL2dw dS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9mYi5jICAgIHwgOTIgLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZmIuaCAgICB8IDEzIC0t LS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9wbGFuZS5jIHwgIDEgLQo+ ID4gIDQgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMTA3IGRlbGV0aW9ucygtKQo+ ID4gIGRlbGV0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9m Yi5jCj4gPiAgZGVsZXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtf ZHJtX2ZiLmgKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9t dGtfZHJtX2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZHJ2LmMKPiA+ IGluZGV4IDg0ZDE0MjEzZDk5Mi4uMmIxYzEyMjA2NmVhIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZHJ2LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9tZWRpYXRlay9tdGtfZHJtX2Rydi5jCj4gPiBAQCAtMTYsOCArMTYsMTAgQEAKPiA+ICAjaW5j bHVkZSA8ZHJtL2RybV9hdG9taWNfaGVscGVyLmg+Cj4gPiAgI2luY2x1ZGUgPGRybS9kcm1fZHJ2 Lmg+Cj4gPiAgI2luY2x1ZGUgPGRybS9kcm1fZmJfaGVscGVyLmg+Cj4gPiArI2luY2x1ZGUgPGRy bS9kcm1fZm91cmNjLmg+Cj4gPiAgI2luY2x1ZGUgPGRybS9kcm1fZ2VtLmg+Cj4gPiAgI2luY2x1 ZGUgPGRybS9kcm1fZ2VtX2NtYV9oZWxwZXIuaD4KPiA+ICsjaW5jbHVkZSA8ZHJtL2RybV9nZW1f ZnJhbWVidWZmZXJfaGVscGVyLmg+Cj4gPiAgI2luY2x1ZGUgPGRybS9kcm1fb2YuaD4KPiA+ICAj aW5jbHVkZSA8ZHJtL2RybV9wcm9iZV9oZWxwZXIuaD4KPiA+ICAjaW5jbHVkZSA8ZHJtL2RybV92 YmxhbmsuaD4KPiA+IEBAIC0yNyw3ICsyOSw2IEBACj4gPiAgI2luY2x1ZGUgIm10a19kcm1fZGRw LmgiCj4gPiAgI2luY2x1ZGUgIm10a19kcm1fZGRwX2NvbXAuaCIKPiA+ICAjaW5jbHVkZSAibXRr X2RybV9kcnYuaCIKPiA+IC0jaW5jbHVkZSAibXRrX2RybV9mYi5oIgo+ID4gICNpbmNsdWRlICJt dGtfZHJtX2dlbS5oIgo+ID4gIAo+ID4gICNkZWZpbmUgRFJJVkVSX05BTUUgIm1lZGlhdGVrIgo+ ID4gQEAgLTExNSw2ICsxMTYsMTkgQEAgc3RhdGljIGludCBtdGtfYXRvbWljX2NvbW1pdChzdHJ1 Y3QgZHJtX2RldmljZSAqZHJtLAo+ID4gIAlyZXR1cm4gMDsKPiA+ICB9Cj4gPiAgCj4gPiArc3Rh dGljIHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKgo+ID4gK210a19kcm1fbW9kZV9mYl9jcmVhdGUo c3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ICsJCSAgICAgICBzdHJ1Y3QgZHJtX2ZpbGUgKmZp bGUsCj4gPiArCQkgICAgICAgY29uc3Qgc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIgKmNtZCkKPiA+ ICt7Cj4gPiArCWNvbnN0IHN0cnVjdCBkcm1fZm9ybWF0X2luZm8gKmluZm8gPSBkcm1fZ2V0X2Zv cm1hdF9pbmZvKGRldiwgY21kKTsKPiA+ICsKPiA+ICsJaWYgKGluZm8tPm51bV9wbGFuZXMgIT0g MSkKPiA+ICsJCXJldHVybiBFUlJfUFRSKC1FSU5WQUwpOwo+ID4gKwo+ID4gKwlyZXR1cm4gZHJt X2dlbV9mYl9jcmVhdGUoZGV2LCBmaWxlLCBjbWQpOwo+ID4gK30KPiA+ICsKPiA+ICBzdGF0aWMg Y29uc3Qgc3RydWN0IGRybV9tb2RlX2NvbmZpZ19mdW5jcyBtdGtfZHJtX21vZGVfY29uZmlnX2Z1 bmNzID0gewo+ID4gIAkuZmJfY3JlYXRlID0gbXRrX2RybV9tb2RlX2ZiX2NyZWF0ZSwKPiA+ICAJ LmF0b21pY19jaGVjayA9IGRybV9hdG9taWNfaGVscGVyX2NoZWNrLAo+ID4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2ZiLmMgYi9kcml2ZXJzL2dwdS9kcm0v bWVkaWF0ZWsvbXRrX2RybV9mYi5jCj4gPiBkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKPiA+IGlu ZGV4IDNmMjMwYTI4YTJkYy4uMDAwMDAwMDAwMDAwCj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v bWVkaWF0ZWsvbXRrX2RybV9mYi5jCj4gPiArKysgL2Rldi9udWxsCj4gPiBAQCAtMSw5MiArMCww IEBACj4gPiAtLy8gU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAtb25seQo+ID4gLS8q Cj4gPiAtICogQ29weXJpZ2h0IChjKSAyMDE1IE1lZGlhVGVrIEluYy4KPiA+IC0gKi8KPiA+IC0K PiA+IC0jaW5jbHVkZSA8bGludXgvZG1hLWJ1Zi5oPgo+ID4gLSNpbmNsdWRlIDxsaW51eC9kbWEt cmVzdi5oPgo+ID4gLQo+ID4gLSNpbmNsdWRlIDxkcm0vZHJtX21vZGVzZXRfaGVscGVyLmg+Cj4g PiAtI2luY2x1ZGUgPGRybS9kcm1fZmJfaGVscGVyLmg+Cj4gPiAtI2luY2x1ZGUgPGRybS9kcm1f Zm91cmNjLmg+Cj4gPiAtI2luY2x1ZGUgPGRybS9kcm1fZ2VtLmg+Cj4gPiAtI2luY2x1ZGUgPGRy bS9kcm1fZ2VtX2ZyYW1lYnVmZmVyX2hlbHBlci5oPgo+ID4gLQo+ID4gLSNpbmNsdWRlICJtdGtf ZHJtX2Rydi5oIgo+ID4gLSNpbmNsdWRlICJtdGtfZHJtX2ZiLmgiCj4gPiAtI2luY2x1ZGUgIm10 a19kcm1fZ2VtLmgiCj4gPiAtCj4gPiAtc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fZnJhbWVidWZm ZXJfZnVuY3MgbXRrX2RybV9mYl9mdW5jcyA9IHsKPiA+IC0JLmNyZWF0ZV9oYW5kbGUgPSBkcm1f Z2VtX2ZiX2NyZWF0ZV9oYW5kbGUsCj4gPiAtCS5kZXN0cm95ID0gZHJtX2dlbV9mYl9kZXN0cm95 LAo+ID4gLX07Cj4gPiAtCj4gPiAtc3RhdGljIHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKm10a19k cm1fZnJhbWVidWZmZXJfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4gLQkJCQkJY29u c3Qgc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIgKm1vZGUsCj4gPiAtCQkJCQlzdHJ1Y3QgZHJtX2dl bV9vYmplY3QgKm9iaikKPiA+IC17Cj4gPiAtCWNvbnN0IHN0cnVjdCBkcm1fZm9ybWF0X2luZm8g KmluZm8gPSBkcm1fZ2V0X2Zvcm1hdF9pbmZvKGRldiwgbW9kZSk7Cj4gPiAtCXN0cnVjdCBkcm1f ZnJhbWVidWZmZXIgKmZiOwo+ID4gLQlpbnQgcmV0Owo+ID4gLQo+ID4gLQlpZiAoaW5mby0+bnVt X3BsYW5lcyAhPSAxKQo+ID4gLQkJcmV0dXJuIEVSUl9QVFIoLUVJTlZBTCk7Cj4gPiAtCj4gPiAt CWZiID0ga3phbGxvYyhzaXplb2YoKmZiKSwgR0ZQX0tFUk5FTCk7Cj4gPiAtCWlmICghZmIpCj4g PiAtCQlyZXR1cm4gRVJSX1BUUigtRU5PTUVNKTsKPiA+IC0KPiA+IC0JZHJtX2hlbHBlcl9tb2Rl X2ZpbGxfZmJfc3RydWN0KGRldiwgZmIsIG1vZGUpOwo+ID4gLQo+ID4gLQlmYi0+b2JqWzBdID0g b2JqOwo+ID4gLQo+ID4gLQlyZXQgPSBkcm1fZnJhbWVidWZmZXJfaW5pdChkZXYsIGZiLCAmbXRr X2RybV9mYl9mdW5jcyk7Cj4gPiAtCWlmIChyZXQpIHsKPiA+IC0JCURSTV9FUlJPUigiZmFpbGVk IHRvIGluaXRpYWxpemUgZnJhbWVidWZmZXJcbiIpOwo+ID4gLQkJa2ZyZWUoZmIpOwo+ID4gLQkJ cmV0dXJuIEVSUl9QVFIocmV0KTsKPiA+IC0JfQo+ID4gLQo+ID4gLQlyZXR1cm4gZmI7Cj4gPiAt fQo+ID4gLQo+ID4gLXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKm10a19kcm1fbW9kZV9mYl9jcmVh dGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+IC0JCQkJCSAgICAgICBzdHJ1Y3QgZHJtX2Zp bGUgKmZpbGUsCj4gPiAtCQkJCQkgICAgICAgY29uc3Qgc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIg KmNtZCkKPiA+IC17Cj4gPiAtCWNvbnN0IHN0cnVjdCBkcm1fZm9ybWF0X2luZm8gKmluZm8gPSBk cm1fZ2V0X2Zvcm1hdF9pbmZvKGRldiwgY21kKTsKPiA+IC0Jc3RydWN0IGRybV9mcmFtZWJ1ZmZl ciAqZmI7Cj4gPiAtCXN0cnVjdCBkcm1fZ2VtX29iamVjdCAqZ2VtOwo+ID4gLQl1bnNpZ25lZCBp bnQgd2lkdGggPSBjbWQtPndpZHRoOwo+ID4gLQl1bnNpZ25lZCBpbnQgaGVpZ2h0ID0gY21kLT5o ZWlnaHQ7Cj4gPiAtCXVuc2lnbmVkIGludCBzaXplLCBicHA7Cj4gPiAtCWludCByZXQ7Cj4gPiAt Cj4gPiAtCWlmIChpbmZvLT5udW1fcGxhbmVzICE9IDEpCj4gPiAtCQlyZXR1cm4gRVJSX1BUUigt RUlOVkFMKTsKPiA+IC0KPiA+IC0JZ2VtID0gZHJtX2dlbV9vYmplY3RfbG9va3VwKGZpbGUsIGNt ZC0+aGFuZGxlc1swXSk7Cj4gPiAtCWlmICghZ2VtKQo+ID4gLQkJcmV0dXJuIEVSUl9QVFIoLUVO T0VOVCk7Cj4gPiAtCj4gPiAtCWJwcCA9IGluZm8tPmNwcFswXTsKPiA+IC0Jc2l6ZSA9IChoZWln aHQgLSAxKSAqIGNtZC0+cGl0Y2hlc1swXSArIHdpZHRoICogYnBwOwo+ID4gLQlzaXplICs9IGNt ZC0+b2Zmc2V0c1swXTsKPiA+IC0KPiA+IC0JaWYgKGdlbS0+c2l6ZSA8IHNpemUpIHsKPiA+IC0J CXJldCA9IC1FSU5WQUw7Cj4gPiAtCQlnb3RvIHVucmVmZXJlbmNlOwo+ID4gLQl9Cj4gPiAtCj4g PiAtCWZiID0gbXRrX2RybV9mcmFtZWJ1ZmZlcl9pbml0KGRldiwgY21kLCBnZW0pOwo+ID4gLQlp ZiAoSVNfRVJSKGZiKSkgewo+ID4gLQkJcmV0ID0gUFRSX0VSUihmYik7Cj4gPiAtCQlnb3RvIHVu cmVmZXJlbmNlOwo+ID4gLQl9Cj4gPiAtCj4gPiAtCXJldHVybiBmYjsKPiA+IC0KPiA+IC11bnJl ZmVyZW5jZToKPiA+IC0JZHJtX2dlbV9vYmplY3RfcHV0X3VubG9ja2VkKGdlbSk7Cj4gPiAtCXJl dHVybiBFUlJfUFRSKHJldCk7Cj4gPiAtfQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9tZWRpYXRlay9tdGtfZHJtX2ZiLmggYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2Ry bV9mYi5oCj4gPiBkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKPiA+IGluZGV4IGViNjRkMjYwMDFj Ni4uMDAwMDAwMDAwMDAwCj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2Ry bV9mYi5oCj4gPiArKysgL2Rldi9udWxsCj4gPiBAQCAtMSwxMyArMCwwIEBACj4gPiAtLyogU1BE WC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAtb25seSAqLwo+ID4gLS8qCj4gPiAtICogQ29w eXJpZ2h0IChjKSAyMDE1IE1lZGlhVGVrIEluYy4KPiA+IC0gKi8KPiA+IC0KPiA+IC0jaWZuZGVm IE1US19EUk1fRkJfSAo+ID4gLSNkZWZpbmUgTVRLX0RSTV9GQl9ICj4gPiAtCj4gPiAtc3RydWN0 IGRybV9mcmFtZWJ1ZmZlciAqbXRrX2RybV9tb2RlX2ZiX2NyZWF0ZShzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2LAo+ID4gLQkJCQkJICAgICAgIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSwKPiA+IC0JCQkJ CSAgICAgICBjb25zdCBzdHJ1Y3QgZHJtX21vZGVfZmJfY21kMiAqY21kKTsKPiA+IC0KPiA+IC0j ZW5kaWYgLyogTVRLX0RSTV9GQl9IICovCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L21lZGlhdGVrL210a19kcm1fcGxhbmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtf ZHJtX3BsYW5lLmMKPiA+IGluZGV4IDNiMGNjOTFjNzAyMy4uNTQwZWYyZmFhNDBhIDEwMDY0NAo+ ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fcGxhbmUuYwo+ID4gKysr IGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fcGxhbmUuYwo+ID4gQEAgLTEzLDcg KzEzLDYgQEAKPiA+ICAjaW5jbHVkZSAibXRrX2RybV9jcnRjLmgiCj4gPiAgI2luY2x1ZGUgIm10 a19kcm1fZGRwX2NvbXAuaCIKPiA+ICAjaW5jbHVkZSAibXRrX2RybV9kcnYuaCIKPiA+IC0jaW5j bHVkZSAibXRrX2RybV9mYi5oIgo+ID4gICNpbmNsdWRlICJtdGtfZHJtX2dlbS5oIgo+ID4gICNp bmNsdWRlICJtdGtfZHJtX3BsYW5lLmgiCj4gPiAgCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0 d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4