* [linux-next:master 13276/13503] drivers/net/dsa/ocelot/felix.c:351:6: sparse: sparse: symbol 'felix_txtstamp' was not declared. Should it be static?
@ 2019-11-22 22:50 ` kbuild test robot
0 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2019-11-22 22:50 UTC (permalink / raw)
To: Yangbo Lu
Cc: kbuild-all, Vladimir Oltean, Claudiu Manoil, Andrew Lunn,
Vivien Didelot, Florian Fainelli, netdev, linux-kernel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: b9d3d01405061bb42358fe53f824e894a1922ced
commit: c0bcf537667cf88bbcbb377d01d2b79c45265741 [13276/13503] net: dsa: ocelot: add hardware timestamping support for Felix
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-32-g233d4e1-dirty
git checkout c0bcf537667cf88bbcbb377d01d2b79c45265741
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/net/dsa/ocelot/felix.c:351:6: sparse: sparse: symbol 'felix_txtstamp' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
^ permalink raw reply [flat|nested] 4+ messages in thread
* [linux-next:master 13276/13503] drivers/net/dsa/ocelot/felix.c:351:6: sparse: sparse: symbol 'felix_txtstamp' was not declared. Should it be static?
@ 2019-11-22 22:50 ` kbuild test robot
0 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2019-11-22 22:50 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: b9d3d01405061bb42358fe53f824e894a1922ced
commit: c0bcf537667cf88bbcbb377d01d2b79c45265741 [13276/13503] net: dsa: ocelot: add hardware timestamping support for Felix
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-32-g233d4e1-dirty
git checkout c0bcf537667cf88bbcbb377d01d2b79c45265741
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/net/dsa/ocelot/felix.c:351:6: sparse: sparse: symbol 'felix_txtstamp' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
^ permalink raw reply [flat|nested] 4+ messages in thread
* [RFC PATCH linux-next] net: dsa: ocelot: felix_txtstamp() can be static
2019-11-22 22:50 ` kbuild test robot
@ 2019-11-22 22:50 ` kbuild test robot
-1 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2019-11-22 22:50 UTC (permalink / raw)
To: Yangbo Lu
Cc: kbuild-all, Vladimir Oltean, Claudiu Manoil, Andrew Lunn,
Vivien Didelot, Florian Fainelli, netdev, linux-kernel
Fixes: c0bcf537667c ("net: dsa: ocelot: add hardware timestamping support for Felix")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
felix.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c
index 167e41549cdd1..b7f92464815d7 100644
--- a/drivers/net/dsa/ocelot/felix.c
+++ b/drivers/net/dsa/ocelot/felix.c
@@ -348,8 +348,8 @@ static bool felix_rxtstamp(struct dsa_switch *ds, int port,
return false;
}
-bool felix_txtstamp(struct dsa_switch *ds, int port,
- struct sk_buff *clone, unsigned int type)
+static bool felix_txtstamp(struct dsa_switch *ds, int port,
+ struct sk_buff *clone, unsigned int type)
{
struct ocelot *ocelot = ds->priv;
struct ocelot_port *ocelot_port = ocelot->ports[port];
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [RFC PATCH linux-next] net: dsa: ocelot: felix_txtstamp() can be static
@ 2019-11-22 22:50 ` kbuild test robot
0 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2019-11-22 22:50 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 834 bytes --]
Fixes: c0bcf537667c ("net: dsa: ocelot: add hardware timestamping support for Felix")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
felix.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c
index 167e41549cdd1..b7f92464815d7 100644
--- a/drivers/net/dsa/ocelot/felix.c
+++ b/drivers/net/dsa/ocelot/felix.c
@@ -348,8 +348,8 @@ static bool felix_rxtstamp(struct dsa_switch *ds, int port,
return false;
}
-bool felix_txtstamp(struct dsa_switch *ds, int port,
- struct sk_buff *clone, unsigned int type)
+static bool felix_txtstamp(struct dsa_switch *ds, int port,
+ struct sk_buff *clone, unsigned int type)
{
struct ocelot *ocelot = ds->priv;
struct ocelot_port *ocelot_port = ocelot->ports[port];
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-22 22:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-22 22:50 [linux-next:master 13276/13503] drivers/net/dsa/ocelot/felix.c:351:6: sparse: sparse: symbol 'felix_txtstamp' was not declared. Should it be static? kbuild test robot
2019-11-22 22:50 ` kbuild test robot
2019-11-22 22:50 ` [RFC PATCH linux-next] net: dsa: ocelot: felix_txtstamp() can be static kbuild test robot
2019-11-22 22:50 ` kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.