From: Phong Tran <tranmanphong@gmail.com>
To: davem@davemloft.net, keescook@chromium.org
Cc: kvalo@codeaurora.org, saeedm@mellanox.com,
jeffrey.t.kirsher@intel.com, luciano.coelho@intel.com,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Phong Tran <tranmanphong@gmail.com>
Subject: [PATCH 2/5] drivers: net: usbnet: Fix -Wcast-function-type
Date: Sun, 24 Nov 2019 16:43:03 +0700 [thread overview]
Message-ID: <20191124094306.21297-3-tranmanphong@gmail.com> (raw)
In-Reply-To: <20191124094306.21297-1-tranmanphong@gmail.com>
correct usage prototype of callback in tasklet_init().
Report by https://github.com/KSPP/linux/issues/20
Signed-off-by: Phong Tran <tranmanphong@gmail.com>
---
drivers/net/usb/usbnet.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index dde05e2fdc3e..d10a5e6d0917 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1573,6 +1573,12 @@ static void usbnet_bh (struct timer_list *t)
}
}
+static void usbnet_bh_tasklet (unsigned long data)
+{
+ struct timer_list *t = (struct timer_list *)data;
+ usbnet_bh(t);
+}
+
/*-------------------------------------------------------------------------
*
@@ -1700,7 +1706,7 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
skb_queue_head_init (&dev->txq);
skb_queue_head_init (&dev->done);
skb_queue_head_init(&dev->rxq_pause);
- dev->bh.func = (void (*)(unsigned long))usbnet_bh;
+ dev->bh.func = usbnet_bh_tasklet;
dev->bh.data = (unsigned long)&dev->delay;
INIT_WORK (&dev->kevent, usbnet_deferred_kevent);
init_usb_anchor(&dev->deferred);
--
2.20.1
next prev parent reply other threads:[~2019-11-24 9:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-24 9:43 [PATCH 0/5] Fix -Wcast-function-type net drivers Phong Tran
2019-11-24 9:43 ` [PATCH 1/5] drivers: net: hso: Fix -Wcast-function-type Phong Tran
2019-11-24 9:43 ` Phong Tran [this message]
2019-11-24 9:43 ` [PATCH 3/5] drivers: net: b43legacy: " Phong Tran
2019-11-25 18:30 ` Larry Finger
2019-11-24 9:43 ` [PATCH 4/5] drivers: net: intel: " Phong Tran
2019-11-24 9:43 ` [PATCH 5/5] drivers: net: realtek: " Phong Tran
2019-11-24 22:39 ` [PATCH 0/5] Fix -Wcast-function-type net drivers Jakub Kicinski
2019-11-25 15:06 ` Phong Tran
2019-11-25 17:04 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191124094306.21297-3-tranmanphong@gmail.com \
--to=tranmanphong@gmail.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=keescook@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.