From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2891C432C0 for ; Sun, 24 Nov 2019 17:30:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7428F207FC for ; Sun, 24 Nov 2019 17:30:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BNXw7SGy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727028AbfKXRaM (ORCPT ); Sun, 24 Nov 2019 12:30:12 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:43334 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726931AbfKXRaK (ORCPT ); Sun, 24 Nov 2019 12:30:10 -0500 Received: by mail-wr1-f66.google.com with SMTP id n1so14657060wra.10; Sun, 24 Nov 2019 09:30:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kBIOZ347etSnW61gnUIaBM64Cedw0cl5jNO3eKEASaI=; b=BNXw7SGybu8K/BnOo/JmbYr3H+qeKULqXTZlFkPQeXtapTFXumcRzWWa5szX8gIRPp l7uDSFr5mU//Kl4U1JBwkwBjsK02e0mNwuLEk2pVhO40nb5ajspahtr7bqep6axQwhEi gzxBVD9Ec9ZOrVxntjnXGO7qAhgNPSeB/sxaiJrNudcMIFeRvMfLGrgl+Mu2kNQDOACB ArL/wo5SGjbWfA6sc7bDNvXpx20xYDg4U2ml/G8QWLADeK20UgsMFIgpjrtSRLj/J/oI yBW3k8s/2isjfXEOwqii/tWcnLSqOJBKgs2pQxGy6weYm6URBoVaUUFzdnry/7ToZdGL 9vIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kBIOZ347etSnW61gnUIaBM64Cedw0cl5jNO3eKEASaI=; b=gvgAT1mYA1o2Mf3R3fom18ReMKHpyb4nxHPg2q5eKm35lPIxYNmuMW/E1l0+53uBDf jpIm+qwpaedmQTkF/Ic7H8kEzpRDm9vEkIbMKf6Di0ryH6GxCluzPDKeC0zOIEbdDvOz yWq7PcJ77ORPGKE+7Rdr2fnqvj8ni22r/4XrqnI1AtrcS5mMLsEoDY694angJj7tSIaS IC1zk4ViFAKcpKvIWtWQfkRqlKic/L/7MB/8uoWITCXguqYGW+h/MMMqbcXVhGLbb+2f MmNInzg1/srDvfhkvcSkE1aPfyThGqTcee+4ntv5FZI36iFk90ofuCpkJ32EqojgTTJH MXtg== X-Gm-Message-State: APjAAAXWt5LVJcuGSVysbHEG+8IzRl0ZAjWsoHoyMBLzkwgnfENpRhGF W1tB+gYLUXjphLOHIJTQFOw= X-Google-Smtp-Source: APXvYqzn2w6E+vLemwZDNa1gBjr8f2SWkG2H6wnWdo2EcpqrquGJr5ycgzX0pUhtms7s/GZ6Vx7wGg== X-Received: by 2002:a5d:55c5:: with SMTP id i5mr29179656wrw.385.1574616607934; Sun, 24 Nov 2019 09:30:07 -0800 (PST) Received: from localhost.localdomain ([2a01:e0a:1f1:d0f0::4e2b:d7ca]) by smtp.gmail.com with ESMTPSA id n13sm5537275wmi.25.2019.11.24.09.30.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Nov 2019 09:30:07 -0800 (PST) From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= To: Thierry Reding , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Maxime Ripard , Chen-Yu Tsai , Philipp Zabel Cc: linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= Subject: [PATCH v9 4/6] pwm: sun4i: Always calculate params when applying new parameters Date: Sun, 24 Nov 2019 18:29:06 +0100 Message-Id: <20191124172908.10804-5-peron.clem@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191124172908.10804-1-peron.clem@gmail.com> References: <20191124172908.10804-1-peron.clem@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bypass mode will require to be re-calculated when the pwm state is changed. Remove the condition so pwm_sun4i_calculate is always called. Reviewed-by: Uwe Kleine-König Signed-off-by: Clément Péron --- drivers/pwm/pwm-sun4i.c | 52 ++++++++++++++++++----------------------- 1 file changed, 23 insertions(+), 29 deletions(-) diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c index a6727dd89e28..e369b5a398f4 100644 --- a/drivers/pwm/pwm-sun4i.c +++ b/drivers/pwm/pwm-sun4i.c @@ -202,9 +202,9 @@ static int sun4i_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, { struct sun4i_pwm_chip *sun4i_pwm = to_sun4i_pwm_chip(chip); struct pwm_state cstate; - u32 ctrl; + u32 ctrl, duty, period, val; int ret; - unsigned int delay_us; + unsigned int delay_us, prescaler; unsigned long now; pwm_get_state(pwm, &cstate); @@ -220,43 +220,37 @@ static int sun4i_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, spin_lock(&sun4i_pwm->ctrl_lock); ctrl = sun4i_pwm_readl(sun4i_pwm, PWM_CTRL_REG); - if ((cstate.period != state->period) || - (cstate.duty_cycle != state->duty_cycle)) { - u32 period, duty, val; - unsigned int prescaler; - - ret = sun4i_pwm_calculate(sun4i_pwm, state, - &duty, &period, &prescaler); - if (ret) { - dev_err(chip->dev, "period exceeds the maximum value\n"); - spin_unlock(&sun4i_pwm->ctrl_lock); - if (!cstate.enabled) - clk_disable_unprepare(sun4i_pwm->clk); - return ret; - } - - if (PWM_REG_PRESCAL(ctrl, pwm->hwpwm) != prescaler) { - /* Prescaler changed, the clock has to be gated */ - ctrl &= ~BIT_CH(PWM_CLK_GATING, pwm->hwpwm); - sun4i_pwm_writel(sun4i_pwm, ctrl, PWM_CTRL_REG); + ret = sun4i_pwm_calculate(sun4i_pwm, state, &duty, &period, &prescaler); + if (ret) { + dev_err(chip->dev, "period exceeds the maximum value\n"); + spin_unlock(&sun4i_pwm->ctrl_lock); + if (!cstate.enabled) + clk_disable_unprepare(sun4i_pwm->clk); + return ret; + } - ctrl &= ~BIT_CH(PWM_PRESCAL_MASK, pwm->hwpwm); - ctrl |= BIT_CH(prescaler, pwm->hwpwm); - } + if (PWM_REG_PRESCAL(ctrl, pwm->hwpwm) != prescaler) { + /* Prescaler changed, the clock has to be gated */ + ctrl &= ~BIT_CH(PWM_CLK_GATING, pwm->hwpwm); + sun4i_pwm_writel(sun4i_pwm, ctrl, PWM_CTRL_REG); - val = (duty & PWM_DTY_MASK) | PWM_PRD(period); - sun4i_pwm_writel(sun4i_pwm, val, PWM_CH_PRD(pwm->hwpwm)); - sun4i_pwm->next_period[pwm->hwpwm] = jiffies + - usecs_to_jiffies(cstate.period / 1000 + 1); - sun4i_pwm->needs_delay[pwm->hwpwm] = true; + ctrl &= ~BIT_CH(PWM_PRESCAL_MASK, pwm->hwpwm); + ctrl |= BIT_CH(prescaler, pwm->hwpwm); } + val = (duty & PWM_DTY_MASK) | PWM_PRD(period); + sun4i_pwm_writel(sun4i_pwm, val, PWM_CH_PRD(pwm->hwpwm)); + sun4i_pwm->next_period[pwm->hwpwm] = jiffies + + usecs_to_jiffies(cstate.period / 1000 + 1); + sun4i_pwm->needs_delay[pwm->hwpwm] = true; + if (state->polarity != PWM_POLARITY_NORMAL) ctrl &= ~BIT_CH(PWM_ACT_STATE, pwm->hwpwm); else ctrl |= BIT_CH(PWM_ACT_STATE, pwm->hwpwm); ctrl |= BIT_CH(PWM_CLK_GATING, pwm->hwpwm); + if (state->enabled) { ctrl |= BIT_CH(PWM_EN, pwm->hwpwm); } else if (!sun4i_pwm->needs_delay[pwm->hwpwm]) { -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= Subject: [PATCH v9 4/6] pwm: sun4i: Always calculate params when applying new parameters Date: Sun, 24 Nov 2019 18:29:06 +0100 Message-ID: <20191124172908.10804-5-peron.clem@gmail.com> References: <20191124172908.10804-1-peron.clem@gmail.com> Reply-To: peron.clem-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20191124172908.10804-1-peron.clem-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Thierry Reding , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Maxime Ripard , Chen-Yu Tsai , Philipp Zabel Cc: linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= List-Id: linux-pwm@vger.kernel.org Bypass mode will require to be re-calculated when the pwm state is changed. Remove the condition so pwm_sun4i_calculate is always called. Reviewed-by: Uwe Kleine-K=C3=B6nig Signed-off-by: Cl=C3=A9ment P=C3=A9ron --- drivers/pwm/pwm-sun4i.c | 52 ++++++++++++++++++----------------------- 1 file changed, 23 insertions(+), 29 deletions(-) diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c index a6727dd89e28..e369b5a398f4 100644 --- a/drivers/pwm/pwm-sun4i.c +++ b/drivers/pwm/pwm-sun4i.c @@ -202,9 +202,9 @@ static int sun4i_pwm_apply(struct pwm_chip *chip, struc= t pwm_device *pwm, { struct sun4i_pwm_chip *sun4i_pwm =3D to_sun4i_pwm_chip(chip); struct pwm_state cstate; - u32 ctrl; + u32 ctrl, duty, period, val; int ret; - unsigned int delay_us; + unsigned int delay_us, prescaler; unsigned long now; =20 pwm_get_state(pwm, &cstate); @@ -220,43 +220,37 @@ static int sun4i_pwm_apply(struct pwm_chip *chip, str= uct pwm_device *pwm, spin_lock(&sun4i_pwm->ctrl_lock); ctrl =3D sun4i_pwm_readl(sun4i_pwm, PWM_CTRL_REG); =20 - if ((cstate.period !=3D state->period) || - (cstate.duty_cycle !=3D state->duty_cycle)) { - u32 period, duty, val; - unsigned int prescaler; - - ret =3D sun4i_pwm_calculate(sun4i_pwm, state, - &duty, &period, &prescaler); - if (ret) { - dev_err(chip->dev, "period exceeds the maximum value\n"); - spin_unlock(&sun4i_pwm->ctrl_lock); - if (!cstate.enabled) - clk_disable_unprepare(sun4i_pwm->clk); - return ret; - } - - if (PWM_REG_PRESCAL(ctrl, pwm->hwpwm) !=3D prescaler) { - /* Prescaler changed, the clock has to be gated */ - ctrl &=3D ~BIT_CH(PWM_CLK_GATING, pwm->hwpwm); - sun4i_pwm_writel(sun4i_pwm, ctrl, PWM_CTRL_REG); + ret =3D sun4i_pwm_calculate(sun4i_pwm, state, &duty, &period, &prescaler)= ; + if (ret) { + dev_err(chip->dev, "period exceeds the maximum value\n"); + spin_unlock(&sun4i_pwm->ctrl_lock); + if (!cstate.enabled) + clk_disable_unprepare(sun4i_pwm->clk); + return ret; + } =20 - ctrl &=3D ~BIT_CH(PWM_PRESCAL_MASK, pwm->hwpwm); - ctrl |=3D BIT_CH(prescaler, pwm->hwpwm); - } + if (PWM_REG_PRESCAL(ctrl, pwm->hwpwm) !=3D prescaler) { + /* Prescaler changed, the clock has to be gated */ + ctrl &=3D ~BIT_CH(PWM_CLK_GATING, pwm->hwpwm); + sun4i_pwm_writel(sun4i_pwm, ctrl, PWM_CTRL_REG); =20 - val =3D (duty & PWM_DTY_MASK) | PWM_PRD(period); - sun4i_pwm_writel(sun4i_pwm, val, PWM_CH_PRD(pwm->hwpwm)); - sun4i_pwm->next_period[pwm->hwpwm] =3D jiffies + - usecs_to_jiffies(cstate.period / 1000 + 1); - sun4i_pwm->needs_delay[pwm->hwpwm] =3D true; + ctrl &=3D ~BIT_CH(PWM_PRESCAL_MASK, pwm->hwpwm); + ctrl |=3D BIT_CH(prescaler, pwm->hwpwm); } =20 + val =3D (duty & PWM_DTY_MASK) | PWM_PRD(period); + sun4i_pwm_writel(sun4i_pwm, val, PWM_CH_PRD(pwm->hwpwm)); + sun4i_pwm->next_period[pwm->hwpwm] =3D jiffies + + usecs_to_jiffies(cstate.period / 1000 + 1); + sun4i_pwm->needs_delay[pwm->hwpwm] =3D true; + if (state->polarity !=3D PWM_POLARITY_NORMAL) ctrl &=3D ~BIT_CH(PWM_ACT_STATE, pwm->hwpwm); else ctrl |=3D BIT_CH(PWM_ACT_STATE, pwm->hwpwm); =20 ctrl |=3D BIT_CH(PWM_CLK_GATING, pwm->hwpwm); + if (state->enabled) { ctrl |=3D BIT_CH(PWM_EN, pwm->hwpwm); } else if (!sun4i_pwm->needs_delay[pwm->hwpwm]) { --=20 2.20.1 --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org To view this discussion on the web, visit https://groups.google.com/d/msgid= /linux-sunxi/20191124172908.10804-5-peron.clem%40gmail.com. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0C4DC432C0 for ; Sun, 24 Nov 2019 17:31:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D139207FC for ; Sun, 24 Nov 2019 17:31:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="d+OtIBVG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BNXw7SGy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D139207FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=egR5Yx8Fbs8Uu3yzupVg+B9GYpknZZeRpmLzBRsVYqk=; b=d+OtIBVGYJjS0H nH30sg+t2ngk4hN9Kz0RLNywjMDSC5EFwE0q82aLPQ9OTWiiJBn1l6qA+qDUiP1YRzib0lerWF9Vu ukOm9nNHksF6t5ECa2I2rZ0w7OBnxio31WfA6WZ8saQWXSRvU/OKdpKiD5PXFmjRSjOufCFdom4Pe l2snxXkCkdl2smS598lQdt+9xI52Axhws/d0UPmjszgCUkpy2mBe2RvWhrUcoVxxx54WSu/TyBc8J YRc8RhwRw3G8zQA0CaSS33L+4iQovHHe8BiNfDcJj2wFc4yxQ2L2wXS5TTc65G4i7JZT1EAFopKbU 5Q31BqLqy0wMfuWR0faQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iYvix-0006eo-Ef; Sun, 24 Nov 2019 17:31:03 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iYvi5-0005Gs-U4 for linux-arm-kernel@lists.infradead.org; Sun, 24 Nov 2019 17:30:11 +0000 Received: by mail-wr1-x442.google.com with SMTP id t2so14726309wrr.1 for ; Sun, 24 Nov 2019 09:30:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kBIOZ347etSnW61gnUIaBM64Cedw0cl5jNO3eKEASaI=; b=BNXw7SGybu8K/BnOo/JmbYr3H+qeKULqXTZlFkPQeXtapTFXumcRzWWa5szX8gIRPp l7uDSFr5mU//Kl4U1JBwkwBjsK02e0mNwuLEk2pVhO40nb5ajspahtr7bqep6axQwhEi gzxBVD9Ec9ZOrVxntjnXGO7qAhgNPSeB/sxaiJrNudcMIFeRvMfLGrgl+Mu2kNQDOACB ArL/wo5SGjbWfA6sc7bDNvXpx20xYDg4U2ml/G8QWLADeK20UgsMFIgpjrtSRLj/J/oI yBW3k8s/2isjfXEOwqii/tWcnLSqOJBKgs2pQxGy6weYm6URBoVaUUFzdnry/7ToZdGL 9vIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kBIOZ347etSnW61gnUIaBM64Cedw0cl5jNO3eKEASaI=; b=j9E/umAaK5zpwsMkuEP3mmpuFchQyURGEg+ZP/bwtNgp2T/czQZ5PqFMQS7zNxMPTh Di6zSvvxGBmE00yBTNj4DlFkBLixMhA69iHeLDGOmk2eQRB/LArD48vH1o6hWKKowIXc E+zRq0iTH3yLgF4JH0z4I7/HJSV6/e8f4/z8wePZes73v8iVTDqL+SSz6aZ8H+lkorYm C+Rz29m36kjL+IQ+OrscSvvpggLZu5snHC0xCHSL4gJhyF3kt1YmdX++ni+HTtbc1tTf f4W4tLI3gSI+BvaFm9XRGdQHctEZVV9gmYpQDIo0qEGJMj5SCoK4cMoTnGJSXKg9/hDr mckQ== X-Gm-Message-State: APjAAAUVHxR0tWSC6hKL/2q25KzhWhQ77GlbrOOHIC7XckF0mn3q1Qf5 8HKWVYFrBqupHPi3jReq6yU= X-Google-Smtp-Source: APXvYqzn2w6E+vLemwZDNa1gBjr8f2SWkG2H6wnWdo2EcpqrquGJr5ycgzX0pUhtms7s/GZ6Vx7wGg== X-Received: by 2002:a5d:55c5:: with SMTP id i5mr29179656wrw.385.1574616607934; Sun, 24 Nov 2019 09:30:07 -0800 (PST) Received: from localhost.localdomain ([2a01:e0a:1f1:d0f0::4e2b:d7ca]) by smtp.gmail.com with ESMTPSA id n13sm5537275wmi.25.2019.11.24.09.30.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Nov 2019 09:30:07 -0800 (PST) From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= To: Thierry Reding , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Maxime Ripard , Chen-Yu Tsai , Philipp Zabel Subject: [PATCH v9 4/6] pwm: sun4i: Always calculate params when applying new parameters Date: Sun, 24 Nov 2019 18:29:06 +0100 Message-Id: <20191124172908.10804-5-peron.clem@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191124172908.10804-1-peron.clem@gmail.com> References: <20191124172908.10804-1-peron.clem@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191124_093010_176135_02AF70FA X-CRM114-Status: GOOD ( 15.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, linux-sunxi@googlegroups.com, =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org QnlwYXNzIG1vZGUgd2lsbCByZXF1aXJlIHRvIGJlIHJlLWNhbGN1bGF0ZWQgd2hlbiB0aGUgcHdt IHN0YXRlCmlzIGNoYW5nZWQuCgpSZW1vdmUgdGhlIGNvbmRpdGlvbiBzbyBwd21fc3VuNGlfY2Fs Y3VsYXRlIGlzIGFsd2F5cyBjYWxsZWQuCgpSZXZpZXdlZC1ieTogVXdlIEtsZWluZS1Lw7ZuaWcg PHUua2xlaW5lLWtvZW5pZ0BwZW5ndXRyb25peC5kZT4KU2lnbmVkLW9mZi1ieTogQ2zDqW1lbnQg UMOpcm9uIDxwZXJvbi5jbGVtQGdtYWlsLmNvbT4KLS0tCiBkcml2ZXJzL3B3bS9wd20tc3VuNGku YyB8IDUyICsrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUg Y2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgMjkgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv ZHJpdmVycy9wd20vcHdtLXN1bjRpLmMgYi9kcml2ZXJzL3B3bS9wd20tc3VuNGkuYwppbmRleCBh NjcyN2RkODllMjguLmUzNjliNWEzOThmNCAxMDA2NDQKLS0tIGEvZHJpdmVycy9wd20vcHdtLXN1 bjRpLmMKKysrIGIvZHJpdmVycy9wd20vcHdtLXN1bjRpLmMKQEAgLTIwMiw5ICsyMDIsOSBAQCBz dGF0aWMgaW50IHN1bjRpX3B3bV9hcHBseShzdHJ1Y3QgcHdtX2NoaXAgKmNoaXAsIHN0cnVjdCBw d21fZGV2aWNlICpwd20sCiB7CiAJc3RydWN0IHN1bjRpX3B3bV9jaGlwICpzdW40aV9wd20gPSB0 b19zdW40aV9wd21fY2hpcChjaGlwKTsKIAlzdHJ1Y3QgcHdtX3N0YXRlIGNzdGF0ZTsKLQl1MzIg Y3RybDsKKwl1MzIgY3RybCwgZHV0eSwgcGVyaW9kLCB2YWw7CiAJaW50IHJldDsKLQl1bnNpZ25l ZCBpbnQgZGVsYXlfdXM7CisJdW5zaWduZWQgaW50IGRlbGF5X3VzLCBwcmVzY2FsZXI7CiAJdW5z aWduZWQgbG9uZyBub3c7CiAKIAlwd21fZ2V0X3N0YXRlKHB3bSwgJmNzdGF0ZSk7CkBAIC0yMjAs NDMgKzIyMCwzNyBAQCBzdGF0aWMgaW50IHN1bjRpX3B3bV9hcHBseShzdHJ1Y3QgcHdtX2NoaXAg KmNoaXAsIHN0cnVjdCBwd21fZGV2aWNlICpwd20sCiAJc3Bpbl9sb2NrKCZzdW40aV9wd20tPmN0 cmxfbG9jayk7CiAJY3RybCA9IHN1bjRpX3B3bV9yZWFkbChzdW40aV9wd20sIFBXTV9DVFJMX1JF Ryk7CiAKLQlpZiAoKGNzdGF0ZS5wZXJpb2QgIT0gc3RhdGUtPnBlcmlvZCkgfHwKLQkgICAgKGNz dGF0ZS5kdXR5X2N5Y2xlICE9IHN0YXRlLT5kdXR5X2N5Y2xlKSkgewotCQl1MzIgcGVyaW9kLCBk dXR5LCB2YWw7Ci0JCXVuc2lnbmVkIGludCBwcmVzY2FsZXI7Ci0KLQkJcmV0ID0gc3VuNGlfcHdt X2NhbGN1bGF0ZShzdW40aV9wd20sIHN0YXRlLAotCQkJCQkgICZkdXR5LCAmcGVyaW9kLCAmcHJl c2NhbGVyKTsKLQkJaWYgKHJldCkgewotCQkJZGV2X2VycihjaGlwLT5kZXYsICJwZXJpb2QgZXhj ZWVkcyB0aGUgbWF4aW11bSB2YWx1ZVxuIik7Ci0JCQlzcGluX3VubG9jaygmc3VuNGlfcHdtLT5j dHJsX2xvY2spOwotCQkJaWYgKCFjc3RhdGUuZW5hYmxlZCkKLQkJCQljbGtfZGlzYWJsZV91bnBy ZXBhcmUoc3VuNGlfcHdtLT5jbGspOwotCQkJcmV0dXJuIHJldDsKLQkJfQotCi0JCWlmIChQV01f UkVHX1BSRVNDQUwoY3RybCwgcHdtLT5od3B3bSkgIT0gcHJlc2NhbGVyKSB7Ci0JCQkvKiBQcmVz Y2FsZXIgY2hhbmdlZCwgdGhlIGNsb2NrIGhhcyB0byBiZSBnYXRlZCAqLwotCQkJY3RybCAmPSB+ QklUX0NIKFBXTV9DTEtfR0FUSU5HLCBwd20tPmh3cHdtKTsKLQkJCXN1bjRpX3B3bV93cml0ZWwo c3VuNGlfcHdtLCBjdHJsLCBQV01fQ1RSTF9SRUcpOworCXJldCA9IHN1bjRpX3B3bV9jYWxjdWxh dGUoc3VuNGlfcHdtLCBzdGF0ZSwgJmR1dHksICZwZXJpb2QsICZwcmVzY2FsZXIpOworCWlmIChy ZXQpIHsKKwkJZGV2X2VycihjaGlwLT5kZXYsICJwZXJpb2QgZXhjZWVkcyB0aGUgbWF4aW11bSB2 YWx1ZVxuIik7CisJCXNwaW5fdW5sb2NrKCZzdW40aV9wd20tPmN0cmxfbG9jayk7CisJCWlmICgh Y3N0YXRlLmVuYWJsZWQpCisJCQljbGtfZGlzYWJsZV91bnByZXBhcmUoc3VuNGlfcHdtLT5jbGsp OworCQlyZXR1cm4gcmV0OworCX0KIAotCQkJY3RybCAmPSB+QklUX0NIKFBXTV9QUkVTQ0FMX01B U0ssIHB3bS0+aHdwd20pOwotCQkJY3RybCB8PSBCSVRfQ0gocHJlc2NhbGVyLCBwd20tPmh3cHdt KTsKLQkJfQorCWlmIChQV01fUkVHX1BSRVNDQUwoY3RybCwgcHdtLT5od3B3bSkgIT0gcHJlc2Nh bGVyKSB7CisJCS8qIFByZXNjYWxlciBjaGFuZ2VkLCB0aGUgY2xvY2sgaGFzIHRvIGJlIGdhdGVk ICovCisJCWN0cmwgJj0gfkJJVF9DSChQV01fQ0xLX0dBVElORywgcHdtLT5od3B3bSk7CisJCXN1 bjRpX3B3bV93cml0ZWwoc3VuNGlfcHdtLCBjdHJsLCBQV01fQ1RSTF9SRUcpOwogCi0JCXZhbCA9 IChkdXR5ICYgUFdNX0RUWV9NQVNLKSB8IFBXTV9QUkQocGVyaW9kKTsKLQkJc3VuNGlfcHdtX3dy aXRlbChzdW40aV9wd20sIHZhbCwgUFdNX0NIX1BSRChwd20tPmh3cHdtKSk7Ci0JCXN1bjRpX3B3 bS0+bmV4dF9wZXJpb2RbcHdtLT5od3B3bV0gPSBqaWZmaWVzICsKLQkJCXVzZWNzX3RvX2ppZmZp ZXMoY3N0YXRlLnBlcmlvZCAvIDEwMDAgKyAxKTsKLQkJc3VuNGlfcHdtLT5uZWVkc19kZWxheVtw d20tPmh3cHdtXSA9IHRydWU7CisJCWN0cmwgJj0gfkJJVF9DSChQV01fUFJFU0NBTF9NQVNLLCBw d20tPmh3cHdtKTsKKwkJY3RybCB8PSBCSVRfQ0gocHJlc2NhbGVyLCBwd20tPmh3cHdtKTsKIAl9 CiAKKwl2YWwgPSAoZHV0eSAmIFBXTV9EVFlfTUFTSykgfCBQV01fUFJEKHBlcmlvZCk7CisJc3Vu NGlfcHdtX3dyaXRlbChzdW40aV9wd20sIHZhbCwgUFdNX0NIX1BSRChwd20tPmh3cHdtKSk7CisJ c3VuNGlfcHdtLT5uZXh0X3BlcmlvZFtwd20tPmh3cHdtXSA9IGppZmZpZXMgKworCQl1c2Vjc190 b19qaWZmaWVzKGNzdGF0ZS5wZXJpb2QgLyAxMDAwICsgMSk7CisJc3VuNGlfcHdtLT5uZWVkc19k ZWxheVtwd20tPmh3cHdtXSA9IHRydWU7CisKIAlpZiAoc3RhdGUtPnBvbGFyaXR5ICE9IFBXTV9Q T0xBUklUWV9OT1JNQUwpCiAJCWN0cmwgJj0gfkJJVF9DSChQV01fQUNUX1NUQVRFLCBwd20tPmh3 cHdtKTsKIAllbHNlCiAJCWN0cmwgfD0gQklUX0NIKFBXTV9BQ1RfU1RBVEUsIHB3bS0+aHdwd20p OwogCiAJY3RybCB8PSBCSVRfQ0goUFdNX0NMS19HQVRJTkcsIHB3bS0+aHdwd20pOworCiAJaWYg KHN0YXRlLT5lbmFibGVkKSB7CiAJCWN0cmwgfD0gQklUX0NIKFBXTV9FTiwgcHdtLT5od3B3bSk7 CiAJfSBlbHNlIGlmICghc3VuNGlfcHdtLT5uZWVkc19kZWxheVtwd20tPmh3cHdtXSkgewotLSAK Mi4yMC4xCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo=