From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pkgconf: Always keep system libs
Date: Sun, 24 Nov 2019 19:42:18 +0100 [thread overview]
Message-ID: <20191124194218.024c82cf@gmx.net> (raw)
In-Reply-To: <20191121183659.1804967-1-thomas.preston@codethink.co.uk>
Hello Thomas,
On Thu, 21 Nov 2019 18:36:59 +0000, Thomas Preston <thomas.preston@codethink.co.uk> wrote:
> Normally pkgconf ignores the system include and system lib directories,
> which is useful because it allows the correct ordering of -I, -isystem
> and compiler default search paths. However, many packages use libtool,
> which relies on pkgconf to print the system libs dirs in order to locate
> the Libtool Archive (.la) files.
>
> Instead of adding PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 to each of these
> packages, just allow system libs globally in the pkg-config wrapper.
> This allows libtool to find the .la files, and retains the correct
> include ordering.
>
> Fixes (at least):
> - http://autobuild.buildroot.org/results/a79e0487135ad90530595d5c6ecc32f9c8cea7c4/
> - http://autobuild.buildroot.net/results/089/08952dbf89bf3c49da7697943441cee411940420/
>
> Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
In favour of a general pgkconf solution (instead fixing individual packages) and
tested for the libv4l and gmpc cases, you can add my
Tested-by: Peter Seiderer <ps.report@gmx.net>
Only nitpick for the subject line s/Always/always/...
Regards,
Peter
> ---
> package/pkgconf/pkg-config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/pkgconf/pkg-config.in b/package/pkgconf/pkg-config.in
> index f411eb0926..e5a23a10f7 100644
> --- a/package/pkgconf/pkg-config.in
> +++ b/package/pkgconf/pkg-config.in
> @@ -9,4 +9,4 @@ PKG_CONFIG_LIBDIR=${PKG_CONFIG_LIBDIR:-${DEFAULT_PKG_CONFIG_LIBDIR}} \
> PKG_CONFIG_SYSROOT_DIR=${PKG_CONFIG_SYSROOT_DIR:-${DEFAULT_PKG_CONFIG_SYSROOT_DIR}} \
> PKG_CONFIG_SYSTEM_INCLUDE_PATH=${PKG_CONFIG_SYSTEM_INCLUDE_PATH:-${DEFAULT_PKG_CONFIG_SYSTEM_INCLUDE_PATH}} \
> PKG_CONFIG_SYSTEM_LIBRARY_PATH=${PKG_CONFIG_SYSTEM_LIBRARY_PATH:-${DEFAULT_PKG_CONFIG_SYSTEM_LIBRARY_PATH}} \
> - exec ${PKGCONFDIR}/pkgconf @STATIC@ "$@"
> + exec ${PKGCONFDIR}/pkgconf --keep-system-libs @STATIC@ "$@"
next prev parent reply other threads:[~2019-11-24 18:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 18:36 [Buildroot] [PATCH] pkgconf: Always keep system libs Thomas Preston
2019-11-24 18:42 ` Peter Seiderer [this message]
2019-11-25 12:41 ` Thomas Preston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191124194218.024c82cf@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.