From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH] utimes: Clamp the timestamps in notify_change() Date: Sun, 24 Nov 2019 19:49:34 +0000 Message-ID: <20191124194934.GB4203@ZenIV.linux.org.uk> References: <20191124193145.22945-1-amir73il@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20191124193145.22945-1-amir73il@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: y2038-bounces@lists.linaro.org Sender: "Y2038" To: Amir Goldstein Cc: linux-nfs@vger.kernel.org, Arnd Bergmann , Miklos Szeredi , y2038@lists.linaro.org, Jeff Layton , linux-unionfs@vger.kernel.org, "J . Bruce Fields" , Deepa Dinamani , linux-fsdevel@vger.kernel.org List-Id: linux-unionfs@vger.kernel.org T24gU3VuLCBOb3YgMjQsIDIwMTkgYXQgMDk6MzE6NDVQTSArMDIwMCwgQW1pciBHb2xkc3RlaW4g d3JvdGU6Cj4gUHVzaCBjbGFtcGluZyB0aW1lc3RhbXBzIGRvd24gdGhlIGNhbGwgc3RhY2sgaW50 byBub3RpZnlfY2hhbmdlKCksIHNvCj4gaW4ta2VybmVsIGNhbGxlcnMgbGlrZSBuZnNkIGFuZCBv dmVybGF5ZnMgd2lsbCBnZXQgc2ltaWxhciB0aW1lc3RhbXAKPiBzZXQgYmVoYXZpb3IgYXMgdXRp bWVzLgogCk1ha2VzIHNlbnNlOyBzYWlkIHRoYXQsIHNob3VsZG4ndCB3ZSBnbyB0aHJvdWdoIC0+ c2V0YXR0cigpIGluc3RhbmNlcyBhbmQKZ2V0IHJpZCBvZiB0aGF0IHRoZXJlLCBub3cgdGhhdCBu b3RpZnlfY2hhbmdlKCkgaXMgbWFkZSB0byBkbyBpdD8KCkkgbWVhbiwKICAgICAgICBpZiAoaWFf dmFsaWQgJiBBVFRSX0FUSU1FKQogICAgICAgICAgICAgICAgc2RfaWF0dHItPmlhX2F0aW1lID0g dGltZXN0YW1wX3RydW5jYXRlKGlhdHRyLT5pYV9hdGltZSwKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW5vZGUpOwppbiBjb25maWdmc19zZXRh dHRyKCkgbG9va3MgbGlrZSBpdCBzaG91bGQgYmUgcmV2ZXJ0ZWQgdG8KICAgICAgICBpZiAoaWFf dmFsaWQgJiBBVFRSX0FUSU1FKQogICAgICAgICAgICAgICAgc2RfaWF0dHItPmlhX2F0aW1lID0g aWF0dHItPmlhX2F0aW1lOwp3aXRoIHRoYXQsIGV0Yy4KCk1vcmVvdmVyLCBkb2VzIHRoYXQgbGVh dmUgYW55IHZhbGlkIGNhbGxlcnMgb2YgdGltZXN0YW1wX3RydW5jYXRlKCkKb3V0c2lkZSBvZiBu b3RpZnlfY2hhbmdlKCkgYW5kIGN1cnJlbnRfdGltZSgpPyAgSU9XLCBpcyB0aGVyZSBhbnkKcG9p bnQgaGF2aW5nIGl0IGV4cG9ydGVkPyAgTG9vazoKZnMvYXR0ci5jOjE4NzogICAgICAgICAgaW5v ZGUtPmlfYXRpbWUgPSB0aW1lc3RhbXBfdHJ1bmNhdGUoYXR0ci0+aWFfYXRpbWUsCmZzL2F0dHIu YzoxOTE6ICAgICAgICAgIGlub2RlLT5pX210aW1lID0gdGltZXN0YW1wX3RydW5jYXRlKGF0dHIt PmlhX210aW1lLApmcy9hdHRyLmM6MTk1OiAgICAgICAgICBpbm9kZS0+aV9jdGltZSA9IHRpbWVz dGFtcF90cnVuY2F0ZShhdHRyLT5pYV9jdGltZSwKCXNldGF0dHJfY29weSgpLCBjYWxsZWQgZG93 bnN0cmVhbSBvZiB5b3VyIGNoYW5nZXMuCmZzL2NvbmZpZ2ZzL2lub2RlLmM6Nzk6ICAgICAgICAg c2RfaWF0dHItPmlhX2F0aW1lID0gdGltZXN0YW1wX3RydW5jYXRlKGlhdHRyLT5pYV9hdGltZSwK ZnMvY29uZmlnZnMvaW5vZGUuYzo4MjogICAgICAgICBzZF9pYXR0ci0+aWFfbXRpbWUgPSB0aW1l c3RhbXBfdHJ1bmNhdGUoaWF0dHItPmlhX210aW1lLApmcy9jb25maWdmcy9pbm9kZS5jOjg1OiAg ICAgICAgIHNkX2lhdHRyLT5pYV9jdGltZSA9IHRpbWVzdGFtcF90cnVuY2F0ZShpYXR0ci0+aWFf Y3RpbWUsCgljb25maWdmc19zZXRhdHRyKCk7IGRpdHRvLgpmcy9mMmZzL2ZpbGUuYzo3NTU6ICAg ICAgICAgICAgIGlub2RlLT5pX2F0aW1lID0gdGltZXN0YW1wX3RydW5jYXRlKGF0dHItPmlhX2F0 aW1lLApmcy9mMmZzL2ZpbGUuYzo3NTk6ICAgICAgICAgICAgIGlub2RlLT5pX210aW1lID0gdGlt ZXN0YW1wX3RydW5jYXRlKGF0dHItPmlhX210aW1lLApmcy9mMmZzL2ZpbGUuYzo3NjM6ICAgICAg ICAgICAgIGlub2RlLT5pX2N0aW1lID0gdGltZXN0YW1wX3RydW5jYXRlKGF0dHItPmlhX2N0aW1l LAoJX19zZXRhdHRyX2NvcHkoKSBmcm9tIGYyZnNfc2V0YXR0cigpOyBkaXR0by4KZnMvaW5vZGUu YzoyMjI0OiAgICAgICAgcmV0dXJuIHRpbWVzdGFtcF90cnVuY2F0ZShub3csIGlub2RlKTsKCWN1 cnJlbnRfdGltZSgpCmZzL2tlcm5mcy9pbm9kZS5jOjE2MzogIGlub2RlLT5pX2F0aW1lID0gdGlt ZXN0YW1wX3RydW5jYXRlKGF0dHJzLT5pYV9hdGltZSwgaW5vZGUpOwpmcy9rZXJuZnMvaW5vZGUu YzoxNjQ6ICBpbm9kZS0+aV9tdGltZSA9IHRpbWVzdGFtcF90cnVuY2F0ZShhdHRycy0+aWFfbXRp bWUsIGlub2RlKTsKZnMva2VybmZzL2lub2RlLmM6MTY1OiAgaW5vZGUtPmlfY3RpbWUgPSB0aW1l c3RhbXBfdHJ1bmNhdGUoYXR0cnMtPmlhX2N0aW1lLCBpbm9kZSk7CgktPnNfdGltZV9tYXggYW5k IC0+c190aW1lX21pbiBhcmUgbGVmdCBUSU1FNjRfTUFYIGFuZCBUSU1FNjRfTUlOIHJlc3AuLCBz bwp0aW1lc3RhbXBfdHJ1bmNhdGUoKSBzaG91bGQgYmUgYSBuby1vcCB0aGVyZS4KZnMvbnRmcy9p bm9kZS5jOjI5MDM6ICAgICAgICAgICB2aS0+aV9hdGltZSA9IHRpbWVzdGFtcF90cnVuY2F0ZShh dHRyLT5pYV9hdGltZSwKZnMvbnRmcy9pbm9kZS5jOjI5MDc6ICAgICAgICAgICB2aS0+aV9tdGlt ZSA9IHRpbWVzdGFtcF90cnVuY2F0ZShhdHRyLT5pYV9tdGltZSwKZnMvbnRmcy9pbm9kZS5jOjI5 MTE6ICAgICAgICAgICB2aS0+aV9jdGltZSA9IHRpbWVzdGFtcF90cnVuY2F0ZShhdHRyLT5pYV9j dGltZSwKCW50ZnNfc2V0YXR0cigpOyBkb3duc3RyZWFtIGZyb20geW91ciBjaGFuZ2VzCmZzL3Vi aWZzL2ZpbGUuYzoxMDgyOiAgICAgICAgICAgaW5vZGUtPmlfYXRpbWUgPSB0aW1lc3RhbXBfdHJ1 bmNhdGUoYXR0ci0+aWFfYXRpbWUsCmZzL3ViaWZzL2ZpbGUuYzoxMDg2OiAgICAgICAgICAgaW5v ZGUtPmlfbXRpbWUgPSB0aW1lc3RhbXBfdHJ1bmNhdGUoYXR0ci0+aWFfbXRpbWUsCmZzL3ViaWZz L2ZpbGUuYzoxMDkwOiAgICAgICAgICAgaW5vZGUtPmlfY3RpbWUgPSB0aW1lc3RhbXBfdHJ1bmNh dGUoYXR0ci0+aWFfY3RpbWUsCglkb19hdHRyX2NoYW5nZXMoKSwgZnJvbSBkb190cnVuY2F0aW9u KCkgb3IgZG9fc2V0YXR0cigpLCBib3RoIGZyb20gdWJpZnNfc2V0YXR0cigpOwpkaXR0by4KZnMv dXRpbWVzLmM6Mzk6ICAgICAgICAgICAgICAgICBuZXdhdHRycy5pYV9hdGltZSA9IHRpbWVzdGFt cF90cnVuY2F0ZSh0aW1lc1swXSwgaW5vZGUpOwpmcy91dGltZXMuYzo0NjogICAgICAgICAgICAg ICAgIG5ld2F0dHJzLmlhX210aW1lID0gdGltZXN0YW1wX3RydW5jYXRlKHRpbWVzWzFdLCBpbm9k ZSk7CglkaXNhcHBlYXJzIGluIHlvdXIgcGF0Y2guCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fClkyMDM4IG1haWxpbmcgbGlzdApZMjAzOEBsaXN0cy5saW5h cm8ub3JnCmh0dHBzOi8vbGlzdHMubGluYXJvLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3kyMDM4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F037FC432C0 for ; Sun, 24 Nov 2019 19:49:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1C972075E for ; Sun, 24 Nov 2019 19:49:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726880AbfKXTtl (ORCPT ); Sun, 24 Nov 2019 14:49:41 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:51540 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726803AbfKXTtk (ORCPT ); Sun, 24 Nov 2019 14:49:40 -0500 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iYxt0-0005eu-Q9; Sun, 24 Nov 2019 19:49:34 +0000 Date: Sun, 24 Nov 2019 19:49:34 +0000 From: Al Viro To: Amir Goldstein Cc: Arnd Bergmann , Deepa Dinamani , Jeff Layton , "J . Bruce Fields" , Miklos Szeredi , linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-nfs@vger.kernel.org, y2038@lists.linaro.org Subject: Re: [PATCH] utimes: Clamp the timestamps in notify_change() Message-ID: <20191124194934.GB4203@ZenIV.linux.org.uk> References: <20191124193145.22945-1-amir73il@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191124193145.22945-1-amir73il@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sun, Nov 24, 2019 at 09:31:45PM +0200, Amir Goldstein wrote: > Push clamping timestamps down the call stack into notify_change(), so > in-kernel callers like nfsd and overlayfs will get similar timestamp > set behavior as utimes. Makes sense; said that, shouldn't we go through ->setattr() instances and get rid of that there, now that notify_change() is made to do it? I mean, if (ia_valid & ATTR_ATIME) sd_iattr->ia_atime = timestamp_truncate(iattr->ia_atime, inode); in configfs_setattr() looks like it should be reverted to if (ia_valid & ATTR_ATIME) sd_iattr->ia_atime = iattr->ia_atime; with that, etc. Moreover, does that leave any valid callers of timestamp_truncate() outside of notify_change() and current_time()? IOW, is there any point having it exported? Look: fs/attr.c:187: inode->i_atime = timestamp_truncate(attr->ia_atime, fs/attr.c:191: inode->i_mtime = timestamp_truncate(attr->ia_mtime, fs/attr.c:195: inode->i_ctime = timestamp_truncate(attr->ia_ctime, setattr_copy(), called downstream of your changes. fs/configfs/inode.c:79: sd_iattr->ia_atime = timestamp_truncate(iattr->ia_atime, fs/configfs/inode.c:82: sd_iattr->ia_mtime = timestamp_truncate(iattr->ia_mtime, fs/configfs/inode.c:85: sd_iattr->ia_ctime = timestamp_truncate(iattr->ia_ctime, configfs_setattr(); ditto. fs/f2fs/file.c:755: inode->i_atime = timestamp_truncate(attr->ia_atime, fs/f2fs/file.c:759: inode->i_mtime = timestamp_truncate(attr->ia_mtime, fs/f2fs/file.c:763: inode->i_ctime = timestamp_truncate(attr->ia_ctime, __setattr_copy() from f2fs_setattr(); ditto. fs/inode.c:2224: return timestamp_truncate(now, inode); current_time() fs/kernfs/inode.c:163: inode->i_atime = timestamp_truncate(attrs->ia_atime, inode); fs/kernfs/inode.c:164: inode->i_mtime = timestamp_truncate(attrs->ia_mtime, inode); fs/kernfs/inode.c:165: inode->i_ctime = timestamp_truncate(attrs->ia_ctime, inode); ->s_time_max and ->s_time_min are left TIME64_MAX and TIME64_MIN resp., so timestamp_truncate() should be a no-op there. fs/ntfs/inode.c:2903: vi->i_atime = timestamp_truncate(attr->ia_atime, fs/ntfs/inode.c:2907: vi->i_mtime = timestamp_truncate(attr->ia_mtime, fs/ntfs/inode.c:2911: vi->i_ctime = timestamp_truncate(attr->ia_ctime, ntfs_setattr(); downstream from your changes fs/ubifs/file.c:1082: inode->i_atime = timestamp_truncate(attr->ia_atime, fs/ubifs/file.c:1086: inode->i_mtime = timestamp_truncate(attr->ia_mtime, fs/ubifs/file.c:1090: inode->i_ctime = timestamp_truncate(attr->ia_ctime, do_attr_changes(), from do_truncation() or do_setattr(), both from ubifs_setattr(); ditto. fs/utimes.c:39: newattrs.ia_atime = timestamp_truncate(times[0], inode); fs/utimes.c:46: newattrs.ia_mtime = timestamp_truncate(times[1], inode); disappears in your patch.