From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 894B0C432C3 for ; Mon, 25 Nov 2019 22:53:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 688BB2075C for ; Mon, 25 Nov 2019 22:53:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727182AbfKYWxh (ORCPT ); Mon, 25 Nov 2019 17:53:37 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:55954 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725946AbfKYWxh (ORCPT ); Mon, 25 Nov 2019 17:53:37 -0500 Received: from localhost (c-73-35-209-67.hsd1.wa.comcast.net [73.35.209.67]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BDED0150728AF; Mon, 25 Nov 2019 14:53:36 -0800 (PST) Date: Mon, 25 Nov 2019 14:53:36 -0800 (PST) Message-Id: <20191125.145336.1803100409578989775.davem@davemloft.net> To: lucien.xin@gmail.com Cc: netdev@vger.kernel.org, dsahern@gmail.com, jbenc@redhat.com, roopa@cumulusnetworks.com Subject: Re: [PATCH net] ipv6: set lwtstate for ns and na dst From: David Miller In-Reply-To: <3743d1e2c7fc26fb5f7401b6b0956097e997c48c.1574662992.git.lucien.xin@gmail.com> References: <3743d1e2c7fc26fb5f7401b6b0956097e997c48c.1574662992.git.lucien.xin@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 25 Nov 2019 14:53:36 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Xin Long Date: Mon, 25 Nov 2019 14:23:12 +0800 > This patch is to fix an issue that ipv6 ns and na can't go out with the > correct tunnel info, and it can be reproduced by: And why shouldn't RS and redirects get this treatment too? And then, at that point, all callers of ndisc_send_skb() have this early route lookup code (and thus the "!dst" code path is unused), and the question ultimately becomes why doesn't ndisc_send_skb() itself have the dst lookup modification? I'm not too sure about this change and will not apply it.