From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86B5CC432C0 for ; Mon, 25 Nov 2019 08:59:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6590720815 for ; Mon, 25 Nov 2019 08:59:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726118AbfKYI7V (ORCPT ); Mon, 25 Nov 2019 03:59:21 -0500 Received: from mx2.suse.de ([195.135.220.15]:56606 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725793AbfKYI7V (ORCPT ); Mon, 25 Nov 2019 03:59:21 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id F1475B308; Mon, 25 Nov 2019 08:59:16 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 1906B1E0A57; Mon, 25 Nov 2019 09:59:15 +0100 (CET) Date: Mon, 25 Nov 2019 09:59:15 +0100 From: Jan Kara To: John Hubbard Cc: Andrew Morton , Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Christoph Hellwig , Dan Williams , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jan Kara , Jason Gunthorpe , Jens Axboe , Jonathan Corbet , =?iso-8859-1?B?Suly9G1l?= Glisse , Magnus Karlsson , Mauro Carvalho Chehab , Michael Ellerman , Michal Hocko , Mike Kravetz , Paul Mackerras , Shuah Khan , Vlastimil Babka , bpf@vger.kernel.org, dri-devel@lists.freedesktop.org, kvm@vger.kernel.org, linux-block@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, linux-rdma@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-mm@kvack.org, LKML Subject: Re: [PATCH 17/19] powerpc: book3s64: convert to pin_user_pages() and put_user_page() Message-ID: <20191125085915.GB1797@quack2.suse.cz> References: <20191125042011.3002372-1-jhubbard@nvidia.com> <20191125042011.3002372-18-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191125042011.3002372-18-jhubbard@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sun 24-11-19 20:20:09, John Hubbard wrote: > 1. Convert from get_user_pages() to pin_user_pages(). > > 2. As required by pin_user_pages(), release these pages via > put_user_page(). In this case, do so via put_user_pages_dirty_lock(). > > That has the side effect of calling set_page_dirty_lock(), instead > of set_page_dirty(). This is probably more accurate. > > As Christoph Hellwig put it, "set_page_dirty() is only safe if we are > dealing with a file backed page where we have reference on the inode it > hangs off." [1] > > 3. Release each page in mem->hpages[] (instead of mem->hpas[]), because > that is the array that pin_longterm_pages() filled in. This is more > accurate and should be a little safer from a maintenance point of > view. Except that this breaks the code. hpages is unioned with hpas... > [1] https://lore.kernel.org/r/20190723153640.GB720@lst.de > > Signed-off-by: John Hubbard > --- > arch/powerpc/mm/book3s64/iommu_api.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/arch/powerpc/mm/book3s64/iommu_api.c b/arch/powerpc/mm/book3s64/iommu_api.c > index 56cc84520577..196383e8e5a9 100644 > --- a/arch/powerpc/mm/book3s64/iommu_api.c > +++ b/arch/powerpc/mm/book3s64/iommu_api.c > @@ -103,7 +103,7 @@ static long mm_iommu_do_alloc(struct mm_struct *mm, unsigned long ua, > for (entry = 0; entry < entries; entry += chunk) { > unsigned long n = min(entries - entry, chunk); > > - ret = get_user_pages(ua + (entry << PAGE_SHIFT), n, > + ret = pin_user_pages(ua + (entry << PAGE_SHIFT), n, > FOLL_WRITE | FOLL_LONGTERM, > mem->hpages + entry, NULL); > if (ret == n) { > @@ -167,9 +167,8 @@ static long mm_iommu_do_alloc(struct mm_struct *mm, unsigned long ua, > return 0; > > free_exit: > - /* free the reference taken */ > - for (i = 0; i < pinned; i++) > - put_page(mem->hpages[i]); > + /* free the references taken */ > + put_user_pages(mem->hpages, pinned); > > vfree(mem->hpas); > kfree(mem); > @@ -212,10 +211,9 @@ static void mm_iommu_unpin(struct mm_iommu_table_group_mem_t *mem) > if (!page) > continue; > > - if (mem->hpas[i] & MM_IOMMU_TABLE_GROUP_PAGE_DIRTY) > - SetPageDirty(page); > + put_user_pages_dirty_lock(&mem->hpages[i], 1, > + MM_IOMMU_TABLE_GROUP_PAGE_DIRTY); And the dirtying condition is wrong here as well. Currently it is always true. Honza -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E716DC432C0 for ; Mon, 25 Nov 2019 09:01:20 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F81D207FD for ; Mon, 25 Nov 2019 09:01:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F81D207FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47M1H24XlZzDqWj for ; Mon, 25 Nov 2019 20:01:18 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.220.15; helo=mx1.suse.de; envelope-from=jack@suse.cz; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.cz Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47M1Dp3TwDzDqVS for ; Mon, 25 Nov 2019 19:59:21 +1100 (AEDT) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id F1475B308; Mon, 25 Nov 2019 08:59:16 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 1906B1E0A57; Mon, 25 Nov 2019 09:59:15 +0100 (CET) Date: Mon, 25 Nov 2019 09:59:15 +0100 From: Jan Kara To: John Hubbard Subject: Re: [PATCH 17/19] powerpc: book3s64: convert to pin_user_pages() and put_user_page() Message-ID: <20191125085915.GB1797@quack2.suse.cz> References: <20191125042011.3002372-1-jhubbard@nvidia.com> <20191125042011.3002372-18-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191125042011.3002372-18-jhubbard@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma@vger.kernel.org, Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kernel.org, Magnus Karlsson , Jens Axboe , netdev@vger.kernel.org, Alex Williamson , Daniel Vetter , linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sun 24-11-19 20:20:09, John Hubbard wrote: > 1. Convert from get_user_pages() to pin_user_pages(). > > 2. As required by pin_user_pages(), release these pages via > put_user_page(). In this case, do so via put_user_pages_dirty_lock(). > > That has the side effect of calling set_page_dirty_lock(), instead > of set_page_dirty(). This is probably more accurate. > > As Christoph Hellwig put it, "set_page_dirty() is only safe if we are > dealing with a file backed page where we have reference on the inode it > hangs off." [1] > > 3. Release each page in mem->hpages[] (instead of mem->hpas[]), because > that is the array that pin_longterm_pages() filled in. This is more > accurate and should be a little safer from a maintenance point of > view. Except that this breaks the code. hpages is unioned with hpas... > [1] https://lore.kernel.org/r/20190723153640.GB720@lst.de > > Signed-off-by: John Hubbard > --- > arch/powerpc/mm/book3s64/iommu_api.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/arch/powerpc/mm/book3s64/iommu_api.c b/arch/powerpc/mm/book3s64/iommu_api.c > index 56cc84520577..196383e8e5a9 100644 > --- a/arch/powerpc/mm/book3s64/iommu_api.c > +++ b/arch/powerpc/mm/book3s64/iommu_api.c > @@ -103,7 +103,7 @@ static long mm_iommu_do_alloc(struct mm_struct *mm, unsigned long ua, > for (entry = 0; entry < entries; entry += chunk) { > unsigned long n = min(entries - entry, chunk); > > - ret = get_user_pages(ua + (entry << PAGE_SHIFT), n, > + ret = pin_user_pages(ua + (entry << PAGE_SHIFT), n, > FOLL_WRITE | FOLL_LONGTERM, > mem->hpages + entry, NULL); > if (ret == n) { > @@ -167,9 +167,8 @@ static long mm_iommu_do_alloc(struct mm_struct *mm, unsigned long ua, > return 0; > > free_exit: > - /* free the reference taken */ > - for (i = 0; i < pinned; i++) > - put_page(mem->hpages[i]); > + /* free the references taken */ > + put_user_pages(mem->hpages, pinned); > > vfree(mem->hpas); > kfree(mem); > @@ -212,10 +211,9 @@ static void mm_iommu_unpin(struct mm_iommu_table_group_mem_t *mem) > if (!page) > continue; > > - if (mem->hpas[i] & MM_IOMMU_TABLE_GROUP_PAGE_DIRTY) > - SetPageDirty(page); > + put_user_pages_dirty_lock(&mem->hpages[i], 1, > + MM_IOMMU_TABLE_GROUP_PAGE_DIRTY); And the dirtying condition is wrong here as well. Currently it is always true. Honza -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 17/19] powerpc: book3s64: convert to pin_user_pages() and put_user_page() Date: Mon, 25 Nov 2019 09:59:15 +0100 Message-ID: <20191125085915.GB1797@quack2.suse.cz> References: <20191125042011.3002372-1-jhubbard@nvidia.com> <20191125042011.3002372-18-jhubbard@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF74D89271 for ; Mon, 25 Nov 2019 08:59:19 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20191125042011.3002372-18-jhubbard@nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Hubbard Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Al Viro , Dan Williams , Mauro Carvalho Chehab List-Id: dri-devel@lists.freedesktop.org T24gU3VuIDI0LTExLTE5IDIwOjIwOjA5LCBKb2huIEh1YmJhcmQgd3JvdGU6Cj4gMS4gQ29udmVy dCBmcm9tIGdldF91c2VyX3BhZ2VzKCkgdG8gcGluX3VzZXJfcGFnZXMoKS4KPiAKPiAyLiBBcyBy ZXF1aXJlZCBieSBwaW5fdXNlcl9wYWdlcygpLCByZWxlYXNlIHRoZXNlIHBhZ2VzIHZpYQo+IHB1 dF91c2VyX3BhZ2UoKS4gSW4gdGhpcyBjYXNlLCBkbyBzbyB2aWEgcHV0X3VzZXJfcGFnZXNfZGly dHlfbG9jaygpLgo+IAo+IFRoYXQgaGFzIHRoZSBzaWRlIGVmZmVjdCBvZiBjYWxsaW5nIHNldF9w YWdlX2RpcnR5X2xvY2soKSwgaW5zdGVhZAo+IG9mIHNldF9wYWdlX2RpcnR5KCkuIFRoaXMgaXMg cHJvYmFibHkgbW9yZSBhY2N1cmF0ZS4KPiAKPiBBcyBDaHJpc3RvcGggSGVsbHdpZyBwdXQgaXQs ICJzZXRfcGFnZV9kaXJ0eSgpIGlzIG9ubHkgc2FmZSBpZiB3ZSBhcmUKPiBkZWFsaW5nIHdpdGgg YSBmaWxlIGJhY2tlZCBwYWdlIHdoZXJlIHdlIGhhdmUgcmVmZXJlbmNlIG9uIHRoZSBpbm9kZSBp dAo+IGhhbmdzIG9mZi4iIFsxXQo+IAo+IDMuIFJlbGVhc2UgZWFjaCBwYWdlIGluIG1lbS0+aHBh Z2VzW10gKGluc3RlYWQgb2YgbWVtLT5ocGFzW10pLCBiZWNhdXNlCj4gdGhhdCBpcyB0aGUgYXJy YXkgdGhhdCBwaW5fbG9uZ3Rlcm1fcGFnZXMoKSBmaWxsZWQgaW4uIFRoaXMgaXMgbW9yZQo+IGFj Y3VyYXRlIGFuZCBzaG91bGQgYmUgYSBsaXR0bGUgc2FmZXIgZnJvbSBhIG1haW50ZW5hbmNlIHBv aW50IG9mCj4gdmlldy4KCkV4Y2VwdCB0aGF0IHRoaXMgYnJlYWtzIHRoZSBjb2RlLiBocGFnZXMg aXMgdW5pb25lZCB3aXRoIGhwYXMuLi4KCj4gWzFdIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3Iv MjAxOTA3MjMxNTM2NDAuR0I3MjBAbHN0LmRlCj4gCj4gU2lnbmVkLW9mZi1ieTogSm9obiBIdWJi YXJkIDxqaHViYmFyZEBudmlkaWEuY29tPgo+IC0tLQo+ICBhcmNoL3Bvd2VycGMvbW0vYm9vazNz NjQvaW9tbXVfYXBpLmMgfCAxMiArKysrKy0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5z ZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBj L21tL2Jvb2szczY0L2lvbW11X2FwaS5jIGIvYXJjaC9wb3dlcnBjL21tL2Jvb2szczY0L2lvbW11 X2FwaS5jCj4gaW5kZXggNTZjYzg0NTIwNTc3Li4xOTYzODNlOGU1YTkgMTAwNjQ0Cj4gLS0tIGEv YXJjaC9wb3dlcnBjL21tL2Jvb2szczY0L2lvbW11X2FwaS5jCj4gKysrIGIvYXJjaC9wb3dlcnBj L21tL2Jvb2szczY0L2lvbW11X2FwaS5jCj4gQEAgLTEwMyw3ICsxMDMsNyBAQCBzdGF0aWMgbG9u ZyBtbV9pb21tdV9kb19hbGxvYyhzdHJ1Y3QgbW1fc3RydWN0ICptbSwgdW5zaWduZWQgbG9uZyB1 YSwKPiAgCWZvciAoZW50cnkgPSAwOyBlbnRyeSA8IGVudHJpZXM7IGVudHJ5ICs9IGNodW5rKSB7 Cj4gIAkJdW5zaWduZWQgbG9uZyBuID0gbWluKGVudHJpZXMgLSBlbnRyeSwgY2h1bmspOwo+ICAK PiAtCQlyZXQgPSBnZXRfdXNlcl9wYWdlcyh1YSArIChlbnRyeSA8PCBQQUdFX1NISUZUKSwgbiwK PiArCQlyZXQgPSBwaW5fdXNlcl9wYWdlcyh1YSArIChlbnRyeSA8PCBQQUdFX1NISUZUKSwgbiwK PiAgCQkJCUZPTExfV1JJVEUgfCBGT0xMX0xPTkdURVJNLAo+ICAJCQkJbWVtLT5ocGFnZXMgKyBl bnRyeSwgTlVMTCk7Cj4gIAkJaWYgKHJldCA9PSBuKSB7Cj4gQEAgLTE2Nyw5ICsxNjcsOCBAQCBz dGF0aWMgbG9uZyBtbV9pb21tdV9kb19hbGxvYyhzdHJ1Y3QgbW1fc3RydWN0ICptbSwgdW5zaWdu ZWQgbG9uZyB1YSwKPiAgCXJldHVybiAwOwo+ICAKPiAgZnJlZV9leGl0Ogo+IC0JLyogZnJlZSB0 aGUgcmVmZXJlbmNlIHRha2VuICovCj4gLQlmb3IgKGkgPSAwOyBpIDwgcGlubmVkOyBpKyspCj4g LQkJcHV0X3BhZ2UobWVtLT5ocGFnZXNbaV0pOwo+ICsJLyogZnJlZSB0aGUgcmVmZXJlbmNlcyB0 YWtlbiAqLwo+ICsJcHV0X3VzZXJfcGFnZXMobWVtLT5ocGFnZXMsIHBpbm5lZCk7Cj4gIAo+ICAJ dmZyZWUobWVtLT5ocGFzKTsKPiAgCWtmcmVlKG1lbSk7Cj4gQEAgLTIxMiwxMCArMjExLDkgQEAg c3RhdGljIHZvaWQgbW1faW9tbXVfdW5waW4oc3RydWN0IG1tX2lvbW11X3RhYmxlX2dyb3VwX21l bV90ICptZW0pCj4gIAkJaWYgKCFwYWdlKQo+ICAJCQljb250aW51ZTsKPiAgCj4gLQkJaWYgKG1l bS0+aHBhc1tpXSAmIE1NX0lPTU1VX1RBQkxFX0dST1VQX1BBR0VfRElSVFkpCj4gLQkJCVNldFBh Z2VEaXJ0eShwYWdlKTsKPiArCQlwdXRfdXNlcl9wYWdlc19kaXJ0eV9sb2NrKCZtZW0tPmhwYWdl c1tpXSwgMSwKPiArCQkJCQkgIE1NX0lPTU1VX1RBQkxFX0dST1VQX1BBR0VfRElSVFkpOwoKQW5k IHRoZSBkaXJ0eWluZyBjb25kaXRpb24gaXMgd3JvbmcgaGVyZSBhcyB3ZWxsLiBDdXJyZW50bHkg aXQgaXMgYWx3YXlzCnRydWUuCgoJCQkJCQkJCUhvbnphCi0tIApKYW4gS2FyYSA8amFja0BzdXNl LmNvbT4KU1VTRSBMYWJzLCBDUgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3E2CC43141 for ; Mon, 25 Nov 2019 08:59:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95342207FD for ; Mon, 25 Nov 2019 08:59:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95342207FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A4AA89271; Mon, 25 Nov 2019 08:59:24 +0000 (UTC) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF74D89271 for ; Mon, 25 Nov 2019 08:59:19 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id F1475B308; Mon, 25 Nov 2019 08:59:16 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 1906B1E0A57; Mon, 25 Nov 2019 09:59:15 +0100 (CET) Date: Mon, 25 Nov 2019 09:59:15 +0100 From: Jan Kara To: John Hubbard Subject: Re: [PATCH 17/19] powerpc: book3s64: convert to pin_user_pages() and put_user_page() Message-ID: <20191125085915.GB1797@quack2.suse.cz> References: <20191125042011.3002372-1-jhubbard@nvidia.com> <20191125042011.3002372-18-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191125042011.3002372-18-jhubbard@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kernel.org, Magnus Karlsson , Jens Axboe , netdev@vger.kernel.org, Alex Williamson , linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Kravetz Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191125085915.8k0G42hqjZuvvSjJ-sn_29eEI7LzYEPM0Ps6LvQOZK4@z> T24gU3VuIDI0LTExLTE5IDIwOjIwOjA5LCBKb2huIEh1YmJhcmQgd3JvdGU6Cj4gMS4gQ29udmVy dCBmcm9tIGdldF91c2VyX3BhZ2VzKCkgdG8gcGluX3VzZXJfcGFnZXMoKS4KPiAKPiAyLiBBcyBy ZXF1aXJlZCBieSBwaW5fdXNlcl9wYWdlcygpLCByZWxlYXNlIHRoZXNlIHBhZ2VzIHZpYQo+IHB1 dF91c2VyX3BhZ2UoKS4gSW4gdGhpcyBjYXNlLCBkbyBzbyB2aWEgcHV0X3VzZXJfcGFnZXNfZGly dHlfbG9jaygpLgo+IAo+IFRoYXQgaGFzIHRoZSBzaWRlIGVmZmVjdCBvZiBjYWxsaW5nIHNldF9w YWdlX2RpcnR5X2xvY2soKSwgaW5zdGVhZAo+IG9mIHNldF9wYWdlX2RpcnR5KCkuIFRoaXMgaXMg cHJvYmFibHkgbW9yZSBhY2N1cmF0ZS4KPiAKPiBBcyBDaHJpc3RvcGggSGVsbHdpZyBwdXQgaXQs ICJzZXRfcGFnZV9kaXJ0eSgpIGlzIG9ubHkgc2FmZSBpZiB3ZSBhcmUKPiBkZWFsaW5nIHdpdGgg YSBmaWxlIGJhY2tlZCBwYWdlIHdoZXJlIHdlIGhhdmUgcmVmZXJlbmNlIG9uIHRoZSBpbm9kZSBp dAo+IGhhbmdzIG9mZi4iIFsxXQo+IAo+IDMuIFJlbGVhc2UgZWFjaCBwYWdlIGluIG1lbS0+aHBh Z2VzW10gKGluc3RlYWQgb2YgbWVtLT5ocGFzW10pLCBiZWNhdXNlCj4gdGhhdCBpcyB0aGUgYXJy YXkgdGhhdCBwaW5fbG9uZ3Rlcm1fcGFnZXMoKSBmaWxsZWQgaW4uIFRoaXMgaXMgbW9yZQo+IGFj Y3VyYXRlIGFuZCBzaG91bGQgYmUgYSBsaXR0bGUgc2FmZXIgZnJvbSBhIG1haW50ZW5hbmNlIHBv aW50IG9mCj4gdmlldy4KCkV4Y2VwdCB0aGF0IHRoaXMgYnJlYWtzIHRoZSBjb2RlLiBocGFnZXMg aXMgdW5pb25lZCB3aXRoIGhwYXMuLi4KCj4gWzFdIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3Iv MjAxOTA3MjMxNTM2NDAuR0I3MjBAbHN0LmRlCj4gCj4gU2lnbmVkLW9mZi1ieTogSm9obiBIdWJi YXJkIDxqaHViYmFyZEBudmlkaWEuY29tPgo+IC0tLQo+ICBhcmNoL3Bvd2VycGMvbW0vYm9vazNz NjQvaW9tbXVfYXBpLmMgfCAxMiArKysrKy0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5z ZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBj L21tL2Jvb2szczY0L2lvbW11X2FwaS5jIGIvYXJjaC9wb3dlcnBjL21tL2Jvb2szczY0L2lvbW11 X2FwaS5jCj4gaW5kZXggNTZjYzg0NTIwNTc3Li4xOTYzODNlOGU1YTkgMTAwNjQ0Cj4gLS0tIGEv YXJjaC9wb3dlcnBjL21tL2Jvb2szczY0L2lvbW11X2FwaS5jCj4gKysrIGIvYXJjaC9wb3dlcnBj L21tL2Jvb2szczY0L2lvbW11X2FwaS5jCj4gQEAgLTEwMyw3ICsxMDMsNyBAQCBzdGF0aWMgbG9u ZyBtbV9pb21tdV9kb19hbGxvYyhzdHJ1Y3QgbW1fc3RydWN0ICptbSwgdW5zaWduZWQgbG9uZyB1 YSwKPiAgCWZvciAoZW50cnkgPSAwOyBlbnRyeSA8IGVudHJpZXM7IGVudHJ5ICs9IGNodW5rKSB7 Cj4gIAkJdW5zaWduZWQgbG9uZyBuID0gbWluKGVudHJpZXMgLSBlbnRyeSwgY2h1bmspOwo+ICAK PiAtCQlyZXQgPSBnZXRfdXNlcl9wYWdlcyh1YSArIChlbnRyeSA8PCBQQUdFX1NISUZUKSwgbiwK PiArCQlyZXQgPSBwaW5fdXNlcl9wYWdlcyh1YSArIChlbnRyeSA8PCBQQUdFX1NISUZUKSwgbiwK PiAgCQkJCUZPTExfV1JJVEUgfCBGT0xMX0xPTkdURVJNLAo+ICAJCQkJbWVtLT5ocGFnZXMgKyBl bnRyeSwgTlVMTCk7Cj4gIAkJaWYgKHJldCA9PSBuKSB7Cj4gQEAgLTE2Nyw5ICsxNjcsOCBAQCBz dGF0aWMgbG9uZyBtbV9pb21tdV9kb19hbGxvYyhzdHJ1Y3QgbW1fc3RydWN0ICptbSwgdW5zaWdu ZWQgbG9uZyB1YSwKPiAgCXJldHVybiAwOwo+ICAKPiAgZnJlZV9leGl0Ogo+IC0JLyogZnJlZSB0 aGUgcmVmZXJlbmNlIHRha2VuICovCj4gLQlmb3IgKGkgPSAwOyBpIDwgcGlubmVkOyBpKyspCj4g LQkJcHV0X3BhZ2UobWVtLT5ocGFnZXNbaV0pOwo+ICsJLyogZnJlZSB0aGUgcmVmZXJlbmNlcyB0 YWtlbiAqLwo+ICsJcHV0X3VzZXJfcGFnZXMobWVtLT5ocGFnZXMsIHBpbm5lZCk7Cj4gIAo+ICAJ dmZyZWUobWVtLT5ocGFzKTsKPiAgCWtmcmVlKG1lbSk7Cj4gQEAgLTIxMiwxMCArMjExLDkgQEAg c3RhdGljIHZvaWQgbW1faW9tbXVfdW5waW4oc3RydWN0IG1tX2lvbW11X3RhYmxlX2dyb3VwX21l bV90ICptZW0pCj4gIAkJaWYgKCFwYWdlKQo+ICAJCQljb250aW51ZTsKPiAgCj4gLQkJaWYgKG1l bS0+aHBhc1tpXSAmIE1NX0lPTU1VX1RBQkxFX0dST1VQX1BBR0VfRElSVFkpCj4gLQkJCVNldFBh Z2VEaXJ0eShwYWdlKTsKPiArCQlwdXRfdXNlcl9wYWdlc19kaXJ0eV9sb2NrKCZtZW0tPmhwYWdl c1tpXSwgMSwKPiArCQkJCQkgIE1NX0lPTU1VX1RBQkxFX0dST1VQX1BBR0VfRElSVFkpOwoKQW5k IHRoZSBkaXJ0eWluZyBjb25kaXRpb24gaXMgd3JvbmcgaGVyZSBhcyB3ZWxsLiBDdXJyZW50bHkg aXQgaXMgYWx3YXlzCnRydWUuCgoJCQkJCQkJCUhvbnphCi0tIApKYW4gS2FyYSA8amFja0BzdXNl LmNvbT4KU1VTRSBMYWJzLCBDUgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWw=