All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Martin Varghese <martinvarghesenokia@gmail.com>
Cc: netdev@vger.kernel.org, pshelar@ovn.org, davem@davemloft.net,
	jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
	martin.varghese@nokia.com
Subject: Re: [PATCH v2 net-next] Enhanced skb_mpls_pop to update ethertype of the packet in all the cases when an ethernet header is present is the packet.
Date: Mon, 25 Nov 2019 09:05:30 -0800	[thread overview]
Message-ID: <20191125090530.5e34fc93@cakuba.netronome.com> (raw)
In-Reply-To: <20191125110234.GA2795@martin-VirtualBox>

On Mon, 25 Nov 2019 16:32:34 +0530, Martin Varghese wrote:
> > > Changes in v2:
> > >     - check for dev type removed while updating ethertype
> > >       in function skb_mpls_pop.
> > >     - key->mac_proto is checked in function pop_mpls to pass
> > >       ethernt flag to skb_mpls_pop.
> > >     - dev type is checked in function tcf_mpls_act to pass
> > >       ethernet flag to skb_mpls_pop.  
> > 
> > nit: changelog can be kept in the commit message for netdev patches
> >  
> Multiple versions are mostly due to coding error.do you insist to keep
> the change log in commit message ?

Not really, just a minor suggestion.

  reply	other threads:[~2019-11-25 17:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-23 10:34 [PATCH v2 net-next] Enhanced skb_mpls_pop to update ethertype of the packet in all the cases when an ethernet header is present is the packet Martin Varghese
2019-11-25  3:10 ` Jakub Kicinski
2019-11-25 11:02   ` Martin Varghese
2019-11-25 17:05     ` Jakub Kicinski [this message]
2019-11-25  5:32 ` Pravin Shelar
2019-11-25 10:39   ` Martin Varghese
2019-11-25 15:49   ` Martin Varghese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191125090530.5e34fc93@cakuba.netronome.com \
    --to=jakub.kicinski@netronome.com \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=martin.varghese@nokia.com \
    --cc=martinvarghesenokia@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@ovn.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.