From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C18E1C43215 for ; Mon, 25 Nov 2019 14:49:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A3123207FD for ; Mon, 25 Nov 2019 14:49:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728299AbfKYOtV (ORCPT ); Mon, 25 Nov 2019 09:49:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:59442 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728078AbfKYOtV (ORCPT ); Mon, 25 Nov 2019 09:49:21 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5FDBE207FD; Mon, 25 Nov 2019 14:49:20 +0000 (UTC) Date: Mon, 25 Nov 2019 09:49:18 -0500 From: Steven Rostedt To: Masami Hiramatsu Cc: Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [BUGFIX PATCH v3 4/4] selftests/ftrace: Fix multiple kprobe testcase Message-ID: <20191125094918.738f2c0c@gandalf.local.home> In-Reply-To: <157466504736.21973.15722652829669648396.stgit@devnote2> References: <157466501169.21973.31401747181477687.stgit@devnote2> <157466504736.21973.15722652829669648396.stgit@devnote2> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Nov 2019 15:57:27 +0900 Masami Hiramatsu wrote: > Fix multiple kprobe event testcase to work it correctly. > There are 2 bugfixes. > - Since `wc -l FILE` returns not only line number but also > FILE filename, following "if" statement always failed. > Fix this bug by replacing it with 'cat FILE | wc -l' > - Since "while do-done loop" block with pipeline becomes a > subshell, $N local variable is not update outside of > the loop. > Fix this bug by using actual target number (256) instead > of $N. > > Signed-off-by: Masami Hiramatsu Reviewed-by: Steven Rostedt (VMware) -- Steve