From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C37F3C43215 for ; Mon, 25 Nov 2019 15:46:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D8AE20869 for ; Mon, 25 Nov 2019 15:46:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728641AbfKYPq1 (ORCPT ); Mon, 25 Nov 2019 10:46:27 -0500 Received: from muru.com ([72.249.23.125]:43484 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728554AbfKYPq1 (ORCPT ); Mon, 25 Nov 2019 10:46:27 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 3A89A80EA; Mon, 25 Nov 2019 15:47:02 +0000 (UTC) Date: Mon, 25 Nov 2019 07:46:21 -0800 From: Tony Lindgren To: "H. Nikolaus Schaller" Cc: Paul Cercueil , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , =?utf-8?Q?Beno=C3=AEt?= Cousson , Ralf Baechle , Paul Burton , James Hogan , dri-devel , devicetree , Linux Kernel Mailing List , Linux-OMAP , OpenPVRSGX Linux Driver Group , Discussions about the Letux Kernel , kernel@pyra-handheld.com, linux-mips@vger.kernel.org, Paul Boddie Subject: Re: [PATCH v3 8/8] MIPS: DTS: jz4780: add sgx gpu node Message-ID: <20191125154621.GY35479@atomide.com> References: <1574600246.3.0@crapouillou.net> <20191124174837.GX35479@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * H. Nikolaus Schaller [191124 18:00]: > Hi Paul, Tony, > > > Am 24.11.2019 um 18:48 schrieb Tony Lindgren : > > > > * Paul Cercueil [191124 12:58]: > >> Le dim., nov. 24, 2019 at 12:40, H. Nikolaus Schaller a > >> écrit : > >>> and add interrupt and clocks. > > ... > >>> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi > >>> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi > >>> @@ -46,6 +46,17 @@ > >>> #clock-cells = <1>; > >>> }; > >>> > >>> + gpu: gpu@13040000 { > >> > >> We try to keep the nodes ordered by address, could you move this node where > >> it belongs? > > ... > > Yes, I have noted. > > > > >>> + compatible = "ingenic,jz4780-sgx540-120", "img,sgx540-120", > >>> "img,sgx540", "img,sgx5"; > >>> + reg = <0x13040000 0x4000>; > >>> + > >>> + clocks = <&cgu JZ4780_CLK_GPU>; > >>> + clock-names = "gpu"; > > > > Just checking.. Is there something else to configure here > > potentially in addition to the clocks? > > It doesn't look so. Unfortuantely there isn't much information > except a v3.18 kernel supported by the vendor and that one also > just has a gpu node with clock control. > > > That is, do we need to do some interconnect specific > > configuration etc in addition to the clocks to have > > runtime PM work for enabling and disabling sgx on > > jz4780? > > I think we have to leave that open for further study. OK for now, let's assume we just need to call clk_enable/disable from the PM runtime functions if a clock exists. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61AE6C432C0 for ; Tue, 26 Nov 2019 08:14:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 286352073F for ; Tue, 26 Nov 2019 08:14:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 286352073F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 377636E24B; Tue, 26 Nov 2019 08:14:10 +0000 (UTC) Received: from muru.com (muru.com [72.249.23.125]) by gabe.freedesktop.org (Postfix) with ESMTP id E699089E5B for ; Mon, 25 Nov 2019 15:46:27 +0000 (UTC) Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 3A89A80EA; Mon, 25 Nov 2019 15:47:02 +0000 (UTC) Date: Mon, 25 Nov 2019 07:46:21 -0800 From: Tony Lindgren To: "H. Nikolaus Schaller" Subject: Re: [PATCH v3 8/8] MIPS: DTS: jz4780: add sgx gpu node Message-ID: <20191125154621.GY35479@atomide.com> References: <1574600246.3.0@crapouillou.net> <20191124174837.GX35479@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-Mailman-Approved-At: Tue, 26 Nov 2019 08:14:07 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Discussions about the Letux Kernel , Paul Burton , David Airlie , James Hogan , OpenPVRSGX Linux Driver Group , Linux Kernel Mailing List , Ralf Baechle , linux-mips@vger.kernel.org, Paul Cercueil , Rob Herring , dri-devel , =?utf-8?Q?Beno=C3=AEt?= Cousson , kernel@pyra-handheld.com, Paul Boddie , Linux-OMAP Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191125154621.qnSMtDfRUwJDLbvQ9jHMgfxWvQYTyjw_P04R1f40QeY@z> KiBILiBOaWtvbGF1cyBTY2hhbGxlciA8aG5zQGdvbGRlbGljby5jb20+IFsxOTExMjQgMTg6MDBd Ogo+IEhpIFBhdWwsIFRvbnksCj4gCj4gPiBBbSAyNC4xMS4yMDE5IHVtIDE4OjQ4IHNjaHJpZWIg VG9ueSBMaW5kZ3JlbiA8dG9ueUBhdG9taWRlLmNvbT46Cj4gPiAKPiA+ICogUGF1bCBDZXJjdWVp bCA8cGF1bEBjcmFwb3VpbGxvdS5uZXQ+IFsxOTExMjQgMTI6NThdOgo+ID4+IExlIGRpbS4sIG5v di4gMjQsIDIwMTkgYXQgMTI6NDAsIEguIE5pa29sYXVzIFNjaGFsbGVyIDxobnNAZ29sZGVsaWNv LmNvbT4gYQo+ID4+IMOpY3JpdCA6Cj4gPj4+IGFuZCBhZGQgaW50ZXJydXB0IGFuZCBjbG9ja3Mu Cj4gPiAuLi4KPiA+Pj4gLS0tIGEvYXJjaC9taXBzL2Jvb3QvZHRzL2luZ2VuaWMvano0NzgwLmR0 c2kKPiA+Pj4gKysrIGIvYXJjaC9taXBzL2Jvb3QvZHRzL2luZ2VuaWMvano0NzgwLmR0c2kKPiA+ Pj4gQEAgLTQ2LDYgKzQ2LDE3IEBACj4gPj4+IAkJI2Nsb2NrLWNlbGxzID0gPDE+Owo+ID4+PiAJ fTsKPiA+Pj4gCj4gPj4+ICsJZ3B1OiBncHVAMTMwNDAwMDAgewo+ID4+IAo+ID4+IFdlIHRyeSB0 byBrZWVwIHRoZSBub2RlcyBvcmRlcmVkIGJ5IGFkZHJlc3MsIGNvdWxkIHlvdSBtb3ZlIHRoaXMg bm9kZSB3aGVyZQo+ID4+IGl0IGJlbG9uZ3M/Cj4gPiAuLi4KPiAKPiBZZXMsIEkgaGF2ZSBub3Rl ZC4KPiAKPiA+IAo+ID4+PiArCQljb21wYXRpYmxlID0gImluZ2VuaWMsano0NzgwLXNneDU0MC0x MjAiLCAiaW1nLHNneDU0MC0xMjAiLAo+ID4+PiAiaW1nLHNneDU0MCIsICJpbWcsc2d4NSI7Cj4g Pj4+ICsJCXJlZyA9IDwweDEzMDQwMDAwIDB4NDAwMD47Cj4gPj4+ICsKPiA+Pj4gKwkJY2xvY2tz ID0gPCZjZ3UgSlo0NzgwX0NMS19HUFU+Owo+ID4+PiArCQljbG9jay1uYW1lcyA9ICJncHUiOwo+ ID4gCj4gPiBKdXN0IGNoZWNraW5nLi4gSXMgdGhlcmUgc29tZXRoaW5nIGVsc2UgdG8gY29uZmln dXJlIGhlcmUKPiA+IHBvdGVudGlhbGx5IGluIGFkZGl0aW9uIHRvIHRoZSBjbG9ja3M/Cj4gCj4g SXQgZG9lc24ndCBsb29rIHNvLiBVbmZvcnR1YW50ZWx5IHRoZXJlIGlzbid0IG11Y2ggaW5mb3Jt YXRpb24KPiBleGNlcHQgYSB2My4xOCBrZXJuZWwgc3VwcG9ydGVkIGJ5IHRoZSB2ZW5kb3IgYW5k IHRoYXQgb25lIGFsc28KPiBqdXN0IGhhcyBhIGdwdSBub2RlIHdpdGggY2xvY2sgY29udHJvbC4K PiAKPiA+IFRoYXQgaXMsIGRvIHdlIG5lZWQgdG8gZG8gc29tZSBpbnRlcmNvbm5lY3Qgc3BlY2lm aWMKPiA+IGNvbmZpZ3VyYXRpb24gZXRjIGluIGFkZGl0aW9uIHRvIHRoZSBjbG9ja3MgdG8gaGF2 ZQo+ID4gcnVudGltZSBQTSB3b3JrIGZvciBlbmFibGluZyBhbmQgZGlzYWJsaW5nIHNneCBvbgo+ ID4gano0NzgwPwo+IAo+IEkgdGhpbmsgd2UgaGF2ZSB0byBsZWF2ZSB0aGF0IG9wZW4gZm9yIGZ1 cnRoZXIgc3R1ZHkuCgpPSyBmb3Igbm93LCBsZXQncyBhc3N1bWUgd2UganVzdCBuZWVkIHRvIGNh bGwKY2xrX2VuYWJsZS9kaXNhYmxlIGZyb20gdGhlIFBNIHJ1bnRpbWUgZnVuY3Rpb25zIGlmIGEK Y2xvY2sgZXhpc3RzLgoKUmVnYXJkcywKClRvbnkKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVs