From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] spl: fix entry_point equal to load_addr
Date: Mon, 25 Nov 2019 17:18:20 +0100 [thread overview]
Message-ID: <20191125161820.32674-1-giulio.benetti@benettiengineering.com> (raw)
At the moment entry_point is set to image_get_load(header) that sets it
to "load address" instead of "entry point", assuming entry_point is
equal to load_addr, but it's not true. Then load_addr is set to
"entry_point - header_size", but this is wrong too since load_addr is
not an entry point.
So use image_get_ep() for entry_point assignment and image_get_load()
for load_addr assignment.
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
common/spl/spl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/spl/spl.c b/common/spl/spl.c
index f1ad8dc9da..cdae346753 100644
--- a/common/spl/spl.c
+++ b/common/spl/spl.c
@@ -261,9 +261,9 @@ int spl_parse_image_header(struct spl_image_info *spl_image,
spl_image->entry_point = image_get_ep(header);
spl_image->size = image_get_data_size(header);
} else {
- spl_image->entry_point = image_get_load(header);
+ spl_image->entry_point = image_get_ep(header);
/* Load including the header */
- spl_image->load_addr = spl_image->entry_point -
+ spl_image->load_addr = image_get_load(header) -
header_size;
spl_image->size = image_get_data_size(header) +
header_size;
--
2.20.1
next reply other threads:[~2019-11-25 16:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 16:18 Giulio Benetti [this message]
2019-12-05 22:09 ` [U-Boot] [PATCH] spl: fix entry_point equal to load_addr Tom Rini
2019-12-06 12:46 ` Patrice CHOTARD
2019-12-06 12:58 ` Simon Goldschmidt
2019-12-06 13:34 ` Tom Rini
2019-12-06 13:37 ` Simon Goldschmidt
2019-12-06 13:44 ` Tom Rini
2019-12-06 13:48 ` Giulio Benetti
2019-12-06 14:04 ` Patrice CHOTARD
2019-12-06 17:23 ` Giulio Benetti
2019-12-06 14:05 ` Simon Goldschmidt
2019-12-06 14:55 ` Tom Rini
2019-12-07 21:28 ` Simon Goldschmidt
2020-01-10 14:57 ` Giulio Benetti
2020-01-10 21:51 ` Tom Rini
2020-01-16 14:40 ` Tom Rini
2020-01-16 14:46 ` Giulio Benetti
2020-01-16 14:49 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125161820.32674-1-giulio.benetti@benettiengineering.com \
--to=giulio.benetti@benettiengineering.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.