All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples/ioat: handle failure case for ioat dequeue
Date: Mon, 25 Nov 2019 16:23:16 +0000	[thread overview]
Message-ID: <20191125162316.GA1615@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20191125152303.68461-1-bruce.richardson@intel.com>

On Mon, Nov 25, 2019 at 03:23:03PM +0000, Bruce Richardson wrote:
> On a failure with the ioat dequeue, -1 is returned, which was not properly
> handled. This could lead to out-of-bounds reads on a later loop which
> assumed a positive return value. Fix this by treating an error as though a
> dequeue of 0 had been encountered.
> 
> Coverity issue: 350342
FYI: also should fix issue: 350349

> Fixes: 2328542ed84e ("examples/ioat: add rawdev copy mode")
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  examples/ioat/ioatfwd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c
> index 5e623a4d5..9fc033bc3 100644
> --- a/examples/ioat/ioatfwd.c
> +++ b/examples/ioat/ioatfwd.c
> @@ -457,7 +457,7 @@ ioat_tx_port(struct rxtx_port_config *tx_config)
>  				MAX_PKT_BURST, NULL);
>  		}
>  
> -		if (nb_dq == 0)
> +		if (nb_dq <= 0)
>  			return;
>  
>  		if (copy_mode == COPY_MODE_IOAT_NUM)
> -- 
> 2.21.0
> 

  reply	other threads:[~2019-11-25 16:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25 15:23 [dpdk-dev] [PATCH] examples/ioat: handle failure case for ioat dequeue Bruce Richardson
2019-11-25 16:23 ` Bruce Richardson [this message]
2019-11-26 16:27   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191125162316.GA1615@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.