From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E085C432C0 for ; Mon, 25 Nov 2019 17:40:04 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F98E20835 for ; Mon, 25 Nov 2019 17:40:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="By/dWAVh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F98E20835 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatomb.cc Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3B40F1771; Mon, 25 Nov 2019 18:39:11 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3B40F1771 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1574703601; bh=xNpofTWw3gc03ba6xoc9SVoWEX1PGDYdwduC5Y9l2Nk=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=By/dWAVh1oe3Vg/q6HOz+bnYU3LuQXN6PtIZ9Ec3AWtNqlthIMV23d6P38rJQh/xj qs617Vf/Uim1zae+8TcG7u56zG5QP49CMjOCpvaYEXqAH0dfLwizvJuD+/Dl/BxHQ2 Xmc1yvoKcGr7KSc7lp7ekRR6IWft3+Juvu6puqCc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B8ED6F8014D; Mon, 25 Nov 2019 18:39:10 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 60B18F8016F; Mon, 25 Nov 2019 18:39:08 +0100 (CET) Received: from mail1.xn--80adja5bqm.su (xn--80adja5bqm.su [45.62.210.217]) by alsa1.perex.cz (Postfix) with ESMTP id 5B588F800AB for ; Mon, 25 Nov 2019 18:39:04 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5B588F800AB Received: by mail1.xn--80adja5bqm.su (Postfix, from userid 1000) id EA39820C5462; Mon, 25 Nov 2019 18:39:02 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mail1.xn--80adja5bqm.su EA39820C5462 Date: Mon, 25 Nov 2019 18:39:02 +0100 From: Sergey 'Jin' Bostandzhyan To: Takashi Iwai Message-Id: <20191125173902.GA27981@xn--80adja5bqm.su> References: <20190719111231.GA26592@xn--80adja5bqm.su> <20190720165435.GA5855@xn--80adja5bqm.su> <20190819195714.GA2737@xn--80adja5bqm.su> <20190822203031.GA22363@xn--80adja5bqm.su> <20190829103805.GA1525@xn--80adja5bqm.su> <20190830114510.GA10027@xn--80adja5bqm.su> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190830114510.GA10027@xn--80adja5bqm.su> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: alsa-devel@alsa-project.org Subject: Re: [alsa-devel] Surround speaker connection on Acer 8951G X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Takashi, sorry - it's me again about the Acer 8951G LFE speaker. On Fri, Aug 30, 2019 at 01:45:10PM +0200, Sergey 'Jin' Bostandzhyan wrote: > > > The below HDA_FIXUP_VERBS does the trick, so I do have all 6 speakers working, > > > finally! > > > > > > {0x01, AC_VERB_SET_GPIO_DIRECTION, 0x02} > > > > Actually this must be paired with the corresponding bit of GPIO_DATA, > > too. Is the bit 0x02 of GPIO_DATA set or cleared? Usually setting it > > turns on the amp, but sometimes inverted. > > If I understood everything correctly, then the bit is set, meaning that the > GPIO signal is configured as output. I'll be honest, I exported the > hda-analyzer setting as a python script (nice feature btw) and deducted the > fixup verb setting from there (relevant part of the hda-analyzer export below): > > def set(nid, verb, param): > verb = (nid << 24) | (verb << 8) | param > res = ioctl(FD, IOCTL_VERB_WRITE, struct.pack('II', verb, 0)) > > set(0x01, 0x717, 0x02) # 0x01071702 (SET_GPIO_DIRECTION) it seems I indeed missed something here regarding GPIO_DATA, I really am not sure what the influence is, but after updating to Fedora 31 my LFE stopped working, even with the self compiled 5.4-rc8 kernel which I am running now (all the time before I was on Fedora 29 and I just backported my patch to 5.2.x and compiled the modules outside the tree after being done with the patch submission). So ultimately, it seems I now need to do the following in my fixup (original commit was 00066e9733f629e536f6b7957de2ce11a85fe15a): --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8875,7 +8875,7 @@ static const struct hda_fixup alc662_fixups[] = { .v.verbs = (const struct hda_verb[]) { {0x01, AC_VERB_SET_GPIO_MASK, 0x02}, {0x01, AC_VERB_SET_GPIO_DIRECTION, 0x02}, - {0x01, AC_VERB_SET_GPIO_DATA, 0x00}, + {0x01, AC_VERB_SET_GPIO_DATA, 0x02}, { } }, .chained = true, My question is: could something on the outside have influence on that? I am really very, very sure that I have tested LFE on kernel 5.4-rc before submitting the original patch and it has been working as submitted. Why did the behavior change now? What else could I have missed? I guess I have to submit the above change again, but I would like to make sure that I am not missing something else somewhere, something that could cause a change of behavior yet again after some future update. Kind regards, Jin _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel