From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DE02C432C0 for ; Tue, 26 Nov 2019 01:54:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D15682068F for ; Tue, 26 Nov 2019 01:54:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727236AbfKZByd (ORCPT ); Mon, 25 Nov 2019 20:54:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:50806 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726866AbfKZByd (ORCPT ); Mon, 25 Nov 2019 20:54:33 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 753802068F; Tue, 26 Nov 2019 01:54:31 +0000 (UTC) Date: Mon, 25 Nov 2019 20:54:29 -0500 From: Steven Rostedt To: Masami Hiramatsu Cc: Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [BUGFIX PATCH v3 1/4] selftests/ftrace: Fix to check the existence of set_ftrace_filter Message-ID: <20191125205429.5c9ba8c4@gandalf.local.home> In-Reply-To: <20191126091345.e2eb722e2939864eeb01bc7e@kernel.org> References: <157466501169.21973.31401747181477687.stgit@devnote2> <157466502067.21973.8795718044691377192.stgit@devnote2> <20191125094445.03d0c8df@gandalf.local.home> <20191126091345.e2eb722e2939864eeb01bc7e@kernel.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Nov 2019 09:13:45 +0900 Masami Hiramatsu wrote: > > > @@ -93,7 +96,6 @@ initialize_ftrace() { # Reset ftrace to initial-state > > > disable_events > > > [ -f set_event_pid ] && echo > set_event_pid > > > [ -f set_ftrace_pid ] && echo > set_ftrace_pid > > > - [ -f set_ftrace_filter ] && echo | tee set_ftrace_* > > > > The above should be changed to: > > > > [ -f set_ftrace_notrace ] && echo > set_ftrace_notrace > > Ah, good point! I think that should be done by another patch, since > it will improve ftracetest. No, it belongs in this patch, because you are removing: [ -f set_ftrace_filter ] && echo | tee set_ftrace_* which is equivalent to: [ -f set_ftrace_filter ] && echo > set_ftrace_filter [ -f set_ftrace_filter ] && echo > set_ftrace_notrace as the "tee set_ftrace_*" covers both. Without this change, this patch removes the update to set_ftrace_notrace. -- Steve