From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF1DAC432C3 for ; Mon, 25 Nov 2019 23:13:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C6ED72080F for ; Mon, 25 Nov 2019 23:13:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="DMWDX1+c" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727285AbfKYXKv (ORCPT ); Mon, 25 Nov 2019 18:10:51 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:1141 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727244AbfKYXKv (ORCPT ); Mon, 25 Nov 2019 18:10:51 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 25 Nov 2019 15:10:53 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 25 Nov 2019 15:10:49 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 25 Nov 2019 15:10:49 -0800 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 25 Nov 2019 23:10:46 +0000 Received: from rnnvemgw01.nvidia.com (10.128.109.123) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 25 Nov 2019 23:10:45 +0000 Received: from blueforge.nvidia.com (Not Verified[10.110.48.28]) by rnnvemgw01.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Mon, 25 Nov 2019 15:10:45 -0800 From: John Hubbard To: Andrew Morton CC: Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= , Christoph Hellwig , Dan Williams , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jan Kara , Jason Gunthorpe , Jens Axboe , Jonathan Corbet , =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= , Magnus Karlsson , "Mauro Carvalho Chehab" , Michael Ellerman , Michal Hocko , Mike Kravetz , "Paul Mackerras" , Shuah Khan , Vlastimil Babka , , , , , , , , , , , , , LKML , John Hubbard , "Jason Gunthorpe" Subject: [PATCH v2 06/19] vfio: fix FOLL_LONGTERM use, simplify get_user_pages_remote() call Date: Mon, 25 Nov 2019 15:10:22 -0800 Message-ID: <20191125231035.1539120-7-jhubbard@nvidia.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191125231035.1539120-1-jhubbard@nvidia.com> References: <20191125231035.1539120-1-jhubbard@nvidia.com> MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1574723453; bh=8L6xDPC0B530xp/MTT0aA3xB5v7i2RtCewyab6Z4Hgg=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:X-NVConfidentiality: Content-Transfer-Encoding:Content-Type; b=DMWDX1+cB4QtymtV0eYFM5L3g0QwBdBod3jf9D+OYp6VcGq+nCWNdeTSIeR2gdlKv OCoLOEHEHnyxxiKoX5Bly0Aub2VfAysxS6sgl5TDhs/QOg4BlJfTzKnfvhYODXLo6S QJZpr9ZaYdSISpTgj22g/mkSJKkzVrh9kioUJnB4hxT19WPhfESoEPiYDmQAW1edgj QPe9Lqv0tnH7Ab1+af4PrCQ4S5pYZ21RHcgLByMymIqV3aUCETXVwq8wJAJwD3iBNb PopTqCLwyQhl89pDrSiyqm8bKjJu0G9CP7yTA3xuI9me5QpmjM0Rq1FTn0CXcQ2wK3 ph7+aTk6aCdag== Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Update VFIO to take advantage of the recently loosened restriction on FOLL_LONGTERM with get_user_pages_remote(). Also, now it is possible to fix a bug: the VFIO caller is logically a FOLL_LONGTERM user, but it wasn't setting FOLL_LONGTERM. Also, remove an unnessary pair of calls that were releasing and reacquiring the mmap_sem. There is no need to avoid holding mmap_sem just in order to call page_to_pfn(). Also, now that the the DAX check ("if a VMA is DAX, don't allow long term pinning") is in the internals of get_user_pages_remote() and __gup_longterm_locked(), there's no need for it at the VFIO call site. So remove it. Tested-by: Alex Williamson Acked-by: Alex Williamson Reviewed-by: Jason Gunthorpe Reviewed-by: Ira Weiny Suggested-by: Jason Gunthorpe Cc: Dan Williams Cc: Jerome Glisse Signed-off-by: John Hubbard --- drivers/vfio/vfio_iommu_type1.c | 30 +++++------------------------- 1 file changed, 5 insertions(+), 25 deletions(-) diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type= 1.c index 2ada8e6cdb88..b800fc9a0251 100644 --- a/drivers/vfio/vfio_iommu_type1.c +++ b/drivers/vfio/vfio_iommu_type1.c @@ -322,7 +322,6 @@ static int vaddr_get_pfn(struct mm_struct *mm, unsigned= long vaddr, { struct page *page[1]; struct vm_area_struct *vma; - struct vm_area_struct *vmas[1]; unsigned int flags =3D 0; int ret; =20 @@ -330,33 +329,14 @@ static int vaddr_get_pfn(struct mm_struct *mm, unsign= ed long vaddr, flags |=3D FOLL_WRITE; =20 down_read(&mm->mmap_sem); - if (mm =3D=3D current->mm) { - ret =3D get_user_pages(vaddr, 1, flags | FOLL_LONGTERM, page, - vmas); - } else { - ret =3D get_user_pages_remote(NULL, mm, vaddr, 1, flags, page, - vmas, NULL); - /* - * The lifetime of a vaddr_get_pfn() page pin is - * userspace-controlled. In the fs-dax case this could - * lead to indefinite stalls in filesystem operations. - * Disallow attempts to pin fs-dax pages via this - * interface. - */ - if (ret > 0 && vma_is_fsdax(vmas[0])) { - ret =3D -EOPNOTSUPP; - put_page(page[0]); - } - } - up_read(&mm->mmap_sem); - + ret =3D get_user_pages_remote(NULL, mm, vaddr, 1, flags | FOLL_LONGTERM, + page, NULL, NULL); if (ret =3D=3D 1) { *pfn =3D page_to_pfn(page[0]); - return 0; + ret =3D 0; + goto done; } =20 - down_read(&mm->mmap_sem); - vaddr =3D untagged_addr(vaddr); =20 vma =3D find_vma_intersection(mm, vaddr, vaddr + 1); @@ -366,7 +346,7 @@ static int vaddr_get_pfn(struct mm_struct *mm, unsigned= long vaddr, if (is_invalid_reserved_pfn(*pfn)) ret =3D 0; } - +done: up_read(&mm->mmap_sem); return ret; } --=20 2.24.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11E12C432C0 for ; Mon, 25 Nov 2019 23:25:15 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B750F20409 for ; Mon, 25 Nov 2019 23:25:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="DMWDX1+c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B750F20409 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47MNRr3QKzzDqdL for ; Tue, 26 Nov 2019 10:25:12 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nvidia.com (client-ip=216.228.121.143; helo=hqemgate14.nvidia.com; envelope-from=jhubbard@nvidia.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=nvidia.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=nvidia.com header.i=@nvidia.com header.b="DMWDX1+c"; dkim-atps=neutral Received: from hqemgate14.nvidia.com (hqemgate14.nvidia.com [216.228.121.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47MN7M64PGzDqbc for ; Tue, 26 Nov 2019 10:10:55 +1100 (AEDT) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 25 Nov 2019 15:10:53 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 25 Nov 2019 15:10:49 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 25 Nov 2019 15:10:49 -0800 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 25 Nov 2019 23:10:46 +0000 Received: from rnnvemgw01.nvidia.com (10.128.109.123) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 25 Nov 2019 23:10:45 +0000 Received: from blueforge.nvidia.com (Not Verified[10.110.48.28]) by rnnvemgw01.nvidia.com with Trustwave SEG (v7, 5, 8, 10121) id ; Mon, 25 Nov 2019 15:10:45 -0800 From: John Hubbard To: Andrew Morton Subject: [PATCH v2 06/19] vfio: fix FOLL_LONGTERM use, simplify get_user_pages_remote() call Date: Mon, 25 Nov 2019 15:10:22 -0800 Message-ID: <20191125231035.1539120-7-jhubbard@nvidia.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191125231035.1539120-1-jhubbard@nvidia.com> References: <20191125231035.1539120-1-jhubbard@nvidia.com> MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1574723453; bh=8L6xDPC0B530xp/MTT0aA3xB5v7i2RtCewyab6Z4Hgg=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:X-NVConfidentiality: Content-Transfer-Encoding:Content-Type; b=DMWDX1+cB4QtymtV0eYFM5L3g0QwBdBod3jf9D+OYp6VcGq+nCWNdeTSIeR2gdlKv OCoLOEHEHnyxxiKoX5Bly0Aub2VfAysxS6sgl5TDhs/QOg4BlJfTzKnfvhYODXLo6S QJZpr9ZaYdSISpTgj22g/mkSJKkzVrh9kioUJnB4hxT19WPhfESoEPiYDmQAW1edgj QPe9Lqv0tnH7Ab1+af4PrCQ4S5pYZ21RHcgLByMymIqV3aUCETXVwq8wJAJwD3iBNb PopTqCLwyQhl89pDrSiyqm8bKjJu0G9CP7yTA3xuI9me5QpmjM0Rq1FTn0CXcQ2wK3 ph7+aTk6aCdag== X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma@vger.kernel.org, Christoph Hellwig , Jason Gunthorpe , Jason Gunthorpe , Vlastimil Babka , =?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= , linux-media@vger.kernel.org, Shuah Khan , John Hubbard , linux-block@vger.kernel.org, =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= , Al Viro , Dan Williams , Mauro Carvalho Chehab , Magnus Karlsson , Jens Axboe , netdev@vger.kernel.org, Alex Williamson , Daniel Vetter , linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Update VFIO to take advantage of the recently loosened restriction on FOLL_LONGTERM with get_user_pages_remote(). Also, now it is possible to fix a bug: the VFIO caller is logically a FOLL_LONGTERM user, but it wasn't setting FOLL_LONGTERM. Also, remove an unnessary pair of calls that were releasing and reacquiring the mmap_sem. There is no need to avoid holding mmap_sem just in order to call page_to_pfn(). Also, now that the the DAX check ("if a VMA is DAX, don't allow long term pinning") is in the internals of get_user_pages_remote() and __gup_longterm_locked(), there's no need for it at the VFIO call site. So remove it. Tested-by: Alex Williamson Acked-by: Alex Williamson Reviewed-by: Jason Gunthorpe Reviewed-by: Ira Weiny Suggested-by: Jason Gunthorpe Cc: Dan Williams Cc: Jerome Glisse Signed-off-by: John Hubbard --- drivers/vfio/vfio_iommu_type1.c | 30 +++++------------------------- 1 file changed, 5 insertions(+), 25 deletions(-) diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type= 1.c index 2ada8e6cdb88..b800fc9a0251 100644 --- a/drivers/vfio/vfio_iommu_type1.c +++ b/drivers/vfio/vfio_iommu_type1.c @@ -322,7 +322,6 @@ static int vaddr_get_pfn(struct mm_struct *mm, unsigned= long vaddr, { struct page *page[1]; struct vm_area_struct *vma; - struct vm_area_struct *vmas[1]; unsigned int flags =3D 0; int ret; =20 @@ -330,33 +329,14 @@ static int vaddr_get_pfn(struct mm_struct *mm, unsign= ed long vaddr, flags |=3D FOLL_WRITE; =20 down_read(&mm->mmap_sem); - if (mm =3D=3D current->mm) { - ret =3D get_user_pages(vaddr, 1, flags | FOLL_LONGTERM, page, - vmas); - } else { - ret =3D get_user_pages_remote(NULL, mm, vaddr, 1, flags, page, - vmas, NULL); - /* - * The lifetime of a vaddr_get_pfn() page pin is - * userspace-controlled. In the fs-dax case this could - * lead to indefinite stalls in filesystem operations. - * Disallow attempts to pin fs-dax pages via this - * interface. - */ - if (ret > 0 && vma_is_fsdax(vmas[0])) { - ret =3D -EOPNOTSUPP; - put_page(page[0]); - } - } - up_read(&mm->mmap_sem); - + ret =3D get_user_pages_remote(NULL, mm, vaddr, 1, flags | FOLL_LONGTERM, + page, NULL, NULL); if (ret =3D=3D 1) { *pfn =3D page_to_pfn(page[0]); - return 0; + ret =3D 0; + goto done; } =20 - down_read(&mm->mmap_sem); - vaddr =3D untagged_addr(vaddr); =20 vma =3D find_vma_intersection(mm, vaddr, vaddr + 1); @@ -366,7 +346,7 @@ static int vaddr_get_pfn(struct mm_struct *mm, unsigned= long vaddr, if (is_invalid_reserved_pfn(*pfn)) ret =3D 0; } - +done: up_read(&mm->mmap_sem); return ret; } --=20 2.24.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Hubbard Subject: [PATCH v2 06/19] vfio: fix FOLL_LONGTERM use, simplify get_user_pages_remote() call Date: Mon, 25 Nov 2019 15:10:22 -0800 Message-ID: <20191125231035.1539120-7-jhubbard@nvidia.com> References: <20191125231035.1539120-1-jhubbard@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from hqemgate14.nvidia.com (hqemgate14.nvidia.com [216.228.121.143]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3AE256E113 for ; Mon, 25 Nov 2019 23:10:50 +0000 (UTC) In-Reply-To: <20191125231035.1539120-1-jhubbard@nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrew Morton Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Jason Gunthorpe , Vlastimil Babka , =?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= , linux-media@vger.kernel.org, Shuah Khan , John Hubbard , linux-block@vger.kernel.org, =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= , Al Viro List-Id: dri-devel@lists.freedesktop.org VXBkYXRlIFZGSU8gdG8gdGFrZSBhZHZhbnRhZ2Ugb2YgdGhlIHJlY2VudGx5IGxvb3NlbmVkIHJl c3RyaWN0aW9uIG9uCkZPTExfTE9OR1RFUk0gd2l0aCBnZXRfdXNlcl9wYWdlc19yZW1vdGUoKS4g QWxzbywgbm93IGl0IGlzIHBvc3NpYmxlIHRvCmZpeCBhIGJ1ZzogdGhlIFZGSU8gY2FsbGVyIGlz IGxvZ2ljYWxseSBhIEZPTExfTE9OR1RFUk0gdXNlciwgYnV0IGl0Cndhc24ndCBzZXR0aW5nIEZP TExfTE9OR1RFUk0uCgpBbHNvLCByZW1vdmUgYW4gdW5uZXNzYXJ5IHBhaXIgb2YgY2FsbHMgdGhh dCB3ZXJlIHJlbGVhc2luZyBhbmQKcmVhY3F1aXJpbmcgdGhlIG1tYXBfc2VtLiBUaGVyZSBpcyBu byBuZWVkIHRvIGF2b2lkIGhvbGRpbmcgbW1hcF9zZW0KanVzdCBpbiBvcmRlciB0byBjYWxsIHBh Z2VfdG9fcGZuKCkuCgpBbHNvLCBub3cgdGhhdCB0aGUgdGhlIERBWCBjaGVjayAoImlmIGEgVk1B IGlzIERBWCwgZG9uJ3QgYWxsb3cgbG9uZwp0ZXJtIHBpbm5pbmciKSBpcyBpbiB0aGUgaW50ZXJu YWxzIG9mIGdldF91c2VyX3BhZ2VzX3JlbW90ZSgpIGFuZApfX2d1cF9sb25ndGVybV9sb2NrZWQo KSwgdGhlcmUncyBubyBuZWVkIGZvciBpdCBhdCB0aGUgVkZJTyBjYWxsIHNpdGUuClNvIHJlbW92 ZSBpdC4KClRlc3RlZC1ieTogQWxleCBXaWxsaWFtc29uIDxhbGV4LndpbGxpYW1zb25AcmVkaGF0 LmNvbT4KQWNrZWQtYnk6IEFsZXggV2lsbGlhbXNvbiA8YWxleC53aWxsaWFtc29uQHJlZGhhdC5j b20+ClJldmlld2VkLWJ5OiBKYXNvbiBHdW50aG9ycGUgPGpnZ0BtZWxsYW5veC5jb20+ClJldmll d2VkLWJ5OiBJcmEgV2VpbnkgPGlyYS53ZWlueUBpbnRlbC5jb20+ClN1Z2dlc3RlZC1ieTogSmFz b24gR3VudGhvcnBlIDxqZ2dAemllcGUuY2E+CkNjOiBEYW4gV2lsbGlhbXMgPGRhbi5qLndpbGxp YW1zQGludGVsLmNvbT4KQ2M6IEplcm9tZSBHbGlzc2UgPGpnbGlzc2VAcmVkaGF0LmNvbT4KU2ln bmVkLW9mZi1ieTogSm9obiBIdWJiYXJkIDxqaHViYmFyZEBudmlkaWEuY29tPgotLS0KIGRyaXZl cnMvdmZpby92ZmlvX2lvbW11X3R5cGUxLmMgfCAzMCArKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDI1IGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmZpby92ZmlvX2lvbW11X3R5cGUxLmMgYi9kcml2ZXJzL3Zm aW8vdmZpb19pb21tdV90eXBlMS5jCmluZGV4IDJhZGE4ZTZjZGI4OC4uYjgwMGZjOWEwMjUxIDEw MDY0NAotLS0gYS9kcml2ZXJzL3ZmaW8vdmZpb19pb21tdV90eXBlMS5jCisrKyBiL2RyaXZlcnMv dmZpby92ZmlvX2lvbW11X3R5cGUxLmMKQEAgLTMyMiw3ICszMjIsNiBAQCBzdGF0aWMgaW50IHZh ZGRyX2dldF9wZm4oc3RydWN0IG1tX3N0cnVjdCAqbW0sIHVuc2lnbmVkIGxvbmcgdmFkZHIsCiB7 CiAJc3RydWN0IHBhZ2UgKnBhZ2VbMV07CiAJc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWE7Ci0J c3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWFzWzFdOwogCXVuc2lnbmVkIGludCBmbGFncyA9IDA7 CiAJaW50IHJldDsKIApAQCAtMzMwLDMzICszMjksMTQgQEAgc3RhdGljIGludCB2YWRkcl9nZXRf cGZuKHN0cnVjdCBtbV9zdHJ1Y3QgKm1tLCB1bnNpZ25lZCBsb25nIHZhZGRyLAogCQlmbGFncyB8 PSBGT0xMX1dSSVRFOwogCiAJZG93bl9yZWFkKCZtbS0+bW1hcF9zZW0pOwotCWlmIChtbSA9PSBj dXJyZW50LT5tbSkgewotCQlyZXQgPSBnZXRfdXNlcl9wYWdlcyh2YWRkciwgMSwgZmxhZ3MgfCBG T0xMX0xPTkdURVJNLCBwYWdlLAotCQkJCSAgICAgdm1hcyk7Ci0JfSBlbHNlIHsKLQkJcmV0ID0g Z2V0X3VzZXJfcGFnZXNfcmVtb3RlKE5VTEwsIG1tLCB2YWRkciwgMSwgZmxhZ3MsIHBhZ2UsCi0J CQkJCSAgICB2bWFzLCBOVUxMKTsKLQkJLyoKLQkJICogVGhlIGxpZmV0aW1lIG9mIGEgdmFkZHJf Z2V0X3BmbigpIHBhZ2UgcGluIGlzCi0JCSAqIHVzZXJzcGFjZS1jb250cm9sbGVkLiBJbiB0aGUg ZnMtZGF4IGNhc2UgdGhpcyBjb3VsZAotCQkgKiBsZWFkIHRvIGluZGVmaW5pdGUgc3RhbGxzIGlu IGZpbGVzeXN0ZW0gb3BlcmF0aW9ucy4KLQkJICogRGlzYWxsb3cgYXR0ZW1wdHMgdG8gcGluIGZz LWRheCBwYWdlcyB2aWEgdGhpcwotCQkgKiBpbnRlcmZhY2UuCi0JCSAqLwotCQlpZiAocmV0ID4g MCAmJiB2bWFfaXNfZnNkYXgodm1hc1swXSkpIHsKLQkJCXJldCA9IC1FT1BOT1RTVVBQOwotCQkJ cHV0X3BhZ2UocGFnZVswXSk7Ci0JCX0KLQl9Ci0JdXBfcmVhZCgmbW0tPm1tYXBfc2VtKTsKLQor CXJldCA9IGdldF91c2VyX3BhZ2VzX3JlbW90ZShOVUxMLCBtbSwgdmFkZHIsIDEsIGZsYWdzIHwg Rk9MTF9MT05HVEVSTSwKKwkJCQkgICAgcGFnZSwgTlVMTCwgTlVMTCk7CiAJaWYgKHJldCA9PSAx KSB7CiAJCSpwZm4gPSBwYWdlX3RvX3BmbihwYWdlWzBdKTsKLQkJcmV0dXJuIDA7CisJCXJldCA9 IDA7CisJCWdvdG8gZG9uZTsKIAl9CiAKLQlkb3duX3JlYWQoJm1tLT5tbWFwX3NlbSk7Ci0KIAl2 YWRkciA9IHVudGFnZ2VkX2FkZHIodmFkZHIpOwogCiAJdm1hID0gZmluZF92bWFfaW50ZXJzZWN0 aW9uKG1tLCB2YWRkciwgdmFkZHIgKyAxKTsKQEAgLTM2Niw3ICszNDYsNyBAQCBzdGF0aWMgaW50 IHZhZGRyX2dldF9wZm4oc3RydWN0IG1tX3N0cnVjdCAqbW0sIHVuc2lnbmVkIGxvbmcgdmFkZHIs CiAJCWlmIChpc19pbnZhbGlkX3Jlc2VydmVkX3BmbigqcGZuKSkKIAkJCXJldCA9IDA7CiAJfQot Citkb25lOgogCXVwX3JlYWQoJm1tLT5tbWFwX3NlbSk7CiAJcmV0dXJuIHJldDsKIH0KLS0gCjIu MjQuMAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04678C432C0 for ; Mon, 25 Nov 2019 23:11:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DAB44207FD for ; Mon, 25 Nov 2019 23:11:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DAB44207FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 144B36E191; Mon, 25 Nov 2019 23:10:59 +0000 (UTC) Received: from hqemgate14.nvidia.com (hqemgate14.nvidia.com [216.228.121.143]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3AE256E113 for ; Mon, 25 Nov 2019 23:10:50 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 25 Nov 2019 15:10:53 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 25 Nov 2019 15:10:49 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 25 Nov 2019 15:10:49 -0800 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 25 Nov 2019 23:10:46 +0000 Received: from rnnvemgw01.nvidia.com (10.128.109.123) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 25 Nov 2019 23:10:45 +0000 Received: from blueforge.nvidia.com (Not Verified[10.110.48.28]) by rnnvemgw01.nvidia.com with Trustwave SEG (v7, 5, 8, 10121) id ; Mon, 25 Nov 2019 15:10:45 -0800 From: John Hubbard To: Andrew Morton Subject: [PATCH v2 06/19] vfio: fix FOLL_LONGTERM use, simplify get_user_pages_remote() call Date: Mon, 25 Nov 2019 15:10:22 -0800 Message-ID: <20191125231035.1539120-7-jhubbard@nvidia.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191125231035.1539120-1-jhubbard@nvidia.com> References: <20191125231035.1539120-1-jhubbard@nvidia.com> MIME-Version: 1.0 X-NVConfidentiality: public X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1574723453; bh=8L6xDPC0B530xp/MTT0aA3xB5v7i2RtCewyab6Z4Hgg=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:X-NVConfidentiality: Content-Transfer-Encoding:Content-Type; b=DMWDX1+cB4QtymtV0eYFM5L3g0QwBdBod3jf9D+OYp6VcGq+nCWNdeTSIeR2gdlKv OCoLOEHEHnyxxiKoX5Bly0Aub2VfAysxS6sgl5TDhs/QOg4BlJfTzKnfvhYODXLo6S QJZpr9ZaYdSISpTgj22g/mkSJKkzVrh9kioUJnB4hxT19WPhfESoEPiYDmQAW1edgj QPe9Lqv0tnH7Ab1+af4PrCQ4S5pYZ21RHcgLByMymIqV3aUCETXVwq8wJAJwD3iBNb PopTqCLwyQhl89pDrSiyqm8bKjJu0G9CP7yTA3xuI9me5QpmjM0Rq1FTn0CXcQ2wK3 ph7+aTk6aCdag== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Jason Gunthorpe , Vlastimil Babka , =?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= , linux-media@vger.kernel.org, Shuah Khan , John Hubbard , linux-block@vger.kernel.org, =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= , Al Viro , Dan Williams , Mauro Carvalho Chehab , Magnus Karlsson , Jens Axboe , netdev@vger.kernel.org, Alex Williamson , linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Kravetz Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191125231022.UMcDgjTc1eHtNpyFtDWEbdXp9zdCOP7SvbO8QFyPo0w@z> VXBkYXRlIFZGSU8gdG8gdGFrZSBhZHZhbnRhZ2Ugb2YgdGhlIHJlY2VudGx5IGxvb3NlbmVkIHJl c3RyaWN0aW9uIG9uCkZPTExfTE9OR1RFUk0gd2l0aCBnZXRfdXNlcl9wYWdlc19yZW1vdGUoKS4g QWxzbywgbm93IGl0IGlzIHBvc3NpYmxlIHRvCmZpeCBhIGJ1ZzogdGhlIFZGSU8gY2FsbGVyIGlz IGxvZ2ljYWxseSBhIEZPTExfTE9OR1RFUk0gdXNlciwgYnV0IGl0Cndhc24ndCBzZXR0aW5nIEZP TExfTE9OR1RFUk0uCgpBbHNvLCByZW1vdmUgYW4gdW5uZXNzYXJ5IHBhaXIgb2YgY2FsbHMgdGhh dCB3ZXJlIHJlbGVhc2luZyBhbmQKcmVhY3F1aXJpbmcgdGhlIG1tYXBfc2VtLiBUaGVyZSBpcyBu byBuZWVkIHRvIGF2b2lkIGhvbGRpbmcgbW1hcF9zZW0KanVzdCBpbiBvcmRlciB0byBjYWxsIHBh Z2VfdG9fcGZuKCkuCgpBbHNvLCBub3cgdGhhdCB0aGUgdGhlIERBWCBjaGVjayAoImlmIGEgVk1B IGlzIERBWCwgZG9uJ3QgYWxsb3cgbG9uZwp0ZXJtIHBpbm5pbmciKSBpcyBpbiB0aGUgaW50ZXJu YWxzIG9mIGdldF91c2VyX3BhZ2VzX3JlbW90ZSgpIGFuZApfX2d1cF9sb25ndGVybV9sb2NrZWQo KSwgdGhlcmUncyBubyBuZWVkIGZvciBpdCBhdCB0aGUgVkZJTyBjYWxsIHNpdGUuClNvIHJlbW92 ZSBpdC4KClRlc3RlZC1ieTogQWxleCBXaWxsaWFtc29uIDxhbGV4LndpbGxpYW1zb25AcmVkaGF0 LmNvbT4KQWNrZWQtYnk6IEFsZXggV2lsbGlhbXNvbiA8YWxleC53aWxsaWFtc29uQHJlZGhhdC5j b20+ClJldmlld2VkLWJ5OiBKYXNvbiBHdW50aG9ycGUgPGpnZ0BtZWxsYW5veC5jb20+ClJldmll d2VkLWJ5OiBJcmEgV2VpbnkgPGlyYS53ZWlueUBpbnRlbC5jb20+ClN1Z2dlc3RlZC1ieTogSmFz b24gR3VudGhvcnBlIDxqZ2dAemllcGUuY2E+CkNjOiBEYW4gV2lsbGlhbXMgPGRhbi5qLndpbGxp YW1zQGludGVsLmNvbT4KQ2M6IEplcm9tZSBHbGlzc2UgPGpnbGlzc2VAcmVkaGF0LmNvbT4KU2ln bmVkLW9mZi1ieTogSm9obiBIdWJiYXJkIDxqaHViYmFyZEBudmlkaWEuY29tPgotLS0KIGRyaXZl cnMvdmZpby92ZmlvX2lvbW11X3R5cGUxLmMgfCAzMCArKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDI1IGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmZpby92ZmlvX2lvbW11X3R5cGUxLmMgYi9kcml2ZXJzL3Zm aW8vdmZpb19pb21tdV90eXBlMS5jCmluZGV4IDJhZGE4ZTZjZGI4OC4uYjgwMGZjOWEwMjUxIDEw MDY0NAotLS0gYS9kcml2ZXJzL3ZmaW8vdmZpb19pb21tdV90eXBlMS5jCisrKyBiL2RyaXZlcnMv dmZpby92ZmlvX2lvbW11X3R5cGUxLmMKQEAgLTMyMiw3ICszMjIsNiBAQCBzdGF0aWMgaW50IHZh ZGRyX2dldF9wZm4oc3RydWN0IG1tX3N0cnVjdCAqbW0sIHVuc2lnbmVkIGxvbmcgdmFkZHIsCiB7 CiAJc3RydWN0IHBhZ2UgKnBhZ2VbMV07CiAJc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWE7Ci0J c3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWFzWzFdOwogCXVuc2lnbmVkIGludCBmbGFncyA9IDA7 CiAJaW50IHJldDsKIApAQCAtMzMwLDMzICszMjksMTQgQEAgc3RhdGljIGludCB2YWRkcl9nZXRf cGZuKHN0cnVjdCBtbV9zdHJ1Y3QgKm1tLCB1bnNpZ25lZCBsb25nIHZhZGRyLAogCQlmbGFncyB8 PSBGT0xMX1dSSVRFOwogCiAJZG93bl9yZWFkKCZtbS0+bW1hcF9zZW0pOwotCWlmIChtbSA9PSBj dXJyZW50LT5tbSkgewotCQlyZXQgPSBnZXRfdXNlcl9wYWdlcyh2YWRkciwgMSwgZmxhZ3MgfCBG T0xMX0xPTkdURVJNLCBwYWdlLAotCQkJCSAgICAgdm1hcyk7Ci0JfSBlbHNlIHsKLQkJcmV0ID0g Z2V0X3VzZXJfcGFnZXNfcmVtb3RlKE5VTEwsIG1tLCB2YWRkciwgMSwgZmxhZ3MsIHBhZ2UsCi0J CQkJCSAgICB2bWFzLCBOVUxMKTsKLQkJLyoKLQkJICogVGhlIGxpZmV0aW1lIG9mIGEgdmFkZHJf Z2V0X3BmbigpIHBhZ2UgcGluIGlzCi0JCSAqIHVzZXJzcGFjZS1jb250cm9sbGVkLiBJbiB0aGUg ZnMtZGF4IGNhc2UgdGhpcyBjb3VsZAotCQkgKiBsZWFkIHRvIGluZGVmaW5pdGUgc3RhbGxzIGlu IGZpbGVzeXN0ZW0gb3BlcmF0aW9ucy4KLQkJICogRGlzYWxsb3cgYXR0ZW1wdHMgdG8gcGluIGZz LWRheCBwYWdlcyB2aWEgdGhpcwotCQkgKiBpbnRlcmZhY2UuCi0JCSAqLwotCQlpZiAocmV0ID4g MCAmJiB2bWFfaXNfZnNkYXgodm1hc1swXSkpIHsKLQkJCXJldCA9IC1FT1BOT1RTVVBQOwotCQkJ cHV0X3BhZ2UocGFnZVswXSk7Ci0JCX0KLQl9Ci0JdXBfcmVhZCgmbW0tPm1tYXBfc2VtKTsKLQor CXJldCA9IGdldF91c2VyX3BhZ2VzX3JlbW90ZShOVUxMLCBtbSwgdmFkZHIsIDEsIGZsYWdzIHwg Rk9MTF9MT05HVEVSTSwKKwkJCQkgICAgcGFnZSwgTlVMTCwgTlVMTCk7CiAJaWYgKHJldCA9PSAx KSB7CiAJCSpwZm4gPSBwYWdlX3RvX3BmbihwYWdlWzBdKTsKLQkJcmV0dXJuIDA7CisJCXJldCA9 IDA7CisJCWdvdG8gZG9uZTsKIAl9CiAKLQlkb3duX3JlYWQoJm1tLT5tbWFwX3NlbSk7Ci0KIAl2 YWRkciA9IHVudGFnZ2VkX2FkZHIodmFkZHIpOwogCiAJdm1hID0gZmluZF92bWFfaW50ZXJzZWN0 aW9uKG1tLCB2YWRkciwgdmFkZHIgKyAxKTsKQEAgLTM2Niw3ICszNDYsNyBAQCBzdGF0aWMgaW50 IHZhZGRyX2dldF9wZm4oc3RydWN0IG1tX3N0cnVjdCAqbW0sIHVuc2lnbmVkIGxvbmcgdmFkZHIs CiAJCWlmIChpc19pbnZhbGlkX3Jlc2VydmVkX3BmbigqcGZuKSkKIAkJCXJldCA9IDA7CiAJfQot Citkb25lOgogCXVwX3JlYWQoJm1tLT5tbWFwX3NlbSk7CiAJcmV0dXJuIHJldDsKIH0KLS0gCjIu MjQuMAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs