All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] linux: adding CIP RT
Date: Tue, 26 Nov 2019 12:51:05 +0100	[thread overview]
Message-ID: <20191126125105.06cd2fcb@windsurf> (raw)
In-Reply-To: <20191125225846.13484-1-angelo@amarulasolutions.com>

Hello,

The .hash file should be updated with the hash of this kernel tarball.

The commit log can be improved, we prefer using imperative sentence
"add <foo>", "fix <bar>" rather than "adding <foo>", "fixing <bar>".

Maybe:

	linux: add option to select the CIP real-time kernel

> -else ifeq ($(BR2_LINUX_KERNEL_LATEST_CIP_VERSION),y)
> +else ifneq ($(filter $(BR2_LINUX_KERNEL_LATEST_CIP_VERSION) $(BR2_LINUX_KERNEL_LATEST_CIP_RT_VERSION),y),)

Since it's a choice, this is sufficient:

ifeq ($(BR2_LINUX_KERNEL_LATEST_CIP_VERSION)$(BR2_LINUX_KERNEL_LATEST_CIP_RT_VERSION),y)

>  LINUX_SOURCE = linux-cip-$(LINUX_VERSION).tar.gz
>  LINUX_SITE = https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/snapshot
>  else ifneq ($(findstring -rc,$(LINUX_VERSION)),)

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2019-11-26 11:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25 22:58 [Buildroot] [PATCH] linux: adding CIP RT Angelo Compagnucci
2019-11-26 11:51 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191126125105.06cd2fcb@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.