All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Cc: linux-kernel@vger.kernel.org, dsterba@suse.com,
	linux-btrfs@vger.kernel.org, anand.jain@oracle.com,
	Marcos Paulo de Souza <mpdesouza@suse.com>
Subject: Re: [PATCH 0/2] btrfs qgroup cleanup
Date: Tue, 26 Nov 2019 18:00:12 +0100	[thread overview]
Message-ID: <20191126170011.GN2734@twin.jikos.cz> (raw)
In-Reply-To: <20191126005851.11813-1-marcos.souza.org@gmail.com>

On Mon, Nov 25, 2019 at 09:58:49PM -0300, Marcos Paulo de Souza wrote:
> From: Marcos Paulo de Souza <mpdesouza@suse.com>
> 
> While reading the qgroup code and doing some tests, I found some two things
> that I would like to change:
> * Remove some useless code that was being set only to check if
>   fs_info->quota_root was not NULL
> * Check why creating a qgroup was returning EINVAL
> 
> The answer to the second point was: EINVAL is returned when a user tries to
> create/delete/list/assign a qgroup to a subvolume, but this subvolume does
> not have quota enabled. Talking with David, he suggested to change it to
> ENOTCONN, following what is currently being used in balance and scrub.
> 
> So here are the changes. Please take a look!

Added to misc-next with minor subject edits, thanks.

      parent reply	other threads:[~2019-11-26 17:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-26  0:58 [PATCH 0/2] btrfs qgroup cleanup Marcos Paulo de Souza
2019-11-26  0:58 ` [PATCH 1/2] btrfs: qgroup: Cleanup quota_root checks Marcos Paulo de Souza
2019-11-26  2:47   ` Qu Wenruo
2019-11-26  0:58 ` [PATCH 2/2] btrfs: qgroup: Return -ENOTCONN instead of -EINVAL Marcos Paulo de Souza
2019-11-26  2:50   ` Qu Wenruo
2019-11-26 17:00 ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191126170011.GN2734@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=anand.jain@oracle.com \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcos.souza.org@gmail.com \
    --cc=mpdesouza@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.