From: Rob Herring <robh@kernel.org>
To: frowand.list@gmail.com
Cc: Vincent Whitchurch <vincent.whitchurch@axis.com>,
pantelis.antoniou@konsulko.com,
Pantelis Antoniou <panto@antoniou-consulting.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Vincent Whitchurch <rabinv@axis.com>,
geert@linux-m68k.org, Alan Tull <atull@kernel.org>
Subject: Re: [PATCH] of: overlay: add_changeset_property() memory leak
Date: Tue, 26 Nov 2019 12:23:54 -0700 [thread overview]
Message-ID: <20191126192354.GA15179@bogus> (raw)
In-Reply-To: <1574363816-13981-1-git-send-email-frowand.list@gmail.com>
On Thu, 21 Nov 2019 13:16:56 -0600, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> No changeset entries are created for #address-cells and #size-cells
> properties, but the duplicated properties are never freed. This
> results in a memory leak which is detected by kmemleak:
>
> unreferenced object 0x85887180 (size 64):
> backtrace:
> kmem_cache_alloc_trace+0x1fb/0x1fc
> __of_prop_dup+0x25/0x7c
> add_changeset_property+0x17f/0x370
> build_changeset_next_level+0x29/0x20c
> of_overlay_fdt_apply+0x32b/0x6b4
> ...
>
> Fixes: 6f75118800acf77f8 ("of: overlay: validate overlay properties #address-cells and #size-cells")
> Reported-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
> drivers/of/overlay.c | 37 ++++++++++++++++++++-----------------
> 1 file changed, 20 insertions(+), 17 deletions(-)
>
Applied, thanks.
Rob
prev parent reply other threads:[~2019-11-26 19:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 19:16 [PATCH] of: overlay: add_changeset_property() memory leak frowand.list
2019-11-21 19:20 ` Frank Rowand
2019-11-25 15:17 ` Vincent Whitchurch
2019-11-26 19:23 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126192354.GA15179@bogus \
--to=robh@kernel.org \
--cc=atull@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=panto@antoniou-consulting.com \
--cc=rabinv@axis.com \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.