From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ED4CC432C3 for ; Wed, 27 Nov 2019 05:05:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04F6920835 for ; Wed, 27 Nov 2019 05:05:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="JLaTbp8I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726092AbfK0FFm (ORCPT ); Wed, 27 Nov 2019 00:05:42 -0500 Received: from mail-pj1-f66.google.com ([209.85.216.66]:45665 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725788AbfK0FFm (ORCPT ); Wed, 27 Nov 2019 00:05:42 -0500 Received: by mail-pj1-f66.google.com with SMTP id r11so1513899pjp.12 for ; Tue, 26 Nov 2019 21:05:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xZ4O83bgDIw/8dIBhV4hXPyaX+XZAbVnynBzLd9+iLI=; b=JLaTbp8IWD3cAfVShRjwwPtl0yRZr6oE7Ksf4+lSwE3sJZ6lsicMVJulQ6G1kM9Dus OXHEYfdMsxCiR3NLCf+GjSURk4lk+VsPw08Zn8+s3EUJSvdinEWQWNBxF9btYJQPqnTC 4zqtp3YYKPt274JrfE7hL+cLC8Ebd0hEeP7+o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xZ4O83bgDIw/8dIBhV4hXPyaX+XZAbVnynBzLd9+iLI=; b=fO2Ws1Wk8vwZOuN+Z11Zn6r89jzHUESi4L+dcvHcPApE5SpIk5xcj0D5iaqFOwc9Yc g6V1Xhiu0xMDa7jK6wy7cqalFUKEJd2YtBvSsrpfuzZiRX2H3Z2kT+XOSF9y5soL9F0+ pgee89B+lGYxeZsRIyp0auurk8Ha7pWZrUWYuHRA0g7FLyvx9l1silYutzPq+HWX3KiP wcjFr+6WhLiidsNGGHv+rb7kvNFfof4SUc1wc/6/fq3JzTr8hoQuPHNRYPio8gHSrYS3 vu0nGhsPo70h/ncXqPFERJjVz28RkKg79theHorb9iWZL6QKbKxhgTYTD0BcEdDrqLm2 HXFQ== X-Gm-Message-State: APjAAAUyXM/yWPKJF59/oCRS5FLhXo7B1vLQcMFr5ibwtKni8qZkjkdy stWT/LEI2D8qIBjL7NRxS85vuw== X-Google-Smtp-Source: APXvYqzsYFZ3auba035H26fOpwRDetbWUh/33lew+U6cqe7LVIiXhT1QT5AwJLEUhwHRXSE9BpoINw== X-Received: by 2002:a17:90a:d353:: with SMTP id i19mr3658245pjx.43.1574831141772; Tue, 26 Nov 2019 21:05:41 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id f10sm14155169pfd.28.2019.11.26.21.05.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2019 21:05:40 -0800 (PST) Date: Tue, 26 Nov 2019 21:05:39 -0800 From: Kees Cook To: Phong Tran Cc: Larry.Finger@lwfinger.net, jakub.kicinski@netronome.com, kvalo@codeaurora.org, Wright.Feng@cypress.com, arend.vanspriel@broadcom.com, davem@davemloft.net, emmanuel.grumbach@intel.com, franky.lin@broadcom.com, johannes.berg@intel.com, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, luciano.coelho@intel.com, netdev@vger.kernel.org, p.figiel@camlintechnologies.com, pieter-paul.giesberts@broadcom.com, pkshih@realtek.com, rafal@milecki.pl, sara.sharon@intel.com, shahar.s.matityahu@intel.com, yhchuang@realtek.com, yuehaibing@huawei.com Subject: Re: [Patch v2 1/4] b43legacy: Fix -Wcast-function-type Message-ID: <201911262105.83DCA06@keescook> References: <20191125150215.29263-1-tranmanphong@gmail.com> <20191126175529.10909-1-tranmanphong@gmail.com> <20191126175529.10909-2-tranmanphong@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191126175529.10909-2-tranmanphong@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, Nov 27, 2019 at 12:55:26AM +0700, Phong Tran wrote: > correct usage prototype of callback in tasklet_init(). > Report by https://github.com/KSPP/linux/issues/20 > > Tested-by: Larry Finger > Signed-off-by: Phong Tran Thanks for sending these! Reviewed-by: Kees Cook -Kees > --- > drivers/net/wireless/broadcom/b43legacy/main.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/broadcom/b43legacy/main.c b/drivers/net/wireless/broadcom/b43legacy/main.c > index 4325e91736eb..8b6b657c4b85 100644 > --- a/drivers/net/wireless/broadcom/b43legacy/main.c > +++ b/drivers/net/wireless/broadcom/b43legacy/main.c > @@ -1275,8 +1275,9 @@ static void handle_irq_ucode_debug(struct b43legacy_wldev *dev) > } > > /* Interrupt handler bottom-half */ > -static void b43legacy_interrupt_tasklet(struct b43legacy_wldev *dev) > +static void b43legacy_interrupt_tasklet(unsigned long data) > { > + struct b43legacy_wldev *dev = (struct b43legacy_wldev *)data; > u32 reason; > u32 dma_reason[ARRAY_SIZE(dev->dma_reason)]; > u32 merged_dma_reason = 0; > @@ -3741,7 +3742,7 @@ static int b43legacy_one_core_attach(struct ssb_device *dev, > b43legacy_set_status(wldev, B43legacy_STAT_UNINIT); > wldev->bad_frames_preempt = modparam_bad_frames_preempt; > tasklet_init(&wldev->isr_tasklet, > - (void (*)(unsigned long))b43legacy_interrupt_tasklet, > + b43legacy_interrupt_tasklet, > (unsigned long)wldev); > if (modparam_pio) > wldev->__using_pio = true; > -- > 2.20.1 > -- Kees Cook